[Koha-bugs] [Bug 25417] Backdating returns and forgiving fines causes and internal server error

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm happy with this now... This improves the behaviour to properly skip adding
a FORGIVEN type credit for OVERDUES that have already been annulled by a
backdated return with CalculateFinesOnBackdate.

We still end up with a zero amount fine line, which I'm still not entirely sure
about, but as that question has been unanswered in bugs 22539 and 8338 already
I don't think to ask it here and holding up this fix is the correct action to
take.

I've also modified the clause to only skip on '0'.. if we somehow end up with a
negative here we do still want to throw an exception as it highlights issues
elsewhere in the codepaths prior to this point.. we should not just silently
ignore that in my opinion.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.