[Koha-bugs] [Bug 25421] Make Koha::Item and Koha::Biblio ->pickup_locations return an arrayref

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25421

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > This was wrong:
> > 
> > -    @libraries = Koha::Libraries->pickup_locations() unless @libraries;
> > +    @libraries = Koha::Libraries->search( { pickup_location => 1 },
> > +        { order_by => ['branchname'] } )->as_list
> > +      unless @libraries;
> > 
> > ->pickup_locations does much more than search for the pickup_location flag.
> 
> Did that, but not from the call in the Branches plugin.
> 
> > Tests from t/db_dependent/Template/Plugin/Branches.t are failing massively.
> 
> Weird, I took care of them. I'll re-check

I'm sorry for the failing tests. This patch was supposed to be pushed along
with bug 24368 which basically rewrites all the tests as well.

-- 
You are receiving this mail because:
You are watching all bug changes.