[Koha-bugs] [Bug 25502] New: /advanced_editor/macros doesn't follow coding guidelines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25502

            Bug ID: 25502
           Summary: /advanced_editor/macros doesn't follow coding
                    guidelines
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

This development started before the changes we introduced in the guidelines in
late 2019, and the major code changes that took place in January 2020.

- Attribute mapping logic is now on the Koha::Object-level (the patches
implement that, but are not using it)
- Related to the above, some helper methods like to_api and to_model are kept,
the same for the mappings in the controller, they should all go away
- Related to the above, set_from_api and new_from_api should be used instead of
using helper to_api and to_model methods in the controller
- $c->objects->search doesn't use the to_model and to_api params
- Response status codes need to be changed, at least for DELETE operations

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.