[Koha-bugs] [Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #8)
> +    $biblionumber = int($biblionumber);
> 
> I think we have a few places where we do that. And it is really ugly imo.
> If you dont pass a valid biblionumber, you should not get a valid response.
> 
> Furthermore int does not like strings. We will have warnings like:
> Argument "3abc" isn't numeric in int 
> 
> I would rather get rid of the other places..

Yeah, that's a good point. 

> 
> Changing status: ID or FQA ?

Probably FQA for now, and maybe we should have a separate bug for returning a
404 or something when an invalid biblionumber is given. (And then this bug
report would either become a duplicate or implement that new strategy.)

-- 
You are receiving this mail because:
You are watching all bug changes.