[Koha-bugs] [Bug 25502] /advanced_editor/macros doesn't follow coding guidelines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25502

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105044|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 105062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105062&action=edit
Bug 25502: Adapt Advanced macros routes to current guidelines

The original development started before the changes we introduced in the
guidelines in late 2019, and the major code changes that took place in January
2020.

- Attribute mapping logic is now on the Koha::Object-level (the patches
implement that, but are not using it)
- Related to the above, some helper methods like to_api and to_model are kept,
the same for the mappings in the controller, they should all go away
- Related to the above, set_from_api and new_from_api should be used instead of
using helper to_api and to_model methods in the controller
- $c->objects->search doesn't use the to_model and to_api params
- Response status codes need to be changed, at least for DELETE operations

Those are fixed by this patch.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/advanced_editor_macros.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.