[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104635|0                           |1
        is obsolete|                            |

--- Comment #13 from Andrew Nugged <nugged at gmail.com> ---
Created attachment 105063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105063&action=edit
Bug 25440: Fix for "uninitialized $maxsuspensiondays" in smart-rules.pl

This warning emitted:

Use of uninitialized value $maxsuspensiondays in string eq
at /admin/smart-rules.pl line 257.

But that not just undef-warning, there is broken logic,
these two lines are mutually contradictory and goes one-by-one:

    $maxsuspensiondays = undef if $maxsuspensiondays eq q||;
    $maxsuspensiondays = '' if $maxsuspensiondays eq q||;

Fix is simple: to make it '' if it comes undef.

-- 
You are receiving this mail because:
You are watching all bug changes.