[Koha-bugs] [Bug 25533] Perl "not numeric" warning on the "Holds" page

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25533

--- Comment #1 from Slava Shishkin <slavashishkin at gmail.com> ---
Created attachment 105101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105101&action=edit
Bug 25533: Fix for 'Argument "" isn't numeric' warning

Perl warning on the intranet "Holds" page
(/cgi-bin/koha/reserve/request.pl)

Argument "" isn't numeric in numeric gt (>)
at .../C4/Reserves.pm line 2233.

Fixed by assigning 0 for $holds_per_record when it has value that can
be considered as false.

To test:
    1) Ensure that values of "Holds per record" is set to Unlimited
        on /cgi-bin/koha/admin/smart-rules.pl
    2) Go to the intranet page (/cgi-bin/koha/reserve/request.pl).
    3) Open item record, like
/cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=1
    4) Observe the warning in the log file.
    5) Apply patch.
    6) Repeat steps 2 and 3.
    7) Check that previous warning was suppressed.

Mentored-by: Peter Vashchuk <stalkernoid at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.