[Koha-bugs] [Bug 25556] Holds blocked when empty holdallowed value present in circulation_rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25556

--- Comment #8 from Andrew Nugged <nugged at gmail.com> ---
So we have two confused-me places:


1. the presence in onboarding.pl of this: 

/opt/n/koha/git/KohaCommunity/installer/onboarding.pl:
  303:                 holdallowed             => "",

makes impossible to plane a hold but even there's not expected to be this block
(just re-save "Default checkout, hold policy by patron category" again in
.../smart-rules.pl and see that "holds not allowed" gone)

which I propose just to be removed (so not to store "" for all those three
items for "Default checkout, hold policy by patron category" rule).



2. Because website (.../smart-rules.pl) shows the same "Not Set" for both, 
undef(=absent) and for "", no matter do we have or not this line in DB:

 (32, NULL, NULL, NULL, NULL, NULL, 'holdallowed', ''),

in DB.

I.e. that dropdown acts like this:

Hold policy:
- "" or absent(undef): "Not Set"
- 0: "No holds allowed"
- 1: "From home library"
- 2: "From any library"
- 3: "From local hold group"

but "" or absence(undef) gives different results in P1.

Here I propose to make both "" and absence(undef) to act similarly if both of
them assumed to be "Not Set" = "not limiting at all".

-- 
You are receiving this mail because:
You are watching all bug changes.