[Koha-bugs] [Bug 25556] Holds blocked when empty holdallowed value present in circulation_rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25556

--- Comment #13 from Andrew Nugged <nugged at gmail.com> ---
(obviously, I planned to pre-check before cleaning up both rules or to leave
what needed, but I got your point)


here's some more observations:


1. On clean (truncated) DB after onboarding tool, I have all as in above
message "INSERT..."
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25556#c6)


2. And when I check holds,  I got "Cannot place hold":
/cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=1


3. now I just go to /cgi-bin/koha/admin/smart-rules.pl to section
"Default checkout, hold policy by patron category": it looks "empty"
("Not Set" for all dropdowns),


4. now I press "Unset" button so it _removes_ from DBj all of these key/val
pairs at all:

 (28, NULL, NULL, NULL, NULL, NULL, 'patron_maxonsiteissueqty', ''),
 (29, NULL, NULL, NULL, NULL, NULL, 'max_holds', ''),
 (30, NULL, NULL, NULL, NULL, NULL, 'patron_maxissueqty', ''),
 (31, NULL, NULL, NULL, NULL, NULL, 'returnbranch', ''),
 (32, NULL, NULL, NULL, NULL, NULL, 'holdallowed', ''),
 (33, NULL, NULL, NULL, NULL, NULL, 'hold_fulfillment_policy', '');


5.I check on smart-rules.pl in "Default checkout, hold policy by patron
category" looks "empty" in the same way as in p3.


6. And when I check holds, it allows hold.
/cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=1


7. now I go to smart-rules.pl again to the same section ("Default checkout,
hold policy by patron category"): press "Unset" button so it adds back to db
but only these lines:

INSERT INTO `circulation_rules` (`id`, `branchcode`, `categorycode`,
`itemtype`, `ccode`, `shelving_location`, `rule_name`, `rule_value`)
VALUES
 (35, NULL, NULL, NULL, NULL, NULL, 'hold_fulfillment_policy', ''),
 (36, NULL, NULL, NULL, NULL, NULL, 'returnbranch', ''),
 (37, NULL, NULL, NULL, NULL, NULL, 'patron_maxonsiteissueqty', ''),
 (38, NULL, NULL, NULL, NULL, NULL, 'patron_maxissueqty', ''),
 (39, NULL, NULL, NULL, NULL, NULL, 'max_holds', '');

added, i.e. no that one added back:

 (32, NULL, NULL, NULL, NULL, NULL, 'holdallowed', ''),

so:


8. And when I check holds, it allows hold.
/cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=1


CONCLUSION: because all SIX keys="" so both from "params_2" and "params_3"
removed in p.4 above – and that is "unset" action, I propose to remove both
"params_2" and "params_3" from onboarding tool.

-- 
You are receiving this mail because:
You are watching all bug changes.