[Koha-bugs] [Bug 14648] Batch remove reserve items

Sat May 23 01:03:47 CEST 2020

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Joe,

having a look at the patch:

1) QA test tools

We have a script the QA team uses to find common mistakes and coding guideline
variations in patches. It's a good habit for devs to run the script on their
patches too. In this case it alerts of tabs:

 FAIL   course_reserves/course-details.pl
   OK     critic
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 55)
                forbidden pattern: tab char (line 56)
                forbidden pattern: tab char (line 57)
                forbidden pattern: tab char (line 58)
   OK     git manipulation
   OK     pod
   OK     spelling
   OK     valid

 FAIL  
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 39)
                forbidden pattern: tab char (line 40)
                forbidden pattern: tab char (line 41)
                forbidden pattern: tab char (line 290)
                forbidden pattern: tab char (line 291)
                forbidden pattern: tab char (line 292)
   OK     git manipulation

In Koha we have agreed to use 4 spaces and no tabs. Please check your editor
settings, that should make things easier.

2) I'd like to suggest to change the label on the button. The 'batch' features
usually work by giving it a list, what you do is delete all - so I think we
should we should name it that and leave the 'Batch remove...' to be added
later.
"Remove all reserves"

-- 
You are receiving this mail because:
You are watching all bug changes.