[Koha-bugs] [Bug 25513] acquisitions_orders.t is failing randomly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #19)
> Additional notes:
> 1. This may break Jessie, so we should have a patch for stables that will
> "fix" the tests by adding specific value to the order we create
> 2. There is a "format" parameter in the API spec, but we don't use it
> https://swagger.io/docs/specification/data-models/data-types/
> Maybe we should.
> 
> Another fix would be to extend the test in that area (TO_JSON) and add 
> _float_column_type. We could then use Math::BigFloat:
>   use Math::BigFloat;
>   my $x = Math::BigFloat->new(10177559957753600000);
>   my $y = Math::BigFloat->new(1.01775599577536e+19);
>   say $x;say $y;
> will display twice 10177559957753600000

I agree we should be identifying floats and using:

"type:" "number",
"format": "float"

I would like to mention that the like you provided is for OAS3 and we are using
OAS2
https://swagger.io/specification/v2/

-- 
You are receiving this mail because:
You are watching all bug changes.