[Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413

didier <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |didier.gautheron at biblibre.c
                   |                            |om

--- Comment #27 from didier <didier.gautheron at biblibre.com> ---
Hi

subtest 'AutoRemoveOverduesRestrictions' doesn't properly cleanup issues and
borrowers tables, issues table is an issue:) it breaks Koha/Biblios.t

On today master
prove  t/db_dependent/Circulation/MarkIssueReturned.t
t/db_dependent/Circulation/MarkIssueReturned.t .. ok   
All tests successful.
Files=1, Tests=4,  4 wallclock secs ( 0.02 usr  0.01 sys +  3.44 cusr  0.59
csys =  4.06 CPU)
Result: PASS

select * from issues;
+----------+----------------+------------+---------------------+------------+------------+-----------------+----------+------------+------------------+---------------------+---------------------+-----------------+------+----------+----------+
| issue_id | borrowernumber | itemnumber | date_due            | branchcode |
returndate | lastreneweddate | renewals | auto_renew | auto_renew_error |
timestamp           | issuedate           | onsite_checkout | note | notedate |
noteseen |
+----------+----------------+------------+---------------------+------------+------------+-----------------+----------+------------+------------------+---------------------+---------------------+-----------------+------+----------+----------+
|      653 |     2000000449 |       2402 | 2020-05-29 23:59:00 | mF9sTiXrX  |
NULL       | NULL            |        0 |          0 | NULL             |
2020-05-24 06:45:13 | 2020-05-24 06:45:13 |               0 | NULL | NULL     |
    NULL |
+----------+----------------+------------+---------------------+------------+------------+-----------------+----------+------------+------------------+---------------------+---------------------+-----------------+------+----------+----------+
1 row in set (0.00 sec)

prove  t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Biblio.t .. 4/12     # No tests run!

#   Failed test 'No tests run for subtest "pickup_locations"'
#   at t/db_dependent/Koha/Biblio.t line 415.
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Cannot delete or update a parent row: a foreign key constraint
fails (`koha_kohadev`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY
(`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE)
[for Statement "DELETE FROM `borrowers` WHERE ( `borrowernumber` = ? )" with
ParamValues: 0=2000000449] at /kohadevbox/koha/Koha/Object.pm line 229
# Looks like your test exited with 255 just after 8.
t/db_dependent/Koha/Biblio.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 5/12 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Biblio.t (Wstat: 65280 Tests: 8 Failed: 1)
  Failed test:  8
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 12 tests but ran 8.
Files=1, Tests=8,  2 wallclock secs ( 0.02 usr  0.01 sys +  1.97 cusr  0.20
csys =  2.20 CPU)
Result: FAIL

mysql> delete from issues;

prove  t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Biblio.t .. ok     
All tests successful.
Files=1, Tests=12, 12 wallclock secs ( 0.03 usr  0.00 sys +  8.40 cusr  1.55
csys =  9.98 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.