[Koha-bugs] [Bug 25444] Before and course reserve values are not correctly shown and data is lost

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #3)
> Retesting with some more details:
> 
> 1) Item used, original values:
> 
> Item type: Books 	
> Holding library: Fairview 
> Home library: Fairview 
> Location: General Stacks 	
> Collection: Reference
> Barcode: 39999000000399 (from sample data) 	
> 
> 2) Added to an active course reserve, using "Add reserves":
> 
> Item type: Maps (changed)
> Holding library: Fairview 
> Home library: Riverside (changed)
> Location: General Stacks 	
> Collection: Fiction (changed)
> 
> 3) Display on course reserves table in staff:
> 
> Maps (Books) 	
> Fiction (Reference) 	
> Unchanged (General Stacks) 	
> Riverside (Riverside) = WRONG!
> Unchanged (Fairview) 

Will be fixed by the follow-up I have just attached to bug 22630:
    Bug 22630: Display correct "in storage" value


> 4) Using "Edit" option from course reserves:
> 
> Additionally changing:
> Location: On Display (was General stacks)
> Holding library: Midway (was Fairview)
> 
> 5) Display on course reserves table in staff:
> 
> Maps (Books) 	
> Fiction (Reference) 	
> On Display () = WRONG! Expected: On display (General stacks)
> Riverside (Riverside) = Still wrong... 	
> Midway () = WRONG! Expected: Midway (Fairview)


At this point we have, in DB:
        holdingbranch: MPL
holdingbranch_enabled: 1
holdingbranch_storage: NULL
             location: DISPLAY
     location_enabled: 1
     location_storage: NULL

My understanding is that the *_storage values are not retrieved when a course
is edited.
Reading the code it seems that it happens in _SwapAllFields, only called by
EnableOrDisableCourseItem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.