[Koha-bugs] [Bug 25556] Holds blocked when empty holdallowed value present in circulation_rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25556

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Andrew Nugged from comment #20)
> (In reply to Jonathan Druart from comment #18)
> > We did not notice the problem before because we have the following code in
> > misc4dev:
> >   ...
> > The rules was inserted with undef instead of "".
> 
> should Peter roll back those erased strings "params_2/3" from the file and
> assign these with "undef" like in misc4dev so approaches will match for the
> future?
> 
> Or let's leave without "param_3" creation at all as it now
> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.
> html&bug=25556&attachment=105347)? 
> 
> ... ah, Passed QA :)... So ok then :P

Yes, it was just a note :)

I removed them from misc4dev as well.

https://gitlab.com/koha-community/koha-misc4dev/-/commit/ea5655e33cb77928ae0f0fa2c53b4ce594a5b697

-- 
You are receiving this mail because:
You are watching all bug changes.