[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851

--- Comment #35 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #34)
> I understand the disagreement, but we have added lots of other information
> on the base that it can be hidden with CSS if unwanted - serials are more
> likely to have analytics than monographs, so that's why the limit was
> introduced in the first place. In our own XSLT we also have a version for
> monographs (same but different class) and control both of them with CSS. But
> I know our libraries would love it too to only see it when there actually
> are child records.

I don't see a disagreement yet. I'm pondering options. My idea is that we could
add different classes for each leader value (if you require that) and even hide
them all by default to keep the current behaviour. No proposal from me will
break your workflow, Katrina.

> I am not sure I understand how 1) would look like, can you explain a bit
> more?

Jonathan's code uses a method to search for EasyAnalytics related biblios. We
need to have that AND a Zebra/Elasticsearch query for Host-item and rcn. If any
of those returns something, then there's analytics and something similar-ish to
Jonathan's approach can be used. I will produce a patch for this option
tomorrow (my) morning so we check how bad it is for performance.

> With 2) we also need to account for every way a record can be added or
> edited in Koha - including the imports.

Yes, they all ultimately call ModBiblio so I'm not *that* worried about it.

So the struggle here is: fix the data? assume heterogeneous database?

-- 
You are receiving this mail because:
You are watching all bug changes.