[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed May 27 12:46:45 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #20)
> (In reply to Kyle M Hall from comment #18)
> > (In reply to Jonathan Druart from comment #15)
> > > The template is displaying permanent_location, is that correct?
> > > In C4::CourseReserves we always play with items.location.
> > > I have, in DB:
> > >         homebranch: RPL
> > >      holdingbranch: FPL
> > >           location: GEN
> > > permanent_location: NULL
> > > 
> > > I guess that's why I don't see the "location".
> > > What is the expected behaviour here?
> > 
> > That was a change made on bug 21446, which doesn't really justify the
> > change. In my original code, everything operates on the 'location' column.
> > The code has never touch permanent location. I would suggest reverting the
> > behavior of 21446.
> 
> I think we should also move this particular visual issue to a new bug. The
> description of this bug is "Course reserve settings are not saved on edit",
> and these patches fix that issue. This discussion relates to a visual bug
> and seems out of scope for this bug report.

Agreed, I opened bug 25609.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list