[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #30 from David Gustafsson <glasklas at gmail.com> ---
(In reply to Jonathan Druart from comment #26)
> 1. Doesn't it make sense to have this for authority records as well?
> 
> 2. Why is --date mandatory?
> 
> 3. POD does not tell that --deleted_only and --include_deleted is only
> available for bibs
> 
> 4. --id_list_file does not work with --deleted_only
> 
> 5. Items are not exported, I guess that's expected but maybe we should have
> it noted somewhere?

2) I think I just assumed it was required since included in the SQL-query, also
before the patch. Did not realize that 
"SELECT * FROM biblio_metadata WHERE timestamp > ''" is equivalent with "SELECT
* FROM biblio_metadata" if every timestamp entry has a value. So with that in
mind an empty timestamp is ok, though the code is a real eyesore :)

3) I think it's already pretty clear since will produce an error message is
--included_deleted or --deleted_only is used in conjunction with record_type
other than 'bibs'. But I clarified this in the usage documentation for said
options. 

4) Did not work since have to add special case for @deleted_record_ids, fixed
this.

5). There actually is a "deleteditems" table so I guess it would be possible to
include these, even though it's hard to imagine why you would want to do this.
Since the default is to include items perhaps it would be best to leave this as
is and never include items for deleted biblios, or you will get more data than
you probably want by default. It would also increase code complexity, probably
with little benefit. If someone requests this it can be fixed later perhaps.
Will point it out in the documentation that items are not included.

-- 
You are receiving this mail because:
You are watching all bug changes.