From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:12:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:12:06 +0000 Subject: [Koha-bugs] [Bug 26795] Remove the use of jquery.checkboxes plugin from ILL pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:12:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:12:10 +0000 Subject: [Koha-bugs] [Bug 26795] Remove the use of jquery.checkboxes plugin from ILL pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112769|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 112770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112770&action=edit Bug 26795: Remove the use of jquery.checkboxes plugin from ILL pages This patch removes the inclusion of the jquery.checkboxes plugin from two staff interface ILL pages where the plugin is unused. To test you need at least one patron with some ILL requests. - Apply the patch and locate a patron with ILL requests. - Click the "ILL requests history" tab. - Confirm that the table of requests has no checkboxes. - Choose "Ill requests" from the "More" menu in the header. - Confirm that the table of requests has no checkboxes. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:15:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:15:13 +0000 Subject: [Koha-bugs] [Bug 26758] Correct OPAC ILL requests page markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:15:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:15:17 +0000 Subject: [Koha-bugs] [Bug 26758] Correct OPAC ILL requests page markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112766|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 112771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112771&action=edit Bug 26758: Correct OPAC ILL requests page markup This patch makes some corrections to the OPAC ILL page which should have been included in the upgrade to Bootstrap 4. To test you must have Interlibrary loan configured and enabled in the OPAC. Enter some text in the ILLModuleCopyrightClearance system preference. - Log in to the OPAC and go to the "your interlibrary loan requests" page. - If you have only one ILL backend set up you should see a "Create a new request" button which is styled correctly. - This patch makes corrections to the menu which displays if you have more than one ILL backend set up, so it would be ideal to be able to test it. - Upon clickng the "new request" button (or selecting a backend from the new request menu) you should be prompted to choose Yes or No in response to the ILLModuleCopyrightClearance text. The buttons should be styled green and red, respectively. - On the new request entry page the "Add new field" and "Create" buttons should be styled in the "secondary" grey style. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:17:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:17:55 +0000 Subject: [Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:17:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:17:58 +0000 Subject: [Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112765|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 112772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112772&action=edit Bug 26808: Improve tab key access to circulation confirmation dialog This patch modifies the checkout template so that the checkout confirmation message can receive focus, improving tab access to the form buttons in the dialog. A "-1" value "tabindex" attribute makes the dialog focusable, and a "focus" class automatically triggers focus. The focus and tabindex are only set when the template logic says that the alert will require confirmation. To test, apply the patch and open a patron's account for checkout. - Submit a barcode for checkout which will trigger a confirmation dialog. For instance: - A barcode they already have checked out - A barcode which is checked out to another patron - When the page reloads you should see an alert-style dialog, "Please confirm checkout." The browser should show a focus outline around the dialog. - Hitting the tab key should move the focus to the first focusable element inside the dialog. If there is a link in the text, this may be the first element. If not the confirmation button should be the next tabbable element. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:18:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:18:47 +0000 Subject: [Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:18:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:18:50 +0000 Subject: [Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112309|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 112773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112773&action=edit Bug 26806: Remove the jquery.checkboxes plugin from the staff client This patch removes the jquery.checkboxes plugin from the staff client. It also removes some leftover instances of the "checkboxed" class which was used in some cases to enable the checkbox plugin on selected elements. To test, apply the patch and check that the jquery.checkboxes plugin no longer exists in /intranet-tmpl/lib/jquery/plugins. To test changes to the templates, confirm that "Check all" and "Check none" links still work on these pages: - The tags review page. See the test plan for Bug 26120. - The inventory page. See the test plan for Bug 26150. - The list contents page. See the test plan for Bug 26204. The other modified templates contained the "checkboxed" class but it served no purpose: - Serials -> Serials collection - Labels -> Edit label batch - Patron cards -> Edit card batch If you search the Koha codebase for instances of "checkboxed" the only results should be from the OPAC (if Bug 26805 hasn't been applied) and in Z39.50 templates where the class is still used by JavaScript. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:19:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:19:05 +0000 Subject: [Koha-bugs] [Bug 26881] Remove the period at the end of 'Limit to currently available items' in facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:19:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:19:09 +0000 Subject: [Koha-bugs] [Bug 26881] Remove the period at the end of 'Limit to currently available items' in facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112764|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 112774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112774&action=edit Bug 26881: Remove period on limit to available items on opac To test: 1- do a search on the opac 2- on the results page, it says "Limit to currently available items." 3- apply patch, restart, reload 4- period is gone Signed-off-by: Owen Leonard Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:19:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:19:26 +0000 Subject: [Koha-bugs] [Bug 26880] Add explanatory text to Add course reserve screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26880 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add explanatory text to Add |Add explanatory text to Add |Course Reserve screens |course reserve screens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:22:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:22:20 +0000 Subject: [Koha-bugs] [Bug 26880] Add explanatory text to Add course reserve screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26880 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:22:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:22:23 +0000 Subject: [Koha-bugs] [Bug 26880] Add explanatory text to Add course reserve screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26880 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112750|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 112775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112775&action=edit Bug 26880: Add explanatory text to add course reserve pages To test: - go to course reserve add item and batch add items pages - batch add has a little bit of explanation, add has none - apply patch, restart, reload pages - both pages have more text explaining how they work! "Checking the box next to the field label will enable changes to that field. Leave boxes unchecked to make no change.
Any items with existing course reserves will have their on reserve values updated." Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:23:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:23:58 +0000 Subject: [Koha-bugs] [Bug 26817] "Total" line in checkouts table is too short when ExportCircHistory is activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:24:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:24:01 +0000 Subject: [Koha-bugs] [Bug 26817] "Total" line in checkouts table is too short when ExportCircHistory is activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112728|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 112776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112776&action=edit Bug 26817: Change checkouts table footer colspan based on ExportCircHistory This patch makes a minor change to the include file which generates the checkouts table footer. It now includes some logic checking for the ExportCircHistory system preference, adjusting the colspan accordingly. To test, apply the patch and enable the ExportCircHistory system preference. - Check out to a patron who has checkouts. In the table of checkouts there should be an "Export" column. The footer at the bottom of the table should span the width of the table. - Disable the ExportCircHistory preference. - View the checkout page again and confirm that table footer still looks correct. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:25:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:25:58 +0000 Subject: [Koha-bugs] [Bug 26816] Remove extra space before comma in staff results item list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26816 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:26:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:26:02 +0000 Subject: [Koha-bugs] [Bug 26816] Remove extra space before comma in staff results item list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26816 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112670|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 112777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112777&action=edit Bug 26816: Chomp whitespace around i18n strings This patch adds the chomp shorthand [%- -%] to the output of i18n.inc to prevent extra spaces from being inserted. To test, apply the patch and perform a catalog search in the staff interface which will return results with multiple items. In the items column, the availability information should not have unwanted spaces: 3 items, 3 available: ...instead of 3 items , 3 available: Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:30:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:30:17 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:30:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:30:21 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112328|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 112778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112778&action=edit Bug 26633: Add REST API for managing transfer limits Test Plan: 1) prove t/db_dependent/api/v1/transfer_limits.t Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:30:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:30:26 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112330|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 112779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112779&action=edit Bug 26633: Add advanced editor for transfer limits The current transfer limits editor works great for Koha instances with small numbers of branches. However, for consortiums with dozens or even hundreds of libraries, the editor does not work well or effectively. We should provide an "advanced" editor displays all to/from library combinations in a grid and allows them to be edited in a manner somewhat similar to the transport cost matrix editor. Test Plan: 1) Apply this patch 2) Browse to the transfer limits editor 3) Click the new "Switch to advanced editor" link 4) Select a collection code/item type to edit limits for 5) Test the "Check all" function 6) Test the "Uncheck all" function 7) Test the "Check" column function 8) Test the "Uncheck" column function 9) Test the "Check" row function 10) Test the "Uncheck" row function 11) Test individual checkboxes/table cells Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:30:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:30:30 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112437|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 112780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112780&action=edit Bug 26633: Fix indirect object notation Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:30:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:30:34 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112438|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 112781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112781&action=edit Bug 26633: (QA follow-up) Change label to "collection" as we display the description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:30:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:30:37 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112587|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 112782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112782&action=edit Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the same action is used multiple times in a row Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:31:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:31:24 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #16 from Katrin Fischer --- Do we need any documentation for the API routes here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:32:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:32:57 +0000 Subject: [Koha-bugs] [Bug 26826] Set focus for cursor to name input box when creating a new list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26826 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:33:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:33:00 +0000 Subject: [Koha-bugs] [Bug 26826] Set focus for cursor to name input box when creating a new list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26826 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112590|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 112783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112783&action=edit Bug 26826: Set focus for cursor to name input box when creating a new list This patch adds the "focus" class to the list name input field so that it automatically has focus when the page loads. To test, apply the patch and open the lists page in the staff client. - Click "New list." - When the list creation page loads the "Name" field should have focus. Signed-off-by: B Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:35:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:35:43 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:35:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:35:46 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112173|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 112784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112784&action=edit Bug 25700: Complete KohaCons informations in timeline Last entry for KohaCons on Koha timeline was for 2013. This patch : - adds KohaCons from 2014 to 2020 - adds missing link to KohaCons websites for events from 2006 to 2013 - suppresses dead links for old KohaCons - standardizes the display of informations To test, apply patch and check : - there is no typo (especially for October > Octobre) - order of dates is correct - links to Koha website ou wiki are correct Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:35:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:35:50 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112174|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 112785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112785&action=edit Bug 25700: (follow-up) Minor corrections to epoch dates It looks like we forgot to account for the year change when grabbing epoch dates for some of the later KohaCon's. This patch fixes those minor mistakes. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:35:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:35:53 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112729|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 112786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112786&action=edit Bug 25700: (follow-up 2) 2 minor corrections for KohaCon This patch corrects : - the wrong link for KohaCon11 - a typo on 'workshops' for KohaCon19 - replace 'hackfest' for 'workshops' for KohaCon20 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:51:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:51:32 +0000 Subject: [Koha-bugs] [Bug 26828] Set focus for cursor to current password field when updating in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:51:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:51:35 +0000 Subject: [Koha-bugs] [Bug 26828] Set focus for cursor to current password field when updating in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112591|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 112787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112787&action=edit Bug 26828: Set focus for cursor to current password field when updating in the OPAC This patch adds the "focus" class to the first field in the OPAC's password update form so that the field automatically receives focus upon page load. To test, apply the patch and make sure the OpacPasswordChange system preference is enabled. - Log in to the OPAC - Open the "Change your password" page - The cursor should automatically be in the "Current password" field when the page loads. Signed-off-by: B Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:55:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:55:22 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:55:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:55:25 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112784|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 112788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112788&action=edit Bug 25700: Complete KohaCons informations in timeline Last entry for KohaCons on Koha timeline was for 2013. This patch : - adds KohaCons from 2014 to 2020 - adds missing link to KohaCons websites for events from 2006 to 2013 - suppresses dead links for old KohaCons - standardizes the display of informations To test, apply patch and check : - there is no typo (especially for October > Octobre) - order of dates is correct - links to Koha website ou wiki are correct Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:55:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:55:29 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112785|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 112789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112789&action=edit Bug 25700: (follow-up) Minor corrections to epoch dates It looks like we forgot to account for the year change when grabbing epoch dates for some of the later KohaCon's. This patch fixes those minor mistakes. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:55:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:55:33 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 --- Comment #20 from Katrin Fischer --- Created attachment 112790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112790&action=edit Bug 25700: (follow-up) 2 minor corrections for KohaCon This patch corrects : - the wrong link for KohaCon11 - a typo on 'workshops' for KohaCon19 - replace 'hackfest' for 'workshops' for KohaCon20 Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:57:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:57:30 +0000 Subject: [Koha-bugs] [Bug 26830] Set focus for cursor to name input box when creating a new list in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:57:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:57:34 +0000 Subject: [Koha-bugs] [Bug 26830] Set focus for cursor to name input box when creating a new list in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112593|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 112791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112791&action=edit Bug 26830: Set focus for cursor to name input box when creating a new list in the OPAC This patch adds the "focus" class to the list name input box in order to automatically set focus on the field. To test, apply the patch and log in to the OPAC. - Go to Lists -> New list. - The cursor focus should automatically be on the "list name" field. Signed-off-by: B Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 00:59:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2020 23:59:59 +0000 Subject: [Koha-bugs] [Bug 26753] Set focus for cursor to password field on Overdrive login popup on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:00:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:00:03 +0000 Subject: [Koha-bugs] [Bug 26753] Set focus for cursor to password field on Overdrive login popup on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112489|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 112792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112792&action=edit Bug 26753: Set focus for cursor to password field on Overdrive login popup on OPAC This patch modifies the OverDrive login process so that clicking the "Log in to your OverDrive account" link automatically puts the focus on the password field when the modal displays. Unrelated change: A redundant "document.ready" function has been removed. To test you must have OverDrive credentials set in system preferences. - Log in to the OPAC. - On the "Your summary" page, open the "OverDrive account" tab. - Click the "Log in to your OverDrive account" link. - A modal dialog should appear, and the cursor focus should automatically be on the password field. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:02:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:02:48 +0000 Subject: [Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- Hi Lucas, thx a lot for reworking this. I feel with the current size of the modal we have the same issue as with the inline one, that it's too small to get a good impression. Could we have this a bit bigger? Or maybe at least as wide as the graphics in it? Sorry to bother you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:26:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:26:11 +0000 Subject: [Koha-bugs] [Bug 26583] Unnecessary code in AddIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:26:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:26:15 +0000 Subject: [Koha-bugs] [Bug 26583] Unnecessary code in AddIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112484|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 112793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112793&action=edit Bug 26583: Remove unneccessary code in AddIssue The lines to calc due date are doubled ModDateLastSeen is not needed as we set the item not lost and we can set the date as we do for date last borrowed and save a DB store Largely this is reading the code and confirming the changes make sense To test: 1 - Apply patch 2 - Check out items, confirm it works as before 3 - prove -v t/db_dependent/Circulation.t Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:29:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:29:57 +0000 Subject: [Koha-bugs] [Bug 26487] Add all MARC flavours for not-onloan-count search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:30:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:30:01 +0000 Subject: [Koha-bugs] [Bug 26487] Add all MARC flavours for not-onloan-count search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112485|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 112794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112794&action=edit Bug 26487: Add all MARC flavours for not-onloan-count search field In admin/searchengine/elasticsearch/mappings.yaml the search field not-onloan-count is defined for MARC21 on 999x. This should be for all the MARC flavours, like in Zebra config. Test plan: 1) On a UNIMARC database 2) Reset Elasticsearch mappings 3) Check search engine config to see field 'not-onloan-count' on 999$x 4) Same on a NORMARC database Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:33:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:33:50 +0000 Subject: [Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:33:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:33:54 +0000 Subject: [Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112773|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 112795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112795&action=edit Bug 26806: Remove the jquery.checkboxes plugin from the staff client This patch removes the jquery.checkboxes plugin from the staff client. It also removes some leftover instances of the "checkboxed" class which was used in some cases to enable the checkbox plugin on selected elements. To test, apply the patch and check that the jquery.checkboxes plugin no longer exists in /intranet-tmpl/lib/jquery/plugins. To test changes to the templates, confirm that "Check all" and "Check none" links still work on these pages: - The tags review page. See the test plan for Bug 26120. - The inventory page. See the test plan for Bug 26150. - The list contents page. See the test plan for Bug 26204. The other modified templates contained the "checkboxed" class but it served no purpose: - Serials -> Serials collection - Labels -> Edit label batch - Patron cards -> Edit card batch If you search the Koha codebase for instances of "checkboxed" the only results should be from the OPAC (if Bug 26805 hasn't been applied) and in Z39.50 templates where the class is still used by JavaScript. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:35:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:35:39 +0000 Subject: [Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 --- Comment #4 from Katrin Fischer --- So glad to see this close to finished :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:46:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:46:22 +0000 Subject: [Koha-bugs] [Bug 26868] biblio and biblio_metadata tables timestamp do not update when moving an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26868 --- Comment #2 from Katrin Fischer --- I can understand the use case, but I feel like it would be giving wrong information somehow to update the timestamp on the record level without an actual change to the record. For example it would create extra updates over our API to the union catalog, where we don't transfer items, but only record changes. That probably would not be that many, but it might be worth seeing if we can figure out a different way to make the 'remove' of items known. How does Aspen Discovery get the record information from Koha, OAI-PMH? How does it deal with deleted items? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:47:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:47:21 +0000 Subject: [Koha-bugs] [Bug 26866] Items table on additem should sort by cn_sort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26866 --- Comment #3 from Katrin Fischer --- Thx, Andrew! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:50:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:50:12 +0000 Subject: [Koha-bugs] [Bug 26842] SIP should allow bib level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26842 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP should allow bib level |SIP should allow bib level |hols |holds --- Comment #1 from Katrin Fischer --- This sounds similar to your discussion with Nick on bug 26461, can you check if it's a duplicate maybe? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:53:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:53:24 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:53:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:53:51 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #1 from Katrin Fischer --- Confirmed on master with kohadevbox. My item was 39999000000276 from sample data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:57:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:57:11 +0000 Subject: [Koha-bugs] [Bug 26820] "Important" flag enforced only at subfield level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26820 --- Comment #1 from Katrin Fischer --- Hi Andrew, I tested with 243 and I do get the warning on saving once all mandatory fields are filled in. Could it be only the controlfields acting differently? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 01:59:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 00:59:08 +0000 Subject: [Koha-bugs] [Bug 26807] Relator term punctuation should not be automatically added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Realtor Term Punctuation |Relator term punctuation |should not be automatically |should not be automatically |added |added -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 02:10:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 01:10:58 +0000 Subject: [Koha-bugs] [Bug 26584] Remove unused C4::Acquisition::CloseBasket function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 02:11:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 01:11:02 +0000 Subject: [Koha-bugs] [Bug 26584] Remove unused C4::Acquisition::CloseBasket function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111010|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 112796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112796&action=edit Bug 26584: Remove unused C4::Acquisition::CloseBasket function This patch makes code use the new Koha::Acquisition::Basket->close method and makes CloseBasket obsolete. It then removes it, and adapts the few places in which it was used. 1. Apply this patch 2. Run: $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => SUCCESS: Tests pass! 3. Try playing with baskets, closing them => SUCCESS: All works as expected! 4. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 09:02:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 08:02:46 +0000 Subject: [Koha-bugs] [Bug 16063] logic from overdue_notice.pl should be moved into a module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16063 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at trust-box.at -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 09:16:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 08:16:19 +0000 Subject: [Koha-bugs] [Bug 26884] New: overdue_notices.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26884 Bug ID: 26884 Summary: overdue_notices.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: koha at trust-box.at QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz command line script overdue_notices.pl should 1. moved to a module (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16063) 2. refactored/cleaned up most importantly 3. made idempotent this could be achived via a checksum/signature including the "defining" fields for the message ie borrowernumber subject content metadata letter_code message_transport_type to_address from_address reply_address content_type so before a message is created a checksum is calculated and a look-up in the database is done whether the message already exists (maybe be ignored via a flag) so no matter how often or "how/too late" the script is executed, no message is "forgotten"/send multiple times -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 09:17:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 08:17:03 +0000 Subject: [Koha-bugs] [Bug 26884] overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26884 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at trust-box.at -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 12:35:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 11:35:59 +0000 Subject: [Koha-bugs] [Bug 26884] overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26884 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16063 --- Comment #1 from Katrin Fischer --- The first part is a duplicate with bug 16063 I think - You could move it there and make this bug about the second part only. I am not sure how big of a problem resending notices actually is. At least if you are using -t for triggering the notices using the overdue notice trigger set up and running the script daily. Do you have a use case where it might be an issue? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 12:35:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 11:35:59 +0000 Subject: [Koha-bugs] [Bug 16063] logic from overdue_notice.pl should be moved into a module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26884 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 12:45:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 11:45:05 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 --- Comment #13 from Katrin Fischer --- I am wondering about the use of the inline style. I know it has been there before, but as we already moved things to the scss, maybe we could finish it off here? I think it might be nicer to have both the locked and the lock in black. Red is a warnung color, but there is not really an error or danger in it being locked, so I think having both black would be ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 12:53:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 11:53:32 +0000 Subject: [Koha-bugs] [Bug 26884] overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26884 --- Comment #2 from Mark Hofstetter --- just judging from my experience i'd say the concept of the triggered notice "feels fragile". You depend on the fact that script is run exactly once daily, it will mostly work, but won't if anything goes wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 12:56:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 11:56:32 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 12:56:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 11:56:36 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112649|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 112797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112797&action=edit Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text. There is a space between the lock icon and the 'Locked' text. Sponsored-by: Catalyst IT Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 12:56:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 11:56:40 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 --- Comment #15 from Katrin Fischer --- Created attachment 112798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112798&action=edit Bug 24012: (QA follow-up) Use standard patterns - Removes the scss change in favor of adding the space to the HTML as is the usual pattern when using Font Awesome icons - Removes the span with the inline style to make things appear as black by default (no danger here in it being locked?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 12:57:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 11:57:27 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 --- Comment #16 from Katrin Fischer --- Attached a follow-up simplifying things a little bit. Can you please check if that would be alright? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 12:58:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 11:58:45 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:15:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:15:38 +0000 Subject: [Koha-bugs] [Bug 26884] overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26884 --- Comment #3 from Katrin Fischer --- I think it all might depend a bit on how your overdues and fines process looks like. Not trying to shoot down your idea, just trying to help out here with the bug and interested in learning about others use cases. In general separate issues should go on separate bugs and descriptive bug titles are key. You can use the 'depends', 'Blocks' and 'See also' to build dependencies. You can also have an "[Omnibus]" improvements bug that serves as a central access point with the patches on separate bugs linked to it. In our use case the timing of the overdue notices is quite important, especially since they are supposed to go out on a specific schedule and the same day a fine is added if fines are used. Some careful configuration is required to achieve this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:16:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:16:07 +0000 Subject: [Koha-bugs] [Bug 26884] overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26884 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC|robin at catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:20:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:20:37 +0000 Subject: [Koha-bugs] [Bug 26885] New: Some text in OPAC is falsely colored Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26885 Bug ID: 26885 Summary: Some text in OPAC is falsely colored Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org 2 examples: - Go to the lists in OPAC and look for the "new list" link - Go to the search history in OPAC and look for the "select all" link Both appear as white text on light grey background. I am not sure if this is already fixed by another bug in the queue, so filing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:23:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:23:40 +0000 Subject: [Koha-bugs] [Bug 26886] New: OPAC suggestions: possible duplicate message should stand out more Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 Bug ID: 26886 Summary: OPAC suggestions: possible duplicate message should stand out more Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I believe this message was styled differently pre Bootstrap update and stood out a bit more visually. To test: - Create a new suggestion in the OPAC for a title named test. - Create another suggestion for "Test". - Verify the duplicate message shows and the suggestion is not saved: A similar document already exists: Test. Click on "Confirm your suggestion" to ignore this message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:25:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:25:00 +0000 Subject: [Koha-bugs] [Bug 26887] New: Missing content types in advance search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26887 Bug ID: 26887 Summary: Missing content types in advance search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: tejoskumar at gmail.com QA Contact: testopia at bugs.koha-community.org The below mentioned additional content types are missing in the advanced search additional content types which are provided in the 008(24). Please add these search content types also. offprints Calendars Comics/Graphic Novels Standards/Specifications Year Books -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:27:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:27:48 +0000 Subject: [Koha-bugs] [Bug 26888] New: New installer: Make it possible to set active currency according to language Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26888 Bug ID: 26888 Summary: New installer: Make it possible to set active currency according to language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org At the moment Koha will be installed with the default currencies available in the en installer if you switch to the new installer yml files. This means USD will be the active currency independent of the language you install with. It would be great if this could be changed. For example for de-DE we would always want to set EUR. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:27:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:27:49 +0000 Subject: [Koha-bugs] [Bug 26882] New installer: Make it possible to use a language specific holidays file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26882 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26888 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:27:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:27:49 +0000 Subject: [Koha-bugs] [Bug 26829] New installer: Make it possible to use a language specific sample quotes file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26829 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26888 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:30:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:30:01 +0000 Subject: [Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:30:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:30:05 +0000 Subject: [Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112594|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 112799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112799&action=edit Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC This patch removes the use of the jquery.checkboxes plugin from the 5 templates in the OPAC which still use it. The plugin itself is removed. To test, apply the patch and test the "Select all" and "Clear all" links work to select and deselect checkboxes on the following pages: - The catalog search results page: The controls should also enable and disable the "Select titles to..." menu. - The list contents page: The controls should also enable and disable the "Select titles to..." links. - The suggestions page: The controls should also enable and disable the "Select suggestions to..." link. - The search history page: The controls should affect only the corresponding table ("Current" or "Previous") and should enable and disable the "Select searches to..." link. This patch also modifies the template for grouped search results, as enabled by the OpacGroupResults system preference, but I don't know how to test it. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:33:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:33:59 +0000 Subject: [Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:34:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:34:03 +0000 Subject: [Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112584|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 112800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112800&action=edit Bug 26833: Logged in library doesn't show with suggestions count This patch corrects the template variables used by the suggestions counts shown on the staff interface home page and the acquisitions home page. They should use [% Branches.GetLoggedInBranchname %] To test you should have some suggestions from multiple libraries. - Log in to the staff interface. - On the home page you should see "Suggestions pending approval," followed by the name of your logged-in library and the count of suggestions for your library. - Go to the acquisitions page. - In the "Pending suggestions" section you should see the same information: Your logged-in library name, suggestion count, and the count of suggestions at all libraries. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 13:36:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 12:36:28 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #123 from Katrin Fischer --- (In reply to Hugo Agud from comment #122) > We have identified one issue this this functionality, when there is no value > in the variable isbn, issn.. or wathever the patch generate the > anyway generating an empty thumnail link. Please move this to a separate bug report linked to this one - this is already in released versions so it needs to be fixed on a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:10:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:10:13 +0000 Subject: [Koha-bugs] [Bug 26584] Remove unused C4::Acquisition::CloseBasket function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:10:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:10:16 +0000 Subject: [Koha-bugs] [Bug 26584] Remove unused C4::Acquisition::CloseBasket function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112796|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 112801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112801&action=edit Bug 26584: Remove unused C4::Acquisition::CloseBasket function This patch makes code use the new Koha::Acquisition::Basket->close method and makes CloseBasket obsolete. It then removes it, and adapts the few places in which it was used. 1. Apply this patch 2. Run: $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => SUCCESS: Tests pass! 3. Try playing with baskets, closing them => SUCCESS: All works as expected! 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:12:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:12:24 +0000 Subject: [Koha-bugs] [Bug 26724] Improve link text for downloading the CSV file on patron import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:12:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:12:27 +0000 Subject: [Koha-bugs] [Bug 26724] Improve link text for downloading the CSV file on patron import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 --- Comment #11 from Katrin Fischer --- Created attachment 112802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112802&action=edit Bug 26724: Improve link text for downloading the CSV file on patron import page. On tools > Patron Import there is a a link labelled "here" on the right side that should be more descriptive. This patch updates the link. To test: 1. Go to tools 2. Under patrons select "Import Patrons" 3. On the right side of the screen, observe the "here" link in the second list item. 4. Apply patch. 5. Reload page 6. Observe the updated link text. 7. Sign off https://bugs.koha-community.org/show_bug.cgi?id=26724 Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:16:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:16:09 +0000 Subject: [Koha-bugs] [Bug 26605] Correctly URI-encode query string in call number browse plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26605 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:16:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:16:12 +0000 Subject: [Koha-bugs] [Bug 26605] Correctly URI-encode query string in call number browse plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26605 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112486|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 112803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112803&action=edit Bug 26605: Correctly URI-encode query string in call number browse plugin If you search for a call number like "M KRUEGER CO #11" in the cn_browser.pl plugin, your query is cut off at "M KRUEGER CO " because the hash isn't escaped, so the browser thinks you are opening a window and trying to navigate to the element with the id 11 rather than passing the #11 to the server. To test: 1) Find the record you will use to test, determing the MARC framework it uses by going to Edit > Edit record > Settings 2) In Administration > MARC bibliographic framework, click MARC structure in the Actions menu for that framework 3) Navigate to the 952 tag, in the Actions menu click Edit subfields 4) In the tab for o, choose the Plugin cn_browser.pl and click Save Changes 5) Click the Edit button next to one of the items on your record 6) In the Full call number field, add " CO #11" to the call number 7) Click the ... next to the field to open the Tag editor 8) In the popup window, verify that the search field includes the " CO #11" you added to the call number Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:18:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:18:52 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- FAIL Koha/SearchEngine/Elasticsearch/QueryBuilder.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling FAIL valid \3 better written as $3 \4 better written as $4 Can you please check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:22:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:22:24 +0000 Subject: [Koha-bugs] [Bug 18051] Advanced Editor - Rancor - encoding issues with some sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18051 --- Comment #11 from Katrin Fischer --- Thx Nick for taking this on and to Barbara for providing the extra information! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:22:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:22:47 +0000 Subject: [Koha-bugs] [Bug 18051] Advanced Editor - Rancor - encoding issues with some sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18051 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:22:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:22:50 +0000 Subject: [Koha-bugs] [Bug 18051] Advanced Editor - Rancor - encoding issues with some sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18051 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112664|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 112804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112804&action=edit Bug 18051: Set UTF8 Flag for record searches/imports from rancor The advanced cataloging editor uses Koha::MetaSearcher to find and import records from Z3950. The records are correctly converted to UTF8, however, we need to set the flag in the record to ensure they are parsed correctly later To test: 1 - Add OHIOLINK as a z39 source as described in earlier comments 2 - Browse to Cataloging->Advanced editor 3 - Click Search->Advanced 4 - Select OHIOLINK 5 - Search for author 'capek karel' 6 - Note records look bad 7 - Apply patch 8 - Restart all the things 9 - Repeat 10 - Success! Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:28:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:28:01 +0000 Subject: [Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515 --- Comment #7 from Katrin Fischer --- I notice that this moves "Local catalog" to the top from the bottom. But I think I like this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:28:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:28:57 +0000 Subject: [Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:29:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:29:01 +0000 Subject: [Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112592|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 112805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112805&action=edit Bug 17515: Order Z3950 server by rank and preserve ordering Previously we put all the servers into an object with keys of the server id This patch converts it to an array of objects to preserve order, and adjusts code to use the array index where necessary and store the server id within the array To test: 1 - Add some new Z3950 servers, they don't need to be valid FIRST SECOND THIRD FOURTH 2 - Adjust the ranking so FOURTH:1 THIRD:2 SECOND:3 FIRST:4 3 - Enable and launch the advanced editor 4 - Click 'Advanced' under search on the left 5 - Note the list displays in the order you entered the servers 6 - Apply patch 7 - Reload 8 - Order is correct 9 - With valid servers, confirm that searching still works and servers can be checked or unchecked to include/remove from results https://bugs.koha-community.org/show_bug.cgi?id=17515 Signed-off-by: B Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:39:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:39:36 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:39:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:39:40 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112138|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 112806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112806&action=edit Bug 25333: Change message transport type for Talking Tech from "phone" to "itiva" >From its inception, phone notices via Talking Tech have not behaved like other notices. Instead of reading notices generated by Koha, the Talking Tech scripts largely generate their own notices. We would like to pave the way to having "generic" phone notices that can be processed by plugins to support arbitrary telephony vendors ( we will be targeting Twilio initially ). To that end, it seems sensible to begin by changing the messaage transport type for Talking Tech from 'phone' to 'itiva' to highlight its specificity and difference from standard message transports. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Test Talking Tech outbound script 5) Note no changes in functionality Signed-off-by: Christopher Zorn Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=25334 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:39:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:39:43 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112669|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 112807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112807&action=edit Bug 25333: (QA follow-up) Update opac messaging for new transport name Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:39:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:39:47 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 --- Comment #13 from Katrin Fischer --- Created attachment 112808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112808&action=edit Bug 25333: (QA follow-up) Change phone to itiva on overduerules.tt Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:54:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:54:13 +0000 Subject: [Koha-bugs] [Bug 26889] New: Remove extra space from "Damaged :" in item search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Bug ID: 26889 Summary: Remove extra space from "Damaged :" in item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The item search displays an extra space between the search label and the following : on the item search form. I did some tracking but was not able to see where it came from. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:54:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:54:19 +0000 Subject: [Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:55:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:55:18 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112707|0 |1 is obsolete| | Attachment #112710|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Created attachment 112809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112809&action=edit Bug 26032: Add unit test Run prove t/db_dependent/Items.t Signed-off-by: Emmi Takkinen Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:55:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:55:21 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112708|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 112810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112810&action=edit Bug 26032: Add 'is new' filter in items search In items search, add a filter on value of items.new_status with a Ignore/Yes/No. Yes meaning != 0, No meaning = 0, with considering that NULL value is like 0. This patch adds 'isnull' option to filter, this may be reused on other fields. Test plan : 1) Define an item subfield on items.new_status with authorised values YES_NO (0 or 1) 2) Edit an item A to set new_status=1 3) Edit an item B to set new_status=0 4) Perform an item search with 'is new' = 'ignore' => you get all items 5) Perform an item search with 'is new' = 'yes' => you get item A 6) Perform an item search with 'is new' = 'no' => you get all items but A Signed-off-by: Emmi Takkinen Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:55:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:55:25 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112709|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer --- Created attachment 112811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112811&action=edit Bug 26032: (follow-up) Replace IFNULL() mysqlism with COALESCE() Signed-off-by: Emmi Takkinen Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:55:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:55:29 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #26 from Katrin Fischer --- Created attachment 112812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112812&action=edit Bug 26032: (follow-up) show 'is new' filter only if items.new_status is used Also adds a class 'item-new-status' to this filter to be able to hidde even if items.new_status used. Addition to test plan: 1) Apply on a database without Koha to MARC mapping on items.new_status 2) Check you dont see the 'is new' filter in items search form 3) Apply on a database with Koha to MARC mapping on items.new_status 4) Check you see class 'form-field item-new-status' Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:56:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:56:31 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112786|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 14:57:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 13:57:10 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:01:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 14:01:25 +0000 Subject: [Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 --- Comment #11 from Katrin Fischer --- Nick, can you fix your QA please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:09:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 14:09:25 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #191 from Katrin Fischer --- There is one small glitch here: It allows you to hide the field using the "*unwanted*" preferences, but the pulldown itself does not change according to the hidden fields. I feel that if a library decides to hide "Fax" in the OPAC, we should also remove this entry from the pull down. I think it should not be too hard to do (I hope I am right), can you please check? I am not sure if we will need changes to the API Patron/Patrons routes too. Something else to look into. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:16:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 14:16:52 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #115 from Arthur Suzuki --- Huuum... Hi David, Sorry, can't reproduce, this is what I got. Can you post verbose log? (in the meantime i'll try to clear those warnings) root at kohadevbox:koha(bz11999)$ prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 1/67 Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. Use of uninitialized value $caller in index at /kohadevbox/koha/C4/Reserves.pm line 429. t/db_dependent/Holds.t .. ok All tests successful. Files=1, Tests=67, 5 wallclock secs ( 0.03 usr 0.01 sys + 3.68 cusr 0.38 csys = 4.10 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:19:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 14:19:16 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #89 from Katrin Fischer --- I am kind of missing unit tests here for the new and changed subs? There is also an issue here in that the search terms from the left side search or the table search are no longer retained. To test: - Enter a search term in either of the search fields - Add a note, receive or do another action - The search term is kept - Apply this patch set - Repeat actions - The search term is now lost Especially when dealing with a long list of orders this is an important feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:19:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 14:19:38 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Slowness in Receiving in |Slowness in receiving in |Acquisitions |acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 15:25:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 14:25:39 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #90 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #89) > I am kind of missing unit tests here for the new and changed subs? Which ones? > There is also an issue here in that the search terms from the left side > search or the table search are no longer retained. > > To test: > - Enter a search term in either of the search fields > - Add a note, receive or do another action > - The search term is kept > - Apply this patch set > - Repeat actions > - The search term is now lost > > Especially when dealing with a long list of orders this is an important > feature. This is paired with the multiple receive patches (dependency) but I see this would be a blocker. I will provide a follow-up to retain that feature in the meantime. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 22:26:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 21:26:06 +0000 Subject: [Koha-bugs] [Bug 26890] New: opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 Bug ID: 26890 Summary: opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: koha at trust-box.at QA Contact: testopia at bugs.koha-community.org enable opac-detail to use the same/similar plugin infrastructure as in intranet/cgi-bin/catalogue/detail.pl 68 my @plugins = Koha::Plugins->new()->GetPlugins({ 69 method => 'intranet_catalog_biblio_enhancements_toolbar_button' 70 }); 71 72 my @tab_plugins = Koha::Plugins->new()->GetPlugins({ 73 method => 'intranet_catalog_biblio_tab', 74 }); 75 my @tabs; 76 foreach my $tab_plugin (@tab_plugins) { 77 my @biblio_tabs; 78 to add a new tab in opac-detail.pl result page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 22:47:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 21:47:22 +0000 Subject: [Koha-bugs] [Bug 26422] Can't call method "title" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-detail.pl line 459. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26422 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at trust-box.at --- Comment #1 from Mark Hofstetter --- I had a similiar problem, please check if your data is consistent ie test libraries or something like this maybe upgrade to a recent version of koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 22:52:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 21:52:55 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Component|OPAC |Plugin architecture -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 23:29:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 22:29:22 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- (In reply to Joonas Kylmälä from comment #0) > The SIP2 server L1 cache is still too long, it is per connection rather than > per SIP2 message. The bug 23640 made the cache per connection but we would > need it to be per sip2 message because the SIP2 machines don't close the > connections after every SIP2 message and so it might be many days or weeks > before the new circ rules, sysprefs, etc. take effect. I wondered at the time if clearing the cache per connection was going to be too infrequent... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 23:37:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 22:37:52 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 1 23:58:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Nov 2020 22:58:02 +0000 Subject: [Koha-bugs] [Bug 26884] overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26884 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- Sound like some good improvements, but I agree with Katrin. This bug should have a more descriptive title, and individual changes should be in their own bug reports. This one can be an "OMNIBUS" report if you are concerned with grouping together the different changes. I would add too that unless you're planning to make these changes, Mark, it's unlikely that anyone else is going to make them. Refactoring usually only happens if it's part of a different change. (For instance, I'm planning to refactor export.pl and its supporting libraries as part of an architectural change which needs to call the code differently.) But thumbs up for the proposed changes. Most Koha scripts would benefit from being moved into modules, so it's certainly a worthwhile idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 05:08:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 04:08:25 +0000 Subject: [Koha-bugs] [Bug 26832] Elasticsearch mappings export should use UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26832 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 05:08:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 04:08:28 +0000 Subject: [Koha-bugs] [Bug 26832] Elasticsearch mappings export should use UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26832 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112546|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 112813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112813&action=edit Bug 26832: Make Elasticsearch mappings export use UTF-8 Script misc/search_tools/export_elasticsearch_mappings.pl allows to export current search engine configuration into a YAML file. This export should use UTF-8 encoding, like other exports. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) Edit a field label to use a diacrtic, for example local-number => Numéro 3) Save 4) Edit file etc/koha-conf.xml to enable 'elasticsearch_index_mappings' 5) Export mappings to file via misc/search_tools/export_elasticsearch_mappings.pl -t $MARCFLAVOUR 6) Reset memcached and plack 7) Back to Administration > Search engine configuration (Elasticsearch) 8) Click on 'Reset Mappings' and accept 9) Look at field 'local-number' => Without patch diacritic 'é' is broken 10) You may try with an emoji B-) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 05:14:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 04:14:45 +0000 Subject: [Koha-bugs] [Bug 26832] Elasticsearch mappings export should use UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26832 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I hope I tested this right! I followed the test plan without applying the patch. I got an error with resetting the mappings at steps 8-9: DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect string value: '\xE9ro' for column 'label' at row 1 at /kohadevbox/koha/Koha/Objects.pm line 114 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Notes for testing using koha-testing-docker: 1. Before starting testing setup elastic search as the search engine: i. Enable Elasticsearch: system preference SearchEngine ii. Reindex: koha-elasticsearch --rebuild -b -a kohadev 2. For step 4: i. Uncomment in /etc/koha/sites/kohadev/koha-conf.xml: ii. Note the location of the file: /etc/koha/sites/kohadev/searchengine/elasticsearch/mappings.yaml iii. Create the directories: searchengine and elasticsearch 3. For step 5: i. misc/search_tools/export_elasticsearch_mappings.pl -t marc21 > /etc/koha/sites/kohadev/searchengine/elasticsearch/mappings.yaml ii. Check that the mappings.yaml file was created iii. Change ownership: chown -R kohadev-koha:kohadev-koha /etc/koha/sites/kohadev/searchengine 4. I got errors in the user interface, a trace error page when trying to Reset Mappings, and when trying to reindex. 5. I got past this by: i. applying the patch ii. disabling in koha-conf.xml iii. flush_memcached, restart_all iv. Reset Mappings v. rerunning through the test plan (see notes 2 and 3 above) 6. To check if the file is UTF-8 use uchardet command: i. Install uchardet: apt-get install uchardet ii. Check the file format: uchardet /etc/koha/sites/kohadev/searchengine/elasticsearch/mappings.yaml iii. It should show as being UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:06:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 07:06:09 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #31 from Séverine Queune --- Definitely bad luck on that one... Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8179: Add tests Applying: Bug 8179: Add syspref to database Applying: Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference confi guration Applying: Bug 8179: Receive multiple orders fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/m odules/acqui/parcel.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8179: Receive multiple orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:21:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 07:21:46 +0000 Subject: [Koha-bugs] [Bug 25898] Prohibit indirect object notation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target, | |RM_priority | --- Comment #16 from Jonathan Druart --- (In reply to Mason James from comment #15) > Created attachment 112525 [details] [review] > Bug 25898: fix Parallel::ForkManager call in debian/list-deps > > fix Parallel::ForkManager call in debian/list-deps Patch pushed to master (by Tomas on Oct 26). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:42:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 07:42:17 +0000 Subject: [Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 --- Comment #20 from Jonathan Druart --- David, this change makes t/00-testcritic.t fail on # Failed test 'Test::Perl::Critic for "C4/Barcodes/ValueBuilder.pm"' # at /usr/share/perl5/Test/Perl/Critic.pm line 121. # # Package declaration must match filename at line 19, column 1. Correct the filename or package statement. (Severity: 5) # Failed test 'Test::Perl::Critic for "Koha/Z3950Responder/RPN.pm"' # at /usr/share/perl5/Test/Perl/Critic.pm line 121. # # Package declaration must match filename at line 1, column 1. Correct the filename or package statement. (Severity: 5) I am aware of bug 26683 but I'd like a quick fix to have the tests green now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:43:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 07:43:15 +0000 Subject: [Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 --- Comment #21 from Jonathan Druart --- Created attachment 112814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112814&action=edit Bug 26673: Fix perlcritic complains This patch fixes the following perlcritic complain: Package declaration must match filename at line 19, column 1. Correct the filename or package statement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:45:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 07:45:00 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #83 from Joonas Kylmälä --- (In reply to David Nind from comment #82) > - Before the patch is applied: the tests pass > - After changing the search engine system preference to elasticsearch and > reindexing: tests fail > - After patch applied: tests fail > - After 1,000 records added and merging: tests fail This seems to be the same case as in comment 67. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 08:46:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 07:46:59 +0000 Subject: [Koha-bugs] [Bug 26877] Add ability for libraries to be able to restart the SIP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26877 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:00:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:00:18 +0000 Subject: [Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:00:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:00:26 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:08:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:08:34 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #156 from Jonathan Druart --- (In reply to Katrin Fischer from comment #155) > The vue patches apply nicely, but the the other POC patches have too many > conflicts. Would love to be able to compare a bit on the different design > approaches. Use the remote branch at https://gitlab.com/joubu/Koha/commits/bug_15522 Not up-to-date but you will be able to compare the 2 approaches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:12:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:12:35 +0000 Subject: [Koha-bugs] [Bug 26724] Improve link text for downloading the CSV file on patron import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #112586|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:15:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:15:13 +0000 Subject: [Koha-bugs] [Bug 26480] With UseControlNumber on, "Show analytics" link doesn't show on parent record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26480 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Keywords| |rel_20_11_target CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:22:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:22:33 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:22:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:22:37 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111358|0 |1 is obsolete| | Attachment #111359|0 |1 is obsolete| | Attachment #111360|0 |1 is obsolete| | Attachment #111361|0 |1 is obsolete| | Attachment #111362|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart --- Created attachment 112815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112815&action=edit Bug 24488: Show correct first patron details on Holds to pull This patch rewrites the complex search query to reduce the risk of reordering the results multiple times. This patch includes a change to schema files so may need to upgrade schema and/or restart memcached To test: 1) Reproduce problem following test plan in Description 2) Apply patch and refresh page 3) Notice the correct patron is now shown 4) Play with date selection, confirm correct results are still shown 5) Test cancelling holds 6) Test filtering table results 7) Test with biblios with multiple items 8) Test with making items unavailable (i.e. not for loan, checked out) Sponsored by: IHC New Zealand Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:22:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:22:41 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #60 from Jonathan Druart --- Created attachment 112816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112816&action=edit Bug 24488: Fix reserve.reserve_id' isn't in GROUP BY Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:22:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:22:45 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #61 from Jonathan Druart --- Created attachment 112817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112817&action=edit Bug 24488: Display patron with the highest priority hold Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:22:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:22:49 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #62 from Jonathan Druart --- Created attachment 112818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112818&action=edit Bug 24488: Simplify searches It also: Use dtf for date handling add missing td Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:22:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:22:53 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #63 from Jonathan Druart --- Created attachment 112819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112819&action=edit Bug 24488: [DISCUSSION] For comparaison I'd like someone to run a benchmark with and without this patch on a quite big database and see which approach is the best Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:23:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:23:19 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #64 from Jonathan Druart --- (In reply to Katrin Fischer from comment #58) > Neither the original patches nor Joubu's alternative(?) apply at the moment. > I feel like we got a bit stuck here. Easy conflict solved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:23:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:23:54 +0000 Subject: [Koha-bugs] [Bug 26086] Add a 'cron' interface limit to the log viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26086 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Who signed the|This enhancement adds the | patch off|option to limit viewing | |logged actions done by cron | |only | Text to go in the| |This enhancement adds the release notes| |option to limit viewing | |logged actions done by cron | |only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:24:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:24:14 +0000 Subject: [Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Who signed the|This enhancement adds the | patch off|option to limit viewing | |logged actions done by API | |only | Text to go in the| |This enhancement adds the release notes| |option to limit viewing | |logged actions done by API | |only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:24:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:24:41 +0000 Subject: [Koha-bugs] [Bug 25694] Add ability to delete a MARC modification template when viewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25694 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Who signed the|This enhancement adds a | patch off|'Delete template' button on | |the page for viewing the | |actions of a MARC | |modification template. | Text to go in the| |This enhancement adds a release notes| |'Delete template' button on | |the page for viewing the | |actions of a MARC | |modification template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:47:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:47:15 +0000 Subject: [Koha-bugs] [Bug 26581] Elasticsearch - Records can be indexed multiple times during returns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26581 --- Comment #19 from Jonathan Druart --- (In reply to Nick Clemens from comment #18) > Created attachment 112578 [details] [review] > Bug 26581: (follow-up) Restore unsetting of doreturn Is this supposed to fix comment 16? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 09:56:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 08:56:52 +0000 Subject: [Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|cookie | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:05:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:05:13 +0000 Subject: [Koha-bugs] [Bug 26781] Marc Modification Templates treat subfield 0 and no subfield set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26781 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- There is a failing test: t/db_dependent/MarcModificationTemplates.t .. 1/126 # Failed test '100$0 has been deleted, added back, updated, moved to 600$0, and copied back to 100$0; finally, 245$0 has been copied and replaced to 700$0' # at t/db_dependent/MarcModificationTemplates.t line 799. # Structures begin differing at: # $got->{_fields}[2]{_ind1} = '1' # $expected->{_fields}[2]{_ind1} = ' ' # Looks like you failed 1 test of 126. Please fix ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:20:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:20:38 +0000 Subject: [Koha-bugs] [Bug 26891] New: Manual: Incorrect image on 'Make payment' documentation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26891 Bug ID: 26891 Summary: Manual: Incorrect image on 'Make payment' documentation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Amongst the bullet point list on the payment/void section of the manual, https://koha-community.org/manual/20.11/en/html/patrons.html#pay-void-fines, is an image of the MARC modification templates. This doesn't belong here.. but I'm not sure what image it should be. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:20:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:20:44 +0000 Subject: [Koha-bugs] [Bug 26891] Manual: Incorrect image on 'Make payment' documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26891 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:20:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:20:56 +0000 Subject: [Koha-bugs] [Bug 26891] Manual: Incorrect image on 'Make payment' documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26891 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:26:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:26:34 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:31:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:31:25 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112806|0 |1 is obsolete| | Attachment #112807|0 |1 is obsolete| | Attachment #112808|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 112820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112820&action=edit Bug 25333: Change message transport type for Talking Tech from "phone" to "itiva" >From its inception, phone notices via Talking Tech have not behaved like other notices. Instead of reading notices generated by Koha, the Talking Tech scripts largely generate their own notices. We would like to pave the way to having "generic" phone notices that can be processed by plugins to support arbitrary telephony vendors ( we will be targeting Twilio initially ). To that end, it seems sensible to begin by changing the messaage transport type for Talking Tech from 'phone' to 'itiva' to highlight its specificity and difference from standard message transports. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Test Talking Tech outbound script 5) Note no changes in functionality Signed-off-by: Christopher Zorn Signed-off-by: Katrin Fischer JD amended patch: remove uneeded indentation change in sample_notices_message_transports.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:31:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:31:28 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 --- Comment #15 from Jonathan Druart --- Created attachment 112821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112821&action=edit Bug 25333: (QA follow-up) Update opac messaging for new transport name Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:31:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:31:32 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 --- Comment #16 from Jonathan Druart --- Created attachment 112822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112822&action=edit Bug 25333: (QA follow-up) Change phone to itiva on overduerules.tt Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:40:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:40:09 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 --- Comment #17 from Jonathan Druart --- Kyle, on bug 25334 it seems that the final goal is to have a plugin for the phone notifications. In that case, should not we have "itiva" code moved to a plugin and so remove "itiva"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:41:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:41:56 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #33 from Jonathan Druart --- Waiting for an answer here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:54:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:54:58 +0000 Subject: [Koha-bugs] [Bug 26605] Correctly URI-encode query string in call number browse plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |13364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 [Bug 13364] Add a call number browser to add item page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:54:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:54:58 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26605 [Bug 26605] Correctly URI-encode query string in call number browse plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:57:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:57:03 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #157 from Katrin Fischer --- (In reply to Jonathan Druart from comment #156) > (In reply to Katrin Fischer from comment #155) > > The vue patches apply nicely, but the the other POC patches have too many > > conflicts. Would love to be able to compare a bit on the different design > > approaches. > > Use the remote branch at https://gitlab.com/joubu/Koha/commits/bug_15522 > Not up-to-date but you will be able to compare the 2 approaches. Augustin made a branch for me after I posted this and I had a look - I think both have advantages so it's really not an easy one. What I miss is an overview kind of page like we have now - not to use it for editing, but to easily see what applies and to be able to export/print when needed even. Not sure if that is something that has been considered as a possible part of the developments. I think Augustin's does a little nicer job in showing which rule applies easily, but you have to make the necessary selections first. The first one I like better for a better/faster editing/adding experience. It's hard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 10:59:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 09:59:17 +0000 Subject: [Koha-bugs] [Bug 26702] Remove explicit libnet-stomp-perl from debian/control.in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26702 --- Comment #7 from Jonathan Druart --- Mason, not directly related to this patch but, I wanted to push the changes to debian/control along with this patch and I have: - libreadonly-xs-perl, and + libtest-harness-perl, Should we deal with them on a separate bug report? Is that new or something you are aware of already? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:09 +0000 Subject: [Koha-bugs] [Bug 13701] Sharing lists: Text hardcoded to 2 weeks, but could be any time frame In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13701 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:11 +0000 Subject: [Koha-bugs] [Bug 13701] Sharing lists: Text hardcoded to 2 weeks, but could be any time frame In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13701 --- Comment #13 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:13 +0000 Subject: [Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:15 +0000 Subject: [Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:16 +0000 Subject: [Koha-bugs] [Bug 18051] Advanced Editor - Rancor - encoding issues with some sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:18 +0000 Subject: [Koha-bugs] [Bug 18051] Advanced Editor - Rancor - encoding issues with some sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18051 --- Comment #13 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:20 +0000 Subject: [Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:22 +0000 Subject: [Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #68 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:24 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:26 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 --- Comment #21 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:28 +0000 Subject: [Koha-bugs] [Bug 26487] Add all MARC flavours for not-onloan-count search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:30 +0000 Subject: [Koha-bugs] [Bug 26487] Add all MARC flavours for not-onloan-count search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26487 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:31 +0000 Subject: [Koha-bugs] [Bug 26583] Unnecessary code in AddIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:33 +0000 Subject: [Koha-bugs] [Bug 26583] Unnecessary code in AddIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:35 +0000 Subject: [Koha-bugs] [Bug 26605] Correctly URI-encode query string in call number browse plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:36 +0000 Subject: [Koha-bugs] [Bug 26605] Correctly URI-encode query string in call number browse plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26605 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:38 +0000 Subject: [Koha-bugs] [Bug 26702] Remove explicit libnet-stomp-perl from debian/control.in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26702 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:40 +0000 Subject: [Koha-bugs] [Bug 26702] Remove explicit libnet-stomp-perl from debian/control.in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26702 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:42 +0000 Subject: [Koha-bugs] [Bug 26706] Fix btn-default styling for better contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:44 +0000 Subject: [Koha-bugs] [Bug 26706] Fix btn-default styling for better contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26706 --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:46 +0000 Subject: [Koha-bugs] [Bug 26723] Improve link text on OverDriveAuthName system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:47 +0000 Subject: [Koha-bugs] [Bug 26723] Improve link text on OverDriveAuthName system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26723 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:49 +0000 Subject: [Koha-bugs] [Bug 26724] Improve link text for downloading the CSV file on patron import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:51 +0000 Subject: [Koha-bugs] [Bug 26724] Improve link text for downloading the CSV file on patron import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 --- Comment #12 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:53 +0000 Subject: [Koha-bugs] [Bug 26758] Correct OPAC ILL requests page markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:54 +0000 Subject: [Koha-bugs] [Bug 26758] Correct OPAC ILL requests page markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:56 +0000 Subject: [Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:05:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:05:58 +0000 Subject: [Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:06:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:06:00 +0000 Subject: [Koha-bugs] [Bug 26816] Remove extra space before comma in staff results item list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:06:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:06:01 +0000 Subject: [Koha-bugs] [Bug 26816] Remove extra space before comma in staff results item list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26816 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:06:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:06:02 +0000 Subject: [Koha-bugs] [Bug 26581] Elasticsearch - Records can be indexed multiple times during returns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26581 --- Comment #20 from Jonathan Druart --- (In reply to Nick Clemens from comment #18) > Created attachment 112578 [details] [review] > Bug 26581: (follow-up) Restore unsetting of doreturn Pushed to master for 20.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:06:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:06:03 +0000 Subject: [Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:06:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:06:05 +0000 Subject: [Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:06:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:06:18 +0000 Subject: [Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 --- Comment #22 from Jonathan Druart --- (In reply to Jonathan Druart from comment #21) > Created attachment 112814 [details] [review] > Bug 26673: Fix perlcritic complains > > This patch fixes the following perlcritic complain: > Package declaration must match filename at line 19, column 1. Correct the > filename or package statement. Pushed to master for 20.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:10:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:10:32 +0000 Subject: [Koha-bugs] [Bug 26398] Credit and Debit types on creating a manual credits and manual invoices are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:26:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:26:32 +0000 Subject: [Koha-bugs] [Bug 26892] New: Remove warnings from t/db_dependent/Koha/Patrons.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 Bug ID: 26892 Summary: Remove warnings from t/db_dependent/Koha/Patrons.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 25515 Those tests generate a lot of warnings "item-level_itypes set but no itemtype set for item" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:26:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:26:32 +0000 Subject: [Koha-bugs] [Bug 25515] Remove warnings and errors from tests output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:27:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:27:38 +0000 Subject: [Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:27:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:27:41 +0000 Subject: [Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 --- Comment #1 from Jonathan Druart --- Created attachment 112823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112823&action=edit Bug 26892: Remove warnings from Koha/Patrons.t Test plan: Confirm that the warnings "item-level_itypes set but no itemtype set for item" disappear after applying this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:30:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:30:32 +0000 Subject: [Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #69 from Jonathan Druart --- Created attachment 112824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112824&action=edit Bug 22806: Remove perlcritic errors Subroutine "new" called using indirect syntax at line 415, column 18. See page 349 of PBP. (Severity: 4) Subroutine "new" called using indirect syntax at line 420, column 14. See page 349 of PBP. (Severity: 4) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:37:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:37:11 +0000 Subject: [Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #70 from Arthur Suzuki --- Yes! Thank you Jonathan! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 11:44:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 10:44:17 +0000 Subject: [Koha-bugs] [Bug 25891] build_holds_queue can be daemonised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25891 --- Comment #8 from Sally --- Hi Christopher, Our cron job does rebuild hourly; this is what Martin refers to when he says, "In their workflows, having to wait for an hour between runs is an annoyance." The request here is to enable the cron job to rebuild more frequently - so once the job has completed, we would like it to start back up again, and not wait for the next hourly timeslot. I think the discussion about whether items coincidentally scanned over the system should be trapped for holds / locking the holds in accordance to the transport cost matrix could be raised on another bug? I agree that it's related, but it's not the whole scenario for us. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 12:16:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 11:16:18 +0000 Subject: [Koha-bugs] [Bug 26893] New: New version of JSON::Validator (D11) break our REST API routes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 Bug ID: 26893 Summary: New version of JSON::Validator (D11) break our REST API routes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't load application from file "/kohadevbox/koha/api/v1/app.pl": Can't use string ("paths.json") as a HASH ref while "strict refs" in use at /usr/share/perl5/JSON/Validator/OpenAPI/Mojolicious.pm line 333. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 12:17:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 11:17:03 +0000 Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) break our REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 12:20:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 11:20:04 +0000 Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) break our REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #1 from Jonathan Druart --- The tests were passing on Oct 22th (run 115) but fail since Oct 26th (run 123) https://jenkins.koha-community.org/job/Koha_Master_D11/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 12:21:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 11:21:20 +0000 Subject: [Koha-bugs] [Bug 26721] Debit and credit type pages should check for the specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112481|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 112825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112825&action=edit Bug 26721: Fix permission check on debit and credit type admin pages At the moment the pages falsely check for parameters_remaining_permissions, but they should check the specific manage_accounts permission. To test: - Create a new staff user with only catalog and manage_acccounts permissions - Log in with this staff user and go to the admin page - You will see the debit and credit type sections, but won't be able to access them - Apply the patch - Veriy the links still show, but pages are now accessible Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 12:22:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 11:22:05 +0000 Subject: [Koha-bugs] [Bug 26721] Debit and credit type pages should check for the specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Dang.. how did I get these mismatched! Works as expected, thanks for the fix Katrin. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 12:22:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 11:22:10 +0000 Subject: [Koha-bugs] [Bug 26721] Debit and credit type pages should check for the specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 12:24:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 11:24:24 +0000 Subject: [Koha-bugs] [Bug 26781] Marc Modification Templates treat subfield 0 and no subfield set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26781 --- Comment #8 from Nick Clemens --- Created attachment 112826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112826&action=edit Bug 26781: (follow-up) Adjust tests as fields are no longer completely removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 12:26:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 11:26:58 +0000 Subject: [Koha-bugs] [Bug 26894] New: Marc Modification Templates treat subfield 0 as no subfield set when moving fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26894 Bug ID: 26894 Summary: Marc Modification Templates treat subfield 0 as no subfield set when moving fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Similar to bug 26781 when moving subfield 0 we move the whole record. The tests from 17510 actually cover this, but I suspect it is still not the desired/expected behavior -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 12:27:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 11:27:20 +0000 Subject: [Koha-bugs] [Bug 26894] Marc Modification Templates treat subfield 0 as no subfield set when moving fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26894 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Depends on| |26781, 17510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 [Bug 17510] MARC modification templates ignore subfield $0 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26781 [Bug 26781] Marc Modification Templates treat subfield 0 and no subfield set -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 12:27:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 11:27:20 +0000 Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26894 [Bug 26894] Marc Modification Templates treat subfield 0 as no subfield set when moving fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 12:27:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 11:27:20 +0000 Subject: [Koha-bugs] [Bug 26781] Marc Modification Templates treat subfield 0 and no subfield set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26894 [Bug 26894] Marc Modification Templates treat subfield 0 as no subfield set when moving fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:11:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:11:00 +0000 Subject: [Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #9 from Owen Leonard --- Lucas: Adding a "modal-wide" class to the "modal-dialog"
will make it a wider version of the modal:
Could I also ask that the new template markup be indented with 4 spaces instead of 2? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:11:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:11:34 +0000 Subject: [Koha-bugs] [Bug 26894] Marc Modification Templates treat subfield 0 as no subfield set when moving fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26894 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:11:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:11:36 +0000 Subject: [Koha-bugs] [Bug 26894] Marc Modification Templates treat subfield 0 as no subfield set when moving fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26894 --- Comment #1 from Nick Clemens --- Created attachment 112827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112827&action=edit Bug 26894: Handle subfield 0 and delete empty fields This patch corrects handling of subfield 0 when copying/moving. Before these patches copying from subfield 0 would copy the entire field. We also correct an error that if moving a single subfield, we can leave behind empty fields with no subfields. They should be deleted. To test: 1 - Define a new MARC Modification template with actions: Delete field 100$0 Add new field 100$0 with value Test Update existing or add new field 100$0 with value TestUpdated Move field 100$0 to 600$0 Copy field 600$0 to 100$0 Copy and replace field 245$0 to 700$0 2 - Define a new record like: LDR 00334nam a22001217a 4500 003 ff 005 20201102111604.0 008 201102b xxu||||| |||| 00| 0 eng d 040 _ _ ‡cvsd 100 1 _ ‡012345‡aKnuth, Donal Ervin‡d1938 245 _ _ ‡012345‡aThe aty of computer programming‡cDonald E. Knuth 650 _ 0 ‡042‡aComputer programming‡9462 3 - Modify this record using the template above 4 - Note that entier 245 is copied to 700, same for 600 field 5 - Apply patch 6 - Now only subfields 0 are copied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:20:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:20:59 +0000 Subject: [Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #10 from Katrin Fischer --- Thx Owen, can we please have a follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:21:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:21:16 +0000 Subject: [Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #11 from Katrin Fischer --- (In reply to Katrin Fischer from comment #10) > Thx Owen, can we please have a follow-up? Meaning Lucas for the follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:27:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:27:08 +0000 Subject: [Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:34:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:34:00 +0000 Subject: [Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:34:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:34:02 +0000 Subject: [Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 --- Comment #1 from Owen Leonard --- Created attachment 112828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112828&action=edit Bug 26889: Remove extra space from "Damaged :" in item search This patch adds the chomp shorthand [%- -%] to the BLOCK for showing labels in the item search template. This collapses the whitespace around the label, eliminating the unwanted space around the ":" To test, apply the patch and go to the item search page in the staff interface. There should be no space before the colon in the "Damaged" label. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:36:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:36:21 +0000 Subject: [Koha-bugs] [Bug 26885] Some text in OPAC is falsely colored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26885 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 26706 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:36:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:36:21 +0000 Subject: [Koha-bugs] [Bug 26706] Fix btn-default styling for better contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26706 --- Comment #11 from Owen Leonard --- *** Bug 26885 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:48:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:48:30 +0000 Subject: [Koha-bugs] [Bug 26581] Elasticsearch - Records can be indexed multiple times during returns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26581 --- Comment #21 from Nick Clemens --- Created attachment 112829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112829&action=edit Bug 26581: (follow-up) Skip merge when deleting authority Tests failing, seems to be because the indexes haven't been created yet. When deleting authority we perform a 'merge' where we search for biblios containing the authority. Since these are simply tets we can skip this step, avoid the search, and avoid a crash -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:51:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:51:27 +0000 Subject: [Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #71 from Jonathan Druart --- (In reply to Jonathan Druart from comment #69) > Created attachment 112824 [details] [review] > Bug 22806: Remove perlcritic errors > > Subroutine "new" called using indirect syntax at line 415, column 18. See > page 349 of PBP. (Severity: 4) > Subroutine "new" called using indirect syntax at line 420, column 14. See > page 349 of PBP. (Severity: 4) Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:51:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:51:36 +0000 Subject: [Koha-bugs] [Bug 26581] Elasticsearch - Records can be indexed multiple times during returns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26581 --- Comment #22 from Jonathan Druart --- (In reply to Nick Clemens from comment #21) > Created attachment 112829 [details] [review] > Bug 26581: (follow-up) Skip merge when deleting authority > > Tests failing, seems to be because the indexes haven't been created yet. > When deleting authority we perform a 'merge' where we search for biblios > containing the authority. > > Since these are simply tets we can skip this step, avoid the search, and > avoid > a crash Pushed to master, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:51:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:51:44 +0000 Subject: [Koha-bugs] [Bug 26781] Marc Modification Templates treat subfield 0 and no subfield set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26781 --- Comment #9 from Jonathan Druart --- (In reply to Nick Clemens from comment #8) > Created attachment 112826 [details] [review] > Bug 26781: (follow-up) Adjust tests as fields are no longer completely > removed Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 13:55:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 12:55:58 +0000 Subject: [Koha-bugs] [Bug 26824] Use confirmation modal when removing titles from a list in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26824 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:12:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:12:18 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #34 from Kyle M Hall --- Created attachment 112830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112830&action=edit Bug 14708: (QA follow-up) Throw exception when deleting anonymous borrower -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:13:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:13:17 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #35 from Kyle M Hall --- (In reply to Jonathan Druart from comment #32) > sub delete { > my ($self) = @_; > > + my $anonymous_patron = C4::Context->preference("AnonymousPatron"); > + return $self if $anonymous_patron && $self->id eq $anonymous_patron; > > > Shouldn't we raise an exception instead? Here you go! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:13:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:13:55 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112830|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall --- Created attachment 112831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112831&action=edit Bug 14708: (QA follow-up) Throw exception when deleting anonymous borrower -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:19:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:19:35 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #158 from Kyle M Hall --- > I think Augustin's does a little nicer job in showing which rule applies > easily, but you have to make the necessary selections first. The first one I > like better for a better/faster editing/adding experience. > > It's hard. I think there is one *big* difference that weighs heavily in my mind. Jesse Weaver is no longer an active member in the Koha community, whereas Augustin is. Augustin will be able to assist other developers in learning how to make changes to the rules editor. If we go with Piano's version, we'll be left to explore and understand it on our own. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:23:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:23:38 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #159 from Katrin Fischer --- (In reply to Kyle M Hall from comment #158) > > I think Augustin's does a little nicer job in showing which rule applies > > easily, but you have to make the necessary selections first. The first one I > > like better for a better/faster editing/adding experience. > > > > It's hard. > > I think there is one *big* difference that weighs heavily in my mind. Jesse > Weaver is no longer an active member in the Koha community, whereas Augustin > is. Augustin will be able to assist other developers in learning how to make > changes to the rules editor. If we go with Piano's version, we'll be left to > explore and understand it on our own. Hi Kyle, I believe we might want to have the discussion about Angular / Vue and the functionality/GUI separately because both are different aspects. At the moment Augustin's patch is a completely new way of doing this both technically and in how the GUI is done. It's not a reimplementation of Jesse's work. We might come to the conclusion that we want something similar to Jesse's but written in Vue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:37:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:37:52 +0000 Subject: [Koha-bugs] [Bug 26868] biblio and biblio_metadata tables timestamp do not update when moving an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26868 Mark Noble changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mark at bywatersolutions.com --- Comment #3 from Mark Noble --- Aspen Discovery is using an ODBC connection to the database to determine what records and items have changed by looking at the biblio timestamp, biblio_metadata timestamp, items timestamp. To determine which bibs and items have been deleted it looks at deleteditems and deletedbiblio. When an item has been moved to another bib, we can detect that it is changed, but we only know the new bib number, not the old bib number. So there is not an easy way to determine that the old bib record also needs to be updated to not include the item. Because items are part of the bib record, we feel it is appropriate to update the timestamp for the old bib record when the item is moved. If that turns out to not be appropriate, we would suggest creating another timestamp for when items within the biblio are created, or deleted so we can detect changes to the contents of the record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:44:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:44:35 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:44:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:44:38 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 --- Comment #6 from Nick Clemens --- Created attachment 112832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112832&action=edit Bug 24567: (follow-up) Use dollar sign to refer to captures -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:45:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:45:37 +0000 Subject: [Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:45:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:45:40 +0000 Subject: [Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112262|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 112833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112833&action=edit Bug 25167: Fix to a fix wrong inventory results Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'A-0' and 'A-9' - Check 'Compare barcodes list to results' - Submit=> without patch, you get no warnings - Redo the same inventory but with checking items.notforloan 'For loan' (using the browser back page is ok) - submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' - Apply patch, repeat, with tems.notforloan 'For loan' checked you get the right warning Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:45:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:45:42 +0000 Subject: [Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112353|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 112834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112834&action=edit Bug 25167: (QA follow-up) Don't add a new variable Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:48:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:48:52 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Needs Signoff |Patch doesn't apply --- Comment #621 from Victor Grousset/tuxayo --- > 2. Run database updates, update schema files and confirm everything applies cleanly "update schema files" => the dbic command right? No diff after running, is that expected? Since last master pushes, patches don't applies anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:54:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:54:50 +0000 Subject: [Koha-bugs] [Bug 26886] OPAC suggestions: possible duplicate message should stand out more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 14:54:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 13:54:53 +0000 Subject: [Koha-bugs] [Bug 26886] OPAC suggestions: possible duplicate message should stand out more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 --- Comment #1 from Owen Leonard --- Created attachment 112835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112835&action=edit Bug 26886: Correct style of alert-error class in the OPAC This patch makes a minor change to the OPAC SCSS so that instances of "alert-error" classes are styled the same as messages with the Bootstrap 4 "alert-warning" class. This change is simpler than making multiple changes to scripts and templates. To test, apply the patch and try to view a single news item in the OPAC which doesn't exist: /cgi-bin/koha/opac-main.pl?news_id=XXX - You should see a warning message with a pale yellow background, "This news item does not exist." - Submit a suggestion, and then submit another suggestion with the same title. - You should see a warning message, "The suggestion has not been added. A suggestion with this title already exists." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:02:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:02:47 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #160 from Kyle M Hall --- Of course. My honest opinion is that React vs Vue is not really an issue. I believe that we as developers are perfectly capable of using either one. On the other hand, a discussion of licensing and other social issue has merit. (In reply to Katrin Fischer from comment #159) > Hi Kyle, I believe we might want to have the discussion about Angular / Vue > and the functionality/GUI separately because both are different aspects. At > the moment Augustin's patch is a completely new way of doing this both > technically and in how the GUI is done. It's not a reimplementation of > Jesse's work. > > We might come to the conclusion that we want something similar to Jesse's > but written in Vue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:06:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:06:17 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 --- Comment #18 from Kyle M Hall --- (In reply to Jonathan Druart from comment #17) > Kyle, on bug 25334 it seems that the final goal is to have a plugin for the > phone notifications. In that case, should not we have "itiva" code moved to > a plugin and so remove "itiva"? I would not be opposed to that! I would advocate that we still push this patch and the blockers for it until we have a working itiva plugin that could be used with the generic phone transport. At that point we could deprecate the existing itiva scripts/transport and replace them with a plugin. That would be a good improvement in may ways, offering more flexibility to what can be done with itiva. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:08:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:08:24 +0000 Subject: [Koha-bugs] [Bug 22343] Add configuration options for SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |System Administration |and plumbing | CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:08:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:08:49 +0000 Subject: [Koha-bugs] [Bug 26290] Add the ability to set a default SMTP server in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |System Administration |and plumbing | CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:09:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:09:54 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #161 from Katrin Fischer --- (In reply to Kyle M Hall from comment #160) > Of course. My honest opinion is that React vs Vue is not really an issue. I > believe that we as developers are perfectly capable of using either one. On > the other hand, a discussion of licensing and other social issue has merit. Glad to hear - I don't have any experience or opinion on either, but hope that we can figure out what is best long term. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:11:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:11:44 +0000 Subject: [Koha-bugs] [Bug 23376] Cleanup order receive page code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:14:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:14:49 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24819 Status|NEW |ASSIGNED --- Comment #3 from Jonathan Druart --- This is caused by bug 24819. It has been pushed 1 month after bug 23590. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819 [Bug 24819] Add ability for librarians to choose a patron when entering a purchase suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:14:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:14:49 +0000 Subject: [Koha-bugs] [Bug 24819] Add ability for librarians to choose a patron when entering a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 [Bug 26738] Unable to change manager of purchase suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:15:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:15:09 +0000 Subject: [Koha-bugs] [Bug 25511] Add --force option to update_dbix_class_files.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz Component|Architecture, internals, |Command-line Utilities |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:16:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:16:09 +0000 Subject: [Koha-bugs] [Bug 26425] Fix history.txt once and for all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |About |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:17:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:17:09 +0000 Subject: [Koha-bugs] [Bug 19322] Typo in UNIMARC field 140 plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19322 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:17:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:17:21 +0000 Subject: [Koha-bugs] [Bug 19327] Typo in UNIMARC field 128a plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19327 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:17:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:17:34 +0000 Subject: [Koha-bugs] [Bug 19322] Typo in UNIMARC field 140 plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19322 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:18:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:18:05 +0000 Subject: [Koha-bugs] [Bug 26330] jQueryUI tabs don't work with non-Latin-1 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:19:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:19:36 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:19:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:19:39 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #4 from Jonathan Druart --- Created attachment 112836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112836&action=edit Bug 26738: (bug 24819 follow-up) Fix manager selection Bug 23590 added a new feature to select the manager of a suggestion. One month later bug 24819 added the ability to pick the suggester. This second patchset broke the manager selection. This patch simplifies the way the suggester is selected, using the generic way and mimicking what is done for the manager. Test plan: - create a new purchase suggestion from within acquisitions (suggestion.pl?op=add) - click "select manager," search for user, click Select - see that the user you just selected shows under "Created by," - see that "Managed by" still says "You" - modify the suggester - save your suggestion => Everything is saved correctly QA will test the permission alert: Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage" Edit the suggestion, select a manager, pick a patron in the list who does not have sufficient permissions, save => you get the alert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:20:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:20:13 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #5 from Jonathan Druart --- New feature advertised in 20.05 is broken, upping severity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:22:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:22:49 +0000 Subject: [Koha-bugs] [Bug 26160] Add column configuration to the Point of sale, Items for purchase table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add column configuration to |Add column configuration to |sales table to allow hiding |the Point of sale, Items |of 'Code' column |for purchase table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:24:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:24:58 +0000 Subject: [Koha-bugs] [Bug 26161] Confirm and cancel buttons should be underneath the right hand form on the POS page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26161 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:26:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:26:35 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:26:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:26:38 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112798|0 |1 is obsolete| | --- Comment #17 from Owen Leonard --- Created attachment 112837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112837&action=edit Bug 24012: (QA follow-up) Use standard patterns - Removes the scss change in favor of adding the space to the HTML as is the usual pattern when using Font Awesome icons - Removes the span with the inline style to make things appear as black by default (no danger here in it being locked?) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:38:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:38:12 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #32 from Agustín Moyano --- (In reply to Séverine Queune from comment #31) > Definitely bad luck on that one... > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 8179: Add tests > Applying: Bug 8179: Add syspref to database > Applying: Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference > confi guration > Applying: Bug 8179: Receive multiple orders > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/m odules/acqui/parcel.tt). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 8179: Receive multiple orders 20212 is currently FQA, that's why patches don't apply. We'll have to wait until it changes state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:38:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:38:15 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #6 from Andrew Fuerste-Henry --- This does allow me to save changes to the manager of a purchase suggestion. I've not seen any notices generated as I do so. My two demo users do both have email addresses and the notice "NOTIFY_MANAGER" exists. Am I missing something there? Is the manager of a purchase suggestion meant to always default to whoever last edited it? If I edit an existing suggestion with another user as the manager, Koha will set me as the manger unless I remember to click to tell it not to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:39:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:39:54 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_26895=5D_New=3A_Template_process_fa?= =?utf-8?q?iled=3A_file_error_-_parse_error_-_patron-title=2Einc_line_37?= =?utf-8?b?OiB1bmV4cGVjdGVkIHRva2VuICgnPHNwYW4pICAgWyUgc3Bhbl9zdGFydCA9?= =?utf-8?b?ICc8c3BhbiBjbGFzcz0icGF0cm9uLXRpdGxlIj7DouKCrMucICVdIGF0IC91?= =?utf-8?q?sr/share/koha/lib/C4/Templates=2Epm_line_122=2E?= Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26895 Bug ID: 26895 Summary: Template process failed: file error - parse error - patron-title.inc line 37: unexpected token (' References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105631|0 |1 is obsolete| | Attachment #105641|0 |1 is obsolete| | Attachment #105706|0 |1 is obsolete| | Attachment #106692|0 |1 is obsolete| | --- Comment #72 from Joonas Kylmälä --- Created attachment 112838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112838&action=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:40:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:40:20 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #73 from Joonas Kylmälä --- Created attachment 112839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112839&action=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:40:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:40:25 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #74 from Joonas Kylmälä --- Created attachment 112840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112840&action=edit Bug 11175: (follow-up) Return empty array if no components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:40:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:40:30 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #75 from Joonas Kylmälä --- Created attachment 112841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112841&action=edit Bug 11175: (follow-up) Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:40:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:40:49 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #76 from Joonas Kylmälä --- Rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:41:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:41:52 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:41:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:41:55 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112836|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 112842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112842&action=edit Bug 26738: (bug 24819 follow-up) Fix manager selection Bug 23590 added a new feature to select the manager of a suggestion. One month later bug 24819 added the ability to pick the suggester. This second patchset broke the manager selection. This patch simplifies the way the suggester is selected, using the generic way and mimicking what is done for the manager. Test plan: - create a new purchase suggestion from within acquisitions (suggestion.pl?op=add) - click "select manager," search for user, click Select - see that the user you just selected shows under "Created by," - see that "Managed by" still says "You" - modify the suggester - save your suggestion => Everything is saved correctly QA will test the permission alert: Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage" Edit the suggestion, select a manager, pick a patron in the list who does not have sufficient permissions, save => you get the alert Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:43:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:43:59 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #8 from Andrew Fuerste-Henry --- I *was* missing something! there's a checkbox! Manager changed successfully through both edit and batch interfaces. Notice sent successfully. I'm still a little torn about defaulting the changing the manager each time you edit, but will wait to see what users think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:50:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:50:25 +0000 Subject: [Koha-bugs] [Bug 26896] New: SIP option holds_block_checkin does not actually block checkin of items on hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 Bug ID: 26896 Summary: SIP option holds_block_checkin does not actually block checkin of items on hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Thanks to matts for alerting me to this major issue with holds_block_checkin! It appears that at some point, the actual blocking of checkins on items with holds got lost from the patch set. This slipped by because the sip server still outputs everything correctly, but the unit tests don't actually test to see if the checkout still exists afterward! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:50:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:50:31 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:52:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:52:31 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:52:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:52:34 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 --- Comment #1 from Kyle M Hall --- Created attachment 112843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112843&action=edit Bug 26896: Enable SIP option holds_block_checkin to actually block checkin of items with holds It appears that at some point, the actual blocking of checkins on items with holds got lost from the patch set. This slipped by because the sip server still outputs everything correctly, but the unit tests don't actually test to see if the checkout still exists afterward! Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:54:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:54:16 +0000 Subject: [Koha-bugs] [Bug 26398] Credit and Debit types on creating a manual credits and manual invoices are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111941|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 112844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112844&action=edit Bug 26398: Restore translations for credit/debit type dropdown 1) run ./translate update xx-XX 2) Translate this big chunk in your xx-XX-staff-prog.po or make sure it's translated msgid "" "%s %s %sPayment %sWriteoff %sForgiven %sCredit %sLost item fee refund " "%sRefund %s%s %s %s %s %sAccount creation fee %sAccount renewal fee %sLost " "item %sManual fee %sNew card %sFine %sLost item processing fee %sRental fee " "%sDaily rental fee %sRenewal of rental item %sRenewal of daily rental item " "%sHold fee %sHold waiting too long %sPayout %s%s %s %s %s " (tip: I search the po file for "Forgiven", there are only two occurrences) 3) run ./translate install xx-XX 4) In your staff interface in your other language, go to a patron's account > Accounting > Create manual Credit 5) Check that the values in the credit drop down are in English 6) Apply patch 7) redo steps 1-4 (careful, the string to be translated changes) 8) Do a hard refresh (Ctrl+F5) (I guess you'd have to restart plack if you have it) 9) Values in the credit drop down are translated Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:54:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:54:30 +0000 Subject: [Koha-bugs] [Bug 26398] Credit and Debit types on creating a manual credits and manual invoices are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:56:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:56:06 +0000 Subject: [Koha-bugs] [Bug 26639] Turn auto_savepoint ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26639 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:56:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:56:08 +0000 Subject: [Koha-bugs] [Bug 26639] Turn auto_savepoint ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26639 --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:56:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:56:27 +0000 Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) break our REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #2 from Julian Maurice --- Confirmed. The problem exists for all versions of JSON::Validator from 4.06 to 4.10 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 15:56:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 14:56:27 +0000 Subject: [Koha-bugs] [Bug 26592] XSS vulnerability when ysearch is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26592 --- Comment #24 from Jonathan Druart --- And finally pushed to master for 20.11! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:01:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:01:58 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25541 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 [Bug 25541] Add ability to prevent checkin via SIP of items with holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:01:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:01:58 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:04:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:04:10 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_26895=5D_Template_process_failed=3A?= =?utf-8?q?_file_error_-_parse_error_-_patron-title=2Einc_line_37=3A_unexp?= =?utf-8?b?ZWN0ZWQgdG9rZW4gKCc8c3BhbikgICBbJSBzcGFuX3N0YXJ0ID0gJzxzcGFu?= =?utf-8?b?IGNsYXNzPSJwYXRyb24tdGl0bGUiPsOi4oKsy5wgJV0gYXQgL3Vzci9zaGFy?= =?utf-8?q?e/koha/lib/C4/Templates=2Epm_line_122=2E?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26895 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Version|20.05 |master Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Component|Templates |I18N/L10N --- Comment #1 from Owen Leonard --- Confirmed: intranet-tmpl/prog/ca-ES/includes/patron-title.inc is generated with the wrong markup: [%- span_start = '‘ %] [%- span_end = ‘' %] Note the "‘" character where there should be a single quote. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:08:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:08:03 +0000 Subject: [Koha-bugs] [Bug 26865] Double quotes in patron's data breaks patron searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26865 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Special characters in |Double quotes in patron's |circulation note makes |data breaks patron searches |patron unsearchable in | |guarantor_search.pl | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:11:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:11:48 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #162 from Agustín Moyano --- (In reply to Katrin Fischer from comment #161) > (In reply to Kyle M Hall from comment #160) > > Of course. My honest opinion is that React vs Vue is not really an issue. I > > believe that we as developers are perfectly capable of using either one. On > > the other hand, a discussion of licensing and other social issue has merit. > > Glad to hear - I don't have any experience or opinion on either, but hope > that we can figure out what is best long term. I think we've got 2 discussions.. one is which technology fits better our needs (React vs Vue) and the other is how do we want our circulation rules revamped. What I don't like of current circulation rules is that it's hard (at least for me) to edit scrolling horizontally, plus if there are a lot of rules it's hard to read. I feel that with the React proposal (the model, not the technology) could potentially happen the same.. if you edit different rules of a category/item type, you may need to scroll horizontally too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:12:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:12:29 +0000 Subject: [Koha-bugs] [Bug 26130] opacbookbag 'Cart' confuses patrons - add optional name alternatives? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26130 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:15:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:15:26 +0000 Subject: [Koha-bugs] [Bug 26897] New: Blank SIP message closes SIP server connection Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26897 Bug ID: 26897 Summary: Blank SIP message closes SIP server connection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com in SIPServer.pm sub sip_protocol_loop 308 my $previous_alarm = alarm($timeout); 309 310 while ( my $inputbuf = read_request() ) { 311 if ( !defined $inputbuf ) { 312 return; #EOF 313 } It seems some machines can send an empty response when sending store and forward requests. Rather than close on an empty string we should just ignore and keep processing, only disconnecting when requested or when timed out -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:16:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:16:19 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Failed QA --- Comment #84 from Martin Renvoize --- I think the test failure is a red herring.. However.. I believe we need to add unit tests for the new Koha::Biblio->adopt_items_from_biblio method and Koha::Item->item_orders relation accessor before we proceed. These should be fairly trivial tests to add, one to prove that the loop happens and the final indexing takes place for the set and the second to prove the relation is setup correctly. Failing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:28:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:28:53 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:28:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:28:55 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 --- Comment #3 from Owen Leonard --- Created attachment 112845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112845&action=edit Bug 25469: Typo: Item does not belongs to your library This patch makes corrections to two strings in the batch delete template to correct a typo. Before: t("Item does not belongs to your library") ...after, t("Item does not belong to your library") To test, apply the patch and inspect the template to confirm that the string is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:31:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:31:18 +0000 Subject: [Koha-bugs] [Bug 26329] opac-tags.pl hardmax should be configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26329 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Component|OPAC |System Administration CC| |gmcharlt at gmail.com Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:32:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:32:50 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #77 from Joonas Kylmälä --- Created attachment 112846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112846&action=edit Bug 11175: (follow-up) Use uppercase AND and OR words in search query Elasticsearch only understands uppercase query operators. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:32:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:32:55 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #78 from Joonas Kylmälä --- Created attachment 112847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112847&action=edit Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:33:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:33:48 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #79 from Joonas Kylmälä --- (In reply to Katrin Fischer from comment #71) > Hm, sorry, found a bigger issue last minute: In the OPAC the display is not > nice, probably due to the bootstrap patch being pushed in between. All the > components show above the title of the record now. To have it show correctly one needs to rebuild the CSS files: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface#Compiling_Sass_files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:36:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:36:38 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:36:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:36:40 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #2 from Kyle M Hall --- Created attachment 112848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112848&action=edit Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:36:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:36:49 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:43:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:43:28 +0000 Subject: [Koha-bugs] [Bug 26594] Patrons merge problem with restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:44:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:44:05 +0000 Subject: [Koha-bugs] [Bug 26594] Patrons merge problem with restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:44:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:44:08 +0000 Subject: [Koha-bugs] [Bug 26594] Patrons merge problem with restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111703|0 |1 is obsolete| | Attachment #111704|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 112849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112849&action=edit Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:44:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:44:17 +0000 Subject: [Koha-bugs] [Bug 26594] Patrons merge problem with restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #13 from Kyle M Hall --- Created attachment 112850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112850&action=edit Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:49:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:49:01 +0000 Subject: [Koha-bugs] [Bug 26842] SIP should allow bib level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26842 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 26461 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:49:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:49:01 +0000 Subject: [Koha-bugs] [Bug 26461] Incorrect handling of hold levels in SIP2 code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26461 --- Comment #2 from Kyle M Hall --- *** Bug 26842 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:51:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:51:17 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #80 from Joonas Kylmälä --- (In reply to Katrin Fischer from comment #70) > Hi Joonas, > > finally found some time to take a closer look: > > 1) System preference > - I think staff interface is not a good tab choise, I'd put it under > "Cataloguing" or "Search". I went with Cataloguing. > - As this currently doesn't work for UNIMARC or Elasticsearch, we should add > a hint about this in the pref so people know what to expect. Added this info to description. > - And maybe "does not require UseControlNumber".? I don't understand what you mean here. > - Change staff client to staff interface (see terminology list) Done. > 3) I am still slightly worried about what will happen when there are several > hundred of analytical records found. This would be very commonly the case > for our law and special libraries that do extensive analytical cataloguing > for serials. And all the analyticals are linked to the serials (there are no > volume or issue records as per the rules of our union catalog) so it gets > quite a lot. Could you think of a strategy for those? > > Maybe we could define a number for a "cutoff" and display a link for "Show > more". Ideal would be to show the newest x linked records. I added 325 component part records and it loaded as far as I could tell the same speed as without any component part records, so there is no noticeable slow down here, the algorithm for this looks linear. The current approach seems OK to me, no need for paging because the HTML links generated here are very light weight. I'm thinking this is again ready for sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:55:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:55:33 +0000 Subject: [Koha-bugs] [Bug 26898] New: Notify new manager when updating suggestions from suggestions homepage Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26898 Bug ID: 26898 Summary: Notify new manager when updating suggestions from suggestions homepage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 23590 When changing the manager of one or more purchase suggestions from suggetion.pl, there's no mechanism for sending a notice to the new manager, as one can do when editing a single suggestion. We should be able to send notice(s) in either interface. If setting multiple suggestions to one manager in bulk, should that be multiple individual notices? Or one digest notice? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Add the ability to change the manager of a suggestion and notify the new manager -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:55:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:55:33 +0000 Subject: [Koha-bugs] [Bug 23590] Add the ability to change the manager of a suggestion and notify the new manager In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26898 [Bug 26898] Notify new manager when updating suggestions from suggestions homepage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 16:56:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 15:56:49 +0000 Subject: [Koha-bugs] [Bug 26898] Notify new manager when updating suggestions from suggestions homepage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26898 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:03:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:03:40 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #81 from Nick Clemens --- Created attachment 112851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112851&action=edit Bug 11175: Add Elasticsearch support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:04:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:04:03 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112846|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:04:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:04:57 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #82 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #77) > Created attachment 112846 [details] [review] > Bug 11175: (follow-up) Use uppercase AND and OR words in search query > > Elasticsearch only understands uppercase query operators. Hi Joonas, I obsoleted yours and added a new patch to fully add ES support here, let me know if that works for you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:07:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:07:34 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:07:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:07:39 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112838|0 |1 is obsolete| | --- Comment #83 from Nick Clemens --- Created attachment 112852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112852&action=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:07:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:07:43 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112839|0 |1 is obsolete| | --- Comment #84 from Nick Clemens --- Created attachment 112853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112853&action=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:07:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:07:48 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112840|0 |1 is obsolete| | --- Comment #85 from Nick Clemens --- Created attachment 112854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112854&action=edit Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:07:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:07:52 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112841|0 |1 is obsolete| | --- Comment #86 from Nick Clemens --- Created attachment 112855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112855&action=edit Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:07:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:07:57 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112847|0 |1 is obsolete| | --- Comment #87 from Nick Clemens --- Created attachment 112856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112856&action=edit Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:08:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:08:02 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112851|0 |1 is obsolete| | --- Comment #88 from Nick Clemens --- Created attachment 112857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112857&action=edit Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:10:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:10:41 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:10:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:10:44 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 --- Comment #2 from Fridolin SOMERS --- Created attachment 112858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112858&action=edit Bug 26860: facets.inc refactor availability facet To prepare new facet, this patch refactors the availability facet, without any change in restult. Appart from an id 'facet-availability', like other facets. Test plan: 1) Perform a search in staff interface 2) Check availability facet displays well 3) Click on it 4) Check availability facet displays well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:11:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:11:03 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 --- Comment #3 from Fridolin SOMERS --- Created attachment 112859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112859&action=edit Bug 26860: Add without items facet Many libraries ask for a way to search biblio records without items. In order to clean the catalogue or acquire items. I propose to add a search limit and facet. Only in staff interface for start. I choose to use homebranch index, should always be defined on items. Looks like itemnumber index can not be used because of its configuration in ccl.properties. Test plan : 1) Check with both Zebra and Elasticsearch 2) Perform a search on staff interface returning some records with and some without items 3) Click on 'Limit to records without items' 4) Check you see only records without items 5) Click on 'Show all records' 6) Check you see all records again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:12:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:12:23 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #89 from Joonas Kylmälä --- (In reply to Nick Clemens from comment #82) > Hi Joonas, > > I obsoleted yours and added a new patch to fully add ES support here, let me > know if that works for you Of course it works for me! You're awesome, thanks :) I tested the Elasticsearch implementation and I noticed slight difference there: with Elasticsearch only the first 100 component part records are returned meanwhile with Zebra all the component part records are returned. Maybe a follow-up for this would be needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:12:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:12:54 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 --- Comment #4 from Fridolin SOMERS --- I've add a TODO for code dealing with "ccl=". I will create a follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:30:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:30:57 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #90 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #89) > (In reply to Nick Clemens from comment #82) > > Hi Joonas, > > > > I obsoleted yours and added a new patch to fully add ES support here, let me > > know if that works for you > > Of course it works for me! You're awesome, thanks :) > > I tested the Elasticsearch implementation and I noticed slight difference > there: with Elasticsearch only the first 100 component part records are > returned meanwhile with Zebra all the component part records are returned. > Maybe a follow-up for this would be needed? Koha/SearchEngine/Elasticsearch/Search.pm 298 =item C<$max_results> 299 300 The max number of results to return. The default is 100 (because unlimited 301 is a pretty terrible thing to do.) Probably this should be a syspref? For Zebra we don't hardcode a limit, but maybe we should not return everything and it would be better to have one syspref to control both> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:48:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:48:38 +0000 Subject: [Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Er.. just wondering.. shouldn't this be at the Koha::Object level rather than within the DBIC Class? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 17:57:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 16:57:13 +0000 Subject: [Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 --- Comment #9 from Martin Renvoize --- Hmm.. also since bug 20782 this does work correctly for us.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:06:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:06:33 +0000 Subject: [Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #10 from Martin Renvoize --- Also, having now conferred with Colin, we believe a message is allowed to contain multiple invoices, so the extraction of invoice_id here may be too simplistic. We do store message_id in the invoices table to allow the link from invoice to message to be recorded.. which is what we're using for the GetInvoices search in current code. Perhaps a ByWater EDI plugin skips setting of message_id somewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:14:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:14:28 +0000 Subject: [Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:15:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:15:53 +0000 Subject: [Koha-bugs] [Bug 26696] Make payment table has a display issue when credits exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26696 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- What's the attached image for Katrin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:16:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:16:57 +0000 Subject: [Koha-bugs] [Bug 26696] Make payment table has a display issue when credits exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26696 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112661|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 112860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112860&action=edit Bug 26696: Fix colspan in payment table when credit exists The colspan was adjusted for the total due when a new column was added to the table, but the 2 lines for credits were missed. To test: - Go to any patron account - Create a manual invoice - Create a credit - Go to the 'Make a payment' tab - Veriy that the total lines at the bottom of the table are slightly off - Apply the patch - Verify that the total lines in the table now display correctly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:17:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:17:18 +0000 Subject: [Koha-bugs] [Bug 26696] Make payment table has a display issue when credits exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26696 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Works as expected.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:21:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:21:25 +0000 Subject: [Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 --- Comment #11 from Martin Renvoize --- Confirmed.. see the loop for 'messages' inside process_invoice within Koha::EDI. It loops through messages in the invoice file and extracts a docmsg_number for each one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:22:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:22:02 +0000 Subject: [Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 --- Comment #12 from Kyle M Hall --- (In reply to Martin Renvoize from comment #8) > Er.. just wondering.. shouldn't this be at the Koha::Object level rather > than within the DBIC Class? That was a development decision made by Colin iirc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:23:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:23:05 +0000 Subject: [Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20782 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:23:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:23:05 +0000 Subject: [Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25759 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:23:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:23:34 +0000 Subject: [Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 --- Comment #13 from Kyle M Hall --- (In reply to Martin Renvoize from comment #11) > Confirmed.. see the loop for 'messages' inside process_invoice within > Koha::EDI. > > It loops through messages in the invoice file and extracts a docmsg_number > for each one. I think we can make it work with multiple messages! Let me see what I can do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:48:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:48:45 +0000 Subject: [Koha-bugs] [Bug 26899] New: Pick up location defaults to first choice if patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26899 Bug ID: 26899 Summary: Pick up location defaults to first choice if patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:54:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:54:22 +0000 Subject: [Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #14 from Kyle M Hall --- (In reply to Martin Renvoize from comment #11) > Confirmed.. see the loop for 'messages' inside process_invoice within > Koha::EDI. > > It loops through messages in the invoice file and extracts a docmsg_number > for each one. Ok, I feel like a nut ;) The invoice links are definitely working in master now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 18:54:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 17:54:24 +0000 Subject: [Koha-bugs] [Bug 26899] Pick up location defaults to first choice if patron's library is disabled as pick up location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26899 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Pick up location defaults |Pick up location defaults |to first choice if patron |to first choice if patron's | |library is disabled as pick | |up location --- Comment #1 from Christopher Brannon --- If patron's home library is disabled as a pick up location, it defaults to the first available location in the dropdown. I'm not sure if this request should be under system administration or hold requests. I think that if their location is disabled, there should be a message in the dropdown, and disable the Confirm hold button until another location is chosen. This is what I did with jQuery: //Reroute Patron Pick-up Locations if($.inArray($('#opac-holds #members span.loggedinusername').attr('data-branchcode'), ['LAKECITY','POSTFALLS','ATHOL','RATHDRUM']) != -1) { $('#opac-holds select[name="branch"]').prepend('').val('NONE').width('350px'); $('#opac-holds select[name="branch"] option[value="NONE"]').prop('disabled', true); $('#opac-holds input.placehold').prop('disabled', true); $('#opac-holds select[name="branch"]').change(function() { $('#opac-holds input.placehold').prop('disabled', false); }); } //End Reroute If the library is in the array, the button is disabled and they are forced to choose a different location. I'm going to change this slightly and have it do this if their logged in library is not in the dropdown, so we don't have to edit this list. But you get the idea. This should be a part of Koha, because this easily slips by the attention of so many patrons, and holds route to the wrong library because of it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 19:12:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 18:12:38 +0000 Subject: [Koha-bugs] [Bug 26899] Pick up location defaults to first choice if patron's library is disabled as pick up location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26899 --- Comment #2 from Christopher Brannon --- I updated the jQuery so it doesn't have to modified each time something changes. It just checks the patron's home library against the dropdown choices. //Reroute Patron Pick-up Locations //if($.inArray($('#opac-holds #members span.loggedinusername').attr('data-branchcode'), ['LAKECITY','POSTFALLS','ATHOL','RATHDRUM']) != -1) { if ( !$('#opac-holds select[name="branch"] option[value=' + $('#opac-holds #members span.loggedinusername').attr('data-branchcode') + ']').length ) { $('#opac-holds select[name="branch"]').prepend('').val('NONE').width('350px'); $('#opac-holds select[name="branch"] option[value="NONE"]').prop('disabled', true); $('#opac-holds input.placehold').prop('disabled', true); $('#opac-holds select[name="branch"]').change(function() { $('#opac-holds input.placehold').prop('disabled', false); }); } //End Reroute -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 19:31:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 18:31:33 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #116 from David Nind --- Patches no longer apply 8-( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 19:48:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 18:48:32 +0000 Subject: [Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:01:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:01:10 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:01:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:01:13 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112848|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 112861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112861&action=edit Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:08:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:08:38 +0000 Subject: [Koha-bugs] [Bug 26696] Make payment table has a display issue when credits exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:10:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:10:26 +0000 Subject: [Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 --- Comment #15 from Katrin Fischer --- Must have messed up testing the before here as well :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:12:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:12:44 +0000 Subject: [Koha-bugs] [Bug 26696] Make payment table has a display issue when credits exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26696 --- Comment #6 from Katrin Fischer --- (In reply to Martin Renvoize from comment #3) > What's the attached image for Katrin? Oops, obviously not the right picture, but at least just a strange bugzilla screenshot! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:14:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:14:23 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:14:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:14:26 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112845|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 112862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112862&action=edit Bug 25469: Typo: Item does not belongs to your library This patch makes corrections to two strings in the batch delete template to correct a typo. Before: t("Item does not belongs to your library") ...after, t("Item does not belong to your library") To test, apply the patch and inspect the template to confirm that the string is correct. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:23:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:23:46 +0000 Subject: [Koha-bugs] [Bug 26900] New: Fixes Koka::Libraries typo in C4/Reserves.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Bug ID: 26900 Summary: Fixes Koka::Libraries typo in C4/Reserves.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Plain simple: my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} ); This patch replaces 'Koka' by 'Koha'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:23:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:23:47 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:23:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:23:50 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112843|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 112863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112863&action=edit Bug 26896: Enable SIP option holds_block_checkin to actually block checkin of items with holds It appears that at some point, the actual blocking of checkins on items with holds got lost from the patch set. This slipped by because the sip server still outputs everything correctly, but the unit tests don't actually test to see if the checkout still exists afterward! Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:25:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:25:31 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #1 from Blou --- Created attachment 112864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112864&action=edit Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm Plain simple: my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} ); This patch replaces 'Koka' by 'Koha'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:25:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:25:55 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:27:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:27:18 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind --- Hi David. Are you able to provide a sample file for import with records that will trigger this? I tried by editing a record and making the title longer, then exporting; but it still worked. Otherwise, I will have another go this evening. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:32:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:32:21 +0000 Subject: [Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:32:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:32:24 +0000 Subject: [Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112828|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 112865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112865&action=edit Bug 26889: Remove extra space from "Damaged :" in item search This patch adds the chomp shorthand [%- -%] to the BLOCK for showing labels in the item search template. This collapses the whitespace around the label, eliminating the unwanted space around the ":" To test, apply the patch and go to the item search page in the staff interface. There should be no space before the colon in the "Damaged" label. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:33:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:33:38 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #2 from Blou --- this is also in 20.05, and I suppose 20.11. I'm checking and rechecking if I'm crazy. This would not have triggered for anybody else in 18 months?! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:35:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:35:14 +0000 Subject: [Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:35:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:35:17 +0000 Subject: [Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 --- Comment #1 from Owen Leonard --- Created attachment 112866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112866&action=edit Bug 26148: OpenLibrary "Preview" link target is unclear to patrons This patch makes changes to the display of the Open Library "read" links in the OPAC search results and detail page. The link is now grouped with other details about the record ("Publisher," "Location(s)," etc. On the detail page, the "Preview" link will no longer appear under the cover image. The label is changed to "Found in Open Library," and the link now opens the Open Library reader in a new window. The patch also changes the Open Library button image links so that they use https and makes it so that the "Found in Open Library" information is hidden until the availability information has loaded. To test, apply the patch and enable the OpenLibrarySearch system preference. - Perform a search in the OPAC which will return results found in Open Library, e.g. "poetry" in the sample data. - Confirm that the "Read now" images from Open Library appear on some search results. - View the detail page for one of these titles. - Confirm that the "Read now" button appears in the same format on the detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:37:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:37:51 +0000 Subject: [Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:37:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:37:55 +0000 Subject: [Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112823|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 112867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112867&action=edit Bug 26892: Remove warnings from Koha/Patrons.t Test plan: Confirm that the warnings "item-level_itypes set but no itemtype set for item" disappear after applying this patch Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:41:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:41:10 +0000 Subject: [Koha-bugs] [Bug 26901] New: Add ability to stop transfer slips to print if TrapHoldsOnOrder is set to Don't Trap Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26901 Bug ID: 26901 Summary: Add ability to stop transfer slips to print if TrapHoldsOnOrder is set to Don't Trap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com With the introduction of the new system preference, TrapHoldsOnOrder, if a library sets this to "Don't Trap", they also would probably not want to get an alert to transfer the items. As libraries are continuing to quarantine their books, they are generally keeping them in the one library until the quarantine is over. However, clicking ignore with each transfer / hold slip for this workflow is a bit much. It would be nice to allow for a library to turn this off - as Koha is allowing with this other system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:53:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:53:56 +0000 Subject: [Koha-bugs] [Bug 26902] New: Add ability to flag a patron email address as possibly invalid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26902 Bug ID: 26902 Summary: Add ability to flag a patron email address as possibly invalid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be beneficial if there was a way to flag email addresses in Koha as possibly invalid. That way, if a library receives a bounce-back for a given email, Koha could flag that email address as questionable. At that point, Koha could show an alert when checking out to that patron so the librarian can confirm the address is correct with the patron. An API endpoint that would accept an email address, find any instance of that email address in patron records, and flag it as potentially invalid would be very useful to integrate automation of converting bounce-back emails into warning flags in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 20:54:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 19:54:12 +0000 Subject: [Koha-bugs] [Bug 26902] Add ability to flag a patron email address as possibly invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26902 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:02:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 20:02:30 +0000 Subject: [Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 --- Comment #5 from Andrew Fuerste-Henry --- Updating test plan. Existing step 9 led to an error as one attempted to create items based on a 952 containing an existing itemnumber: To test: 0 - Be using Elasticsearch, apply patches, reindex 1 - Add multiple items to several records in your catalog 2 - Export those records 3 - Update the items on the records in Koha to be 'damaged' 4 - Import the file exported above, matchign on biblionumber and overlaying items 5 - Perform a search to return the imported records 6 - Confirm all items have damaged correctly removed in search results 7 - Import without matching and ignoring items to confirm new records are added 8 - Search to return records and verify they are indexed (shoudl see 2 copies) 9 - Alter exported records to remove itemnumber and barcode 10 - Import the file matching on biblionumber and adding items 11 - Search tp return records, confirm the new items are indexed 12 - Export some authority records 13 - Import them without matching and confirm new records are searchable 14 - Alter the existing records, and match on AuthID, you will need to create a matching rule for this 15 - Import and match and confirm the records are searchable and reflect the change back to original values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:03:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 20:03:13 +0000 Subject: [Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Andrew Fuerste-Henry --- Failing on step 13. New authorities are created but don't come up in searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:20:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 20:20:03 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #3 from Blou --- well, my maths suck. I guess I'm too used to work on 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:20:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 20:20:38 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #91 from Tomás Cohen Arazi --- Created attachment 112868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112868&action=edit Bug 20212: (QA follow-up) Remember current filter This patch restores the original behaviour: if you jump into receiving an order, and then go back to receiving, you want the page to remember your filters. This feature was overlooked. On fixing it, I wrapped some JS code in a function for reusing it and simplified it a bit as well. To test: 1. Enter a search term in either of the search fields 2. Add a note, receive or do another action => SUCCESS: The search term is kept 3. Apply this patch set 4. Repeat 2 => SUCCESS: The search term is kept Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:26:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 20:26:44 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #92 from Tomás Cohen Arazi --- Katrin, I've submitted a follow-up for fixing the problem with remembering searches. As for the regression tests, what I did was embedding the objects->search code in the controller, so I can tweak the handling for biblioitems.* fields in the query, because biblio objects include the biblioitems columns, so a special handling is required until we merge those tables (or not). So my feeling was that the fact that running: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t was passing, was enough. I can try adding tests for filtering on biblioitems.* fields, but the general tests cover the routes already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:38:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 20:38:57 +0000 Subject: [Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:39:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 20:39:00 +0000 Subject: [Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112866|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 112869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112869&action=edit Bug 26148: OpenLibrary "Preview" link target is unclear to patrons This patch makes changes to the display of the Open Library "read" links in the OPAC search results and detail page. The link is now grouped with other details about the record ("Publisher," "Location(s)," etc. On the detail page, the "Preview" link will no longer appear under the cover image. The label is changed to "Found in Open Library," and the link now opens the Open Library reader in a new window. The patch also changes the Open Library button image links so that they use https and makes it so that the "Found in Open Library" information is hidden until the availability information has loaded. To test, apply the patch and enable the OpenLibrarySearch system preference. - Perform a search in the OPAC which will return results found in Open Library, e.g. "poetry" in the sample data. - Confirm that the "Read now" images from Open Library appear on some search results. - View the detail page for one of these titles. - Confirm that the "Read now" button appears in the same format on the detail page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:47:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 20:47:19 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 21:47:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 20:47:22 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112864|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 112870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112870&action=edit Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm Plain simple: my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} ); This patch replaces 'Koka' by 'Koha'. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:06:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:06:36 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:06:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:06:41 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111687|0 |1 is obsolete| | Attachment #111688|0 |1 is obsolete| | Attachment #111689|0 |1 is obsolete| | --- Comment #117 from Arthur Suzuki --- Created attachment 112871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112871&action=edit Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower Apply the patch 3/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 4/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:07:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:07:02 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #118 from Arthur Suzuki --- Created attachment 112872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112872&action=edit Bug 11999: Test improvements + check maxreserves improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:07:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:07:08 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #119 from Arthur Suzuki --- Created attachment 112873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112873&action=edit Bug 11999: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:16:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:16:38 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #120 from Arthur Suzuki --- Thanks david :) Patch did no longer apply because one of my other patch actually got into master, hurray! \o/ Re-posted all patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:24:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:24:45 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112873|0 |1 is obsolete| | --- Comment #121 from Arthur Suzuki --- Created attachment 112874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112874&action=edit Bug 11999: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:24:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:24:51 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:24:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:24:54 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112797|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 112875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112875&action=edit Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text. There is a space between the lock icon and the 'Locked' text. Sponsored-by: Catalyst IT Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:24:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:24:58 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112837|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 112876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112876&action=edit Bug 24012: (QA follow-up) Use standard patterns - Removes the scss change in favor of adding the space to the HTML as is the usual pattern when using Font Awesome icons - Removes the span with the inline style to make things appear as black by default (no danger here in it being locked?) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:29:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:29:04 +0000 Subject: [Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:29:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:29:07 +0000 Subject: [Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112867|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 112877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112877&action=edit Bug 26892: Remove warnings from Koha/Patrons.t Test plan: Confirm that the warnings "item-level_itypes set but no itemtype set for item" disappear after applying this patch Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:34:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:34:16 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:34:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:34:19 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112861|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 112878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112878&action=edit Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt Test Plan: 1) In the staff interface go to course reserves. 2) Add a new course. 3) Add a reserve (Add reserves > add a valid barcode > submit). 4) Go to the list of courses and select the course you added the item to. 5) An error trace log is generated 6) Apply this patch 7) Reload the page 8) No errors! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:37:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:37:15 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:37:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:37:18 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112862|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 112879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112879&action=edit Bug 25469: Typo: Item does not belongs to your library This patch makes corrections to two strings in the batch delete template to correct a typo. Before: t("Item does not belongs to your library") ...after, t("Item does not belong to your library") To test, apply the patch and inspect the template to confirm that the string is correct. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:46:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:46:17 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:46:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:46:20 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112870|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 112880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112880&action=edit Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm Plain simple: my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} ); This patch replaces 'Koka' by 'Koha'. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:46:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:46:53 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #6 from Katrin Fischer --- Is it possible that the if ($pickup_library) {} is dead code? The only time we seem to be using the parameter is in a test in t/db_dependent/Reserves.t. Or... should we have been using it somewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:48:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:48:34 +0000 Subject: [Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:48:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:48:38 +0000 Subject: [Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112865|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 112881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112881&action=edit Bug 26889: Remove extra space from "Damaged :" in item search This patch adds the chomp shorthand [%- -%] to the BLOCK for showing labels in the item search template. This collapses the whitespace around the label, eliminating the unwanted space around the ":" To test, apply the patch and go to the item search page in the staff interface. There should be no space before the colon in the "Damaged" label. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 22:49:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 21:49:10 +0000 Subject: [Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 --- Comment #4 from Katrin Fischer --- I tried adding a few -, but obviously not in the right spots :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 23:02:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 22:02:06 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #7 from Blou --- Not exactly sure, but this occurred in the opening sequences of our testing of 20.05.05 - Default database - No modification of preferences - add a rule to allow all to put on reserve. - add one record with one item using "book" as itemtype - Search for it in the OPAC - click on Hold, select a library, save, boom! So this was through the UI, and I *presume* of normal usage by our librarian who gave me the steps to reproduce. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 23:03:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 22:03:45 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #7 from David Cook --- (In reply to David Nind from comment #6) > Hi David. > > Are you able to provide a sample file for import with records that will > trigger this? > > I tried by editing a record and making the title longer, then exporting; but > it still worked. > > Otherwise, I will have another go this evening. > > David Were you testing the patch or trying to reproduce the error? The problem is really difficult to spot, but I'll look at putting together a sample set of data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 23:05:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 22:05:31 +0000 Subject: [Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED --- Comment #7 from David Cook --- I don't think this is needed thanks to https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112814 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 2 23:48:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 22:48:31 +0000 Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) break our REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 00:00:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 23:00:13 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #93 from Tomás Cohen Arazi --- Created attachment 112882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112882&action=edit Bug 20212: Controller changes regression tests This patchset did a copy and paste of the objects->search helper inside the controller, to handle a very special case that wasn't worth generalizing: the fact that the biblio object (that this patchset makes embeddable) is actually built from two tables, and we want to filter by fields in both tables. This requires us to translate: - Any filter reference to fields in biblioitems we allow to search on, through an allow list. - For filtering to work, we need to tweak the stashed 'embed' object so the prefetch is done correctly This patchset also adds a new query parameter: only_active. It is used to only request active orders (see the spec for more details). This patch adds tests for: - Filtering by a column in bilbioitems (this implies correctly prefetching the bilbio => biblioitems relation, and translating the filtering parameter. - Using the only_active query parameter to retrieve only active orders To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Verify the tests check for the explained behaviours. => SUCCESS: They do! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 00:44:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 23:44:07 +0000 Subject: [Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 00:44:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 23:44:10 +0000 Subject: [Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #12 from Lucas Gass --- Created attachment 112883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112883&action=edit Bug 26804: (QA follow-up) add modal-lg class and intent markup correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 00:46:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Nov 2020 23:46:10 +0000 Subject: [Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #13 from Lucas Gass --- Owen, modal-wide didn't work for me but modal-lg did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:20:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 00:20:57 +0000 Subject: [Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #14 from Owen Leonard --- (In reply to Lucas Gass from comment #13) > modal-wide didn't work for me but modal-lg did. Sorry, that's what I meant! :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:37:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 00:37:14 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #8 from David Cook --- Created attachment 112884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112884&action=edit Record with long title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:38:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 00:38:38 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #9 from David Cook --- I've added a record with a long title. Without the patch, when I go to view the import batch (at /cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=1), I see that the "Citation" says "null". If I go into the database, I can see 1 record in import_records, but there are 0 records in import_biblios. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:41:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 00:41:37 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Yes! I am 100% in favour of turning on RaiseError for the UI. For what it's worth, I don't think that it will be a huge drama. When running on openSUSE, we have turned on RaiseError on the staff interface for many years now, and while there is an occasional fatal software error, which I try to clean up and upstream, for the most part it's quite stable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 01:52:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 00:52:15 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #2 from David Cook --- (In reply to David Cook from comment #1) > Yes! I am 100% in favour of turning on RaiseError for the UI. > > For what it's worth, I don't think that it will be a huge drama. > > When running on openSUSE, we have turned on RaiseError on the staff > interface for many years now, and while there is an occasional fatal > software error, which I try to clean up and upstream, for the most part it's > quite stable. Plus, we could look at moving forward on Bug 26048, so that any errors in the UI are much more user friendly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 02:07:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 01:07:42 +0000 Subject: [Koha-bugs] [Bug 26903] New: Imported authorities not added to ES indices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Bug ID: 26903 Summary: Imported authorities not added to ES indices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com Blocks: 26543 To recreate: - set your SearchEngine to Elastic - have an authority record - stage and import it - use link from completed import to see authority and confirm it exists in your system - search for authority, confirm you cannot find it Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 02:07:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 01:07:42 +0000 Subject: [Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26903 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 [Bug 26903] Imported authorities not added to ES indices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 02:09:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 01:09:01 +0000 Subject: [Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 --- Comment #7 from Andrew Fuerste-Henry --- See blocking bug, 26903. Turns out the behavior I ran into happens on master without this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 02:09:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 01:09:13 +0000 Subject: [Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 03:52:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 02:52:44 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 03:52:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 02:52:47 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112657|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 112885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112885&action=edit Bug 26853: Harmonize import_biblios with biblio and biblioitems This patch harmonizes the column datatypes of import_biblios with biblio and biblioitems to prevent database errors which cause staged MARC uploads to sometimes fail to update 100% correctly. To test: 1. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 2. Upload a file with MARC records with titles longer than 128 characters long 3. Click "Stage for import" 4. Monitor /var/log/koha/kohadev/intranet-error.log for database errors 5. Note that there are no database errors Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 03:52:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 02:52:51 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112658|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 112886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112886&action=edit Bug 26853: Throw a fatal error if import_biblios insert fails Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 04:00:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 03:00:25 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #12 from David Nind --- Thanks David! I had tried to recreate the error first, but I had no luck. The record you provided really helped! I hadn't spotted that a database was required as well. Everything appears to work now for me so I have signed off. I did notice another error in the database - it happened both before and after the patch was applied, but I don't think this is related to this bug: [Tue Nov 03 02:57:55.761624 2020] [cgi:error] [pid 3980] [client 172.18.0.1: 58304] AH01215: [Tue Nov 3 02:57:55 2020] stage-marc-import.pl: Filehandle STDOUT reopened as $fh only for input at /usr/share/perl5/DateTime/TimeZone/ Local/Unix.pm line 146.: /kohadevbox/koha/tools/stage-marc-import.pl, refere r: http://127.0.0.1:8081/cgi-bin/koha/tools/stage-marc-import.pl David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:10:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 04:10:13 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Status|BLOCKED |Failed QA --- Comment #17 from David Cook --- Actually, we have a customization that does something like this patch, and it actually causes the problem to be worse. If you set the idx element value to '', the idx select elements don't get sent, but the empty q input elements do. So you wind up with a mismatched number of parameters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:11:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 04:11:47 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #24 from David Cook --- (In reply to Nick Clemens from comment #20) > Would it be reasonable to clear empty inputs with javascript before the > submission? On reflection, that won't work the way you think it would work. It would create the problems described in Bug 7607. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:13:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 04:13:13 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #25 from David Cook --- (In reply to Katrin Fischer from comment #23) > (In reply to Jonathan Druart from comment #22) > > Who is volunteering? > > Hm, just clearning the inputs won't fix the problem of bug 7607 I think? The > problem is, that people leave search fields empty so idx and search terms > don't match up. > > kw - no search term entered > title - some title words > > Turns into: kw search for some title words > > We have found this workaround from the other bug to be working, but I am not > sure if that will fix the ugliness of the URL. With the Apache change, you don't need to do the workaround. The URL is equally as ugly as well. At the moment, it looks like the only way of having a less ugly URL is by removing empty search boxes from the DOM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:14:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 04:14:32 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #26 from David Cook --- I am tempted to move this back to "Passed QA" because it actually resolves the problem from Bug 7607. While it makes for uglier URLs, it is functionally superior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:15:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 04:15:17 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #18 from David Cook --- (In reply to Jonathan Druart from comment #16) > If we have the change from bug 25548, this issue will get fixed. I agree. Bug 25548 would resolve Bug 7607. And if people are worried about ugly URLs, then I think they should open a new bug report to remove unused search boxes in advanced search from the DOM so they don't get submitted with the HTML form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:15:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 04:15:35 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:17:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 04:17:45 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #19 from David Cook --- (In reply to David Cook from comment #18) > And if people are worried about ugly URLs, then I think they should open a > new bug report to remove unused search boxes in advanced search from the DOM > so they don't get submitted with the HTML form. Alternatively, we could only show 1 search box on the advanced search page, and make people add more search boxes as needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:30:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 04:30:13 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #20 from David Cook --- (In reply to David Cook from comment #17) > Actually, we have a customization that does something like this patch, and > it actually causes the problem to be worse. > > If you set the idx element value to '', the idx select elements don't get > sent, but the empty q input elements do. So you wind up with a mismatched > number of parameters. This isn't true *if* you provide an option in the select list with a value of ''. So adding that option element in the list would help, if we want to use the Javascript in the patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:34:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 04:34:33 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #13 from David Cook --- (In reply to David Nind from comment #12) > > Everything appears to work now for me so I have signed off. Thanks, David. Much appreciated! I think is a really nasty bug that is easy to miss, especially when RaiseError is turned off. When Bug 25026 is pushed, it will make issues like this more obvious. > I did notice another error in the database - it happened both before and > after the patch was applied, but I don't think this is related to this bug: > > [Tue Nov 03 02:57:55.761624 2020] [cgi:error] [pid 3980] [client 172.18.0.1: > 58304] AH01215: [Tue Nov 3 02:57:55 2020] stage-marc-import.pl: Filehandle > STDOUT reopened as $fh only for input at /usr/share/perl5/DateTime/TimeZone/ > Local/Unix.pm line 146.: /kohadevbox/koha/tools/stage-marc-import.pl, refere > r: http://127.0.0.1:8081/cgi-bin/koha/tools/stage-marc-import.pl That's more of a warning than an error. It's not related to this bug, but I have been thinking of looking into it more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:35:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 04:35:18 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #3 from David Cook --- Note that Bug 26853 is an example where RaiseError would be really helpful because it would help surface edge cases that otherwise fail with silent errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 05:47:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 04:47:11 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 --- Comment #20 from Alex Buckley --- Thank you Katrin and Owen! On reflection I agree with you that 'Locked' probably shouldn't be displayed in red as it is not an error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 06:24:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 05:24:18 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 06:24:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 05:24:52 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #25 from Alex Buckley --- Created attachment 112887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112887&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell prove xt prove t prove t/db_dependent/Circulation/issue.t prove t/db_dependent/Koha/Object.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 06:26:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 05:26:24 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #26 from Alex Buckley --- Hi David, I've attached a (hopefully!) fixed up unit tests patch. Would you mind re-testing the unit tests and see if the t/db_dependent/Circulation/issue.t test now passes for you? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 08:21:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 07:21:46 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_26895=5D_Template_process_failed=3A?= =?utf-8?q?_file_error_-_parse_error_-_patron-title=2Einc_line_37=3A_unexp?= =?utf-8?b?ZWN0ZWQgdG9rZW4gKCc8c3BhbikgICBbJSBzcGFuX3N0YXJ0ID0gJzxzcGFu?= =?utf-8?b?IGNsYXNzPSJwYXRyb24tdGl0bGUiPsOi4oKsy5wgJV0gYXQgL3Vzci9zaGFy?= =?utf-8?q?e/koha/lib/C4/Templates=2Epm_line_122=2E?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26895 --- Comment #2 from francesc --- But this happens with clean installation. I don't have written this character anywhere. This error is caused with installation. I use catalan language that contains this character. May be the default catalan templates use this character. But this character is common used in this language. So the site would be configured in order to process it. I guess it may be the problem. Any clues abiut the problem? Thank you very much. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 08:52:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 07:52:25 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala at helsinki.fi --- Comment #122 from Joonas Kylmälä --- The attached patch contains git merge conflict resolution hints. Also, if I understand correctly maxreserves is already checked in some other places in some other way, it would be really good idea to have a patch then to convert those calls to just use CanBookBeReserved(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 08:59:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 07:59:07 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112885|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 112888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112888&action=edit Bug 26853: Harmonize import_biblios with biblio and biblioitems This patch harmonizes the column datatypes of import_biblios with biblio and biblioitems to prevent database errors which cause staged MARC uploads to sometimes fail to update 100% correctly. To test: 1. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 2. Upload a file with MARC records with titles longer than 128 characters long 3. Click "Stage for import" 4. Monitor /var/log/koha/kohadev/intranet-error.log for database errors 5. Note that there are no database errors Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 08:59:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 07:59:11 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112886|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 112889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112889&action=edit Bug 26853: Throw a fatal error if import_biblios insert fails Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 08:59:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 07:59:53 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #16 from Martin Renvoize --- It makes sense for these tables to be harmonized and I'm happy with the error being thrown on failures. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:03:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:03:01 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- (In reply to Andrew Fuerste-Henry from comment #8) > I *was* missing something! there's a checkbox! > > Manager changed successfully through both edit and batch interfaces. > Notice sent successfully. > I'm still a little torn about defaulting the changing the manager each time > you edit, but will wait to see what users think. I'm sure I've seen another bug regarding always setting the manager to the last person to update the suggestion.. I can't remember which way the bug was pushing for and can't find the bug now though :(. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:08:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:08:08 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |26323 --- Comment #5 from Jonathan Druart --- Caused by commit 9bbf90969304943210e24dcd69422c9fe7d28303 Bug 26323: (follow-up) Add new cases introduced Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:08:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:08:08 +0000 Subject: [Koha-bugs] [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:08:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:08:09 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #123 from Joonas Kylmälä --- I didn't realize the follow-ups here removed those git merge conflict resolution hints. It would still probably be better if the conflicts were solved in the patches they happen. If I review the patch "Test improvements + check maxreserves" it contains merge resolution and test improvements, so two things, git commits should do just one thing. Also "Bug 11999: (QA follow-up)" doesn't say what it does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:10:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:10:20 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from Jonathan Druart --- It may fixes the crash, but not the behaviour. The parameter is authorised_value, not authorized_value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:11:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:11:43 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #7 from Jonathan Druart --- There is also another occurrence in circ/branchtransfers.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:12:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:12:40 +0000 Subject: [Koha-bugs] [Bug 26664] Inventory: Sorting column 'Last seen' goes wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112482|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 112890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112890&action=edit Bug 26664: Fix sorting for date last seen in inventory tool This adds the standard datatable sorting for dates to the inventory table as described here: https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference To test: - Go to the inventory tool - Search for a big sample list of items with different date last seen - Sort the table now by "date last seen" by clicking on the table header cell - Try different settings of the DateFormat system preferences - Verify sorting is incorrect (alphabetic, not by date) - Apply patch - Repeat testing and very all is sorting correctly now Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:12:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:12:43 +0000 Subject: [Koha-bugs] [Bug 26664] Inventory: Sorting column 'Last seen' goes wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 --- Comment #5 from Martin Renvoize --- Created attachment 112891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112891&action=edit Bug 26664: (QA follow-up) Add filters Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:13:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:13:14 +0000 Subject: [Koha-bugs] [Bug 26664] Inventory: Sorting column 'Last seen' goes wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Works as expected; passes QA tests (with follow-up) Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:13:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:13:45 +0000 Subject: [Koha-bugs] [Bug 25897] Inventory table call number sort should use cn_sort value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112684|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 112892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112892&action=edit Bug 25897: Use cn_sort for sorting callnumbers in inventory table Instead of using the machine sortable form of the callnumber from cn_sort the table was only sorting on the callnumber. This tries to fix it using the same technique as for sorting the differently formatted dates. To test: - If your database has items with suitably cataloged items, use these. Otherwise you could use the examples from the bug report: - Catalog items with the following barcodes: B 29 V55 1998 B29 .C55 2008 B29 .L24 1983 B29 .L264 1998 B29 .P666 2004 Make sure the LOC is selected in $2 as source of classification This makes sure the sortable form of the callnumber is calculated correctly. - Go to inventory - Search for your items - Before patch, they should sort on callnumber as above, after the patch the correct sort order should be: B29 .C55 2008 B29 .L24 1983 B29 .L264 1998 B29 .P666 2004 B 29 V55 1998 Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:13:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:13:48 +0000 Subject: [Koha-bugs] [Bug 25897] Inventory table call number sort should use cn_sort value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897 --- Comment #7 from Martin Renvoize --- Created attachment 112893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112893&action=edit Bug 25897: (QA follow-up) Add filters Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:14:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:14:06 +0000 Subject: [Koha-bugs] [Bug 25897] Inventory table call number sort should use cn_sort value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Works as expected, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:19:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:19:52 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22284 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Caused by commit a998ba5714c8dc1b78062e95bd78e2738112737d Bug 22284: Control hold groups in C4::Reserves Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Add ability to define groups of locations for hold pickup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:19:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:19:52 +0000 Subject: [Koha-bugs] [Bug 22284] Add ability to define groups of locations for hold pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26900 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:21:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:21:08 +0000 Subject: [Koha-bugs] [Bug 22284] Add ability to define groups of locations for hold pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #304 from Jonathan Druart --- There was a typo "Koka" vs "Koha" in this patch, fixed on bug 26900. That should have been caught earlier, and it highlights that some of the code is not covered by tests. That would be good to provide them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:22:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:22:44 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:26:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:26:19 +0000 Subject: [Koha-bugs] [Bug 26594] Patrons merge problem with restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #11) > I am not convince by this patch, we should not call a private method. > Asking for a second QA POV. Kyle, can you confirm that you see this comment before you PQAed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:28:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:28:52 +0000 Subject: [Koha-bugs] [Bug 26638] System preference ArticleRequestsMandatoryFieldsItemsOnly is unused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26638 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112483|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 112894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112894&action=edit Bug 26638: Remove unused system preference ArticleRequestsMandatoryFieldsItemsOnly The preference was probably added because of a typo, as there is a used system preference ArticleRequestsMandatoryFieldsItemOnly (Item vs Items). This patch fixes the situation: - syspref.sql had the pref name with the typo, this is fixed. - A database update removes the unused variable and makes sure the used one is added. To test: - Look at the local use system preferences, verify the false pref is there - Look at the other ArticleRequests* preferences, verify the other without "s" is there - Apply patch and run database update - Verify the local use tab one is gone now Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:29:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:29:29 +0000 Subject: [Koha-bugs] [Bug 26638] System preference ArticleRequestsMandatoryFieldsItemsOnly is unused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26638 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Confirmed the preference is not used, confirmed the DB update is idempotent, confirmed the QA tests pass. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:30:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:30:16 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #27 from Jonathan Druart --- (In reply to David Cook from comment #24) > (In reply to Nick Clemens from comment #20) > > Would it be reasonable to clear empty inputs with javascript before the > > submission? > > On reflection, that won't work the way you think it would work. It would > create the problems described in Bug 7607. It won't if you remove the related idx. I don't think we should push this patch without having both sides happy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:35:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:35:16 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 --- Comment #3 from Martin Renvoize --- Comment on attachment 112761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112761 Bug 26727: Fix

appearing in the templates Review of attachment 112761: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=26727&attachment=112761) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt @@ +90,4 @@ > >

> Place article request from [% biblio.title | html %] for [% patron.firstname | html %] [% patron.surname | html %] ( [% patron.cardnumber | html %] ) > +

Hmm, not sure about this one.. won't it result in an unmatched tag? (i.e. I can't see a closing

anywhere beneath this opening

) ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt @@ +220,4 @@ > > > > +

Why a double
here compared to a single
in koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:35:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:35:27 +0000 Subject: [Koha-bugs] [Bug 20023] Password recovery should be case insensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20023 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26904 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:35:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:35:50 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:40:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:40:28 +0000 Subject: [Koha-bugs] [Bug 25759] Invoices hyperlink is broken on edifactmsgs.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25759 --- Comment #16 from Martin Renvoize --- :), thanks guys, really glad it's working as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:44:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:44:08 +0000 Subject: [Koha-bugs] [Bug 11460] Correction to default itemcallnumber system preference in UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11460 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112762|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 112896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112896&action=edit Bug 11460: Remove MARC21 default mapping from itemcallnumber system preference The mapping in the itemcallnumber system preference is only valid for MARC21 libraries using DDC classification, but not for libraries using UNIMARC or other classification. This patch suggests to remove the default mapping and start new installations with an empty value. To test: - On an emtpy database - Apply patch - Run the web installer, selecting either MARC21 or UNIMARC - Verify that the itemcallnumber system preference is empty - Verify the description now also include examples for UNIMARC Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:44:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:44:32 +0000 Subject: [Koha-bugs] [Bug 11460] Correction to default itemcallnumber system preference in UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11460 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Change makes sense, passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:48:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:48:04 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Yikes.. I think you and I were working in this area around the same time Kyle.. bet it was a mix of our bugs that caused the issue. Looks good now, just testing for QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:48:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:48:08 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:49:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:49:19 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112863|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 112897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112897&action=edit Bug 26896: Enable SIP option holds_block_checkin to actually block checkin of items with holds It appears that at some point, the actual blocking of checkins on items with holds got lost from the patch set. This slipped by because the sip server still outputs everything correctly, but the unit tests don't actually test to see if the checkout still exists afterward! Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:49:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:49:43 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Tests now cover fully and pass. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:56:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:56:17 +0000 Subject: [Koha-bugs] [Bug 26832] Elasticsearch mappings export should use UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26832 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112813|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 112899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112899&action=edit Bug 26832: Make Elasticsearch mappings export use UTF-8 Script misc/search_tools/export_elasticsearch_mappings.pl allows to export current search engine configuration into a YAML file. This export should use UTF-8 encoding, like other exports. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) Edit a field label to use a diacrtic, for example local-number => Numéro 3) Save 4) Edit file etc/koha-conf.xml to enable 'elasticsearch_index_mappings' 5) Export mappings to file via misc/search_tools/export_elasticsearch_mappings.pl -t $MARCFLAVOUR 6) Reset memcached and plack 7) Back to Administration > Search engine configuration (Elasticsearch) 8) Click on 'Reset Mappings' and accept 9) Look at field 'local-number' => Without patch diacritic 'é' is broken 10) You may try with an emoji B-) Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:56:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:56:52 +0000 Subject: [Koha-bugs] [Bug 26832] Elasticsearch mappings export should use UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26832 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 09:56:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 08:56:53 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112897|0 |1 is obsolete| | --- Comment #6 from Matthias Meusburger --- Created attachment 112900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112900&action=edit Bug 26896: Enable SIP option holds_block_checkin to actually block checkin of items with holds It appears that at some point, the actual blocking of checkins on items with holds got lost from the patch set. This slipped by because the sip server still outputs everything correctly, but the unit tests don't actually test to see if the checkout still exists afterward! Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:13:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:13:16 +0000 Subject: [Koha-bugs] [Bug 26800] Remove the use of jquery.checkboxes plugin from checkout page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26800 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #112396|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:13:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:13:46 +0000 Subject: [Koha-bugs] [Bug 26769] Remove the use of jquery.checkboxes plugin from staff interface search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26769 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #112399|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:17:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:17:20 +0000 Subject: [Koha-bugs] [Bug 26798] Remove the use of jquery.checkboxes plugin from patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #112398|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:20:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:20:54 +0000 Subject: [Koha-bugs] [Bug 24665] Add ability to run cash register report with new cash register feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:23:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:23:08 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #91 from Joonas Kylmälä --- (In reply to Nick Clemens from comment #90) > Koha/SearchEngine/Elasticsearch/Search.pm > 298 =item C<$max_results> > 299 > 300 The max number of results to return. The default is 100 (because > unlimited > 301 is a pretty terrible thing to do.) > > Probably this should be a syspref? For Zebra we don't hardcode a limit, but > maybe we should not return everything and it would be better to have one > syspref to control both> I don't think a global max results syspref would be a good idea. We could probably identify all calls of simple_search_compat() and then those that require more than 100 results, like this feature, should handle this case by making more calls using offset or different max results value. So it seems like we are now back to the question whether implement AJAX as was discussed earlier but it would be useful to have a rest api endpoint for component parts in that case. Or we could also say we are fine with 100 results at this point in time. What are your opinions on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:27:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:27:58 +0000 Subject: [Koha-bugs] [Bug 24665] Add ability to run cash register report with new cash register feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107164|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 112901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112901&action=edit Bug 24665: Add support for filtering by cash register Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:28:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:28:13 +0000 Subject: [Koha-bugs] [Bug 24665] Add ability to run cash register report with new cash register feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 --- Comment #9 from Martin Renvoize --- Rebased, ready for QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:31:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:31:18 +0000 Subject: [Koha-bugs] [Bug 26905] New: Purchase suggestion button hidden for users with suggestion permission but not acq permission Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Bug ID: 26905 Summary: Purchase suggestion button hidden for users with suggestion permission but not acq permission Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: gormanp at parliament.uk QA Contact: testopia at bugs.koha-community.org We have library staff who may need to submit purchase suggestions to our acquisitions team, but do not need access to the rest of the acquisitions module. We do not have purchase suggestions turned on on the OPAC. We have permissions set so that they can manage purchase suggestions, but do not have any acquisitions module permissions set. Unless I'm mistaken, the only route to access the purchase suggestion form through the staff client is through the acquisitions module, but if these users have no acquisitions permissions, they do not have the acquisitions page link available on the Koha homepage. Can I propose that a link to the purchase suggestion form be added somewhere else on the staff client homepage, so that users with this particular set of permissions can access the form without needing to have additional acquisitions permissions? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:33:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:33:30 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Phil changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11911 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:33:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:33:30 +0000 Subject: [Koha-bugs] [Bug 11911] Add separate permission for managing suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Phil changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26905 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:45:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:45:52 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #27 from David Nind --- Hi Alex. I'm only getting one test failure now: not ok 33 - UpdateNotForLoanStatusOnCheckin does not update notforloan value when itemtypes.updatenotforloanstatusoncheckin = 0 # Failed test 'UpdateNotForLoanStatusOnCheckin does not update notforloan value when itemtypes.updatenotforloanstatusoncheckin = 0' # at t/db_dependent/Circulation/issue.t line 440. This happens after applying the patches, and working through the test plan including the system preference changes. If I just apply the patches and update the database the tests pass. Let me know if that is sufficient to sign off. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:46:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:46:26 +0000 Subject: [Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 --- Comment #5 from Jonathan Druart --- Created attachment 112902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112902&action=edit Bug 26806: Remove 1 remaining occurrence of jquery.checkboxes.min.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:53:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:53:29 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26904 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:54:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:54:40 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:54:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:54:44 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112564|0 |1 is obsolete| | Attachment #112832|0 |1 is obsolete| | --- Comment #7 from Joonas Kylmälä --- Created attachment 112903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112903&action=edit Bug 24567: Don't strip spaces along with dangling colons This updates the regex used for removing colons to capture those with space on either side, and remove the colon while preserving the space To test: 1 - Have Koha using ES 2 - Search for: ti:chess AND chess 3 - You should get a result in sample data, otherwise replace 'chess' with a title in your catalogue 4 - Search for: ti:chess AND kw:chess 5 - No result 6 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate 7 - Repeate search and check page source 8 - search_query has: title:chess ANDchess 9 - Apply patch 10 - Repeat 11 - Seaerch works! 12 - query is now: title:chess AND chess Signed-off-by: Séverine QUEUNE Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:54:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:54:47 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 --- Comment #8 from Joonas Kylmälä --- Created attachment 112904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112904&action=edit Bug 24567: (follow-up) Use dollar sign to refer to captures Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:55:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:55:39 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:58:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:58:11 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |joonas.kylmala at helsinki.fi --- Comment #9 from Joonas Kylmälä --- I only now noticed the warning > Use of uninitialized value $3 in concatenation (.) or string at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 943. Moving back to FQA until sure what to do with this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:58:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:58:43 +0000 Subject: [Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:58:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:58:45 +0000 Subject: [Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 --- Comment #14 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:58:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:58:47 +0000 Subject: [Koha-bugs] [Bug 26398] Credit and Debit types on creating a manual credits and manual invoices are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:58:49 +0000 Subject: [Koha-bugs] [Bug 26398] Credit and Debit types on creating a manual credits and manual invoices are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 --- Comment #14 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:58:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:58:51 +0000 Subject: [Koha-bugs] [Bug 26694] Set focus for cursor to search input box on guarantor_search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26694 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:58:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:58:52 +0000 Subject: [Koha-bugs] [Bug 26694] Set focus for cursor to search input box on guarantor_search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26694 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:58:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:58:54 +0000 Subject: [Koha-bugs] [Bug 26695] Set focus for cursor to login box on the login popup modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26695 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:58:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:58:56 +0000 Subject: [Koha-bugs] [Bug 26695] Set focus for cursor to login box on the login popup modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26695 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:58:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:58:58 +0000 Subject: [Koha-bugs] [Bug 26696] Make payment table has a display issue when credits exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26696 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:00 +0000 Subject: [Koha-bugs] [Bug 26696] Make payment table has a display issue when credits exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26696 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:01 +0000 Subject: [Koha-bugs] [Bug 26712] Set focus for cursor to basket name input box on basketheader.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26712 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:03 +0000 Subject: [Koha-bugs] [Bug 26712] Set focus for cursor to basket name input box on basketheader.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26712 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:05 +0000 Subject: [Koha-bugs] [Bug 26721] Debit and credit type pages should check for the specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26721 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:07 +0000 Subject: [Koha-bugs] [Bug 26721] Debit and credit type pages should check for the specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26721 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:08 +0000 Subject: [Koha-bugs] [Bug 26753] Set focus for cursor to password field on Overdrive login popup on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26753 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:10 +0000 Subject: [Koha-bugs] [Bug 26753] Set focus for cursor to password field on Overdrive login popup on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26753 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:12 +0000 Subject: [Koha-bugs] [Bug 26767] Remove the use of jquery.checkboxes plugin from duplicate orders template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26767 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:13 +0000 Subject: [Koha-bugs] [Bug 26767] Remove the use of jquery.checkboxes plugin from duplicate orders template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26767 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:15 +0000 Subject: [Koha-bugs] [Bug 26768] Remove the use of jquery.checkboxes plugin from library transfer limits page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26768 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:17 +0000 Subject: [Koha-bugs] [Bug 26768] Remove the use of jquery.checkboxes plugin from library transfer limits page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26768 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:18 +0000 Subject: [Koha-bugs] [Bug 26769] Remove the use of jquery.checkboxes plugin from staff interface search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26769 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:20 +0000 Subject: [Koha-bugs] [Bug 26769] Remove the use of jquery.checkboxes plugin from staff interface search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26769 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:22 +0000 Subject: [Koha-bugs] [Bug 26795] Remove the use of jquery.checkboxes plugin from ILL pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:24 +0000 Subject: [Koha-bugs] [Bug 26795] Remove the use of jquery.checkboxes plugin from ILL pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:26 +0000 Subject: [Koha-bugs] [Bug 26798] Remove the use of jquery.checkboxes plugin from patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:28 +0000 Subject: [Koha-bugs] [Bug 26798] Remove the use of jquery.checkboxes plugin from patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26798 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:30 +0000 Subject: [Koha-bugs] [Bug 26799] Remove the use of jquery.checkboxes plugin from patron payment page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:31 +0000 Subject: [Koha-bugs] [Bug 26799] Remove the use of jquery.checkboxes plugin from patron payment page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26799 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:33 +0000 Subject: [Koha-bugs] [Bug 26800] Remove the use of jquery.checkboxes plugin from checkout page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26800 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:35 +0000 Subject: [Koha-bugs] [Bug 26800] Remove the use of jquery.checkboxes plugin from checkout page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26800 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:37 +0000 Subject: [Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:38 +0000 Subject: [Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 --- Comment #12 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:40 +0000 Subject: [Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:42 +0000 Subject: [Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:43 +0000 Subject: [Koha-bugs] [Bug 26826] Set focus for cursor to name input box when creating a new list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26826 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:45 +0000 Subject: [Koha-bugs] [Bug 26826] Set focus for cursor to name input box when creating a new list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26826 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:47 +0000 Subject: [Koha-bugs] [Bug 26828] Set focus for cursor to current password field when updating in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:49 +0000 Subject: [Koha-bugs] [Bug 26828] Set focus for cursor to current password field when updating in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26828 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:51 +0000 Subject: [Koha-bugs] [Bug 26830] Set focus for cursor to name input box when creating a new list in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26830 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:52 +0000 Subject: [Koha-bugs] [Bug 26830] Set focus for cursor to name input box when creating a new list in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26830 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:54 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:56 +0000 Subject: [Koha-bugs] [Bug 26853] Data lost due to "Data too long for column" errors during MARC import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26853 --- Comment #17 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:58 +0000 Subject: [Koha-bugs] [Bug 26880] Add explanatory text to Add course reserve screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26880 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 10:59:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 09:59:59 +0000 Subject: [Koha-bugs] [Bug 26880] Add explanatory text to Add course reserve screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26880 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:00:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:00:01 +0000 Subject: [Koha-bugs] [Bug 26881] Remove the period at the end of 'Limit to currently available items' in facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:00:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:00:03 +0000 Subject: [Koha-bugs] [Bug 26881] Remove the period at the end of 'Limit to currently available items' in facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26881 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:00:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:00:05 +0000 Subject: [Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:00:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:00:07 +0000 Subject: [Koha-bugs] [Bug 26889] Remove extra space from "Damaged :" in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:00:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:00:08 +0000 Subject: [Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:00:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:00:10 +0000 Subject: [Koha-bugs] [Bug 26892] Remove warnings from t/db_dependent/Koha/Patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26892 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:00:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:00:11 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:00:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:00:13 +0000 Subject: [Koha-bugs] [Bug 26900] Fixes Koka::Libraries typo in C4/Reserves.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:00:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:00:52 +0000 Subject: [Koha-bugs] [Bug 26906] New: Koha_ExternalContent_OverDrive.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26906 Bug ID: 26906 Summary: Koha_ExternalContent_OverDrive.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 25551 Master_U18 (run 933) 18:10:19 koha_1 | # Failed test 'error_message()' 18:10:19 koha_1 | # at t/db_dependent/Koha_ExternalContent_OverDrive.t line 41. 18:10:19 koha_1 | # Original: 18:10:19 koha_1 | # Can't connect to oauth.overdrive.com:443 18:10:19 koha_1 | # Request: 18:10:19 koha_1 | # POST https://oauth.overdrive.com/token 18:10:19 koha_1 | # Authorization: Basic RFVNTVk6RFVNTVk= 18:10:19 koha_1 | # User-Agent: Koha/20.06.00.055 18:10:19 koha_1 | # Content-Length: 126 18:10:19 koha_1 | # Content-Type: application/x-www-form-urlencoded 18:10:19 koha_1 | # 18:10:19 koha_1 | # code=blah&grant_type=authorization_code&redirect_uri=http%3A%2F%2Fmykoha.org%2Fcgi-bin%2Fkoha%2Fexternal%2Foverdrive%2Fauth.pl 18:10:19 koha_1 | # 18:10:19 koha_1 | # Response: 18:10:19 koha_1 | # 500 Can't connect to oauth.overdrive.com:443 18:10:19 koha_1 | # Content-Type: text/plain 18:10:19 koha_1 | # Client-Date: Mon, 02 Nov 2020 17:10:19 GMT 18:10:19 koha_1 | # Client-Warning: Internal response 18:10:19 koha_1 | # 18:10:19 koha_1 | # Can't connect to oauth.overdrive.com:443 18:10:19 koha_1 | # 18:10:19 koha_1 | # 18:10:19 koha_1 | # Turned into: 18:10:19 koha_1 | # Can't connect to oauth.overdrive.com:443 18:10:19 koha_1 | # Looks like you failed 1 test of 6. 18:10:19 koha_1 | [17:10:19] t/db_dependent/Koha_ExternalContent_OverDrive. Maybe we should skip the test if the server is not reachable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:00:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:00:52 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26906 [Bug 26906] Koha_ExternalContent_OverDrive.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:01:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:01:50 +0000 Subject: [Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Looks like we can close this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:13:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:13:20 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #622 from David Nind --- That's right - run the dbic command (if using koha-testing-docker). There were changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:27:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:27:23 +0000 Subject: [Koha-bugs] [Bug 26516] Importing records with unexpected format of copyrightdate fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26516 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:27:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:27:26 +0000 Subject: [Koha-bugs] [Bug 26516] Importing records with unexpected format of copyrightdate fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26516 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110605|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 112905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112905&action=edit Bug 26516: [alternate] Don't accept incorrect values for copyrightdate/publicationyear The previous patch rejects incorrect values when saving to the db specifically for copyrightdate An error is thrown for the int conversion when it fails Rather than catching things when saving we can fix the value when generated, simply returning null when parsing the record To test: 1 - Add a new record to Koha making sure data is valid except 260$c: 198- 2 - Save the record 3 - It fails 4 - Apply this patch 5 - Restart all the thigns 6 - Repeat 7 - Success! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:29:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:29:30 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:35:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:35:40 +0000 Subject: [Koha-bugs] [Bug 26516] Importing records with unexpected format of copyrightdate fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26516 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- (In reply to Lisette Scheer from comment #3) > Before applying the patch, when adding a record with 198- in the 260$c: > field, we got the following error on the sandbox: > > Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 > in Exception::Class::Base::throw at /usr/share/perl5/Exception/Class/Base.pm > line 88 I got this error as well locally using koha-testing-docker. For me the error mentioned in the description appeared in /var/log/koha/kohadev/plack-intranet-error.log (not sure whether this will be the same when using kohadevbox). I imported a record using Z39.50 from the Library of Congress (title = IBM Style Guide), and changed the 260$c to 198- After applying the patch I went flush_memcached and restart_all, redid the import and everything worked as per the test plan - successfully able to add a record with 198- for $260$c. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:35:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:35:52 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:35:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:35:56 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 --- Comment #10 from Joonas Kylmälä --- Created attachment 112906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112906&action=edit Bug 24567: (QA follow-up) Remove warning in regex Without this patch we get Use of uninitialized value $3 in concatenation (.) or string at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 943. This converts the | OR operator to two different regexes so that the capture group variables will be defined in every case. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:36:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:36:40 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 --- Comment #11 from Joonas Kylmälä --- Added follow-up to remove the warning. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:47:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:47:19 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #92 from paxed --- Just as an example, from one of our larger consortiums, the single biblio with the most components they have is 1000 - from "THE FOLKSONG FAKE BOOK : A COLLECTION OF OVER 1000 FOLKSONGS FROM AROUND THE WORLD" Average number of components is 18.5, and there are about 56000 component parts in total. If the max number of components is set to something like 300, it would cover more than 99% of the cases, which IMO would be good enough for now - this could be changed after the feature is in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:48:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:48:27 +0000 Subject: [Koha-bugs] [Bug 26172] Add a cashup summary view (with option to print) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #44 from Jonathan Druart --- Created attachment 112907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112907&action=edit Bug 26172: Replace calls to _result[set] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:48:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:48:51 +0000 Subject: [Koha-bugs] [Bug 26172] Add a cashup summary view (with option to print) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112907|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 112908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112908&action=edit Bug 26172: Replace _result[set] calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:50:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:50:07 +0000 Subject: [Koha-bugs] [Bug 26172] Add a cashup summary view (with option to print) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112908|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart --- Created attachment 112909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112909&action=edit Bug 26172: Replace _result[set] calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 11:50:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 10:50:21 +0000 Subject: [Koha-bugs] [Bug 26172] Add a cashup summary view (with option to print) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #47 from Jonathan Druart --- (In reply to Jonathan Druart from comment #46) > Created attachment 112909 [details] [review] > Bug 26172: Replace _result[set] calls Martin, do you agree with this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:03:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:03:09 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|critical |major --- Comment #7 from Jonathan Druart --- Lowering the severity, it's not in stable yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:28:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:28:56 +0000 Subject: [Koha-bugs] [Bug 26886] OPAC suggestions: possible duplicate message should stand out more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:28:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:28:59 +0000 Subject: [Koha-bugs] [Bug 26886] OPAC suggestions: possible duplicate message should stand out more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112835|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 112911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112911&action=edit Bug 26886: Correct style of alert-error class in the OPAC This patch makes a minor change to the OPAC SCSS so that instances of "alert-error" classes are styled the same as messages with the Bootstrap 4 "alert-warning" class. This change is simpler than making multiple changes to scripts and templates. To test, apply the patch and try to view a single news item in the OPAC which doesn't exist: /cgi-bin/koha/opac-main.pl?news_id=XXX - You should see a warning message with a pale yellow background, "This news item does not exist." - Submit a suggestion, and then submit another suggestion with the same title. - You should see a warning message, "The suggestion has not been added. A suggestion with this title already exists." Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:29:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:29:38 +0000 Subject: [Koha-bugs] [Bug 26886] OPAC suggestions: possible duplicate message should stand out more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing note: - Need to updated the OPAC CSS - see https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:29:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:29:46 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:33:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:33:45 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:33:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:33:48 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #21 from Nick Clemens --- Created attachment 112912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112912&action=edit Bug 7607: [Alternate] Remove empty inputs when submitting search form This patch surrounds the operator, index, and query fields on the advanced search page wtih a 'search_set' class. This allows us to process them as a group and confirm the query is populated before submitting the other parts to the form TO test: 1 - Go to advanced search 2 - Use search boxes to search like: Title: (leave blank) Author: clinton keyword: shuffle 3 - Perform search 4 - Note no results as you searched for title:clinton etc. 5 - apply patch 6 - refresh and repeat 7 - search is now correct 8 - Try vaeious searches with 'more options' and selecting different operators -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:35:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:35:42 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #22 from Nick Clemens --- hopefully helping and not muddying, adding an alternate patch to remove the whole search (index, query, operator) if there is no value provided -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:46:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:46:06 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:46:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:46:09 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112858|0 |1 is obsolete| | --- Comment #5 from Séverine Queune --- Created attachment 112913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112913&action=edit Bug 26860: facets.inc refactor availability facet To prepare new facet, this patch refactors the availability facet, without any change in restult. Appart from an id 'facet-availability', like other facets. Test plan: 1) Perform a search in staff interface 2) Check availability facet displays well 3) Click on it 4) Check availability facet displays well Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:46:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:46:12 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112859|0 |1 is obsolete| | --- Comment #6 from Séverine Queune --- Created attachment 112914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112914&action=edit Bug 26860: Add without items facet Many libraries ask for a way to search biblio records without items. In order to clean the catalogue or acquire items. I propose to add a search limit and facet. Only in staff interface for start. I choose to use homebranch index, should always be defined on items. Looks like itemnumber index can not be used because of its configuration in ccl.properties. Test plan : 1) Check with both Zebra and Elasticsearch 2) Perform a search on staff interface returning some records with and some without items 3) Click on 'Limit to records without items' 4) Check you see only records without items 5) Click on 'Show all records' 6) Check you see all records again Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 12:47:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 11:47:52 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #7 from Séverine Queune --- Can't test with Zebra, I only validate the very good behaviour with ES. Thanks Frido for this nice patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:06:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 12:06:29 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Katrin Fischer --- (In reply to Martin Renvoize from comment #3) > Comment on attachment 112761 [details] [review] > Bug 26727: Fix

appearing in the templates > > Review of attachment 112761 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt > @@ +90,4 @@ > > > >

> > Place article request from [% biblio.title | html %] for [% patron.firstname | html %] [% patron.surname | html %] ( [% patron.cardnumber | html %] ) > > +

We use HTML5 - we don't need closing

, see: https://www.w3.org/TR/2010/WD-html-markup-20100624/p.html A p element’s end tag may be omitted if the p element is immediately followed by an address, article, aside, blockquote, dir, div, dl, fieldset, footer, form, h1, h2, h3, h4, h5, h6, header, hr, menu, nav, ol, p, pre, section, table, or ul element, or if there is no more content in the parent element and the parent element is not an a element. In this case, the following tag is

    . > > Hmm, not sure about this one.. won't it result in an unmatched tag? (i.e. I > can't see a closing

    anywhere beneath this opening

    ) > > ::: > koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt > @@ +220,4 @@ > > > > > > > > +

    > > Why a double
    here compared to a single
    in > koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt ? I believe "looks". It was using a br br in another spot in the same file and I wanted to achieve the same 'distance'. It's not the cleanest way to do this, but I wanted to aim for making the HTML templates valid first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:12:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 12:12:58 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #93 from Katrin Fischer --- If the performance is ok, I would be happy with 100. Maybe we could add a note that it will show up to 100 if 100 results are returned or so? Just a hint that there might be more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:14:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 12:14:16 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #23 from Katrin Fischer --- (In reply to Nick Clemens from comment #22) > hopefully helping and not muddying, adding an alternate patch to remove the > whole search (index, query, operator) if there is no value provided Thx Nick, I was going to comment that we don't need to change the form itself! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:28:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 12:28:58 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #94 from Nick Clemens --- (In reply to Katrin Fischer from comment #93) > If the performance is ok, I would be happy with 100. Maybe we could add a > note that it will show up to 100 if 100 results are returned or so? Just a > hint that there might be more. As the page here uses a search to find these, why not just add a link to perform that search as a regular search and provide the results to the user? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:32:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 12:32:06 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #95 from Joonas Kylmälä --- (In reply to Nick Clemens from comment #94) > (In reply to Katrin Fischer from comment #93) > > If the performance is ok, I would be happy with 100. Maybe we could add a > > note that it will show up to 100 if 100 results are returned or so? Just a > > hint that there might be more. > > As the page here uses a search to find these, why not just add a link to > perform that search as a regular search and provide the results to the user? Great idea! I will start working on a follow-up. I will also fix the wording in the syspref page regarding ES not being supported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:35:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 12:35:33 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:46:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 12:46:38 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:51:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 12:51:28 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Tomás Cohen Arazi --- I don't manage to change the manager to another user than the current one. Followed Andrew's steps. Jonathan's are about changing the 'suggester' so I'm confused. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:57:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 12:57:03 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 13:59:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 12:59:02 +0000 Subject: [Koha-bugs] [Bug 25886] libmojolicious-plugin-openapi-perl and libnet-oauth2-authorizationserver-perl unable to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25886 José Anjos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joseanjos at gmail.com --- Comment #14 from José Anjos --- Similar situation: Description: Ubuntu 16.04.7 LTS Release: 16.04 Codename: xenial sudo apt list --upgradable Listing... Pronto koha-common/stable,stable 20.05.05-1 all [upgradable from: 19.05.03-1] libcryptx-perl/stable 0.068-1 amd64 [upgradable from: 0.059-1~koha2] libjson-validator-perl/stable,stable 3.25+dfsg-1+koha3 all [upgradable from: 0.97-1~kohadev1] libmojolicious-perl/stable,stable 8.12+dfsg-1.2~koha1 all [upgradable from: 7.21+dfsg-1~kohadev1] libmojolicious-plugin-openapi-perl/stable,stable 2.16-1+koha1 all [upgradable from: 1.15-1~kohadev1] sudo apt upgrade Serão mantidos em suas versões actuais os seguintes pacotes: libjson-validator-perl libmojolicious-perl libmojolicious-plugin-openapi-perl 0 pacotes actualizados, 0 pacotes novos instalados, 0 a remover e 3 não actualizados. sudo apt install koha-common Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies: koha-common : Depende: libplack-middleware-logwarn-perl mas não é instalável E: Unable to correct problems, you have held broken packages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:06:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:06:14 +0000 Subject: [Koha-bugs] [Bug 26907] New: Fix POD for C4::Auth::checkauth Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26907 Bug ID: 26907 Summary: Fix POD for C4::Auth::checkauth Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org Multiple problems here: - There are several "private" subroutines (starting with underscore) between the POD and the actual checkauth subroutine, so if you search for "sub checkauth" you might miss that the POD is actually there (I did). - The example of how to use the sub is: ($userid, $cookie, $sessionID) = &checkauth($query, $noauth, $flagsrequired, $type); but the sub is actually looking for more possible arguments: 793 my $authnotrequired = shift; 794 my $flagsrequired = shift; 795 my $type = shift; 796 my $emailaddress = shift; 797 my $template_name = shift; - The POD says "The login page is provided using a HTML::Template". As far as I know that would now be TT, HTML::Template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:12:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:12:47 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #10) > I don't manage to change the manager to another user than the current one. > Followed Andrew's steps. > > Jonathan's are about changing the 'suggester' so I'm confused. Code is affecting both, manager and suggester, so both searches must be tested. The manager search will only return patrons with suggestions_manage. "Only staff with superlibrarian or suggestions_manage permissions are returned in the search results" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:13:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:13:11 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #12 from Andrew Fuerste-Henry --- Just tested this again, successfully. Updated test plan: To test: 1- make sure you have at least 2 patrons with purchase suggestion permissions and email addresses 2- open a new or existing purchase suggestion 3- in the Suggestion Management section, click the Select Manager link 4- in the patron search popup, search for and select a staff member with suggestion permissions 5- on the suggestion, click the "Notifiy Manager" checkbox 6- save your suggestion 7- on suggestion.pl, confirm your suggestion shows your selected staff member for Managed By 8- confirm your staff member received a notice 9- on suggestion.pl, use the checkboxes to select your suggestion and any number of additional suggestions 10- click Select Manager in the Update Manger box underneath the suggestions table 11- again, use the patron search popup to pick someone 12- click Submit to make your change 13- confirm the suggestions table reflects your change (there is not yet a way to send a notice for batch changes) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:19:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:19:33 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #13 from Tomás Cohen Arazi --- Both search+choose work correctly. I just found saving didn't store the chosen manager. RETESTING. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:20:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:20:35 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8132 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 [Bug 8132] Batch delete tool deletes items with holds on them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:20:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:20:35 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 [Bug 25469] Typo: Item does not belongs to your library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:20:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:20:48 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:23:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:23:16 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112809|0 |1 is obsolete| | Attachment #112810|0 |1 is obsolete| | Attachment #112811|0 |1 is obsolete| | Attachment #112812|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 112915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112915&action=edit Bug 26032: Add unit test Run prove t/db_dependent/Items.t Signed-off-by: Emmi Takkinen Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:23:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:23:19 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #28 from Jonathan Druart --- Created attachment 112916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112916&action=edit Bug 26032: Add 'is new' filter in items search In items search, add a filter on value of items.new_status with a Ignore/Yes/No. Yes meaning != 0, No meaning = 0, with considering that NULL value is like 0. This patch adds 'isnull' option to filter, this may be reused on other fields. Test plan : 1) Define an item subfield on items.new_status with authorised values YES_NO (0 or 1) 2) Edit an item A to set new_status=1 3) Edit an item B to set new_status=0 4) Perform an item search with 'is new' = 'ignore' => you get all items 5) Perform an item search with 'is new' = 'yes' => you get item A 6) Perform an item search with 'is new' = 'no' => you get all items but A Signed-off-by: Emmi Takkinen Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:23:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:23:22 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #29 from Jonathan Druart --- Created attachment 112917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112917&action=edit Bug 26032: (follow-up) Replace IFNULL() mysqlism with COALESCE() Signed-off-by: Emmi Takkinen Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:23:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:23:25 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #30 from Jonathan Druart --- Created attachment 112918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112918&action=edit Bug 26032: (follow-up) show 'is new' filter only if items.new_status is used Also adds a class 'item-new-status' to this filter to be able to hidde even if items.new_status used. Addition to test plan: 1) Apply on a database without Koha to MARC mapping on items.new_status 2) Check you dont see the 'is new' filter in items search form 3) Apply on a database with Koha to MARC mapping on items.new_status 4) Check you see class 'form-field item-new-status' Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:23:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:23:42 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #31 from Jonathan Druart --- Added missing signed-off-by lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:31:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:31:23 +0000 Subject: [Koha-bugs] [Bug 26908] New: EDI vendor accounts edit no longer allows plugins to be selected for an account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Bug ID: 26908 Summary: EDI vendor accounts edit no longer allows plugins to be selected for an account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org I believe the removal of the syspref caused the plugins pulldown to no longer show on the edi vendor accounts editor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:31:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:31:34 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:33:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:33:46 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:33:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:33:49 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 --- Comment #1 from Kyle M Hall --- Created attachment 112919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112919&action=edit Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:34:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:34:10 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:37:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:37:23 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:38:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:38:28 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com --- Comment #17 from Jonathan Druart --- Tomas, can I get your stamp on this one please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:43:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:43:15 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:43:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:43:18 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112842|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:43:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:43:55 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 112920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112920&action=edit Bug 26738: (bug 24819 follow-up) Fix manager selection Bug 23590 added a new feature to select the manager of a suggestion. One month later bug 24819 added the ability to pick the suggester. This second patchset broke the manager selection. This patch simplifies the way the suggester is selected, using the generic way and mimicking what is done for the manager. Test plan: - create a new purchase suggestion from within acquisitions (suggestion.pl?op=add) - click "select manager," search for user, click Select - see that the user you just selected shows under "Created by," - see that "Managed by" still says "You" - modify the suggester - save your suggestion => Everything is saved correctly QA will test the permission alert: Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage" Edit the suggestion, select a manager, pick a patron in the list who does not have sufficient permissions, save => you get the alert Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:43:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:43:59 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 112921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112921&action=edit Bug 26738: (QA follow-up) Add missing filter Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:44:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:44:21 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:45:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:45:23 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #17) > Tomas, can I get your stamp on this one please? I've been tracking this dev closely with Kyle and he responded to my suggestions, on the API part of it. I will review it altogether now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:50:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:50:11 +0000 Subject: [Koha-bugs] [Bug 26687] Add a Font Awesome icon for superlibrarian patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords|Academy |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:50:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:50:38 +0000 Subject: [Koha-bugs] [Bug 26909] New: Add circulation_rules values to FAQ Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26909 Bug ID: 26909 Summary: Add circulation_rules values to FAQ Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The manual's FAQ includes a section that explains various coded values from the database: https://koha-community.org/manual/latest/en/html/faq.html#codes-stored-in-the-database We should add the numeric codes from circulation_rules to this section. For example, the holdallowed rule is stored with these codes: 0: no holds 1: home library 2: any library 3: hold group -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:55:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:55:22 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #37 from Kyle M Hall --- Created attachment 112922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112922&action=edit Bug 14708: (QA follow-up) Use try/catch blocks when calling delete() on a patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:55:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:55:39 +0000 Subject: [Koha-bugs] [Bug 26310] Allow setting trace_to parameter in Elasticsearch config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 14:56:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 13:56:13 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

    appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #5 from Joonas Kylmälä --- (In reply to Katrin Fischer from comment #4) > (In reply to Martin Renvoize from comment #3) > > Comment on attachment 112761 [details] [review] [review] > > Bug 26727: Fix

    appearing in the templates > > > > Review of attachment 112761 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt > > @@ +90,4 @@ > > > > > >

    > > > Place article request from [% biblio.title | html %] for [% patron.firstname | html %] [% patron.surname | html %] ( [% patron.cardnumber | html %] ) > > > +

    > > We use HTML5 - we don't need closing

    , see: > > https://www.w3.org/TR/2010/WD-html-markup-20100624/p.html > A p element’s end tag may be omitted if the p element is immediately > followed by an address, article, aside, blockquote, dir, div, dl, fieldset, > footer, form, h1, h2, h3, h4, h5, h6, header, hr, menu, nav, ol, p, pre, > section, table, or ul element, or if there is no more content in the parent > element and the parent element is not an a element. > > In this case, the following tag is

      . So then there is a paragraph with no content. That doesn't make any sense to me, in that case the paragraph tag should be just removed. If it is for styling reason it should be done in CSS instead of HTML. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:00:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:00:30 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 --- Comment #6 from Katrin Fischer --- I am out then, because I am not sure enough about best practices with the CSS. I think more developers are not as we will find a lot of
      and similar if we start looking closer :) Don't mistake me: I agree in general, but the goal here was just to fix the completely wrong tags. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:09:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:09:03 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Joonas Kylmälä --- (In reply to Katrin Fischer from comment #6) > I am out then, because I am not sure enough about best practices with the > CSS. I think more developers are not as we will find a lot of
      and > similar if we start looking closer :) > > Don't mistake me: I agree in general, but the goal here was just to fix the > completely wrong tags. Ok, I'm inclined to mark this as FQA until there is a patch that fixes this issue in such a way that it won't cause another (smaller) problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:14:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:14:50 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:14:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:14:53 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:14:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:14:56 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:14:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:14:59 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:15:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:15:02 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:15:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:15:04 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:15:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:15:26 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:15:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:15:42 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:16:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:16:05 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 112923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112923&action=edit Bug 26633: Add REST API for managing transfer limits Test Plan: 1) prove t/db_dependent/api/v1/transfer_limits.t Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:16:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:16:10 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 112924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112924&action=edit Bug 26633: Add advanced editor for transfer limits The current transfer limits editor works great for Koha instances with small numbers of branches. However, for consortiums with dozens or even hundreds of libraries, the editor does not work well or effectively. We should provide an "advanced" editor displays all to/from library combinations in a grid and allows them to be edited in a manner somewhat similar to the transport cost matrix editor. Test Plan: 1) Apply this patch 2) Browse to the transfer limits editor 3) Click the new "Switch to advanced editor" link 4) Select a collection code/item type to edit limits for 5) Test the "Check all" function 6) Test the "Uncheck all" function 7) Test the "Check" column function 8) Test the "Uncheck" column function 9) Test the "Check" row function 10) Test the "Uncheck" row function 11) Test individual checkboxes/table cells Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:16:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:16:15 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 112925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112925&action=edit Bug 26633: Fix indirect object notation Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:16:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:16:21 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 112926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112926&action=edit Bug 26633: (QA follow-up) Change label to "collection" as we display the description Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:16:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:16:26 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 112927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112927&action=edit Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the same action is used multiple times in a row Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:16:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:16:30 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 112928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112928&action=edit Bug 26633: (QA follow-up) Tests on error condition This patch highlights a problem with the try/catch conditions in the ad() controlled method. Tests are added, and the controller is fixed to reflect the right behaviour. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/transfer_limits.t => SUCCESS: Tests pass! 409 is returned as appropriate! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:16:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:16:35 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 112929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112929&action=edit Bug 26633: POD for the exceptions file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:18:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:18:30 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #26 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #17) > Tomas, can I get your stamp on this one please? Yes, we need them, Kyle? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:21:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:21:34 +0000 Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26803 Keywords|additional_work_needed | CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:21:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:21:34 +0000 Subject: [Koha-bugs] [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 [Bug 23237] Add support for [% INCLUDE %] in plugin templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:26:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:26:12 +0000 Subject: [Koha-bugs] [Bug 26172] Add a cashup summary view (with option to print) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #48 from Martin Renvoize --- Seems reasonable to me.. I'm going to run the test with dbic_trace enabled to double check the db calls we make.. it feels like we might have introduced a couple of extra one's this way. Having said that.. I'm not sure how a correlate subquery performs compared to a pair of independent queries anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:29:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:29:19 +0000 Subject: [Koha-bugs] [Bug 23979] "Account is locked" message should be displayed on all patron pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23979 --- Comment #7 from Jonathan Druart --- Created attachment 112930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112930&action=edit Bug 23979: Remove final dot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:33:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:33:09 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Can be hidden with CSS, release notes| |using the #withoutitems_id | |selector. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:34:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:34:24 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:34:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:34:27 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112913|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:34:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:34:30 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112914|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:38:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:38:14 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 112931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112931&action=edit Bug 26860: facets.inc refactor availability facet To prepare new facet, this patch refactors the availability facet, without any change in restult. Appart from an id 'facet-availability', like other facets. Test plan: 1) Perform a search in staff interface 2) Check availability facet displays well 3) Click on it 4) Check availability facet displays well Signed-off-by: Séverine QUEUNE Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:38:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:38:18 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 112932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112932&action=edit Bug 26860: Add without items facet Many libraries ask for a way to search biblio records without items. In order to clean the catalogue or acquire items. I propose to add a search limit and facet. Only in staff interface for start. I choose to use homebranch index, should always be defined on items. Looks like itemnumber index can not be used because of its configuration in ccl.properties. Test plan : 1) Check with both Zebra and Elasticsearch 2) Perform a search on staff interface returning some records with and some without items 3) Click on 'Limit to records without items' 4) Check you see only records without items 5) Click on 'Show all records' 6) Check you see all records again Signed-off-by: Séverine QUEUNE Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:42:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:42:03 +0000 Subject: [Koha-bugs] [Bug 26910] New: When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 Bug ID: 26910 Summary: When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: jonathan.druart at bugs.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, nick at bywatersolutions.com When calling allowed reserves - git effective rule, if this rule is undef, the default is now set to zero. Prior to the change made in 18936, the default was set to undef. It appears this change was made "Bug 18936: Fix some more tests (19.56 KB, patch)" during this stage in the bug. In conclusion, this is very critical, as libraries will come across the inability to allow holds if they have circulation rules effective by this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:42:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:42:03 +0000 Subject: [Koha-bugs] [Bug 18936] Move issuingrules into circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26910 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:43:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:43:20 +0000 Subject: [Koha-bugs] [Bug 26910] When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:53:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:53:55 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #110 from Séverine Queune --- Applying: Bug 14242: (follow-up) Move English strings out of JavaScript fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 14242: (follow-up) Move English strings out of JavaScript -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 15:55:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 14:55:19 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:03:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:03:01 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:06:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:06:01 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:09:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:09:58 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:09:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:09:58 +0000 Subject: [Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:13:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:13:24 +0000 Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:13:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:13:28 +0000 Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107415|0 |1 is obsolete| | --- Comment #12 from Séverine Queune --- Created attachment 112933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112933&action=edit Bug 24541: Purge old messages misc/cronjobs/cleanup_database.pl provides some database cleanup. This patch adds cleanup for messages table. Test plan : - Count messages : select count(*),date(message_date) from messages group by date(message_date); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --confirm --messages 365 - Recount messages Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:14:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:14:06 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #69 from Jonathan Druart --- I am a bit reluctant regarding the 'if ($@ || @messages)' test, some messages could have been pushed outside of the eval. But letting it as it for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:14:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:14:25 +0000 Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #13 from Séverine Queune --- Works fine and respects the use of 'confirm' flag. Nice one :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:14:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:14:45 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #70 from Jonathan Druart --- This is what I had in mind. @ admin/searchengine/elasticsearch/mappings.pl:119 @ if ( $op eq 'edit' ) { } elsif ($field_weight <= 0 || !looks_like_number($field_weight)) { push @messages, { type => 'error', code => 'invalid_field_weight', 'weight' => $field_weight }; + $errors++; } else { $search_field->weight($field_weight); @ admin/searchengine/elasticsearch/mappings.pl:165 @ if ( $op eq 'edit' ) { search => $mapping_search }); } - push @messages, { type => 'error', code => 'missing_mandatory_fields' } if $mandatory_after < $mandatory_before; + if ( $mandatory_after < $mandatory_before ) { + push @messages, { type => 'error', code => 'missing_mandatory_fields' }; + $error++; + } }; - if ($@ || @messages) { + if ($@ || $errors) { push @messages, { type => 'error', code => 'error_on_update', message => $@, }; $schema->storage->txn_rollback; } else { Will see later if we need it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:17:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:17:17 +0000 Subject: [Koha-bugs] [Bug 26783] Set OpacRenewalAllowed to "Allowed" for new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112356|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 112934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112934&action=edit Bug 26783: set OpacRenewalAllowed to "Allow" for new Koha installations test plan: 1.Drop and recreate database 2.Go through web installer 3.Observe that "OpacRenewalAllowed" is set to "Don't Allow" 4.Apply patch 5.Repeat steps 1 and 2 6.Observe that "OpacRenewalAllowed" is now set to "Allow" sponsored-by: Catalyst Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:17:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:17:36 +0000 Subject: [Koha-bugs] [Bug 26783] Set OpacRenewalAllowed to "Allowed" for new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Added missing signed-off-by line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:21:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:21:02 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:21:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:21:02 +0000 Subject: [Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason and store the reason when canceling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:25:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:25:26 +0000 Subject: [Koha-bugs] [Bug 26760] Redirect to paycollect.pl when clicking on "Save and pay" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- 1. Parameter needs to be URI escaped, at least the description 2. Why the sprintf? I am expecting the formatting to be template side? Failing QA for 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:28:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:28:59 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #23 from Tomás Cohen Arazi --- Things to fix: - New status: 'processing' (bug 12556) - New column: cancellation_reason (bug 25534) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:31:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:31:50 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22789 --- Comment #24 from Tomás Cohen Arazi --- New column: non_priority (bug 22789) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 [Bug 22789] Establish non-priority holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:31:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:31:50 +0000 Subject: [Koha-bugs] [Bug 22789] Establish non-priority holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:33:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:33:46 +0000 Subject: [Koha-bugs] [Bug 26911] New: Update for 18936 can cause data loss if constraints are violated Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Bug ID: 26911 Summary: Update for 18936 can cause data loss if constraints are violated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In 19.11 and before you can create circ rules for an itemtype, delete the itemtype, and the circ rule remains. This also applies to category codes and branches On upgrade from bug 18936 we insert from issuing into circulation rules, however, if rules exist that violate the new constraints on circulation_rules then the upgrade will fail and rules will not be inserted To test: 1 - Checkout 19.11.x 2 - Add a new itemtype 3 - Define some circ rules for that type and some others 4 - Delete that itemtype 5 - Checkout 20.05.x 6 - updatedatabase 7 - See errors: DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`circulation_rules`, CONSTRAINT `circ_rules_ibfk_3` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement " INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) SELECT IF(categorycode='*', NULL, categorycode), IF(branchcode='*', NULL, branchcode), IF(itemtype='*', NULL, itemtype), 'restrictedtype', COALESCE( restrictedtype, '' ) FROM issuingrules "] at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 20712. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:33:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:33:57 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Move issuingrules into circulation_rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:33:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:33:57 +0000 Subject: [Koha-bugs] [Bug 18936] Move issuingrules into circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 [Bug 26911] Update for 18936 can cause data loss if constraints are violated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:36:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:36:47 +0000 Subject: [Koha-bugs] [Bug 26910] When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 --- Comment #1 from Jonathan Druart --- Can you provide a step by step plan to recreate the issue please? I edited the main circulation rule, filled "Holds allowed (total)" with an empty string, saved => "" is set in DB and I am able to place hold on items. Do you mean you have NULL in DB? What is the return of > select rule_value from circulation_rules where rule_name="reservesallowed"; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:46:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:46:30 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 --- Comment #1 from Jonathan Druart --- Created attachment 112935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112935&action=edit Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:47:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:47:03 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- I did not test the patch but it should fix the issue you reported. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:47:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:47:30 +0000 Subject: [Koha-bugs] [Bug 26910] When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 --- Comment #2 from Nick Clemens --- Found from bug 26911 Set some other values for a rule in the circ matrix then DELETE FROM circulation_rules WHERE rule_name = 'reservesallowed'; The rules now appear as unlimited, but act as if 0 This line: 427 $allowedreserves = $rights->{reservesallowed} // $allowedreserves; Previously it did not assign to allowed reserves which is defaulted to 0 at the beginning of CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:47:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:47:45 +0000 Subject: [Koha-bugs] [Bug 26910] When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26911 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:47:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:47:45 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26910 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:48:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:48:01 +0000 Subject: [Koha-bugs] [Bug 26912] New: Expired staff accounts can still log in to Koha staff intranet Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 Bug ID: 26912 Summary: Expired staff accounts can still log in to Koha staff intranet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We just discovered that staff accounts can be used for staff logins, SIP, API, etc even if they are expired. The question we don't have an answer to is; should this be allowed? We could prevent staff logins for expired accounts, or perhaps add a new 'enabled' column to explicitly enable/disable accounts from logging in to Koha. Right now, the only way to disable an account without deleting it is to remove user permissions, which may be non trivial if the account has complicated permissions and may need to be 'restored' in the future. What do you all think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:48:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:48:27 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Expired staff accounts can |Expired staff accounts can |still log in to Koha staff |still log in to Koha staff |intranet |intranet, SIP, API, etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:49:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:49:47 +0000 Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #29 from Jonathan Druart --- Please don't forget to describe what the new enhancement is supposed to add when you write the commit message. The title and test plan are, most of the time, not enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:52:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:52:44 +0000 Subject: [Koha-bugs] [Bug 26913] New: More than one title element on homepage when news item is displayed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26913 Bug ID: 26913 Summary: More than one title element on homepage when news item is displayed Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: gormanp at parliament.uk QA Contact: testopia at bugs.koha-community.org When a news item is displayed on the OPAC homepage, there are two title elements on the page. This doesn't meet standards required by WCAG Technique H25 which states that a page should only have one title element. https://www.w3.org/TR/WCAG20-TECHS/H25.html Could the title element in the news item be a paragraph or a div instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:54:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:54:29 +0000 Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15523 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:54:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:54:29 +0000 Subject: [Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14866 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 [Bug 14866] Make high holds work with different item types and number of open days -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:58:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:58:32 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 16:59:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 15:59:54 +0000 Subject: [Koha-bugs] [Bug 26910] When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 --- Comment #3 from Jonathan Druart --- So it does not happen if the upgrade does not fail? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 17:03:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 16:03:43 +0000 Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 --- Comment #30 from Jonathan Druart --- Created attachment 112936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112936&action=edit Bug 14866: Trivial code simplification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:17:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:17:45 +0000 Subject: [Koha-bugs] [Bug 26172] Add a cashup summary view (with option to print) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #49 from Martin Renvoize --- So.. I've tested my hypothesis and your version does indeed result in 2 additional DB calls (the subselect being executed independently).. However, it does not change performance in any meaningful way (I benchamarked it).. So.. for consistency and to be more Koha::Object like, not having to reach inside dbic guts to much I would take your approach. Thanks for the followup :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:31:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:31:43 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:31:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:31:47 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112751|0 |1 is obsolete| | Attachment #112752|0 |1 is obsolete| | Attachment #112753|0 |1 is obsolete| | Attachment #112755|0 |1 is obsolete| | Attachment #112756|0 |1 is obsolete| | Attachment #112757|0 |1 is obsolete| | Attachment #112758|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 112937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112937&action=edit Bug 19133: Password recovery via REST API This patch adds password recovery functionality to REST API. POST /public/patrons/password/recovery Creates a new password recovery request. Takes a JSON body with "email" and one of "userid" or "cardnumber" as parameters. Sends patron PASSWORD_RESET email. POST /public/patrons/password/recovery/complete Completes pending password recovery. Takes a JSON body with "uuid", "new_password" and "confirm_new_password" as parameters. If passwords meet Koha's password requirements, changes patron's password to the requested new password. To test: 1. prove t/db_dependent/api/v1/patrons_password_recovery.t 2. Send POST requests to the endpoints listed above. See the description of endpoints above for required parameters. 3. Check message_queue (or your email if you actually send messages in the queue) to make sure your password recovery was enqueued 4. Observe your password has been changed once you completed the recovery process Sponsored-by: Koha-Suomi Oy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:31:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:31:59 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 --- Comment #20 from Kyle M Hall --- Created attachment 112938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112938&action=edit Bug 19133: Add an ability to link patron to third party service to reset their password Adds additional functionality to POST /public/patrons/password/recovery. Pass a new parameter "custom_link" to send patron a recovery email that contains this link instead of Koha OPAC's opac-password-recovery.pl page. This way third party services can link Koha patrons to their own service to have passwords recovered. By default, forbids all custom links. To enable specific services, use the new system preference OpacResetPasswordHostWhitelist. This preference contains a list of allowed host names to which it is allowed to link the patron in recovery email. Use case in steps (to understand the feature better): 1. Library uses a discovery software (e.g. VuFind, from now on VF) and has disabled Koha's OPAC 2. VF uses Koha REST API 3. Patrons can login to VF with their Koha userid and password 4. Patron goes to VF login screen, but has forgotten their password 5. Patron requests their password to be reset in VF 6. VF sends a POST request to /api/v1/patrons/password/recovery with patron's userid and email as parameters, as well as custom_link to a password reset page in VF 7. Koha sends patron an email containing a link to VF password reset page (instead of Koha OPAC's opac-password-recovery.pl) 8. Patron reads their email and resets password in VF To test: 1. Apply patch and run updatedatabase.pl 2. prove t/db_dependent/api/v1/patrons_password_recovery.t 3. Modify OpacResetPasswordHostWhitelist system preference. Add "anything" to its value. 4. Send a POST request to /api/v1/public/atrons/password/recovery with parameters "email", "userid" and "custom_link" (custom_link value e.g. "https://anything/reset-password.pl?token={uuid}") 5. You should get a HTTP 201 response 6. Check your message_queue. Your password recovery email should now contain the link you provided in step 4 7. Repeat step 4 but this time use something else as custom_link value 8. You should get a response that this host name is not accepted Sponsored-by: Koha-Suomi Oy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:32:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:32:03 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 --- Comment #21 from Kyle M Hall --- Created attachment 112939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112939&action=edit Bug 19133: Allow third party services to send password recovery emails instead of Koha Adds a new parameter "skip_mail" to POST /api/v1/public/patrons/password/recovery. This allows third party services to avoid Koha enqueueing recovery email to message queue. Instead, letter content and the link containing uuid is returned. Requires permission to do so. Adds a new permission borrowers.get_password_reset_uuid that allows the above. To test: 1. Apply patch and run updatedatabase.pl 2. prove t/db_dependent/api/v1/patrons_password_recovery.t 3. Add yourself borrowers.get_password_reset_uuid permission 4. Send POST request to /api/v1/public/patrons/password/recovery containing a JSON body { "email": "patrons at email.com", "userid": "patrons userid", "custom_link": "https://allowed/reset.pl?token={uuid}", "skip_mail": true } (Make sure custom link is allowed by the system preference introduced in previous patch) 5. Check that the message contents and other related data is returned 6. Check borrower_password_recovery table - there should be a new entry for you 7. Check message_queue table - this message should not be enqueued Sponsored-by: Koha-Suomi Oy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:32:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:32:06 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 --- Comment #22 from Kyle M Hall --- Created attachment 112940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112940&action=edit Bug 19133: (QA follow-up) Remove unrelated change Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:32:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:32:09 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 --- Comment #23 from Kyle M Hall --- Created attachment 112941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112941&action=edit Bug 19133: (QA follow-up) More contemporary language Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:32:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:32:12 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 --- Comment #24 from Kyle M Hall --- Created attachment 112942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112942&action=edit Bug 19133: (QA follow-up) Correct exception description Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:32:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:32:15 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 --- Comment #25 from Kyle M Hall --- Created attachment 112943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112943&action=edit Bug 19133: Fix tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:32:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:32:18 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 --- Comment #26 from Kyle M Hall --- Created attachment 112944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112944&action=edit Bug 19133: (QA follow-up) Fix QA script issues Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:33:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:33:15 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:34:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:34:10 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #36 from Séverine Queune --- This patch works fine ! But I won't sign it because of 2 points : - I can't test the sms part, I don't know how it works and how to use the feature - I've got a question about the content of the message : when there several holds, only the informations about the oldest reserve (for what I saw) are displayed. Fields coming from the items or biblio tables can't be used. I know it's happening for some other notices so don't Failed the patch because of this point, but I regret I couldn't use the <> or <> datas as it is recommended for some other notices, I think it could be useful for patron to have some details about the waiting holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 18:49:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 17:49:36 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #58 from Andrew Fuerste-Henry --- I applied your patches, updated the database, and restarted services. I then edited my All/All rule for all libraries and saved it as Has Priority. Then I copied my All/All rule for all libraries to one of my branches. After doing that, I am unable to save changes to any of my circ rules. I cannot save edits my branch rules or my all libraries rules. When I click Save, the values revert back to their original values and I get this error in the plack log: [2020/11/03 17:19:17] [WARN] DBD::mysql::st execute failed: Unknown column 'me.has_priority' in 'field list' [for Statement "SELECT `me`.`id`, `me`.`branchcode`, `me`.`categorycode`, `me`.`itemtype`, `me`.`has_priority`, `me`.`rule_name`, `me`.`rule_value` FROM `circulation_rules` `me` WHERE ( ( `me`.`branchcode` IS NULL AND `me`.`rule_name` = ? ) )" with ParamValues: 0='refund'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:15:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 18:15:42 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:15:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 18:15:45 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 --- Comment #8 from Owen Leonard --- Created attachment 112945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112945&action=edit Bug 26727: (follow-up) More markup corrections This patch makes more markup changes to the templates previously modified in order to try to arrive at some agreeable solutions. - In the value_builder EXAMPLE template, the

      is unnecessary and is removed. Also removed is the script "type" attribute and obsolete CDATA markers. - In the article request template an unnecessary

      is removed. - In the merge patrons template the submit button is now in a

      as is consistent with other forms. - In the MARC modifications template I've added
      s around each "line" in the form to add the line break, along with some CSS to add margins. - The submit button is now inside a
      and the "Cancel" link now has the "cancel" class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:21:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 18:21:58 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:22:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 18:22:01 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112119|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 112946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112946&action=edit Bug 25334: Add generic 'phone' message transport type As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. Test Plan; 1) Apply this patch 2) Run updatedatabase 3) Restart all the things! 4) Disable TalkingTechItivaPhoneNotificationi if enabled 5) Enable new PhoneNotification system preference 6) Go to a patron's messaging preferences, not you can select the 'phone' option for all the same notices as the 'email' option 7) Enable the phone option for all the message types 8) Browser to the Notices and slips editor 9) Add a phone notice version for each notice you wish to test 10) Test some notices ( CHECKIN, CHECKOUT, etc ) 11) Notices should show in the patron's messages as 'phone' notices Signed-off-by: Christopher Zorn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:22:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 18:22:11 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #12 from Kyle M Hall --- Created attachment 112947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112947&action=edit Bug 25334: (QA follow-up) Update opac messaging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:22:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 18:22:14 +0000 Subject: [Koha-bugs] [Bug 26910] When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Severity|major |normal --- Comment #4 from Nick Clemens --- To recreate: 1 - Remove any All/All rules from circulation rules 2 - Set a circ rule for a specific itemtype with Holds allowed (total) set to 5 3 - Attempt to place a hold on an itemtype without the rules 4 - Too many holds: Edna Acosta can only place a maximum of 0 total holds. Turns out, this behaviour is consistent in my testing, so the problem was the upgrade only There is a question whether no rules set should allow unlimited holds, or 0 holds but that's not necessarily a bug. Currently we set "" for unlimited, and the rule not existing means that holds are not allowed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:22:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 18:22:14 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #13 from Kyle M Hall --- Created attachment 112948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112948&action=edit Bug 25334: (QA follow-up) Update overduerules.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:39:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 18:39:08 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:39:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 18:39:28 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:39:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 18:39:31 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112935|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 112949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112949&action=edit Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ rules To test: 1 - Checkout 19.11.x and reset_all 2 - Add a new patron category, itemtype, and branch to your system 3 - Create issuing rules using thise 3 values, and others 4 - Delete the new category, itemtype and branch 5 - Checkout master 6 - Restart_all 7 - updatedatabase 8 - you get errors 9 - repeat 1-4 10 - apply patch 11 - restart_all 12 - updatedatabase 13 - no errors! Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 19:54:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 18:54:00 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 --- Comment #9 from Katrin Fischer --- Thanks a lot, Owen! Wouldn't mind if you want my patch out for simplicity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 20:01:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 19:01:31 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 --- Comment #10 from Katrin Fischer --- (In reply to Katrin Fischer from comment #9) > Thanks a lot, Owen! Wouldn't mind if you want to throw my patch out for simplicity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 20:07:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 19:07:42 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 didier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron at biblibre.c | |om --- Comment #1 from didier --- Hi, Isn't changing password good enough? Doing it the Unix way , with an invalid password should be better though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 20:26:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 19:26:59 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |andrew at bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry --- These delete statements would also delete rules where the value is *. That'd be bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 20:49:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 19:49:06 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 --- Comment #27 from Lari Taskula --- (In reply to Tomás Cohen Arazi from comment #18) > This is also missing some tests for the Recovery.pm changes (url param). Hi Tomas, and Kyle, nice to see you testing and QA'ing this. I can confirm the missing tests - Recovery.pm::SendPasswordRecoveryEmail() is missing tests for the changes introduced in the second and third patch (url and skip_mail parameters). The main functionality is tested in the REST tests but of course we should still add unit tests to SendPasswordRecoveryEmail itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 20:51:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 19:51:04 +0000 Subject: [Koha-bugs] [Bug 19133] Password recovery routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133 --- Comment #28 from Tomás Cohen Arazi --- (In reply to Lari Taskula from comment #27) > (In reply to Tomás Cohen Arazi from comment #18) > > This is also missing some tests for the Recovery.pm changes (url param). > > Hi Tomas, and Kyle, nice to see you testing and QA'ing this. I can confirm > the missing tests - Recovery.pm::SendPasswordRecoveryEmail() is missing > tests for the changes introduced in the second and third patch (url and > skip_mail parameters). The main functionality is tested in the REST tests > but of course we should still add unit tests to SendPasswordRecoveryEmail > itself. We are almost on feature freeze. If the RM would consider this for inclusion (I would include it, as it is not going to break any existing feature) I can help with the missing tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 21:13:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 20:13:25 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 21:13:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 20:13:28 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112949|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 112950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112950&action=edit Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ rules UPDATE: changed queries to not touch * values To test: 1 - Checkout 19.11.x and reset_all 2 - Add a new patron category, itemtype, and branch to your system 3 - Create issuing rules using thise 3 values, and others 4 - Delete the new category, itemtype and branch 5 - Checkout master 6 - Restart_all 7 - updatedatabase 8 - you get errors 9 - repeat 1-4 10 - apply patch 11 - restart_all 12 - updatedatabase 13 - no errors! Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 21:55:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 20:55:06 +0000 Subject: [Koha-bugs] [Bug 26914] New: Advanced search "fewer options" hides boolean operator dropdowns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26914 Bug ID: 26914 Summary: Advanced search "fewer options" hides boolean operator dropdowns Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org In advanced search in both OPAC and staff client, choosing "fewer options" removes the and/or/not dropdown choices. Libraries would like to have the minimized look of the "fewer options" search but need the boolean operator choices to show. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:04:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:04:20 +0000 Subject: [Koha-bugs] [Bug 26915] New: Koha explodes when writing off a fee with FinePaymentAutoPopup Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 Bug ID: 26915 Summary: Koha explodes when writing off a fee with FinePaymentAutoPopup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org - To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) - Experience error on saving the writeoff http://localhost:8081/cgi-bin/koha/members/printfeercpt.pl?action=print&accountlines_id=HASH(0x558152468290)&borrowernumber=51 Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 This problem was first found in 20.05.03 so affects stable releases as well! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:05:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:05:19 +0000 Subject: [Koha-bugs] [Bug 23507] Add ability to show and print change given on fee receipt from FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:05:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:05:19 +0000 Subject: [Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23507 [Bug 23507] Add ability to show and print change given on fee receipt from FinePaymentAutoPopup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:07:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:07:17 +0000 Subject: [Koha-bugs] [Bug 26914] Advanced search "fewer options" hides boolean operator dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26914 --- Comment #1 from Katrin Fischer --- Maybe the booleans could be added to the AdvancedSearchTypes system preference options? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:11:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:11:28 +0000 Subject: [Koha-bugs] [Bug 25886] libmojolicious-plugin-openapi-perl and libnet-oauth2-authorizationserver-perl unable to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25886 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #15 from Mason James --- (In reply to José Anjos from comment #14) > Similar situation: > > Description: Ubuntu 16.04.7 LTS > Release: 16.04 > Codename: xenial > please follow the official community instructions at... https://wiki.koha-community.org/wiki/Koha_on_Debian 1.1.2.3 Support for Koha on older versions of Debian/Ubuntu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:14:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:14:42 +0000 Subject: [Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:14:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:14:44 +0000 Subject: [Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 112951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112951&action=edit Bug 24863: QueryFuzzy syspref says it requires Zebra but ElasticSearch has some support. This patch updates the description of the QueryFuzzy system preference to make it more clear how it works with Zebra and how Elasticsearch has some amount of fuzzy available for searches. To test: 1. Go to administration 2. Search for QueryFuzzy 3. Observe the current description, which only includes Zebra. 4. Apply patch 5. Repeat steps 1-2 6. Observe the updated description. 7. Sign off Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:15:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:15:08 +0000 Subject: [Koha-bugs] [Bug 26815] QueryFuzzy should also fuzzy Elasticsearch searches when set to "try" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26815 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:25:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:25:06 +0000 Subject: [Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:25:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:25:09 +0000 Subject: [Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112869|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 112952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112952&action=edit Bug 26148: OpenLibrary "Preview" link target is unclear to patrons This patch makes changes to the display of the Open Library "read" links in the OPAC search results and detail page. The link is now grouped with other details about the record ("Publisher," "Location(s)," etc. On the detail page, the "Preview" link will no longer appear under the cover image. The label is changed to "Found in Open Library," and the link now opens the Open Library reader in a new window. The patch also changes the Open Library button image links so that they use https and makes it so that the "Found in Open Library" information is hidden until the availability information has loaded. To test, apply the patch and enable the OpenLibrarySearch system preference. - Perform a search in the OPAC which will return results found in Open Library, e.g. "poetry" in the sample data. - Confirm that the "Read now" images from Open Library appear on some search results. - View the detail page for one of these titles. - Confirm that the "Read now" button appears in the same format on the detail page. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:31:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:31:10 +0000 Subject: [Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:31:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:31:13 +0000 Subject: [Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112683|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 112953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112953&action=edit Bug 26804: Add modal content preview This patch turns the 'News' column into a preview button. That preview button displays a modal with content of that rows news item. To test: 1. Apply patch 2. Add some HTML to a News Item. I am using a bunch of lorem ipsum HTML and this image set to 1000px. ''. 3. Make sure and have some content with a lot of width and some content with a lot of height. 4. Test the Preview content button 5. Make sure you can scroll through long modals and across modals that are wide 6. Try at different screen sizes and with different combonations of News items Signed-off-by: Kelly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:31:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:31:17 +0000 Subject: [Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112883|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 112954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112954&action=edit Bug 26804: (QA follow-up) add modal-lg class and intent markup correctly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:31:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:31:37 +0000 Subject: [Koha-bugs] [Bug 26804] News: Limit the size of the news content column in newst table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit the size of the news |News: Limit the size of the |content column in newst |news content column in |table (News tool) |newst table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:32:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:32:55 +0000 Subject: [Koha-bugs] [Bug 26914] Advanced search "fewer options" hides boolean operator dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26914 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- +1 to adding those to sysprefs. Katrin, did you mean OpacAdvSearchOptions and OpacAdvSearchMoreOptions? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:36:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:36:22 +0000 Subject: [Koha-bugs] [Bug 26914] Advanced search "fewer options" hides boolean operator dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26914 --- Comment #3 from Katrin Fischer --- (In reply to Andrew Fuerste-Henry from comment #2) > +1 to adding those to sysprefs. Katrin, did you mean OpacAdvSearchOptions > and OpacAdvSearchMoreOptions? Definitely - thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:38:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:38:29 +0000 Subject: [Koha-bugs] [Bug 26916] New: Allow patron attributes in DefaultPatronSearchFields syspref and patron search dropdown Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 Bug ID: 26916 Summary: Allow patron attributes in DefaultPatronSearchFields syspref and patron search dropdown Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 17374 following bug 17374, fields listed in DefaultPatronSearchFields also appear in the patron search fields dropdown. It would be great to be able to get patron attributes to show in that dropdown, too. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:38:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:38:29 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 [Bug 26916] Allow patron attributes in DefaultPatronSearchFields syspref and patron search dropdown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:39:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:39:21 +0000 Subject: [Koha-bugs] [Bug 26886] OPAC suggestions: possible duplicate message should stand out more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:39:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:39:25 +0000 Subject: [Koha-bugs] [Bug 26886] OPAC suggestions: possible duplicate message should stand out more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112911|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 112955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112955&action=edit Bug 26886: Correct style of alert-error class in the OPAC This patch makes a minor change to the OPAC SCSS so that instances of "alert-error" classes are styled the same as messages with the Bootstrap 4 "alert-warning" class. This change is simpler than making multiple changes to scripts and templates. To test, apply the patch and try to view a single news item in the OPAC which doesn't exist: /cgi-bin/koha/opac-main.pl?news_id=XXX - You should see a warning message with a pale yellow background, "This news item does not exist." - Submit a suggestion, and then submit another suggestion with the same title. - You should see a warning message, "The suggestion has not been added. A suggestion with this title already exists." Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:44:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:44:30 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 --- Comment #2 from Katrin Fischer --- A changed password can't be queried, I like the idea of an enable/disable functionality for the permissions. You would still want to allow OPAC logins, but block staff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:56:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:56:47 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112671|0 |1 is obsolete| | --- Comment #81 from Alexis Ripetti --- Created attachment 112956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112956&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:57:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:57:31 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112678|0 |1 is obsolete| | --- Comment #82 from Alexis Ripetti --- Created attachment 112957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112957&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:57:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:57:46 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112679|0 |1 is obsolete| | --- Comment #83 from Alexis Ripetti --- Created attachment 112958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112958&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 22:58:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 21:58:29 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112677|0 |1 is obsolete| | Attachment #112680|0 |1 is obsolete| | Attachment #112681|0 |1 is obsolete| | Attachment #112682|0 |1 is obsolete| | --- Comment #84 from Alexis Ripetti --- Created attachment 112959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112959&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : 

      $ prove -l t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. 1/3
    #   Failed test 'This list comes from the cache and that is fine'
    #   at t/db_dependent/XSLT.t line 122.
    #          got: '1'
    #     expected: '2'
    # Looks like you failed 1 test of 1.

 #   Failed test 'CustomXSLTExportList: Caching'
 #   at t/db_dependent/XSLT.t line 124.
 # Looks like you failed 1 test of 3.
t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
-------------------
t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
csys =  1.91 CPU)
Result: FAIL
      This one works fine : 
      $ prove -l t/XSLT.t
t/XSLT.t .. ok
All tests successful.
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
csys =  2.74 CPU)
Result: PASS
      -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:06:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:06:04 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_26895=5D_Template_process_failed=3A?= =?utf-8?q?_file_error_-_parse_error_-_patron-title=2Einc_line_37=3A_unexp?= =?utf-8?b?ZWN0ZWQgdG9rZW4gKCc8c3BhbikgICBbJSBzcGFuX3N0YXJ0ID0gJzxzcGFu?= =?utf-8?b?IGNsYXNzPSJwYXRyb24tdGl0bGUiPsOi4oKsy5wgJV0gYXQgL3Vzci9zaGFy?= =?utf-8?q?e/koha/lib/C4/Templates=2Epm_line_122=2E?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26895 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #3 from Katrin Fischer --- The mistake was in the translation files, I fixed them. It was: ‘ %%] [%%- span_end = ‘ https://translate.koha-community.org/ca/translate/#search=span&sfields=source,target,locations&soptions=exact,case&unit=6524062&offset=10 You can either fix the file mentioned by Owen in comment#1 manually or wait for the next bug fix release when this will be fixed by an update to the translation files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:23:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:23:33 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #94 from Katrin Fischer --- There still appears to be some regression :( - The filters on the datatable are no longer kept - and the column filters have vanished altogether -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:23:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:23:42 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:31:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:31:29 +0000 Subject: [Koha-bugs] [Bug 24665] Add ability to run cash register report with new cash register feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:31:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:31:32 +0000 Subject: [Koha-bugs] [Bug 24665] Add ability to run cash register report with new cash register feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112901|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 112960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112960&action=edit Bug 24665: Add support for filtering by cash register This patch makes it possible to filter on cash register on the cash register statistics page. To test: - Activate UseCashRegisters - Create a cash register or more to use - Create some manual fees and fines - Pay some of them off - Go to Tools > Cash register statistics - Test if the new filter for cash registers works as it should Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:32:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:32:15 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:33:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:33:54 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #95 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #94) > There still appears to be some regression :( > > - The filters on the datatable are no longer kept Is that a thing in master?? I don't recall seeing code related to that. > - and the column filters have vanished altogether Do we miss them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:35:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:35:27 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:35:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:35:31 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112761|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 112961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112961&action=edit Bug 26727: Fix

      appearing in the templates The self-closing p is not valid in HTML5: Error: Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag. To test: 1) - Activate Article requests - Search for a record to place an article request on in staff - Look up the patron - Verify the article request form looks ok 2) - Search for a list of patrons - Check 2 patrons and merge them using the button above the list - Verify the distance between the button and the table looks ok 3) - Create a new MARC modification template - Create a new action - Verify the distances between the first and second line of form elements looks ok 4) - Place a hold in staff - Click on the Suspend link in the holds table (not below) - Verify the modal looks ok Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:35:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:35:34 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112945|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 112962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112962&action=edit Bug 26727: (follow-up) More markup corrections This patch makes more markup changes to the templates previously modified in order to try to arrive at some agreeable solutions. - In the value_builder EXAMPLE template, the

      is unnecessary and is removed. Also removed is the script "type" attribute and obsolete CDATA markers. - In the article request template an unnecessary

      is removed. - In the merge patrons template the submit button is now in a

      as is consistent with other forms. - In the MARC modifications template I've added
      s around each "line" in the form to add the line break, along with some CSS to add margins. - The submit button is now inside a
      and the "Cancel" link now has the "cancel" class. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:40:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:40:14 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #96 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #95) > (In reply to Katrin Fischer from comment #94) > > There still appears to be some regression :( > > > > - The filters on the datatable are no longer kept > > Is that a thing in master?? I don't recall seeing code related to that. I tested and yes, it worked in my tests. I had also noted it in comment#89 "or the table search". > > > - and the column filters have vanished altogether > > Do we miss them? They allow filtering on aspects that cannot be searched otherwise - I believe they would be missed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:42:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:42:14 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #13 from David Nind --- The updated forms and pages as per the test plan look okay to me - I checked using Firefox Developer Edition on Ubuntu 18.04. I didn't do any HTML validation, but I think these two tools will be useful for future UI/accessibility work to help pick up and fix errors: - WAVE Toolbar (for both Firefox and Google Chrome): https://wave.webaim.org/extension/ - HTML Validator (for Firefox): https://addons.mozilla.org/en-US/firefox/addon/html-validator/: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 3 23:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 22:58:49 +0000 Subject: [Koha-bugs] [Bug 26917] New: Searching for patrons: member.pl vs circulation.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26917 Bug ID: 26917 Summary: Searching for patrons: member.pl vs circulation.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When searching for a partial name, you get a list of results. Depending on whether you start your search in check out or patron search, the results differ. The records are the same, but the layout and information shown is different. This is confusing to staff, as they don't remember which place to search for the information they want to search through. I would suggest that we standardize the results so they are consistent. On top of that, I would like to see the ability to pick what information is included the table of results. There are fields we don't need to see, and there are fields we would like to see, in order to determine which patron is the right one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:03:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 23:03:58 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #24 from David Cook --- Comment on attachment 112912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112912 Bug 7607: [Alternate] Remove empty inputs when submitting search form Review of attachment 112912: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7607&attachment=112912) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ +140,5 @@ > + if( $(this).find('input[name="q"]').val() == "" ){ > + $(this).remove(); > + removedPrior = true; > + } > + }); I haven't tested the code but what about the idx? Wouldn't this code exacerbate the problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:04:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 23:04:34 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:04:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 23:04:38 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112912|0 |1 is obsolete| | --- Comment #25 from David Nind --- Created attachment 112963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112963&action=edit Bug 7607: [Alternate] Remove empty inputs when submitting search form This patch surrounds the operator, index, and query fields on the advanced search page wtih a 'search_set' class. This allows us to process them as a group and confirm the query is populated before submitting the other parts to the form TO test: 1 - Go to advanced search 2 - Use search boxes to search like: Title: (leave blank) Author: clinton keyword: shuffle 3 - Perform search 4 - Note no results as you searched for title:clinton etc. 5 - apply patch 6 - refresh and repeat 7 - search is now correct 8 - Try vaeious searches with 'more options' and selecting different operators Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:09:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 23:09:56 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #28 from David Cook --- (In reply to Jonathan Druart from comment #27) > (In reply to David Cook from comment #24) > > (In reply to Nick Clemens from comment #20) > > > Would it be reasonable to clear empty inputs with javascript before the > > > submission? > > > > On reflection, that won't work the way you think it would work. It would > > create the problems described in Bug 7607. > > It won't if you remove the related idx. > What I meant was that if you set the idx value to '' (ie if you "clear empty inputs"), it will actually create an inconsistency in the form submission where the idx param is *not* sent in the form submission but the q param *is* sent. That is, unless you include an option in the select list for the idx that has a value of ''. It seems like glitchy/unexpected browser behaviour (at least in Chrome). But, as you say, removing the elements from the HTML form all together would work. > I don't think we should push this patch without having both sides happy. Sounds all right to me. I already applied these patches locally about 6 months ago, so I don't mind too much. Happy to help with Bug 7607 and then we can push this one once that's sorted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:27:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 23:27:56 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #26 from David Cook --- Ok this issue is really annoying me, so let's get it sorted... Test plan: 0. No patch 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?expanded_options=1 2. Change 2nd "Keyword" and 3rd "Keyword" to "Author" 3. Change 2nd search box to "Martin" and 3rd search box to "Humble" 4. Change 2nd op box (between Martin and Humble) to "or" 5. Click "Search" 6. Note the following URL: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=kw&op=and&idx=au&q=Martin&op=or&idx=au&q=Humble&sort_by=relevance 7. Note the HTML response: No results match your search for 'kw,wrdl: Martin and au,wrdl: Humble'. Test plan: 0. Apply Nick's patch and "koha-plack --restart kohadev" 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?expanded_options=1 2. Change 2nd "Keyword" and 3rd "Keyword" to "Author" 3. Change 2nd search box to "Martin" and 3rd search box to "Humble" 4. Change 2nd op box (between Martin and Humble) to "or" 5. Click "Search" 5b. If you have a quick eye, you'll see the empty search box was removed by Javascript. Yay! 6. Note the following URL: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=au&q=Martin&op=or&idx=au&q=Humble&sort_by=relevance 7. Note the HTML response: 12 result(s) found for 'au,wrdl: Martin or au,wrdl: Humble'. Great patch, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:30:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 23:30:33 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111064|0 |1 is obsolete| | Attachment #111065|0 |1 is obsolete| | Attachment #112963|0 |1 is obsolete| | --- Comment #27 from David Cook --- Created attachment 112964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112964&action=edit Bug 7607: [Alternate] Remove empty inputs when submitting search form This patch surrounds the operator, index, and query fields on the advanced search page wtih a 'search_set' class. This allows us to process them as a group and confirm the query is populated before submitting the other parts to the form TO test: 1 - Go to advanced search 2 - Use search boxes to search like: Title: (leave blank) Author: clinton keyword: shuffle 3 - Perform search 4 - Note no results as you searched for title:clinton etc. 5 - apply patch 6 - refresh and repeat 7 - search is now correct 8 - Try vaeious searches with 'more options' and selecting different operators Signed-off-by: David Nind Signed-off-by: David Cook https://bugs.koha-community.org/show_bug.cgi?id=7606 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:31:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 23:31:43 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #29 from David Cook --- (In reply to Jonathan Druart from comment #27) > > I don't think we should push this patch without having both sides happy. David Nind and I have signed off on Nick's patch on Bug 7607. Once QA pass it, then we should all be happy ^_^. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:32:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 23:32:49 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7607 Status|In Discussion |Passed QA --- Comment #30 from David Cook --- Moving back to Passed QA and adding a dependency on Bug 7607. Just so that it doesn't get lost. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:32:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 23:32:49 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 [Bug 25548] Package install Apache performs unnecessary redirects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:58:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 23:58:21 +0000 Subject: [Koha-bugs] [Bug 26918] New: anjg Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26918 Bug ID: 26918 Summary: anjg Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: alvianyulianto63 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 112965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112965&action=edit hai jambu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 00:58:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Nov 2020 23:58:55 +0000 Subject: [Koha-bugs] [Bug 26918] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26918 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|anjg |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:03:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:03:52 +0000 Subject: [Koha-bugs] [Bug 26919] New: aenjeaye Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26919 Bug ID: 26919 Summary: aenjeaye Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: alvianyulianto63 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 112966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112966&action=edit aenjeaye -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:04:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:04:26 +0000 Subject: [Koha-bugs] [Bug 26919] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|aenjeaye |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:05:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:05:31 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Locally, I think that we block all expired users from logging in. We do already have the "debarred" column. We use that for some local customizations too where we want to block people from logging in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:06:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:06:04 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 --- Comment #4 from David Cook --- (In reply to David Cook from comment #3) > Locally, I think that we block all expired users from logging in. > > We do already have the "debarred" column. We use that for some local > customizations too where we want to block people from logging in. Although I suppose being debarred until 9999-12-31 isn't exactly the same as "disabled" heh. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:08:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:08:27 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #2) > A changed password can't be queried, I like the idea of an enable/disable > functionality for the permissions. You would still want to allow OPAC > logins, but block staff. We could query it if we changed the password field to "!". I feel that's something that Koha sometimes does? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:09:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:09:42 +0000 Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:10:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:10:34 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:13:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:13:37 +0000 Subject: [Koha-bugs] [Bug 26920] New: aenjeayeh Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26920 Bug ID: 26920 Summary: aenjeayeh Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: contribs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: alvianyulianto63 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 112967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112967&action=edit :v1 jembot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:14:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:14:40 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #38 from David Cook --- I like the idea that the Anonymous Patron cannot be deleted, but I think that this implementation is too narrowly cast. I think that we should consider doing Bug 26170 (Create "system" patrons that cannot be (easily) deleted via the web UI) instead of this one, since there are many scenarios where we don't want to be able to delete patron accounts that are important (e.g. SIP patron, REST API patron, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:16:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:16:13 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #39 from David Cook --- (In reply to David Cook from comment #38) > I like the idea that the Anonymous Patron cannot be deleted, but I think > that this implementation is too narrowly cast. > > I think that we should consider doing Bug 26170 (Create "system" patrons > that cannot be (easily) deleted via the web UI) instead of this one, since > there are many scenarios where we don't want to be able to delete patron > accounts that are important (e.g. SIP patron, REST API patron, etc.) Admittedly, I don't have any patches on Bug 26170, and it's not high on my priority list at the moment, so I don't see myself working on it any time soon. Kyle has done all this great work, and really if it could be adapted to be more generalizable for all kinds of "system" patrons, that would be amazing. It would be a very useful development. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:25:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:25:34 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:25:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:25:38 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112950|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 112968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112968&action=edit Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ rules UPDATE: changed queries to not touch * values To test: 1 - Checkout 19.11.x and reset_all 2 - Add a new patron category, itemtype, and branch to your system 3 - Create issuing rules using thise 3 values, and others 4 - Delete the new category, itemtype and branch 5 - Checkout master 6 - Restart_all 7 - updatedatabase 8 - you get errors 9 - repeat 1-5 10 - apply patch 11 - restart_all 12 - updatedatabase 13 - no errors! Signed-off-by: Nick Clemens Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:37:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:37:30 +0000 Subject: [Koha-bugs] [Bug 26920] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|aenjeayeh |SPAM Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:43:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:43:45 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #345 from David Cook --- (In reply to David Cook from comment #344) > I'm going to be testing out this version of RabbitMQ over the next few weeks > on a few different servers. > > Note that I have no issues running an older version of RabbitMQ on openSUSE > Leap 15.1. No issues running this on a backup server. Just started running the latest RabbitMQ on a prod Ubuntu 18.04 as per the aforementioned installation steps. I am using "+sbwt none" and very little CPU usage. I could add those other anti-busy wait arguments, but I'm not too concerned at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:54:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:54:50 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 01:54:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 00:54:53 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112919|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 112969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112969&action=edit Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 02:04:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 01:04:47 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes - step 1: 1. Download one of the EDI plugins from https://github.com/bywatersolutions/koha-plugin-edifact-enhanced/releases (it doesn't matter which one). 2. Install the plugin (Koha administration > Plugins > Manage plugins > Upload plugin > browse for the plugin you downloaded in step 1 > click upload - the plugin will then show in the list of plugins). Note: Plugins need to be enabled for your development environment - make sure your plugin directory is set (KTD = /var/lib/koha/kohadev/plugins) and it is enabled (1) in the koha-conf.xml file for your instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:00:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 02:00:29 +0000 Subject: [Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112951|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 112970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112970&action=edit Bug 24863: QueryFuzzy syspref says it requires Zebra but ElasticSearch has some support. This patch updates the description of the QueryFuzzy system preference to make it more clear how it works with Zebra and how Elasticsearch has some amount of fuzzy available for searches. To test: 1. Go to administration 2. Search for QueryFuzzy 3. Observe the current description, which only includes Zebra. 4. Apply patch 5. Repeat steps 1-2 6. Observe the updated description. 7. Sign off Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:07:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 02:07:02 +0000 Subject: [Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:07:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 02:07:05 +0000 Subject: [Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112714|0 |1 is obsolete| | --- Comment #26 from David Nind --- Created attachment 112971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112971&action=edit Bug 23475: Use localStorage to preserve simple search values To test: 1 - Enable IntranetCatalogSearchPulldown 2 - Perform a search that brings you to a single title 3 - Note the search is not displayed on the details page 4 - Apply patch 5 - Repeat 6 - Note the search is retained on details page 7 - Try with different dropdown values and search terms 8 - Test search terms including accented characters etc Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:31:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 02:31:50 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112012|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:32:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 02:32:18 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:33:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 02:33:22 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112091|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:34:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 02:34:13 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make rabbitmq-server a |Make rabbitmq-server |'recommended' package |suggested rather than | |required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:36:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 02:36:25 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112012|0 |1 is obsolete| | --- Comment #9 from Mason James --- Created attachment 112972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112972&action=edit Bug 26741: Remove rabbitmq-server requirements (replace with suggestions) Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:38:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 02:38:34 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #10 from Mason James --- (In reply to David Cook from comment #8) > Note that there are a lot of recommended packages that aren't installed when > using "--no-install-recommends": > > I think the original idea of using Suggests rather than Recommends might be > the safest. i'm happy with this idea, so i sign-off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 03:41:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 02:41:50 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #11 from David Cook --- (In reply to Mason James from comment #10) > > i'm happy with this idea, so i sign-off :) Great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 05:38:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 04:38:44 +0000 Subject: [Koha-bugs] [Bug 26875] Allow printing of just one barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26875 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 05:38:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 04:38:48 +0000 Subject: [Koha-bugs] [Bug 26875] Allow printing of just one barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26875 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112726|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 112973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112973&action=edit Bug 26875: Allow printing of just one barcode in batch To test: 1- go to the Print Barcode Range page 2- enter From=1 and To=1 3- confirm error "Must be greater than from value." 4- apply patch, restart, reload page 5- enter From=1, To=1 6- confirm no error 7- change From to 2, error reappears Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 07:24:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 06:24:17 +0000 Subject: [Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |koha-bugs at lists.koha-commun |.com |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:02:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:02:31 +0000 Subject: [Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23051 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED --- Comment #1 from Jonathan Druart --- Caused by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test Which modified the return value of Koha::Account->pay Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 [Bug 23051] Add ability to optionally renew fine accruing items when all fines on item are paid off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:02:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:02:31 +0000 Subject: [Koha-bugs] [Bug 23051] Add ability to optionally renew fine accruing items when all fines on item are paid off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:04:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:04:38 +0000 Subject: [Koha-bugs] [Bug 26921] New: Create cover image even when there is no record identificator Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Bug ID: 26921 Summary: Create cover image even when there is no record identificator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl We have identified an issue with bug 22445, when we define the url we add the value to identify the id and create the link The link is created even there is no identification Example: https://xxxxx.xxxx.cat/cobertes.php?isbn={isbn}&institucio=xxxx If the record has not isbn, the patch create the thumnail with empty value, the patch should avoid create the thumbnail if the {}values are empty be aware that we could have more than one identifier {isbn}{issn}, it should check both values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:04:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:04:38 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26921 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:06:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:06:36 +0000 Subject: [Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:06:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:06:38 +0000 Subject: [Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 --- Comment #2 from Jonathan Druart --- Created attachment 112974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112974&action=edit Bug 26915: Fix FinePaymentAutoPopup behaviour The behaviour of the syspref FinePaymentAutoPopup is broken, the popup explodes with Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 It has been broken by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test which modified the return value of Koha::Account->pay (from $payment_id to a hashref) Test plan: - To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) => Without the patch you get the error => With the patch applied the popup is correctly displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:13:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:13:18 +0000 Subject: [Koha-bugs] [Bug 26639] Turn auto_savepoint ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26639 --- Comment #11 from Jonathan Druart --- Good news, I compared the different job execution times on Jenkins (before and after this patch) and I have not noticed any significant changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:13:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:13:41 +0000 Subject: [Koha-bugs] [Bug 26639] Turn auto_savepoint ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26639 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:13:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:13:44 +0000 Subject: [Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:13:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:13:47 +0000 Subject: [Koha-bugs] [Bug 24972] Remove de-DE installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24972 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:13:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:13:48 +0000 Subject: [Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:15:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:15:48 +0000 Subject: [Koha-bugs] [Bug 26347] Wrong publication pattern locale on months In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26347 --- Comment #2 from Hugo Agud --- Let me give you an example: When we create a pattern using months, the user expect just months names: january, february, march...etc, when using locate = ca-ES, we are not getting months, we are getting: de gener (of january) it should be just 'gener' (january) de febrer (of february) it should be just 'february' (february) de març (of march) it should be just 'march' (march) Example: Wrong: New england journal of medicine vol:23 issue:333 of january 2020 Right: Wrong: New england journal of medicine vol:23 issue:333 january 2020 This is happeing at least locat ca-ES -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:16:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:16:17 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22445 --- Comment #1 from Katrin Fischer --- Please use the depends on field in such cases to link the bugs together, thishelps to identify which versions we have to fix and to alert anyone involved in hte previous bug. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 [Bug 22445] Ability to define a URL for custom cover images -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:16:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:16:17 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 [Bug 26921] Create cover image even when there is no record identificator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:22:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:22:24 +0000 Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 --- Comment #31 from Jonathan Druart --- As we are inserting the value into the default circulation rule, why do we keep the syspref? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:24:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:24:13 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 --- Comment #1 from Matthias Meusburger --- Created attachment 112975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112975&action=edit Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:25:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:25:22 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:25:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:25:31 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:28:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:28:32 +0000 Subject: [Koha-bugs] [Bug 26347] Wrong publication pattern locale on months In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26347 --- Comment #3 from Katrin Fischer --- The translations don't appear to be in translate.koha-community.org - I believe we are using a Perl library to generate these. It might be wrong there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:28:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:28:37 +0000 Subject: [Koha-bugs] [Bug 26347] Wrong publication pattern locale on months In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26347 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:30:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:30:40 +0000 Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 --- Comment #32 from Katrin Fischer --- It's a fallback when no other value is set in the circulation conditions: + if ( defined($rule) && $rule->rule_value ne '' ){ + # overrides decreaseLoanHighHoldsDuration syspref ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:31:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:31:24 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |In Discussion --- Comment #5 from Jonathan Druart --- I have the feeling that the path you chose is way too complicated for what you tried to implement. The "PrefillGuaranteeField" notion should not appear in the DT patron search module (C4:Utils::DataTables::Members). A more elegant implementation would be to retrieve the patron's data using the REST API route and keep the logic of "prefilling" JS-side. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:47:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:47:59 +0000 Subject: [Koha-bugs] [Bug 26745] Notice titles/subjects should support Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Please add a test for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:52:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:52:37 +0000 Subject: [Koha-bugs] [Bug 26180] Elasticsearch - Add option to index records in descending order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:53:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:53:39 +0000 Subject: [Koha-bugs] [Bug 26180] Elasticsearch - Add option to index records in descending order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112159|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 112976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112976&action=edit Bug 26180: Add descending option to rebuild_elasticsearch.pl While the ES index is incremental and provides results as it commits, we currently index from the oldest records to the newest. This patch provides the option to go the other direction To test: 1 - Have ES setup and running for Koha 2 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -b 3 - Note the biblios index from number 1 the end 4 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -a 5 - Notice the same 6 - Apply patch 7 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -b 8 - Still in ascending order 9 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -b --desc 10 - Now records index in descending order 11 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -a 12 - Still ascending 13 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v -a --desc 14 - Now descending Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize JD amended patch: fix typo "inde" vs "index" and add commit body -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 09:57:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 08:57:55 +0000 Subject: [Koha-bugs] [Bug 20125] Add a cron script to claim late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 --- Comment #15 from Alex Arnaud --- Created attachment 112977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112977&action=edit Bug 20125: Take into account new table aqorders_claims -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:04:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:04:44 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- 1. I think you should call Koha::Patron->relationships_debt to get the guarantees' fines 2. Why did you put the new tab between "checkouts" and "holds"? I don't think it's the more appropriate. Maybe just before "Restrictions"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:09:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:09:39 +0000 Subject: [Koha-bugs] [Bug 26630] Allow custom text for each library on Purchase Suggestion Page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:10:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:10:32 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:10:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:10:38 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:11:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:11:26 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:22:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:22:31 +0000 Subject: [Koha-bugs] [Bug 26190] Cannot close baskets when all lines have been cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Parenthesis would have helped the readability, but it works as it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:28:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:28:01 +0000 Subject: [Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:28:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:28:06 +0000 Subject: [Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112974|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 112978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112978&action=edit Bug 26915: Fix FinePaymentAutoPopup behaviour The behaviour of the syspref FinePaymentAutoPopup is broken, the popup explodes with Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 It has been broken by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test which modified the return value of Koha::Account->pay (from $payment_id to a hashref) Test plan: - To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) => Without the patch you get the error => With the patch applied the popup is correctly displayed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:29:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:29:37 +0000 Subject: [Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:41:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:41:19 +0000 Subject: [Koha-bugs] [Bug 26922] New: SendAlerts does not correctly handle error on sending emails Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26922 Bug ID: 26922 Summary: SendAlerts does not correctly handle error on sending emails Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: System Administration Assignee: tomascohen at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 22343 When an email is sent from C4::Letters::SendAlerts (for instance emailing a acquisition basket), the UI displays a "all good" message even if the email has not been sent properly. To recreate: 1. Set KohaAdminEmailAddress to admin at example.org 2. Edit a vendor, set a valid email address 3. Create a new basket, a new order. Send the basket As you did not configure a valid SMTP server, the email is not sent and logs displayed "unable to establish SMTP connection to (localhost) port 25", with the stracktrace. The problem is coming from the return inside the catch (which returns from the catch, not the subroutine as expected). There are 2 problematic occurrences in SendAlerts: 360 try { 361 $mail->send_or_die({ transport => $library->smtp_server->transport }); 362 } 363 catch { 364 carp "$_"; 365 return { error => "$_" }; 366 }; 512 try { 513 $mail->send_or_die({ transport => $library->smtp_server->transport }); 514 } 515 catch { 516 carp "$_"; 517 return { error => "$_" }; 518 }; => SendAlerts will return 1 (from l.577) anyway. And 1 occurrence in _send_message_by_email that should be corrected to avoid confusion. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 [Bug 22343] Add configuration options for SMTP servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:41:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:41:19 +0000 Subject: [Koha-bugs] [Bug 22343] Add configuration options for SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26922 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26922 [Bug 26922] SendAlerts does not correctly handle error on sending emails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:41:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:41:28 +0000 Subject: [Koha-bugs] [Bug 26922] SendAlerts does not correctly handle error on sending emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:48:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:48:09 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 --- Comment #1 from Mark Hofstetter --- see https://github.com/HKS3/koha-plugin-subordinate-items for a prove of concept implementation/why this makes sense for us -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:51:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:51:51 +0000 Subject: [Koha-bugs] [Bug 21898] Allow use of placeholders in ACQORDER email subject In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 --- Comment #8 from Jonathan Druart --- Created attachment 112979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112979&action=edit Bug 21898: Add aqbasket to available tables for ACQORDER This patch should allow <> replacements to work in both email subject and email content fields for notices. Test plan 1/ Add <> into the ACQORDER notice (In the subject line and content box) 2/ Trigger said notice to send (before applying the patch) 3/ Note that the replacements have not taken place.. <> is present as is. 4/ Apply patch 5/ Trigger the notice again 6/ Note that the replacements are now made. 7/ Signoff Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer JD amended patch: fix alignment in hashref, edit commit message to fix letter code "AQORDER" vs "ACQORDER" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:52:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:52:05 +0000 Subject: [Koha-bugs] [Bug 21898] Allow use of placeholders in ACQORDER email subject In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #112039|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:57:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:57:18 +0000 Subject: [Koha-bugs] [Bug 21898] Add basket info available for ACQORDER In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow use of placeholders |Add basket info available |in ACQORDER email subject |for ACQORDER Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 10:58:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 09:58:45 +0000 Subject: [Koha-bugs] [Bug 21898] Add basket info available for ACQORDER In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 --- Comment #9 from Jonathan Druart --- Created attachment 112980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112980&action=edit Bug 21898: Add basket for TT syntax Without this patch the basket's info won't be available for the TT syntax. With this patch you can now use [% basket.basketname %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:03:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 10:03:51 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |nick at bywatersolutions.com --- Comment #18 from Jonathan Druart --- I am not sure about the term "owning", we usually use "homebranch". Maybe we should stick with this terminology as it is widely used in Koha. Katrin, Nick, what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:11:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 10:11:53 +0000 Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 --- Comment #33 from Jonathan Druart --- Yes, but we insert the rule during the update process. If we create the rule with the value in the syspref I think we could remove the it. Is it worth it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:21:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 10:21:04 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #19 from Martin Renvoize --- Good question.. WE could use --use-homebranch as the current implementation is a boolean.. the '-use-' would make that a little clearer.. OR Perhaps we should change it to something more descriptive entirely.. '--branchfilter=issuebranch|homebranch' to make it clear that we're applying a filter on the lookup and it can take either 'issuebranch' or 'homebranch'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:22:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 10:22:18 +0000 Subject: [Koha-bugs] [Bug 26641] link_bibs_to_authorities.pl: Add the ability to specify the MARC field to operate on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26641 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart --- why "g"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:30:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 10:30:32 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #20 from Martin Renvoize --- (In reply to Martin Renvoize from comment #19) > Good question.. > > WE could use --use-homebranch as the current implementation is a boolean.. > the '-use-' would make that a little clearer.. > > OR > > Perhaps we should change it to something more descriptive entirely.. > '--branchfilter=issuebranch|homebranch' to make it clear that we're applying > a filter on the lookup and it can take either 'issuebranch' or 'homebranch'. That final one should more likely be `--frombranch=issuebranch|homebranch` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:34:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 10:34:56 +0000 Subject: [Koha-bugs] [Bug 20125] Add a cron script to claim late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 --- Comment #16 from Alex Arnaud --- Created attachment 112981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112981&action=edit Bug 20125: Make Koha::Acquisition::Orders->filter_by_lates usable in command line scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:43:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 10:43:16 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #21 from Katrin Fischer --- I just wanted to say that I think filter is wrong here. I think replacing owning is a good point. But I'd suggest different parameter names if we want to stick with terminology: - checkout_library - item_home_library homebranch is a bit misleading as it could be the patron's or the item's. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:55:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 10:55:32 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #142 from Jonathan Druart --- 1. I don't manage to have something else than "branch default" on the login page 2. Do we really want the register list to be public? 3. Why "branch default"? branch vs library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 11:58:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 10:58:59 +0000 Subject: [Koha-bugs] [Bug 21111] Add --exclude-indexes option to koha-run-backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111746|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 112982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112982&action=edit Bug 21111: Add --exclude-indexes to koha-run-backups This patch adds a trivial switch so koha-run-backups can pass the --exclude-indexes option switch to koha-dump. This way if the sysadmin doesn't want to backup the Zebra indexes, it can be controlled by tweaking the cron definition. To test: 1. Apply this patch 2. Run: $ debian/scripts/koha-run-backups --days 2 --output /var/spool/koha 3. Notice the size of the backups: $ ls -lh /var/spool/koha/kohadev 4. Try the new option switch: $ debian/scripts/koha-run-backups \ --exclude-indexes \ --days 2 --output /var/spool/koha 5. Repeat 3 => SUCCESS: Backups are smaller! 6. Sign off :-D Signed-off-by: David Nind Signed-off-by: Nick Clemens JD amended patch: fix --exclude_indexes vs --exclude-indexes in koha-run-backups.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:09:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 11:09:58 +0000 Subject: [Koha-bugs] [Bug 26745] Notice titles/subjects should support Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 --- Comment #6 from Martin Renvoize --- Created attachment 112983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112983&action=edit Bug 26745: (QA follow-up) Add Unit Tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:10:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 11:10:10 +0000 Subject: [Koha-bugs] [Bug 26745] Notice titles/subjects should support Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:12:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 11:12:39 +0000 Subject: [Koha-bugs] [Bug 26572] Add autocomplete to librarian field in log viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111736|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 112984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112984&action=edit Bug 26572: (QA follow-up) Escape strings in autocomplete This patch updates the construction of the autocomplete dropdown so that values are escaped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:14:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 11:14:05 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:16:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 11:16:24 +0000 Subject: [Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:22:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 11:22:58 +0000 Subject: [Koha-bugs] [Bug 16440] Update report parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:28:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 11:28:01 +0000 Subject: [Koha-bugs] [Bug 26923] New: Batch modification for Reports Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26923 Bug ID: 26923 Summary: Batch modification for Reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org It would be useful to update some datas for several reports at a time when selecting them. For more security, only the following fields could be updatde : - group - sub-group - public - Cache expiry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:28:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 11:28:08 +0000 Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 --- Comment #34 from Katrin Fischer --- (In reply to Jonathan Druart from comment #33) > Yes, but we insert the rule during the update process. > > If we create the rule with the value in the syspref I think we could remove > the it. Is it worth it? Hm ist could work, but I haven't fully worked out the structure yet, but I think there is a functional difference with your suggestion and the current implementation: The * * * rule shoudl only be applied if there is no rule that is more specific. So, when you have: itemtype a - patroncategory b ... high holds value left empty. Current suggestion: - the pref value will be used as a fallback. Your suggestion: - I am not sure. I believe that it won't fall back but use the "empty" and that it will need to have some meaning, like "0" or "inactive"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:31:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 11:31:39 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 --- Comment #143 from Katrin Fischer --- (In reply to Jonathan Druart from comment #142) > 1. I don't manage to have something else than "branch default" on the login > page > 2. Do we really want the register list to be public? I don't see this as a high risk thing. We have the list of libraries public... I don't see it as a blocker. Otherwise we'd need a pop-up or similar after login which could add lots of extra clicks. > 3. Why "branch default"? branch vs library I think library default woudl be better, I missed that, but easy fix in a follow-up. Did you add multiple cash registers for your homebranch/login branch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:35:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 11:35:55 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 --- Comment #144 from Martin Renvoize --- Sorry.. the 'library' vs 'branch' thing gets me every time :(. I still think of 'library' being the whole organisation and 'branch' being the individual buildings that make up the organisation. Happy to do a followup for that string fix here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 12:54:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 11:54:59 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 --- Comment #145 from Martin Renvoize --- Created attachment 112985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112985&action=edit Bug 24786: (QA follow-up) String fix This patch updates 'Branch default' to 'Library default' on the login page to match the coding terminology guidelines. We also update the table heading on the cash registers management page to match the terminology above for clarity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:01:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:01:59 +0000 Subject: [Koha-bugs] [Bug 11460] Correction to default itemcallnumber system preference in UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11460 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:01 +0000 Subject: [Koha-bugs] [Bug 11460] Correction to default itemcallnumber system preference in UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11460 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:03 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:05 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 --- Comment #15 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:08 +0000 Subject: [Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:11 +0000 Subject: [Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 --- Comment #19 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:13 +0000 Subject: [Koha-bugs] [Bug 15141] Add MARC21 770/772 to OPAC and staff detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15141 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:15 +0000 Subject: [Koha-bugs] [Bug 15141] Add MARC21 770/772 to OPAC and staff detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15141 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:17 +0000 Subject: [Koha-bugs] [Bug 15329] Show budget in addition to fund for late orders in acquisition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:19 +0000 Subject: [Koha-bugs] [Bug 15329] Show budget in addition to fund for late orders in acquisition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:21 +0000 Subject: [Koha-bugs] [Bug 15780] Include inventory number in patron account summary print In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15780 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:22 +0000 Subject: [Koha-bugs] [Bug 15780] Include inventory number in patron account summary print In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15780 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:24 +0000 Subject: [Koha-bugs] [Bug 16696] Rename "Publisher" on detail and result lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16696 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:27 +0000 Subject: [Koha-bugs] [Bug 16696] Rename "Publisher" on detail and result lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16696 --- Comment #12 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:29 +0000 Subject: [Koha-bugs] [Bug 19351] Add copynumber in the checkouts table in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19351 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:30 +0000 Subject: [Koha-bugs] [Bug 19351] Add copynumber in the checkouts table in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19351 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:32 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:34 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #71 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:37 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:39 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #38 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:41 +0000 Subject: [Koha-bugs] [Bug 21111] Add --exclude-indexes option to koha-run-backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:42 +0000 Subject: [Koha-bugs] [Bug 21111] Add --exclude-indexes option to koha-run-backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21111 --- Comment #11 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:44 +0000 Subject: [Koha-bugs] [Bug 21882] Add price column to acquisition details tab in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:46 +0000 Subject: [Koha-bugs] [Bug 21882] Add price column to acquisition details tab in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21882 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:48 +0000 Subject: [Koha-bugs] [Bug 21898] Add basket info available for ACQORDER In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:50 +0000 Subject: [Koha-bugs] [Bug 21898] Add basket info available for ACQORDER In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:51 +0000 Subject: [Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:53 +0000 Subject: [Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:55 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:02:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:02:57 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #21 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:00 +0000 Subject: [Koha-bugs] [Bug 23979] "Account is locked" message should be displayed on all patron pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:02 +0000 Subject: [Koha-bugs] [Bug 23979] "Account is locked" message should be displayed on all patron pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23979 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:04 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:06 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 --- Comment #21 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:08 +0000 Subject: [Koha-bugs] [Bug 24834] Display report number after running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24834 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:10 +0000 Subject: [Koha-bugs] [Bug 24834] Display report number after running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24834 --- Comment #33 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:12 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:14 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 --- Comment #19 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:15 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:17 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:19 +0000 Subject: [Koha-bugs] [Bug 25834] Relabel "Search to add" to "Search for guarantor" or "Add guarantor" on patron form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:21 +0000 Subject: [Koha-bugs] [Bug 25834] Relabel "Search to add" to "Search for guarantor" or "Add guarantor" on patron form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25834 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:22 +0000 Subject: [Koha-bugs] [Bug 25897] Inventory table call number sort should use cn_sort value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:24 +0000 Subject: [Koha-bugs] [Bug 25897] Inventory table call number sort should use cn_sort value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:26 +0000 Subject: [Koha-bugs] [Bug 25941] Reindent Upload local cover image page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:28 +0000 Subject: [Koha-bugs] [Bug 25941] Reindent Upload local cover image page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 --- Comment #14 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:30 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:32 +0000 Subject: [Koha-bugs] [Bug 26032] Add 'is new' filter in items search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032 --- Comment #32 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:33 +0000 Subject: [Koha-bugs] [Bug 26180] Elasticsearch - Add option to index records in descending order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:35 +0000 Subject: [Koha-bugs] [Bug 26180] Elasticsearch - Add option to index records in descending order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26180 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:37 +0000 Subject: [Koha-bugs] [Bug 26190] Cannot close baskets when all lines have been cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:38 +0000 Subject: [Koha-bugs] [Bug 26190] Cannot close baskets when all lines have been cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26190 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:40 +0000 Subject: [Koha-bugs] [Bug 26310] Allow setting trace_to parameter in Elasticsearch config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:42 +0000 Subject: [Koha-bugs] [Bug 26310] Allow setting trace_to parameter in Elasticsearch config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26310 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:44 +0000 Subject: [Koha-bugs] [Bug 26439] Move cart-related strings out of js_includes.inc and into basket.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26439 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:46 +0000 Subject: [Koha-bugs] [Bug 26439] Move cart-related strings out of js_includes.inc and into basket.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26439 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:47 +0000 Subject: [Koha-bugs] [Bug 26572] Add autocomplete to librarian field in log viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:49 +0000 Subject: [Koha-bugs] [Bug 26572] Add autocomplete to librarian field in log viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26572 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:51 +0000 Subject: [Koha-bugs] [Bug 26638] System preference ArticleRequestsMandatoryFieldsItemsOnly is unused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:52 +0000 Subject: [Koha-bugs] [Bug 26638] System preference ArticleRequestsMandatoryFieldsItemsOnly is unused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26638 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:54 +0000 Subject: [Koha-bugs] [Bug 26641] link_bibs_to_authorities.pl: Add the ability to specify the MARC field to operate on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26641 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:56 +0000 Subject: [Koha-bugs] [Bug 26641] link_bibs_to_authorities.pl: Add the ability to specify the MARC field to operate on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26641 --- Comment #16 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:03:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:03:58 +0000 Subject: [Koha-bugs] [Bug 26664] Inventory: Sorting column 'Last seen' goes wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:00 +0000 Subject: [Koha-bugs] [Bug 26664] Inventory: Sorting column 'Last seen' goes wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:02 +0000 Subject: [Koha-bugs] [Bug 26680] Update (rcvd) to (received) with its own class in basket view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:03 +0000 Subject: [Koha-bugs] [Bug 26680] Update (rcvd) to (received) with its own class in basket view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680 --- Comment #12 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:05 +0000 Subject: [Koha-bugs] [Bug 26687] Add a Font Awesome icon for superlibrarian patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:07 +0000 Subject: [Koha-bugs] [Bug 26687] Add a Font Awesome icon for superlibrarian patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 --- Comment #23 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:09 +0000 Subject: [Koha-bugs] [Bug 26718] Change 'Your reading history" to "Your checkout history" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:11 +0000 Subject: [Koha-bugs] [Bug 26718] Change 'Your reading history" to "Your checkout history" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26718 --- Comment #11 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:13 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:14 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #16 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:16 +0000 Subject: [Koha-bugs] [Bug 26763] Use standard information style for multi-hold message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:18 +0000 Subject: [Koha-bugs] [Bug 26763] Use standard information style for multi-hold message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26763 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:21 +0000 Subject: [Koha-bugs] [Bug 26783] Set OpacRenewalAllowed to "Allowed" for new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:22 +0000 Subject: [Koha-bugs] [Bug 26783] Set OpacRenewalAllowed to "Allowed" for new installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26783 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:24 +0000 Subject: [Koha-bugs] [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:26 +0000 Subject: [Koha-bugs] [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:28 +0000 Subject: [Koha-bugs] [Bug 26817] "Total" line in checkouts table is too short when ExportCircHistory is activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:30 +0000 Subject: [Koha-bugs] [Bug 26817] "Total" line in checkouts table is too short when ExportCircHistory is activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:32 +0000 Subject: [Koha-bugs] [Bug 26825] Add span for publication date in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:33 +0000 Subject: [Koha-bugs] [Bug 26825] Add span for publication date in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26825 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:35 +0000 Subject: [Koha-bugs] [Bug 26832] Elasticsearch mappings export should use UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:37 +0000 Subject: [Koha-bugs] [Bug 26832] Elasticsearch mappings export should use UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26832 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:39 +0000 Subject: [Koha-bugs] [Bug 26844] Log viewer does not indicate which logs are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:41 +0000 Subject: [Koha-bugs] [Bug 26844] Log viewer does not indicate which logs are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26844 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:43 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:04:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:04:45 +0000 Subject: [Koha-bugs] [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:06:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:06:39 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:06:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:06:42 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112975|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 112986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112986&action=edit Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:11:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:11:27 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 --- Comment #3 from Jonathan Druart --- Matthias, please provide a complete test plan. Prove is not enough here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:12:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:12:23 +0000 Subject: [Koha-bugs] [Bug 26639] Turn auto_savepoint ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26639 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #11) > Good news, I compared the different job execution times on Jenkins (before > and after this patch) and I have not noticed any significant changes. That's great, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:12:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:12:35 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 --- Comment #6 from Kyle M Hall --- (In reply to David Cook from comment #5) > (In reply to Katrin Fischer from comment #2) > > A changed password can't be queried, I like the idea of an enable/disable > > functionality for the permissions. You would still want to allow OPAC > > logins, but block staff. > > We could query it if we changed the password field to "!". I feel that's > something that Koha sometimes does? I'm not seeing the in the code with some basic grepping. The problem I see with that is, again, that it changes data about the user. The user's password is then lost, and without additional data ( public note, private note ), the reason for the password being changed would be unknown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:20:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:20:17 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #27 from Jonathan Druart --- Please rebase error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:24:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:24:29 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #97 from Jonathan Druart --- Applying: Bug 23916: Record and display item issuer CONFLICT (content): Merge conflict in C4/Circulation.pm Recorded preimage for 'C4/Circulation.pm' Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:25:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:25:15 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #146 from Jonathan Druart --- Applying: Bug 23091: Move _Restore to Koha::Item store trigger error: sha1 information is lacking or useless (C4/Circulation.pm). Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:25:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:25:44 +0000 Subject: [Koha-bugs] [Bug 26923] Batch modification for Reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26923 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- +1, good idea! At first I thought you meant, like, some sort of regex-based edit of the reports themselves, which sounds real messy. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:25:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:25:47 +0000 Subject: [Koha-bugs] [Bug 23258] Batch holding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Failed QA --- Comment #22 from Séverine Queune --- Sorry Matthias, I fail this patch for it doesn't respect the availability of the item (tested with notforloan !=0, itype without holds allowed). I also agree with Kelly about the table displayed after the cancellation : biblio datas are missing, it could be useful to display them so it becomes possible to place an individual hold after cancelling (patrons can sometimes be hesitant...). Presence of the link "Show holds" makes me think it was the original purpose of this table, am I right ? Some things I wonder about : - when cancelling holds, don't know if a warning for an item with no hold for this patron could be useful or not - when cancelling the action on 'Confirm selection' page, maybe we could return to 'Batch holding' page instead of 'Circulation home' Several good points though ! : - warning on unknown barcode - warning when patron already has a hold on the item- good recalculation of priority if cancelled hold was not the last one - respect of the hold limitation set in circulation rules (tested total, daily and per record) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:33:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:33:28 +0000 Subject: [Koha-bugs] [Bug 26923] Batch modification for Reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26923 --- Comment #2 from Séverine Queune --- > At first I thought you meant, like, some sort of regex-based edit of the > reports themselves, which sounds real messy. Oh no ! That would be to scary ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:34:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:34:02 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #97 from Tomás Cohen Arazi --- Created attachment 112987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112987&action=edit Bug 20212: (QA follow-up) Restore table filter sticky Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:38:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:38:30 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 --- Comment #146 from Katrin Fischer --- (In reply to Martin Renvoize from comment #144) > Sorry.. the 'library' vs 'branch' thing gets me every time :(. > > I still think of 'library' being the whole organisation and 'branch' being > the individual buildings that make up the organisation. > > Happy to do a followup for that string fix here. Think consortia and independent branches - they might not be branches of the same organisation and still sharing the same Koha. ( I think that was the reasoning ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:55:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:55:55 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 --- Comment #147 from Martin Renvoize --- Created attachment 112988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112988&action=edit Bug 24786: (QA follow-up) Remove trailing space in classes The trailing space after branch in the class attribute for the register select options cause issues in the 'hasClass' javascript selector Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 13:56:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 12:56:46 +0000 Subject: [Koha-bugs] [Bug 26914] Advanced search "fewer options" hides boolean operator dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26914 --- Comment #4 from Owen Leonard --- I agree that this could be added to OpacAdvSearchOptions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:03:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:03:43 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112988|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize --- Created attachment 112989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112989&action=edit Bug 24786: (QA follow-up) Remove trailing space in classes The trailing space after branch in the class attribute for the register select options cause issues in the 'hasClass' javascript selector Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:07:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:07:38 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #98 from Martin Renvoize --- I'm sure we can restore the column filters as a followup.. I was hoping to see this in the queue for this release. Getting stuck this close to the deadline is plain disheartening :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:09:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:09:25 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #22 from Nick Clemens --- (In reply to Katrin Fischer from comment #21) > I just wanted to say that I think filter is wrong here. > > I think replacing owning is a good point. But I'd suggest different > parameter names if we want to stick with terminology: > > - checkout_library > - item_home_library > > homebranch is a bit misleading as it could be the patron's or the item's. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:12:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:12:00 +0000 Subject: [Koha-bugs] [Bug 1005] mouse's click doesn't work in submit button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1005 Gourav tester changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gourav.geitpl at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:12:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:12:59 +0000 Subject: [Koha-bugs] [Bug 26924] New: Enter email and password then click login button Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26924 Bug ID: 26924 Summary: Enter email and password then click login button Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: gourav.geitpl at gmail.com QA Contact: testopia at bugs.koha-community.org Login page > enter email and password > click login button > it shows user doesn't exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:14:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:14:39 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #99 from Andrew Fuerste-Henry --- > They allow filtering on aspects that cannot be searched otherwise - I > believe they would be missed. Testing this, it seems that on current code the main search box above the pending orders table is capable of searching every column in that table except the fund. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:14:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:14:56 +0000 Subject: [Koha-bugs] [Bug 26924] Enter email and password then click login button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26924 Gourav tester changed: What |Removed |Added ---------------------------------------------------------------------------- Hours Worked| |23.00 Deadline| |2020-11-06 Keywords| |Manual URL| |https://www.theboisson.com/ Hours Left|0.00 |1.00 Orig. Est.|0.00 |3.00 --- Comment #1 from Gourav tester --- No other comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:17:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:17:50 +0000 Subject: [Koha-bugs] [Bug 26924] Enter email and password then click login button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26924 Gourav tester changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gouravchawda.240 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:20:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:20:41 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #23 from Martin Renvoize --- Created attachment 112990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112990&action=edit Bug 21886: (QA follow-up) Update parameters As discussed, this patch updates the --owning parameter to more clearly represent it's function. --owning boolean => --frombranch=item-homebranch|item-issuebranch Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:21:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:21:23 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #24 from Martin Renvoize --- Be great to get a final independant QA on my followup.. setting signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:29:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:29:27 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 --- Comment #4 from Matthias Meusburger --- Sure thing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:30:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:30:23 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112986|0 |1 is obsolete| | --- Comment #5 from Matthias Meusburger --- Created attachment 112991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112991&action=edit Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Enable the CheckPrevCheckout syspref (on "Do" for instance) 3) Enable prevcheckout_block_checkout in the SIP server config file 4) Checkout and checkin an item for a user 5) Checkout the item again with the SIP CLI tool 6) Check that the SIP message is "This item was previously checked out by you" and that the item was not checked out 7) Disable prevcheckout_block_checkout in the SIP server config file 8) Checkout the item again with the SIP CLI tool 9) Check that the SIP message is "This item was previously checked out by you" and that the item was checked out. 10) Prove t/db_dependent/SIP/Message.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:38:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:38:28 +0000 Subject: [Koha-bugs] [Bug 21898] Add basket info available for ACQORDER In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #11 from Jonathan Druart --- There is a failing test, can you have a look, Martin? # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=26] at /kohadevbox/koha/C4/Letters.pm line 679 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:41:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:41:59 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #5 from Ivan Dziuba --- Created attachment 112992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112992&action=edit Bug 21214: I changed cleanup_database.pl and some corrections with --keep-lc to dodge deletion in message_queue based on letter_code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:42:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:42:40 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ivan.dziuba at inlibro.com Status|Failed QA |Needs Signoff Assignee|charles.farmer at inlibro.com |ivan.dziuba at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:44:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:44:05 +0000 Subject: [Koha-bugs] [Bug 26925] New: Pickup library list should be in alphabetical order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Bug ID: 26925 Summary: Pickup library list should be in alphabetical order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When we fetch the list of valid pickup locations for placing a hold on the staff client, we grab a separate list of valid locations for each item on that bib, put each of those sub-lists in alphabetical order, and then string them together. We need to alphabetize the entire list at the end. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:45:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:45:03 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_26895=5D_Template_process_failed=3A?= =?utf-8?q?_file_error_-_parse_error_-_patron-title=2Einc_line_37=3A_unexp?= =?utf-8?b?ZWN0ZWQgdG9rZW4gKCc8c3BhbikgICBbJSBzcGFuX3N0YXJ0ID0gJzxzcGFu?= =?utf-8?b?IGNsYXNzPSJwYXRyb24tdGl0bGUiPsOi4oKsy5wgJV0gYXQgL3Vzci9zaGFy?= =?utf-8?q?e/koha/lib/C4/Templates=2Epm_line_122=2E?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26895 --- Comment #4 from francesc --- Solved. Thank you very much for your help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:49:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:49:39 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77762|0 |1 is obsolete| | --- Comment #6 from Ivan Dziuba --- Created attachment 112993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112993&action=edit Bug 21214: cleanup_database.pl --keep-lc to dodge deletion in message_queue based on letter_code Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:49:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:49:42 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112992|0 |1 is obsolete| | --- Comment #7 from Ivan Dziuba --- Created attachment 112994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112994&action=edit Bug 21214: I changed cleanup_database.pl and some corrections with --keep-lc to dodge deletion in message_queue based on letter_code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:52:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:52:22 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 --- Comment #10 from Jonathan Druart --- Comment on attachment 112932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112932 Bug 26860: Add without items facet Review of attachment 112932: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=26860&attachment=112932) ----------------------------------------------------------------- ::: C4/Search.pm @@ +1322,4 @@ > } > $q .= ' and '.join(' and ', @limits) if @limits; > } > + #TODO withoutitems limit What is this TODO about? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:53:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:53:01 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #4) > I've add a TODO for code dealing with "ccl=". > I will create a follow-up Still waiting the follow-up then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 14:54:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 13:54:32 +0000 Subject: [Koha-bugs] [Bug 26924] Enter email and password then click login button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26924 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Hours Left|1.00 |0.00 URL|https://www.theboisson.com/ | Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:00:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:00:38 +0000 Subject: [Koha-bugs] [Bug 26804] News: Limit the size of the news content column in newst table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart --- It may be a problem if the content is malformed, but the codemirror editor should prevent that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:24:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:24:42 +0000 Subject: [Koha-bugs] [Bug 26925] Pickup library list should be in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:24:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:24:45 +0000 Subject: [Koha-bugs] [Bug 26925] Pickup library list should be in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 --- Comment #1 from Nick Clemens --- Created attachment 112995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112995&action=edit Bug 26925: Sort pickup locations for biblio Currently we fetch the pickup locations for each item on the biblio, then we remove duplicates. Each items locations are sorted alphabetically, however, we don't ensure the final list is ordered To test: 1 - Find a title with items from two different libraries 2 - Create two library groups and select 'is local hold group' 3 - Place the libraries of the items in separate groups with differing libraries 4 - Attempt to place a hold for the title in the staff client 5 - Note the "Pickup at" list is not in alphabetical order 6 - Apply patch 7 - Restart all and reload 8 - Pickup locations are now sorted correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:27:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:27:29 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #40 from Kyle M Hall --- (In reply to David Cook from comment #39) > (In reply to David Cook from comment #38) > > I like the idea that the Anonymous Patron cannot be deleted, but I think > > that this implementation is too narrowly cast. > > > > I think that we should consider doing Bug 26170 (Create "system" patrons > > that cannot be (easily) deleted via the web UI) instead of this one, since > > there are many scenarios where we don't want to be able to delete patron > > accounts that are important (e.g. SIP patron, REST API patron, etc.) > > Admittedly, I don't have any patches on Bug 26170, and it's not high on my > priority list at the moment, so I don't see myself working on it any time > soon. > > Kyle has done all this great work, and really if it could be adapted to be > more generalizable for all kinds of "system" patrons, that would be amazing. > It would be a very useful development. I was actually discussing that as the 'next step' after this development. We could easily add a 'read-only' flag to a given account and move the AnonymousPatron logic into a a new Patron method like is_deletable. This would be especially useful for accounts used for SIP, APIs, and so forth. I would consider this to be a building block for bug 26170. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:36:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:36:55 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104746|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 112996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112996&action=edit Bug 25462: Shelving location should be on a new line in holdings table This patch moves the shelving location a new line after the Home library in the holdings table. To test: 1) Assign a shelving location with a long description to an item. 2) See that it displays on the same line as the Home Library in /cgi-bin/koha/catalogue/detail.pl 3) Apply the patch 4) Check that the shelving location is now on a new line Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:37:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:37:03 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104772|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 112997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112997&action=edit Bug 25462: Show shelving location on a new line after home library (staff client) This patch updates the staff client CSS to move the shelving location a new line after the 'Home library' in list of holdings on the bibliographic detail page. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a title in the staff client which has items with a shelving location. - View the detail page for that title. In the table of holdings, confirm that the shelving location information is on a separate line from the home library information. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:37:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:37:12 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104773|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 112998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112998&action=edit Bug 25462: Show shelving location on a new line after home library (OPAC) This patch updates the OPAC CSS to move the shelving location a new line after the 'Home library' in list of holdings on the bibliographic detail page. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a title in the OPAC which has items with a shelving location. - View the detail page for that title. In the table of holdings, confirm that the shelving location information is on a separate line from the home library information. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:38:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:38:36 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #11 from Martin Renvoize --- Tested on a sandbox on live testing youtube. All works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:40:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:40:30 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #25 from Katrin Fischer --- got 2 votes for checkout and library now :) Maybe missed more discussion, why not using comment#22 suggestions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:42:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:42:46 +0000 Subject: [Koha-bugs] [Bug 24412] Attach waiting hold to desk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #109 from Jonathan Druart --- 1. POD for Koha::Hold->desk is wrong 2. If not desk set, biblio hold list (reserves/request.pl) explodes with: Can't call method "desk_name" on an undefined value at /kohadevbox/koha/reserve/request.pl line 661 3. The desk's name is not correctly escaped in the patron's hold list (circ/circulation.pl, "Holds" tab) Try to use the following string as a desk name: Search for "escapeHtml" in the same js file for the solution. 4. I am not sure about the desk_id parameter we passed to Koha::Hold->set_waiting. We could also set it from ModReserveAffect, what's the benefit of this approach? Failing QA for 1, 2, 3. 4 is for discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:49:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:49:04 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:49:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:49:08 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106962|0 |1 is obsolete| | --- Comment #37 from Andrew Fuerste-Henry --- Created attachment 112999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112999&action=edit Bug 15986: Add a script for sending hold waiting reminder notices This patch adds a script for sending holds reminder notice to patrons. We add a 'send_notice' routine to Koha::Patrons - this will either send using the patron's email prefs, or allow forcing of a single method via the cron To test: 1 - Create an email hold reminder notice for a single library (Koha module: Holds, code HOLDREMINDER, branch: CPL) 2 - Set some waiting holds today for patrons at CPL, ensure those patrons have 'email' as the transport for hold filled notices 3 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL 4 - You should see the patrons here would have received emails 5 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL 6 - You should see the emails that were sent 7 - Check the patron notices tab to confirm 8 - Note a ptron with two holds waiting receives only one notice 9 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL -days 3 10 - No notices are sent 11 - Adjust the waiting date for the holds: UPDATE reserves SET waitingdate=DATE_SUB(CURDATE(), INTERVAL 3 DAY) WHERE waitingdate = CURDATE(); 12 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -li CPL -days 3 13 - Confirm the holds are now reminded 14 - Set yesterday as a holiday for CPL 15 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 3 16 - Notices should not be sent 17 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -li CPL -holidays -days 2 18 - Notices should be sent again 19 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 2 20 - Should get feedback that notice was not found for other libraries 21 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 2 -mtt sms 22 - Notice is not found 23 - Add the notice for sms 24 - perl misc/cronjobs/holds_reminder.pl -v -lettercode HOLDREMINDER -n -holidays -days 2 -mtt sms 25 - The notice should be sent 26 - Check patrons messaging tab to confirm 27 - prove -v t/db_dependent/Koha/Patrons.t Sponsored by: The Hotchkiss School (http://www.hotchkiss.org/) Signed-off-by: Kim Gnerre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:49:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:49:11 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106963|0 |1 is obsolete| | --- Comment #38 from Andrew Fuerste-Henry --- Created attachment 113000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113000&action=edit Bug 15986: Update for bug 24159 The job is concerned with holds waiting and takes days, I think using days_mode 'Calendar' makes sense as we are not calculating due dates Signed-off-by: Kim Gnerre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:49:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:49:15 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106964|0 |1 is obsolete| | --- Comment #39 from Andrew Fuerste-Henry --- Created attachment 113001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113001&action=edit Bug 15986: Rename send_notice to queue_notice and update test count Signed-off-by: Kim Gnerre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:55:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:55:11 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Kim Gnerre changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kgnerre at hotchkiss.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:55:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:55:51 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Kim Gnerre changed: What |Removed |Added ---------------------------------------------------------------------------- CC|rhilliker at hotchkiss.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 15:58:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 14:58:08 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #108 from Jonathan Druart --- Andrew, could you try to squash some patches here? Especially the atomicupdate file that is added then removed, and the 2 "Fix bad rebase" patches. And more if you can (the several tiny "fix" patches). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:00:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:00:01 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #8 from Ivan Dziuba --- Created attachment 113002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113002&action=edit Bug_21214: Changes after merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:00:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:00:34 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #1 from Martin Renvoize --- Created attachment 113003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113003&action=edit Bug 26847: Add unit test for categorycode in masthead This unit test adds a regression test for the addition of categorycode into the masthead of the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:00:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:00:37 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #2 from Martin Renvoize --- Created attachment 113004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113004&action=edit Bug 26847: Add data-categorycode to opac pages This patch adds the data-categorycode attribute to the loggedinuser span for all pages in the opac. Test plan 1/ Apply first patch, varify unit test fails. 2/ Apply second patch, varify unit test now passes. 3/ Navigate to opac and login 4/ Varify that data-categorycode is present in the loggedinuser span in the client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:00:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:00:57 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:07:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:07:01 +0000 Subject: [Koha-bugs] [Bug 26913] More than one title element on homepage when news item is displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26913 --- Comment #1 from Owen Leonard --- I cannot reproduce this error in 19.11.x. Are you sure the HTML isn't coming from the contents of your news item? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:07:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:07:10 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112993|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:07:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:07:23 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112994|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:07:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:07:37 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:08:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:08:03 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77762|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:08:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:08:10 +0000 Subject: [Koha-bugs] [Bug 26925] Pickup library list should be in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:08:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:08:12 +0000 Subject: [Koha-bugs] [Bug 26925] Pickup library list should be in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112995|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 113005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113005&action=edit Bug 26925: Sort pickup locations for biblio Currently we fetch the pickup locations for each item on the biblio, then we remove duplicates. Each items locations are sorted alphabetically, however, we don't ensure the final list is ordered To test: 1 - Find a title with items from two different libraries 2 - Create two library groups and select 'is local hold group' 3 - Place the libraries of the items in separate groups with differing libraries 4 - Attempt to place a hold for the title in the staff client 5 - Note the "Pickup at" list is not in alphabetical order 6 - Apply patch 7 - Restart all and reload 8 - Pickup locations are now sorted correctly Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:11:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:11:03 +0000 Subject: [Koha-bugs] [Bug 26132] Improve readability of TooMany In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #21 from Joonas Kylmälä --- Created attachment 113006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113006&action=edit Bug 26132: (follow-up) Add test to show errors in max issues amount calculation If you set default branch limits for issue quantity circulation rules you will get errors when calling TooMany function. To reproduce the error: 1) Apply this patch 2) Run prove t/db_dependent/Circulation/TooMany.t and notice the following error: No method count found for Koha::Checkouts DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'item.homebranch' in 'where clause' [...] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:11:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:11:07 +0000 Subject: [Koha-bugs] [Bug 26132] Improve readability of TooMany In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #22 from Joonas Kylmälä --- Created attachment 113007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113007&action=edit Bug 26132: (follow-up) Fix broken code in TooMany function The $checkouts variable was not defined in the PatronLibrary case at all and in the else case the SQL join was totally missing. To test: 1) Without this patch notice prove t/db_dependent/Circulation/TooMany.t fails 2) With this patch notice prove t/db_dependent/Circulation/TooMany.t succeeds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:24:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:24:03 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #40 from Nick Clemens --- (In reply to Séverine Queune from comment #36) > This patch works fine ! > But I won't sign it because of 2 points : > - I can't test the sms part, I don't know how it works and how to use the > feature > - I've got a question about the content of the message : when there several > holds, only the informations about the oldest reserve (for what I saw) are > displayed. Fields coming from the items or biblio tables can't be used. I > know it's happening for some other notices so don't Failed the patch because > of this point, but I regret I couldn't use the <> or > <> datas as it is recommended for some other notices, I think > it could be useful for patron to have some details about the waiting holds. - sms part works exactly like email up to the sending of the message, so testing is the same, just need to confirm it makes it into the queue - the notice supports template toolkit, so you can get other holds information like: Dear [% borrower.firstname %] [% borrower.surname %], Your hold for [% hold.biblio.title %] is waiting since [% hold.waitingdate %] [% IF borrower.holds.count > 0 %] You also have other holds: [% FOREACH hold IN borrower.holds %] [% hold.biblio.title %] : [% hold.found %] [% END %] [% END %] That could be cleaned up and made fancier, but just to give an idea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:28:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:28:01 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #41 from Séverine Queune --- (In reply to Nick Clemens from comment #40) > (In reply to Séverine Queune from comment #36) > > This patch works fine ! > > But I won't sign it because of 2 points : > > - I can't test the sms part, I don't know how it works and how to use the > > feature > > - I've got a question about the content of the message : when there several > > holds, only the informations about the oldest reserve (for what I saw) are > > displayed. Fields coming from the items or biblio tables can't be used. I > > know it's happening for some other notices so don't Failed the patch because > > of this point, but I regret I couldn't use the <> or > > <> datas as it is recommended for some other notices, I think > > it could be useful for patron to have some details about the waiting holds. > > - sms part works exactly like email up to the sending of the message, so > testing is the same, just need to confirm it makes it into the queue > > - the notice supports template toolkit, so you can get other holds > information like: > Dear [% borrower.firstname %] [% borrower.surname %], > > Your hold for [% hold.biblio.title %] is waiting since [% hold.waitingdate %] > > [% IF borrower.holds.count > 0 %] > You also have other holds: > [% FOREACH hold IN borrower.holds %] > [% hold.biblio.title %] : [% hold.found %] > [% END %] > [% END %] > > That could be cleaned up and made fancier, but just to give an idea Thanks Nick ! I completely forgot we could use template toolkit #ashamed... Do you need a second sign off for that one ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:35:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:35:59 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77762|0 |1 is obsolete| | --- Comment #9 from Ivan Dziuba --- Created attachment 113008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113008&action=edit Bug 21214: cleanup_database.pl --keep-lc to dodge deletion in message_queue based on letter_code Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:36:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:36:02 +0000 Subject: [Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 --- Comment #10 from Ivan Dziuba --- Created attachment 113009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113009&action=edit Bug_21214: Change of SQL request in condition $mail with letter_code and code modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:37:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:37:08 +0000 Subject: [Koha-bugs] [Bug 26925] Pickup library list should be in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 --- Comment #3 from Andrew Fuerste-Henry --- Oh, missing a step in the test plan. One must set one's hold pickup branch policy to Item's Hold Group. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:46:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:46:58 +0000 Subject: [Koha-bugs] [Bug 26925] Pickup library list should be in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 --- Comment #4 from Andrew Fuerste-Henry --- a jQuery bandaid in the meantime: if ( $('#circ_request').length ) { var select = $('#pickup'); select.html(select.find('option').sort(function(x, y) { return $(x).text() > $(y).text() ? 1 : -1; })); } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:55:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:55:48 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:55:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:55:51 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #98 from Lari Taskula --- Created attachment 113010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113010&action=edit Bug 17499: (follow-up) More explicit exceptions Adds and throws more detailed exceptions. This is useful for APIs and generating translatable errors in GUI. In short, replaces Koha::Exceptions::BadParameter with: Koha::Exceptions::Patron::NotFound Koha::Exceptions::Patron::Category Koha::Exceptions::Patron::Category::NotFound Koha::Exceptions::Patron::Message::Preference Koha::Exceptions::Patron::Message::Preference::AttributeNotFound Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceOutOfRange Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceNotAvailable Koha::Exceptions::Patron::Message::Preference::DigestNotAvailable Koha::Exceptions::Patron::Message::Preference::DigestRequired Koha::Exceptions::Patron::Message::Preference::EmailAddressRequired Koha::Exceptions::Patron::Message::Preference::NoTransportType Koha::Exceptions::Patron::Message::Preference::SMSNumberRequired To test: 1. prove t/db_dependent/Koha/Patron/Message/Preferences.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:55:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:55:53 +0000 Subject: [Koha-bugs] [Bug 26926] New: Update all occurrences of to apply ACC2 coding guideline Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Bug ID: 26926 Summary: Update all occurrences of to apply ACC2 coding guideline Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Retroactively apply ACC2 coding guideline We need to update all `input type="number"` occurrences to use `` as per the new accessibility guideline. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:56:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:56:09 +0000 Subject: [Koha-bugs] [Bug 26926] Update all occurrences of to apply ACC2 coding guideline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:56:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:56:30 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #100 from Tomás Cohen Arazi --- (In reply to Andrew Fuerste-Henry from comment #99) > > They allow filtering on aspects that cannot be searched otherwise - I > > believe they would be missed. > > Testing this, it seems that on current code the main search box above the > pending orders table is capable of searching every column in that table > except the fund. Good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 16:58:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 15:58:25 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #101 from Tomás Cohen Arazi --- I have a question about column filtering. The current code fetches all orders and then provides a 'string search' on the columns, based on the data there's on them. How would it work for numbers? If we translate that to a DB query, how would you say it should be done? Treat them as strings and '%%'? I ask this because I don't know what is expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:01:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:01:06 +0000 Subject: [Koha-bugs] [Bug 26927] New: Add the ability to advance search Authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26927 Bug ID: 26927 Summary: Add the ability to advance search Authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently searching is quite limited in search authorities in Koha, it would be nice to have an 'advanced search' to broaden the current search that is available. One specific search would be to the ability to search by Authority number in this module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:06:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:06:06 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113010|0 |1 is obsolete| | --- Comment #99 from Lari Taskula --- Created attachment 113011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113011&action=edit Bug 17499: (follow-up) More explicit exceptions Adds and throws more detailed exceptions. This is useful for APIs and generating translatable errors in GUI. In short, replaces Koha::Exceptions::BadParameter with: Koha::Exceptions::Patron::NotFound Koha::Exceptions::Patron::Category Koha::Exceptions::Patron::Category::NotFound Koha::Exceptions::Patron::Message::Preference Koha::Exceptions::Patron::Message::Preference::AttributeNotFound Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceOutOfRange Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceNotAvailable Koha::Exceptions::Patron::Message::Preference::DigestNotAvailable Koha::Exceptions::Patron::Message::Preference::DigestRequired Koha::Exceptions::Patron::Message::Preference::EmailAddressRequired Koha::Exceptions::Patron::Message::Preference::NoTransportType Koha::Exceptions::Patron::Message::Preference::SMSNumberRequired To test: 1. prove t/db_dependent/Koha/Patron/Message/Preferences.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:07:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:07:42 +0000 Subject: [Koha-bugs] [Bug 25263] Elasticsearch - Space after CCL index is removed from query and index is concatenated to term In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25263 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Nick Clemens --- This is 'fixed' by 24567 title: novel will be searched as title novel I think this is appropriate as title may contain colons - if you want CCL you need to not use spaces after the colon *** This bug has been marked as a duplicate of bug 24567 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:07:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:07:42 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 --- Comment #12 from Nick Clemens --- *** Bug 25263 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:07:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:07:50 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #100 from Lari Taskula --- As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595#c114 , I have attached a patch that provides more explicit Koha::Exceptions and reset bug status from "Passed QA" back to "Needs Signoff" for that patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:08:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:08:49 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #26 from Martin Renvoize --- (In reply to Katrin Fischer from comment #25) > got 2 votes for checkout and library now :) Maybe missed more discussion, > why not using comment#22 suggestions? Why not using comment#20 ;). I didn't get a reply to why that wasn't a good idea.. I feel my followup makes the syntax considerably clearer personally. having two boolean options that are mutually excluding and don't clearly say what they actually do in the name is far less clear to me than having one parameter that's clearly named with two clear options available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:23:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:23:20 +0000 Subject: [Koha-bugs] [Bug 26928] New: Allow for Specific Patron Modifications on the OPAC to be instantly approved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26928 Bug ID: 26928 Summary: Allow for Specific Patron Modifications on the OPAC to be instantly approved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently, any patron modifications that a patron has submitted through the OPAC to their library needs to be approved by staff. Some libraries would like to have the option to have specific borrower fields allocated to allow for these modifications instantly approved without going through the approval process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:32:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:32:29 +0000 Subject: [Koha-bugs] [Bug 26928] Allow for Specific Patron Modifications on the OPAC to be instantly approved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26928 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com Component|OPAC |Patrons Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:33:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:33:36 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:33:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:33:40 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113003|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 113012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113012&action=edit Bug 26847: Add unit test for categorycode in masthead This unit test adds a regression test for the addition of categorycode into the masthead of the staff client. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:33:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:33:42 +0000 Subject: [Koha-bugs] [Bug 23823] Allow system preferences to be bookmarked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:33:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:33:48 +0000 Subject: [Koha-bugs] [Bug 23823] Allow system preferences to be bookmarked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #31 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:33:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:33:49 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113004|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 113013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113013&action=edit Bug 26847: Add data-categorycode to opac pages This patch adds the data-categorycode attribute to the loggedinuser span for all pages in the opac. Test plan 1/ Apply first patch, varify unit test fails. 2/ Apply second patch, varify unit test now passes. 3/ Navigate to opac and login 4/ Varify that data-categorycode is present in the loggedinuser span in the client. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:33:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:33:50 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:33:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:33:52 +0000 Subject: [Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 --- Comment #13 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:33:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:33:54 +0000 Subject: [Koha-bugs] [Bug 26729] When adding a new vendor set focus for cursor to name input box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:33:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:33:56 +0000 Subject: [Koha-bugs] [Bug 26729] When adding a new vendor set focus for cursor to name input box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26729 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:33:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:33:58 +0000 Subject: [Koha-bugs] [Bug 26736] Compare values of reports log entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:34:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:34:00 +0000 Subject: [Koha-bugs] [Bug 26736] Compare values of reports log entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26736 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:34:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:34:01 +0000 Subject: [Koha-bugs] [Bug 26745] Notice titles/subjects should support Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:34:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:34:03 +0000 Subject: [Koha-bugs] [Bug 26745] Notice titles/subjects should support Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:34:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:34:05 +0000 Subject: [Koha-bugs] [Bug 26804] News: Limit the size of the news content column in newst table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:34:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:34:07 +0000 Subject: [Koha-bugs] [Bug 26804] News: Limit the size of the news content column in newst table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 --- Comment #18 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:34:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:34:09 +0000 Subject: [Koha-bugs] [Bug 26886] OPAC suggestions: possible duplicate message should stand out more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:34:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:34:11 +0000 Subject: [Koha-bugs] [Bug 26886] OPAC suggestions: possible duplicate message should stand out more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26886 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:34:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:34:46 +0000 Subject: [Koha-bugs] [Bug 26132] Improve readability of TooMany In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #23 from Jonathan Druart --- Last two patches pushed to master for 20.11 Thanks Joonas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:35:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:35:36 +0000 Subject: [Koha-bugs] [Bug 23823] Allow system preferences to be bookmarked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #32 from Jonathan Druart --- Congratulations for your first patch pushed, Ivan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:43:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:43:37 +0000 Subject: [Koha-bugs] [Bug 26928] Allow for Specific Patron Modifications on the OPAC to be instantly approved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26928 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- +1, nice idea! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 17:53:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 16:53:07 +0000 Subject: [Koha-bugs] [Bug 26132] Improve readability of TooMany In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #24 from Martin Renvoize --- Created attachment 113014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113014&action=edit Bug 26132: (GOLF EXAMPLE) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 18:05:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 17:05:22 +0000 Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111294|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 113015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113015&action=edit Bug 25846: Improve handling of multiple covers on catalog search results in the staff client This patch modifies the template, JS, and CSS for the staff interface catalog search results in order to gracefully handle multiple cover images. The changed version loops through any cover images which might be embedded and checks that they are successfully loaded. Only successfully-loaded images are shown. Only the first image is shown, and the others can be "paged through" using generated navigation controls. To test, apply the page and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Enable multiple cover image services. The patch was developed with these services available: - Amazon - Local cover images (including multiple local cover images) - Coce (serving up Amazon, Google, and OpenLibrary images) - Images from the CustomCoverImages preference Perform a variet of searches and confirm that cover images are displaying correctly, whether there be 0, 1, 2, or more covers available for each. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 18:23:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 17:23:35 +0000 Subject: [Koha-bugs] [Bug 26707] Split cart and lists button on bibliographic detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26707 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111930|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 113016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113016&action=edit Bug 26707: Split cart and lists button on bibliographic detail pages This patch modifies the toolbar shown on bibliographic detail pages so that the "Add to cart" and "Add to lists" buttons are separate. The "Add to cart" will now reflect whether the title is in the cart. The "Add to lists" button will now be a menu of list choices like it is on the search results page. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Search for a title in the staff client and view the detail page for one of the results. Testing the cart button: - In the toolbar you should see an "Add to cart" button and an "Add to lists" menu button. - Clicking the "Add to cart" button should show the cart message associated with cart link in the header. - The label showing the number of items in the cart should be incremented. - The button should change to a "Remove from cart" button. - Clicking the "Remove from cart" button should correctly remove the item from the cart: - The label showing the number of items in the cart should be decremented. - The button should change to "Add to cart." - Add a title to the cart and click the cart link in the header to open the cart pop-up window. - Click the "Empty and close" button in the cart window. - After you confirm the cart window should close. The "Remove from cart" button should now be an "Add to cart" button. - Add a title to the cart and navigate between each of the other views of that title: Normal, MARC, Labeled MARC, and ISBD. On each page you should see a "Remove from cart" button. - Test the add and remove functions from each of the other bibliographic detail views. Testing the lists button: - On the normal bibliographic detail page you should see an "Add to list" menu button. Clicking it should reveal the same kind of lists menu you see on the catalog search results page, with recent public and private lists and options for "More lists" and "New list." - Test that each of these options works correctly to trigger the expected pop-up window. - Confrim that the correct title is added to the correct list. - Perform this test from each of the bibliographic detail pages: Normal, MARC, Labeled MARC, and ISBD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 18:24:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 17:24:00 +0000 Subject: [Koha-bugs] [Bug 26928] Allow for Specific Patron Modifications on the OPAC to be instantly approved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26928 Martha Fuerst changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #2 from Martha Fuerst --- Please and thank you! We have several additional attribute fields that we'd like to have patrons be able to toggle themselves. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 18:24:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 17:24:44 +0000 Subject: [Koha-bugs] [Bug 26707] Split cart and lists button on bibliographic detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26707 --- Comment #7 from Owen Leonard --- This patch should fix the problems you described in comment 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 18:56:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 17:56:20 +0000 Subject: [Koha-bugs] [Bug 26928] Allow for Specific Patron Modifications on the OPAC to be instantly approved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26928 Margaret Hade changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 19:07:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 18:07:48 +0000 Subject: [Koha-bugs] [Bug 22086] Birthday Wishes email to patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22086 Elaine Bradtke changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org --- Comment #8 from Elaine Bradtke --- I agree patrons should have the ability to opt out. Some people find these messages annoying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 20:02:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 19:02:52 +0000 Subject: [Koha-bugs] [Bug 22086] Birthday Wishes email to patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22086 Michael Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik at adminkuhn.ch --- Comment #9 from Michael Kuhn --- In my opinion birthday wishes (if taken seriously) are something personal. So you can't order a program to congratulate people automatically. Unless in very special cases I would consider this plain Spam that noone has waited for - except the possible sender. However, I also agree patrons have to have the ability to opt out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 20:21:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 19:21:45 +0000 Subject: [Koha-bugs] [Bug 22086] Birthday Wishes email to patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22086 --- Comment #10 from Katrin Fischer --- Of course this should be an optional feature, but what we think is not a good idea from our own context is maybe something very common or even expected somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 20:36:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 19:36:12 +0000 Subject: [Koha-bugs] [Bug 26927] Add the ability to advance search Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26927 estherm at sodaspringsid.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm at sodaspringsid.com --- Comment #1 from estherm at sodaspringsid.com --- To further explain. sn: biblio number returns a specific bibliographic record an: authority number returns bibliographic records that use authorities with that number. While a useful search, is not as logical. I expected the search to return that specific authority record. Both of these searches occur in the Search Catalog search box. It would be an improvement if the search authority box in the authority module had an option or ability to search by authority number to return specific authority records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 20:56:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 19:56:43 +0000 Subject: [Koha-bugs] [Bug 26927] Add the ability to advance search Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26927 --- Comment #2 from Katrin Fischer --- Hi Esther, are you searching in the catalog or in the authorities module? Authorities can't be found in the catalog as authorities and bibliographic records are different data sets in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 21:04:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 20:04:12 +0000 Subject: [Koha-bugs] [Bug 26927] Add the ability to advance search Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26927 --- Comment #3 from estherm at sodaspringsid.com --- I tried both. an: authority number only appears to work when searching the catalog. It makes sense it would return bibliographic records in that module that use the required authority. It does not appear to work in the authority search, nor does there appear to be any other way to search by authority number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 21:04:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 20:04:37 +0000 Subject: [Koha-bugs] [Bug 26929] New: Koha will only display the first 20 macros Advanced Editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Bug ID: 26929 Summary: Koha will only display the first 20 macros Advanced Editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: nick at bywatersolutions.com Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In 20.05, if a library has more than 20 macros, then they will not appear on the screen and will not be accessible to the cataloger. The current workaround, upping the value in this system preference, RESTdefaultPageSize - increased to 40, this will display the rest of the macros (over 20) for the library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 21:05:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 20:05:30 +0000 Subject: [Koha-bugs] [Bug 26927] Add the ability to advance search Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26927 --- Comment #4 from Katrin Fischer --- Both data sets are differently indexed - i believe you are right that the search in authorities could be improved. The authority number might be indexed under a different index name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 21:08:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 20:08:19 +0000 Subject: [Koha-bugs] [Bug 18628] Reference books shows as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18628 Elaine Bradtke changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org --- Comment #2 from Elaine Bradtke --- I agree this is a problem. It seems almost redundant when you consider there's a not for loan status that contains descriptions for the OPAC and the Staff interface. Depending on the setup - the display can say Available for reference, unavailable and not for loan all at the same time depending on which interface you look at. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 21:58:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 20:58:39 +0000 Subject: [Koha-bugs] [Bug 26930] New: Add css class to collaborators in OPAC results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26930 Bug ID: 26930 Summary: Add css class to collaborators in OPAC results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org When a record has a lot of collaborators/added authors (70X to 75X in MARC21), the record in the results list can get quite big, and all that information is not necessary for a first look. The proposition is to add a CSS class to added authors/collaborators in order to be able to hide them if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 22:04:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 21:04:18 +0000 Subject: [Koha-bugs] [Bug 26925] Pickup library list should be in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113005|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 113017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113017&action=edit Bug 26925: Sort pickup locations for biblio Currently we fetch the pickup locations for each item on the biblio, then we remove duplicates. Each items locations are sorted alphabetically, however, we don't ensure the final list is ordered To test: 1 - Find a title with items from two different libraries 2 - Create two library groups and select 'is local hold group' 3 - Place the libraries of the items in separate groups with differing libraries 4 - Attempt to place a hold for the title in the staff client 5 - Note the "Pickup at" list is not in alphabetical order 6 - Apply patch 7 - Restart all and reload 8 - Pickup locations are now sorted correctly Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Bob Bennhoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 22:18:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 21:18:46 +0000 Subject: [Koha-bugs] [Bug 26250] Test suite does not pass if Elastic is used as search engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26250 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:07:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:07:43 +0000 Subject: [Koha-bugs] [Bug 26931] New: Volumes tab should show all volumes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26931 Bug ID: 26931 Summary: Volumes tab should show all volumes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 24857 This may want to just get folded into 24857, but filing separately to start. In the volumes interface defined by 24857, we haven't explicitly defined how many volumes to show or how to paginate them, so if you have volumes in excess of your RESTdefaultPageSize syspref those volumes cannot be seen. We should make it show them all. Or paginate, but showing them all would be more consistent with other bits of the catalog. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:07:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:07:43 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26931 [Bug 26931] Volumes tab should show all volumes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:07:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:07:59 +0000 Subject: [Koha-bugs] [Bug 26931] Volumes tab should show all volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26931 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:17:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:17:05 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90915|0 |1 is obsolete| | --- Comment #56 from Alexis Ripetti --- Created attachment 113018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113018&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:17:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:17:16 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90916|0 |1 is obsolete| | --- Comment #57 from Alexis Ripetti --- Created attachment 113019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113019&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:17:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:17:24 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90918|0 |1 is obsolete| | --- Comment #58 from Alexis Ripetti --- Created attachment 113020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113020&action=edit Bug 19368 - Syspref now SortIgnoreArticles, used in datatables.inc Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:17:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:17:30 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90919|0 |1 is obsolete| | --- Comment #59 from Alexis Ripetti --- Created attachment 113021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113021&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:17:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:17:41 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90920|0 |1 is obsolete| | --- Comment #60 from Alexis Ripetti --- Created attachment 113022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113022&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:17:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:17:47 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90921|0 |1 is obsolete| | --- Comment #61 from Alexis Ripetti --- Created attachment 113023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113023&action=edit Bug 19368 - Added missing closing bracket at the end of serials-search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:18:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:18:12 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexis.ripetti at inLibro.com Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:58:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:58:25 +0000 Subject: [Koha-bugs] [Bug 26707] Split cart and lists button on bibliographic detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26707 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 4 23:58:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 22:58:28 +0000 Subject: [Koha-bugs] [Bug 26707] Split cart and lists button on bibliographic detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26707 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113016|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 113024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113024&action=edit Bug 26707: Split cart and lists button on bibliographic detail pages This patch modifies the toolbar shown on bibliographic detail pages so that the "Add to cart" and "Add to lists" buttons are separate. The "Add to cart" will now reflect whether the title is in the cart. The "Add to lists" button will now be a menu of list choices like it is on the search results page. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Search for a title in the staff client and view the detail page for one of the results. Testing the cart button: - In the toolbar you should see an "Add to cart" button and an "Add to lists" menu button. - Clicking the "Add to cart" button should show the cart message associated with cart link in the header. - The label showing the number of items in the cart should be incremented. - The button should change to a "Remove from cart" button. - Clicking the "Remove from cart" button should correctly remove the item from the cart: - The label showing the number of items in the cart should be decremented. - The button should change to "Add to cart." - Add a title to the cart and click the cart link in the header to open the cart pop-up window. - Click the "Empty and close" button in the cart window. - After you confirm the cart window should close. The "Remove from cart" button should now be an "Add to cart" button. - Add a title to the cart and navigate between each of the other views of that title: Normal, MARC, Labeled MARC, and ISBD. On each page you should see a "Remove from cart" button. - Test the add and remove functions from each of the other bibliographic detail views. Testing the lists button: - On the normal bibliographic detail page you should see an "Add to list" menu button. Clicking it should reveal the same kind of lists menu you see on the catalog search results page, with recent public and private lists and options for "More lists" and "New list." - Test that each of these options works correctly to trigger the expected pop-up window. - Confrim that the correct title is added to the correct list. - Perform this test from each of the bibliographic detail pages: Normal, MARC, Labeled MARC, and ISBD. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 00:21:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 23:21:27 +0000 Subject: [Koha-bugs] [Bug 26707] Split cart and lists button on bibliographic detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26707 --- Comment #9 from David Nind --- (In reply to Owen Leonard from comment #7) > This patch should fix the problems you described in comment 3. Thanks Owen! Everything is now working as expected and signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 00:30:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 23:30:44 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #346 from David Cook --- By the way, AWS have just launched a managed RabbitMQ service: https://aws.amazon.com/blogs/aws/amazon-mq-update-new-rabbitmq-message-broker-service/ I haven't tried it but people might find that useful, especially if/when Bug 26742 is pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 00:35:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 23:35:32 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #41 from David Cook --- (In reply to Kyle M Hall from comment #40) > I was actually discussing that as the 'next step' after this development. We > could easily add a 'read-only' flag to a given account and move the > AnonymousPatron logic into a a new Patron method like is_deletable. This > would be especially useful for accounts used for SIP, APIs, and so forth. I > would consider this to be a building block for bug 26170. That sounds good to me! I worry a bit that we're talking about refactoring a change before it's even pushed into Koha, but I suppose that I wouldn't really want to hold up this change either... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 00:36:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 23:36:43 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 --- Comment #7 from David Cook --- (In reply to Kyle M Hall from comment #6) > (In reply to David Cook from comment #5) > > (In reply to Katrin Fischer from comment #2) > > > A changed password can't be queried, I like the idea of an enable/disable > > > functionality for the permissions. You would still want to allow OPAC > > > logins, but block staff. > > > > We could query it if we changed the password field to "!". I feel that's > > something that Koha sometimes does? > > I'm not seeing the in the code with some basic grepping. The problem I see > with that is, again, that it changes data about the user. The user's > password is then lost, and without additional data ( public note, private > note ), the reason for the password being changed would be unknown. Hmm maybe that's something from the past then. I thought we used to set the password field to ! when we didn't have a password for users. Or maybe that's something we did locally... But I agree about the reasons not to do it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 00:41:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Nov 2020 23:41:03 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 --- Comment #2 from David Cook --- I'm not familiar with the plugin use on intranet/cgi-bin/catalogue/detail.pl, but would an alternative be to implement the plugin as an API route and then inject some Javascript into OpacUserJS to insert the tab? I suppose the annoying part of doing that is injecting the Javascript though... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 01:15:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 00:15:37 +0000 Subject: [Koha-bugs] [Bug 26932] New: Importing staged bibliographic MARC records does not show a completed status if there are any item records to stage Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26932 Bug ID: 26932 Summary: Importing staged bibliographic MARC records does not show a completed status if there are any item records to stage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Created attachment 113025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113025&action=edit MARC with no item records Important: imported does WORK but the completed message never shows. It just hangs on 0% when importing. However if you give it some time and do a search, the imported record shows in search results. We see the completed message if importing a staged record that has no item records. We do NOT see the completed message if importing a staged record that DOES have item records. I've attached two sample records to test with. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 01:15:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 00:15:55 +0000 Subject: [Koha-bugs] [Bug 26932] Importing staged bibliographic MARC records does not show a completed status if there are any item records to stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26932 --- Comment #1 from Aleisha Amohia --- Created attachment 113026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113026&action=edit MARC with item records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 01:19:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 00:19:07 +0000 Subject: [Koha-bugs] [Bug 26497] "Hide all columns" throws Javascript error on aqplan.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26497 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 01:24:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 00:24:13 +0000 Subject: [Koha-bugs] [Bug 26497] "Hide all columns" throws Javascript error on aqplan.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26497 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.05 |20.11.00, 20.05.05, released in| |19.11.12 Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Aleisha Amohia --- backported to 19.11.x for 19.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 01:39:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 00:39:57 +0000 Subject: [Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.05 |20.11.00, 20.05.05, released in| |19.11.12 CC| |aleisha at catalyst.net.nz Status|Pushed to stable |Pushed to oldstable --- Comment #24 from Aleisha Amohia --- backported to 19.11.x for 19.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 01:45:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 00:45:40 +0000 Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 01:45:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 00:45:45 +0000 Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113015|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 113027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113027&action=edit Bug 25846: Improve handling of multiple covers on catalog search results in the staff client This patch modifies the template, JS, and CSS for the staff interface catalog search results in order to gracefully handle multiple cover images. The changed version loops through any cover images which might be embedded and checks that they are successfully loaded. Only successfully-loaded images are shown. Only the first image is shown, and the others can be "paged through" using generated navigation controls. To test, apply the page and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Enable multiple cover image services. The patch was developed with these services available: - Amazon - Local cover images (including multiple local cover images) - Coce (serving up Amazon, Google, and OpenLibrary images) - Images from the CustomCoverImages preference Perform a variet of searches and confirm that cover images are displaying correctly, whether there be 0, 1, 2, or more covers available for each. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 01:51:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 00:51:33 +0000 Subject: [Koha-bugs] [Bug 26932] Importing staged bibliographic MARC records does not show a completed status if there are any item records to stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26932 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 01:52:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 00:52:47 +0000 Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind --- NOTE: I was only able to test with AmazonCoverImages and LocalCoverImages. Feel free to change back to Needs Signoff if it needs to be tested with the other services. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 05:30:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 04:30:18 +0000 Subject: [Koha-bugs] [Bug 26933] New: OPAC - Multiple cover image show in results and details pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 Bug ID: 26933 Summary: OPAC - Multiple cover image show in results and details pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Created attachment 113028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113028&action=edit Screenshots - Multiple cover images displayed in the OPAC If multiple cover image sources are enabled for the OPAC, multiple images are displayed in search results and record detail pages. See the attached examples. To recreate: 1. Enable Amazon (AmazonCoverImages), Google (GoogleJackets), Open Library (OpenLibraryCovers), and local cover images (LocalCoverImages). 2. Search on the OPAC for perl. 3. Note that on the search results pages and record details pages that multiple images are displayed. I'm assuming here that it is valid to have multiple cover image sources enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 05:45:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 04:45:01 +0000 Subject: [Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 05:45:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 04:45:04 +0000 Subject: [Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112655|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 113029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113029&action=edit Bug 26854: Close STDERR when forking stage-marc-import.pl We need to close STDERR when forking stage-marc-import.pl, or else the CGI session with Apache httpd does not properly finish. This leads to unexpected behaviour across different httpd versions, operating systems, etc. This patch closes the STDERR file handle when forking a child process to do MARC imports, and it re-opens STDERR to a log file in the logdir directory to catch any import errors. Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 3. Upload a MARC file with a large number of records (e.g. 30,000 records) 4. Open F12 dev tools 5. Click on "Network" tab 6. Clear all existing network logs 7. Click "Stage for import" 8. After ~30 seconds, the request to stage-marc-import.pl should return a 200 code 9. Immediately, calls to background-job-progress.pl should start, and the "Job progress" bar should update at a maximum rate of every .5 seconds (or more realistically 1-2 seconds) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 05:46:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 04:46:13 +0000 Subject: [Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind --- I've tested as per the test plan, hopefully someone else understands the technical details for this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 06:06:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 05:06:06 +0000 Subject: [Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I tried to test in koha-testing-docker this by: 1. Applying the patch. 2. Changed the ownership to kohadev-koha (chown kohadev-koha:kohadev-koha check_syspref_cache.pl) and permissions (chmod 755 check_syspref_cache.pl). 3. Running the script: perl misc/maintenance/check_syspref_cache.pl I received this message: Global symbol "$syspref_cache" requires explicit package name (did you forget to declare "my $syspref_cache"?) at misc/maintenance/check_syspref_cache.pl line 40. Execution of misc/maintenance/check_syspref_cache.pl aborted due to compilation errors. I don't know how system preferences are cached and to check for differences between those and what is in the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 06:33:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 05:33:16 +0000 Subject: [Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 06:33:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 05:33:19 +0000 Subject: [Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109431|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 113030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113030&action=edit Bug 26337: Pass skip_merge to DelAuthority when removing unsused authorities This script checks that an authority is not being used before deleting it. We do not need to check biblios for the authority id as we have already verified it is unused. TO test: 1 - Reset db to koha test database 2 - perl misc/migration_tools/remove_unused_authorities.pl -t 3 - Note a number of unsued authorities 4 - perl misc/migration_tools/remove_unused_authorities.pl -c 5 - Note authorities are removed 6 - Reset db 7 - Apply patch 8 - perl misc/migration_tools/remove_unused_authorities.pl -t 9 - Note results are the same 10 - perl misc/migration_tools/remove_unused_authorities.pl -c 11 - Note results are the same Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 06:34:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 05:34:09 +0000 Subject: [Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Results from running through the test plan. Before patch applied ==================== perl misc/migration_tools/remove_unused_authorities.pl -t 1706 authorities parsed 493 can be deleted because unused 1213 unchanged because used perl misc/migration_tools/remove_unused_authorities.pl -c 1706 authorities parsed 493 deleted because unused 1213 unchanged because used After patch applied =================== perl misc/migration_tools/remove_unused_authorities.pl -t 1706 authorities parsed 493 can be deleted because unused 1213 unchanged because used perl misc/migration_tools/remove_unused_authorities.pl -c 1706 authorities parsed 493 deleted because unused 1213 unchanged because used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:38:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 06:38:32 +0000 Subject: [Koha-bugs] [Bug 26367] Warn in HoldsQueue if request itemtype set but request is not item specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:38:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 06:38:36 +0000 Subject: [Koha-bugs] [Bug 26367] Warn in HoldsQueue if request itemtype set but request is not item specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109620|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 113031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113031&action=edit Bug 26367: Unit test This warn only appears when: The borrower and item branches match AND The hold fulfillment policy is any or the pickupbranch matches the items branch specified by hold_fulfillment_policy AND The request has an itemtype set To trigger we simply add some itemtype to existing hold requests in the test To test: 1 - prove -v t/db_dependent/HoldsQueue.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:38:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 06:38:39 +0000 Subject: [Koha-bugs] [Bug 26367] Warn in HoldsQueue if request itemtype set but request is not item specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109621|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 113032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113032&action=edit Bug 26367: Prevent warn about undefined values when record level hold has an itemtype To test: 1 - set AllowHoldItemTypeSelection to 'Allow' 2 - Find a patron from Library A 3 - Find a record with an item from Library A 4 - Place a title level hold with itemtype specified for a delivery at Library A for patron and record above 5 - perl misc/cronjobs/holds/build_holds_queue.pl 6 - There are warns: Use of uninitialized value in hash element at /kohadevbox/koha/C4/HoldsQueue.pm line 523. Use of uninitialized value in string eq at /kohadevbox/koha/C4/HoldsQueue.pm line 523 7 - Apply this patch 8 - perl misc/cronjobs/holds/build_holds_queue.pl 9 - No more warns! 10 - prove -v t/db_dependent/HoldsQueue.t 11 - All tests pass! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 07:57:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 06:57:48 +0000 Subject: [Koha-bugs] [Bug 26367] Warn in HoldsQueue if request itemtype set but request is not item specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Testing notes - to generate the warnings when build_holds_queue.pl is run (using koha-testing-docker): 1. In staff interface change the library to Midway. 2. Search the catalog for Xenophōntos Agēsilaos. 3. Click on 'Place hold'. 4. For the patron choose Henry Acevedo. 5. For hold details for "Request specific item type" select "Books", then Place hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 08:47:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 07:47:20 +0000 Subject: [Koha-bugs] [Bug 26934] New: SIP2 allows checkin of already checked in item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26934 Bug ID: 26934 Summary: SIP2 allows checkin of already checked in item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: diwesh.diwakar at celect.in QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When we performing check in to the items already checked in SIP2 do check in of the same instead of blocking as the item is not checked out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:11:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:11:11 +0000 Subject: [Koha-bugs] [Bug 26935] New: Incorrect basketid sent for claimacquisition and claimissues Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Bug ID: 26935 Summary: Incorrect basketid sent for claimacquisition and claimissues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The basket info are not used in the default template of these notices, but if it is used, a wrong basket may be passed to generate the notice. This has been caught by a test failure after bug 26745. # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at /kohadevbox/koha/C4/Letters.pm line 679 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:12:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:12:02 +0000 Subject: [Koha-bugs] [Bug 26745] Notice titles/subjects should support Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 --- Comment #8 from Jonathan Druart --- A very unintentional side-effect of this patch has been to caught a bug in SendAlerts, see bug 26935. # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at /kohadevbox/koha/C4/Letters.pm line 679 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:15:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:15:30 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:15:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:15:33 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 --- Comment #1 from Jonathan Druart --- Created attachment 113033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113033&action=edit Bug 26935: Don't use basket for claimacquisition and claimissues Incorrect basketid is sent for claimacquisition and claimissues. The basket info are not used in the default template of these notices, but if it is used, a wrong basket may be passed to generate the notice. This has been caught by a test failure after bug 26745. # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at /kohadevbox/koha/C4/Letters.pm line 679 This is a quick patch to fix the failing test, bug more work would needed. We are removing the basket info from those 2 notices and keeping it only for orderacquisition. Technically: the $externalid is coming from the parameter list of SendAlerts, but it is a basketno only for orderacquisition. We must not pass it for other notices. Test plan: Confirm that the failing test is now passing and that the changes make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:21:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:21:14 +0000 Subject: [Koha-bugs] [Bug 26132] Improve readability of TooMany In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #25 from Jonathan Druart --- Created attachment 113034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113034&action=edit Bug 26132: continuing code golf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:22:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:22:25 +0000 Subject: [Koha-bugs] [Bug 26132] Improve readability of TooMany In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #26 from Jonathan Druart --- I am willing to continue and push follow-ups here. However, Martin, I think that with this approach we are going to join in all cases, which is only needed in 1 situation. I guess that's why I wrote the different search calls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:25:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:25:06 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority --- Comment #2 from Jonathan Druart --- This patch has a high priority, Jenkins is not happy without it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:28:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:28:21 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #28 from Jonathan Druart --- To prevent the values to be sent maybe we could disable the elements instead of removing them from the DOM. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:28:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:28:35 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |nick at bywatersolutions.com |ommunity.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:28:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:28:57 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:29:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:29:55 +0000 Subject: [Koha-bugs] [Bug 26697] Make translation file for types and descriptions of charges consistent between OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26697 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Patch doesn't apply --- Comment #13 from Jonathan Druart --- error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc). Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:30:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:30:42 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:58:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:58:43 +0000 Subject: [Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #74 from Jonathan Druart --- Mason, Could you have a look at how hard/easy Locale::XGettext::TT2 can be packaged (from 20.11 ideally)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 09:59:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 08:59:57 +0000 Subject: [Koha-bugs] [Bug 24412] Attach waiting hold to desk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #110 from Martin Renvoize --- (In reply to Jonathan Druart from comment #109) > 4. I am not sure about the desk_id parameter we passed to > Koha::Hold->set_waiting. > We could also set it from ModReserveAffect, what's the benefit of this > approach? I felt it was a good thing having it at the set_waiting level. In part because it encourages code to be written cleanly in the Koha:: space and because I feel it's the set_waiting call that links closely with when a desk would be assigned to a reserve and as such having it in this function now means if we use set_waiting down the line without calling ModReserveAffect then we would be reminded to set desk_id if appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:05:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:05:36 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112363|0 |1 is obsolete| | --- Comment #98 from Andrew Isherwood --- Created attachment 113035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113035&action=edit Bug 23916: Add issues.issuer column and FK This patch adds the issues.issuer column which is a foreign key to borrowers.borrowernumber Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:05:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:05:40 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112364|0 |1 is obsolete| | --- Comment #99 from Andrew Isherwood --- Created attachment 113036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113036&action=edit Bug 23916: Add "RecordIssuer" syspref This patch adds the "RecordIssuer" syspref, which is disabled by default Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:05:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:05:45 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112365|0 |1 is obsolete| | --- Comment #100 from Andrew Isherwood --- Created attachment 113037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113037&action=edit Bug 23916: Record and display item issuer This patch adds the recording and display of the item issuer. This behaviour is governed by the RecordIssuer syspref, if disabled (the default), no recording or display of issuer will take place. Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:05:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:05:49 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112366|0 |1 is obsolete| | --- Comment #101 from Andrew Isherwood --- Created attachment 113038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113038&action=edit Bug 23916: Anonymise 'issuer' when required This patch adds the anonymisation of 'old_issues.issuer' alongside the existing anonymisation of 'old_issues.borrowernumber' Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:05:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:05:53 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112367|0 |1 is obsolete| | --- Comment #102 from Andrew Isherwood --- Created attachment 113039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113039&action=edit Bug 23916: Add unit tests This patch adds unit tests for the new functions Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:05:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:05:57 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112368|0 |1 is obsolete| | --- Comment #103 from Andrew Isherwood --- Created attachment 113040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113040&action=edit Bug 23916: (follow-up) Fix column name collision Seems that joining 'borrowers' into the query run in C4::Members::GetAllIssues caused a column name collision, which blatted the retrieval of issues.branchcode. So we now are being a bit more specific in what is coming from where in the query. Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:06:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:06:01 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112369|0 |1 is obsolete| | --- Comment #104 from Andrew Isherwood --- Created attachment 113041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113041&action=edit Bug 23916: (follow-up) Don't anonymise issuer and don't update action_logs on upgrade This commit implements the two suggestions made by Nick in comment #41: - Removes the attempted retrospective addition of issuers to old issues. It was not particularly reliable, it also is not appropriate if the user does not wish to make use of this functionality - Removes the conversion of a NULL issuer to the anonymous borrowernumber when anonymising checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:06:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:06:05 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112370|0 |1 is obsolete| | --- Comment #105 from Andrew Isherwood --- Created attachment 113042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113042&action=edit Bug 23916: (follow-up) Fix terminology, use patron-title and make column consistent in issues and old_issues This commit makes the changes suggested by Katrin in comment #50: - Changed syspref from RecordIssuer to RecordStaffUserOnCheckout - Changed terminology from "issue" to "check out" and variations - Fixed name display to use patron-title.inc - Made issuer column DEFAULT NULL consistently between issues and old_issues and between the DB update and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:06:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:06:09 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112371|0 |1 is obsolete| | --- Comment #106 from Andrew Isherwood --- Created attachment 113043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113043&action=edit Bug 23916: (follow-up) Rebase unit tests This commit is a response to Katrin's comments in comment #62: - Fixed merge conflict It also fixes a test which now fails due to an upstream change in C4::Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:06:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:06:14 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112372|0 |1 is obsolete| | --- Comment #107 from Andrew Isherwood --- Created attachment 113044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113044&action=edit Bug 23916: (follow-up) Fix unit test This commit responds to the comment made by Katrin in comment #73. I have removed the lines cited as causing the contraint violation. The were added in the original iteration of the bug patches and, despite spending time trying to get to the bottom of it, I cannot figure out why. There are no changes in the patchset relating to Koha/Patron.pm and removing the lines does not cause any of the tests in files that *are* affected by this patchset to fail. I do not know why these lines were ever added in the first place, unfortunately I did not add comments explaining (lesson learned)! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:06:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:06:18 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112373|0 |1 is obsolete| | --- Comment #108 from Andrew Isherwood --- Created attachment 113045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113045&action=edit Bug 23916: (QA follow-up) Remove stray changes and fix typo There were a couple changes that had no effect, so cleaned those up Typo 'is' for 'if' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:06:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:06:42 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #109 from Andrew Isherwood --- Now rebased, thanks Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:08:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:08:45 +0000 Subject: [Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #19 from David Nind --- Created attachment 113046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113046&action=edit Screenshot - After patch applied and attempting to save the record I can replicate the issue. After applying the patches I attempt to add another new record. When saving the record, I don't get the add new item screen - see the screenshot attached. The record is not added, it shows up in the reservoir, and there are these warnings are in the log: 66 [2020/11/05 08:29:42] [WARN] DBD::mysql::st execute failed: Data too long for column 'lccn' at row 1 [for Statement "INSERT INTO `biblioitems` ( `agerestriction`, `biblionumber`, `cn_class`, `cn_ite m`, `cn_sort`, `cn_source`, `cn_suffix`, `collectionissn`, `collectiontitle`, `collectionvolume`, `ean`, `editionresponsibility`, `editionstatement`, `illus`, `isbn`, `issn`, `itemtype`, `lccn`, `no tes`, `number`, `pages`, `place`, `publicationyear`, `publishercode`, `size`, `timestamp`, `totalissues`, `url`, `volume`, `volumedate`, `volumedesc`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ?, ?, ?, ?, ? )" with ParamValues: 0=undef, 1='448', 2=undef, 3=undef, 4='', 5="ddc", 6=undef, 7=undef, 8=undef, 9=undef, 10=undef, 11=undef, 12=undef, 13="ill. ;", 14="9780132480529 (pbk. : alk. paper) | 0132480522 (pbk. : alk. paper)", 15=undef, 16="BK", 17="ThisisgoingtobetoomanycharactersfortheLCCNfield", 18=undef, 19=undef, 20="xix, 281 p. :", 21="Upper Saddle River, NJ :", 22=undef, 23="IBM Press : | Pearson,", 24="24 cm.", 25=undef, 26=undef, 27=undef, 28=undef, 29=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 183 6. 67 [2020/11/05 08:29:42] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'lccn' at row 1 at /kohadevbox/koha/Koha/Object.pm line 169 68 [2020/11/05 08:29:42] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'lccn' at row 1 at /kohadevbox/koha/Koha/Object.pm line 169 69 [2020/11/05 08:29:42] [WARN] Use of uninitialized value $biblionumber in concatenation (.) or string at /kohadevbox/koha/cataloguing/addbiblio.pl line 870. 70 [2020/11/05 08:29:42] [WARN] Use of uninitialized value $searchid in concatenation (.) or string at /kohadevbox/koha/cataloguing/addbiblio.pl line 870. 71 [2020/11/05 08:29:42] [WARN] Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/additem.pl line 432. 72 [2020/11/05 08:29:42] [WARN] GetMarcBiblio called with undefined biblionumber at /kohadevbox/koha/cataloguing/additem.pl line 453. My notes for testing (koha-testing-docker): 1. Run through the test plan in the bug description 2. Run the tests: prove -v t/db_dependent/Biblio.t - these should pass 3. Delete the record created 4. Apply the patches 5. Repeat the test plan, this time: - There should be no errors in /var/log/koha/kohadev/plack-intranet-error.log - You should be able to successfully add an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:15:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:15:30 +0000 Subject: [Koha-bugs] [Bug 26913] More than one title element on homepage when news item is displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26913 --- Comment #2 from Phil --- (In reply to Owen Leonard from comment #1) > I cannot reproduce this error in 19.11.x. Are you sure the HTML isn't coming > from the contents of your news item? Thanks Owen, I had considered this as well, but the title element is populated by the title feed in the news form rather than the open text field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:21:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:21:51 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113033|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 113047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113047&action=edit Bug 26935: Don't use basket for claimacquisition and claimissues Incorrect basketid is sent for claimacquisition and claimissues. The basket info are not used in the default template of these notices, but if it is used, a wrong basket may be passed to generate the notice. This has been caught by a test failure after bug 26745. # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at /kohadevbox/koha/C4/Letters.pm line 679 This is a quick patch to fix the failing test, bug more work would needed. We are removing the basket info from those 2 notices and keeping it only for orderacquisition. Technically: the $externalid is coming from the parameter list of SendAlerts, but it is a basketno only for orderacquisition. We must not pass it for other notices. Test plan: Confirm that the failing test is now passing and that the changes make sense. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:22:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:22:48 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Yikes, that sub is kinda horrible.. but that's cleanup for another day. I agree with your changes here and the tests now pass consistently. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:25:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:25:40 +0000 Subject: [Koha-bugs] [Bug 15729] SIP server allows checkin of reserved item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729 Vihaan Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ujjwalguptax202 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:26:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:26:20 +0000 Subject: [Koha-bugs] [Bug 26936] New: sip2 allows the checkin the item was already checkin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26936 Bug ID: 26936 Summary: sip2 allows the checkin the item was already checkin Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: ujjwalguptax202 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com sip2 allows the checkin the item was already checkin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:32:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:32:44 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111794|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 113048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113048&action=edit Bug 24603: Allow to cancel charges in patron accounting There is already a button to void a payment. It should be possible to cancel a charge too. This patch adds a button in patron's accounting section (Transactions tab) that allow to cancel charges. Charges that have been fully or partially paid cannot be cancelled. It also fixes Koha::Account::Line::is_credit by looking at credit_type_code instead of amount (amount can be 0 for voided payments) It also fixes the tests for Koha::Account::Line::void when database does not contain the borrowernumber 51 (the default in t::lib::Mocks::mock_userenv) Test plan: 1. Go to a patron's accounting section 2. Create a manual invoice 3. In Transactions tab, you should see a 'Cancel charge' button. Click on it. It should now be marked as cancelled 4. Create another manual invoice 5. Pay it (partially or fully) 6. Notice that the 'Cancel charge' button is not available 7. Void the payment 8. 'Cancel charge' button is available again. Click on it and verify that it still works 9. prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=24063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:32:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:32:48 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111795|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 113049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113049&action=edit Bug 24603: (follow-up) Update to double entry accounting This patch updates the logic to create a cancellation accountline and apply it to the charge line so we correction record the transaction in terms of double entry accounting standards. Test plan: 1. Go to a patron's accounting section 2. Create a manual invoice 3. In Transactions tab, you should see a 'Cancel charge' button. Click on it. It should now be marked as cancelled 4. A cancellation line should be associated with the original charge. 5. Create another manual invoice 6. Pay it (partially or fully) 7. Notice that the 'Cancel charge' button is not available 8. Void the payment 9. 'Cancel charge' button is available again. Click on it and verify that it still works 10. prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=24063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:32:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:32:52 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111796|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize --- Created attachment 113050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113050&action=edit Bug 24603: Fix number of unit tests Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=24063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:32:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:32:55 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111797|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 113051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113051&action=edit Bug 24603: (QA follow-up) Make the new credit type translatable and shorten description a bit Adding the new offset type and credit type to the include so it can be translated. Also suggest shortening the db description a bit. Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=24063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:32:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:32:59 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111914|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize --- Created attachment 113052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113052&action=edit Bug 24603: (QA follow-up) Add translation to OPAC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:34:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:34:24 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #33 from Martin Renvoize --- Rebased as requested... soooo many rebases at the minute.. great to see master catching up on the queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:42:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:42:12 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #27 from Jonathan Druart --- Created attachment 113053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113053&action=edit Bug 26633: Remove jquery.checkboxes.min.js include No longer exists and not used in this template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:50:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:50:00 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:50:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:50:04 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109821|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 113054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113054&action=edit Bug 26364: Don't skip records that match the isbn we passed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:50:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:50:07 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109822|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 113055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113055&action=edit Bug 26364: Remove false matches on isbn The test here was returning 0590353403 when searched for 9780590353403 because of the regex matching Koha doesn't work this way unless SearchWithISBNVariations is set to 'search' and you use a dropdown to select ISBN for searching To test: 1 - Search catalog for nb=9780590353403 2 - Confirm you don't have results, or delete the records with results 3 - Add isbn 0590353403 to a record 4 - Repeat search, fails 5 - Enable SearchWithISBNVariations 6 - Repeat search, fails 7 - Go to advanced search, select ISBN, search for 9780590353403 8 - Get results Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:50:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:50:11 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109823|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 113056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113056&action=edit Bug 26364: Remove useless condition $response_data is a hash with one key, content Why are we checkiing it against a string? Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:50:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:50:16 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109824|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 113057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113057&action=edit Bug 26364: Don't discard the passed isbn I don't know, if we get rid fo this check we can now check the db for the same isbn we passed This may be useful as we may want to see the biblio with the same isbn as long as number is different? This will make tests fail Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:50:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:50:21 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109825|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 113058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113058&action=edit Bug 26364: Adjust unit tests We shouldn't rely on knowing exactly which ISBNs we get, we should specifically check for what we do or don't expect. I believe we should return biblios that have the same isbn we passed, as it signlas we have another biblio in the catalog that matches the one we are on. To test: prove -v t/db_dependent/XISBN.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:52:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:52:10 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #19 from David Nind --- To test, I followed the test plans in comment #13, #15 and #18. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:54:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:54:09 +0000 Subject: [Koha-bugs] [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #10 from Fridolin SOMERS --- This is a bug report more than enhancement no ? Please backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 10:54:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 09:54:23 +0000 Subject: [Koha-bugs] [Bug 26936] sip2 allows the checkin the item was already checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26936 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME CC| |magnus at libriotech.no Status|NEW |RESOLVED --- Comment #1 from Magnus Enger --- This can be configured with the checked_in_ok setting in the SIP2 config file: https://wiki.koha-community.org/wiki/SIP2_configuration#checked_in_ok -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:04:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:04:10 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #28 from Jonathan Druart --- 1. Please provide documentation for the API 2. There is no error handling when the page is loaded. I first tried with D11 (which has the REST API broken) and the "loading..." was running forever, the table was loaded but without any checkboxes. Maybe we should not display anything in that case. 3. I am a bit concern that there is no "save" or "undo" button. If you click "Check all" or "Uncheck all", you may have lost your work! It's not blocker but worth noting it here. 4. There is no way to bookmark or share the URL to display a given table. That would have been useful. Is that something we could implement easily? 5. (In reply to Kyle M Hall from comment #0) > The current transfer limits editor works great for Koha instances with small > numbers of branches. However, for consortiums with dozens or even hundreds > of libraries, the editor does not work well or effectively. I've added around 30 libraries and it creates a huge table. I am not sure we are answering the need as the table is not readable easily if you are starting to scroll. Maybe it would have been useful to have "floating th"'s, which are always displayed when you scroll. Not blocker however, but feel free to submit if you think it would be useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:04:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:04:18 +0000 Subject: [Koha-bugs] [Bug 26633] Add advanced editor for transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:08:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:08:03 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #12 from Fridolin SOMERS --- Careful, class "shelvingloc" is used in a lot of places, see comment 7 And should we not remove patch adding
      ? "Bug 25462: Shelving location should be on a new line in holdings table" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:09:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:09:07 +0000 Subject: [Koha-bugs] [Bug 25886] libmojolicious-plugin-openapi-perl and libnet-oauth2-authorizationserver-perl unable to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25886 José Anjos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #16 from José Anjos --- I did it: $ echo 'deb http://debian.koha-community.org/koha stable main xenial' | sudo tee /etc/apt/sources.list.d/koha.list $ sudo apt-get update $ sudo apt-get install koha-common Then a message says that libjson-validator-perl libmojolicious-perl libmojolicious-plugin-openapi-perl were not upgraded. Now when I go to: koha/about.pl Ihave: Internal Server Error On Firefox Dev Tools I have: The character encoding of the plain text document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the file needs to be declared in the transfer protocol or file needs to use a byte order mark as an encoding signature. about.pl (In reply to Mason James from comment #15) > > please follow the official community instructions at... > https://wiki.koha-community.org/wiki/Koha_on_Debian > > 1.1.2.3 Support for Koha on older versions of Debian/Ubuntu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:10:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:10:28 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #23 from David Nind --- Patch no longer applies 8-(.. Applying: Bug 21301: (QA follow-up) Fix number of tests Using index info to reconstruct a base tree... M t/db_dependent/Circulation/issue.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation/issue.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation/issue.t error: Failed to merge in the changes. Patch failed at 0001 Bug 21301: (QA follow-up) Fix number of tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:14:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:14:29 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112947|0 |1 is obsolete| | Attachment #112948|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 113059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113059&action=edit Bug 25334: (QA follow-up) Update opac messaging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:14:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:14:33 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #15 from Jonathan Druart --- Created attachment 113060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113060&action=edit Bug 25334: (QA follow-up) Update overduerules.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:15:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:15:00 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart --- Fixed patch author. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:20:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:20:12 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95158|0 |1 is obsolete| | --- Comment #24 from Fridolin SOMERS --- Created attachment 113061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113061&action=edit Bug 21301: Remove patron informations in issues for GetRecords ILS-DI service Actually, the GetRecords service gives many information : bibliographic data (marcxml field) item data (items field) issue data (issues field) The issue data should not be sent by these service, its a privacy problem. Biblio title and author are redundant. This patch changes to use Koha::Checkouts to get issues informations with only the addition of item barcode. Test plan : 1) Enable ILS-DI webservice 2) Checkout an item 3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords&id={biblionumber} 4) Check the issues tag content Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:20:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:20:32 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95159|0 |1 is obsolete| | --- Comment #25 from Fridolin SOMERS --- Created attachment 113062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113062&action=edit Bug 21301: Remove patron informations in reserves for GetRecords ILS-DI service Actually, the GetRecords service gives many information : borrowernumber (reserves field) The issue data should not be sent by these service, its a privacy problem. Test plan : 1) Enable ILS-DI webservice 2) Place hold on an item 3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords&id={biblionumber} 4) Check the reserves tag content Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:20:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:20:43 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95178|0 |1 is obsolete| | --- Comment #26 from Fridolin SOMERS --- Created attachment 113063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113063&action=edit Bug 21301: (QA follow-up) Fix number of tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:20:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:20:56 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101818|0 |1 is obsolete| | --- Comment #27 from Fridolin SOMERS --- Created attachment 113064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113064&action=edit Bug 21301: (follow-up) Remove borrowernumber in issues for GetRecords ILS-DI service -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:21:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:21:19 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109646|0 |1 is obsolete| | --- Comment #28 from Fridolin SOMERS --- Created attachment 113065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113065&action=edit Bug 21301: add unit tests Run t/db_dependent/ILSDI_Services.t with and without previous patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:24:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:24:09 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #29 from Fridolin SOMERS --- trivial conflict on Bug 21301: (QA follow-up) Fix number of tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:25:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:25:02 +0000 Subject: [Koha-bugs] [Bug 26459] Allow sip_cli_emulator to handle cancelling holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26459 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:25:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:25:05 +0000 Subject: [Koha-bugs] [Bug 26459] Allow sip_cli_emulator to handle cancelling holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26459 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110071|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 113066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113066&action=edit Bug 26459: Add hold-mode option to sip_cli_emulator To test: 1 - Apply patch 2 - Restart all 3 - Place an item level hold for a patron via the staff client 4 - Cancel the hold using the sip_cli_emulator with hold-mode: - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --patron {cardnumber} --item {BARCODE} -m hold -l CPL --hold-mode - 5 - Run the sip_cli_emulator with no params 6 - Verify help text is understandable Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:33:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:33:50 +0000 Subject: [Koha-bugs] [Bug 26627] Print and confirming a hold can cause an infinite loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26627 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #8 from Joonas Kylmälä --- The fix here seems to have created another problem, it causes the button "Print slip, transfer, and confirm" to not do anything when clicked. In Javascript console I see Uncaught TypeError: this.form.barcode is undefined /cgi-bin/koha/circ/returns.pl:31317 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:38:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:38:55 +0000 Subject: [Koha-bugs] [Bug 26697] Make translation file for types and descriptions of charges consistent between OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26697 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112077|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 113067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113067&action=edit Bug 26697: Make account.inc consistent between staff and opac Test plan - Regression 1/ Login to the OPAC as a user with various account charges and payments. 2/ Navigate to the 'Your charges' page. 3/ Compare the display of the table before and after applying the patchset. They should match. Test plan - Sync 1/ Compare koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc with koha-tmpl/opac-tmpl/bootstrap/en/includes/accounts.inc. 2/ They files should match after the patch is applied. Test plan - Translation 1) ./translate update fr-CA 2) Open fr-CA-opac-bootstrap.po and translated this part msgid "" "%s %s %sPayment %sWriteoff %sForgiven %sCredit %sLost item fee refund " "%sRefund %s%s %s %s %s %sAccount creation fee %sAccount renewal fee %sLost " "item %sManual fee %sNew card %sFine %sLost item processing fee %sRental fee " "%sDaily rental fee %sRenewal of rental item %sRenewal of daily rental item " "%sHold fee %sHold waiting too long %s%s %s %s %s " 3) ./translate install fr-CA 4) Login to the OPAC as a patron with various charges 5) Check 'My charges' (in fr-CA) to confirm the translations have been picked up. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:39:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:39:11 +0000 Subject: [Koha-bugs] [Bug 26697] Make translation file for types and descriptions of charges consistent between OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26697 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:39:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:39:17 +0000 Subject: [Koha-bugs] [Bug 26697] Make translation file for types and descriptions of charges consistent between OPAC and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26697 --- Comment #15 from Martin Renvoize --- Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:43:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:43:07 +0000 Subject: [Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 --- Comment #75 from Julian Maurice --- (In reply to Jonathan Druart from comment #74) > Mason, Could you have a look at how hard/easy Locale::XGettext::TT2 can be > packaged (from 20.11 ideally)? Should it be packaged ? It is a dev-only dependency, so it won't be used in a production environment. Still better to have it as a deb package, but not required IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:43:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:43:30 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:43:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:43:35 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113061|0 |1 is obsolete| | --- Comment #30 from David Nind --- Created attachment 113068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113068&action=edit Bug 21301: Remove patron informations in issues for GetRecords ILS-DI service Actually, the GetRecords service gives many information : bibliographic data (marcxml field) item data (items field) issue data (issues field) The issue data should not be sent by these service, its a privacy problem. Biblio title and author are redundant. This patch changes to use Koha::Checkouts to get issues informations with only the addition of item barcode. Test plan : 1) Enable ILS-DI webservice 2) Checkout an item 3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords&id={biblionumber} 4) Check the issues tag content Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:43:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:43:39 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113062|0 |1 is obsolete| | --- Comment #31 from David Nind --- Created attachment 113069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113069&action=edit Bug 21301: Remove patron informations in reserves for GetRecords ILS-DI service Actually, the GetRecords service gives many information : borrowernumber (reserves field) The issue data should not be sent by these service, its a privacy problem. Test plan : 1) Enable ILS-DI webservice 2) Place hold on an item 3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords&id={biblionumber} 4) Check the reserves tag content Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:43:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:43:44 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113063|0 |1 is obsolete| | --- Comment #32 from David Nind --- Created attachment 113070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113070&action=edit Bug 21301: (QA follow-up) Fix number of tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:43:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:43:48 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113064|0 |1 is obsolete| | --- Comment #33 from David Nind --- Created attachment 113071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113071&action=edit Bug 21301: (follow-up) Remove borrowernumber in issues for GetRecords ILS-DI service Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:43:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:43:52 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113065|0 |1 is obsolete| | --- Comment #34 from David Nind --- Created attachment 113072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113072&action=edit Bug 21301: add unit tests Run t/db_dependent/ILSDI_Services.t with and without previous patches Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:45:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:45:19 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #21 from Jonathan Druart --- Won't it open the door to generate someone else's barcode (easily)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:49:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:49:58 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112410|0 |1 is obsolete| | --- Comment #109 from Andrew Isherwood --- Created attachment 113073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113073&action=edit Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - Add unseen_renewals_allowed to circulation_rules - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals Signed-off-by: Sally Healey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:50:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:50:02 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112411|0 |1 is obsolete| | --- Comment #110 from Andrew Isherwood --- Created attachment 113074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113074&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules Signed-off-by: Sally Healey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:50:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:50:06 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112412|0 |1 is obsolete| | --- Comment #111 from Andrew Isherwood --- Created attachment 113075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113075&action=edit Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. Signed-off-by: Sally Healey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:50:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:50:10 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112413|0 |1 is obsolete| | --- Comment #112 from Andrew Isherwood --- Created attachment 113076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113076&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals Signed-off-by: Sally Healey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:50:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:50:14 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112414|0 |1 is obsolete| | --- Comment #113 from Andrew Isherwood --- Created attachment 113077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113077&action=edit Bug 24083: (follow-up) Fix params to AddRenewal The merging of Bug 23051 has added a paramter that can be passed to C4::AddRenewal. This bug does also, so the offset of this bug's new paramter was wrong. This patch fixes it. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:50:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:50:18 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112415|0 |1 is obsolete| | --- Comment #114 from Andrew Isherwood --- Created attachment 113078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113078&action=edit Bug 24083: (follow-up) Respond to QA feedback This patch implements changes requested by Katrin in QA feedback (comment #38): - Fix QA script failures - Fix alter table column order mismatch - Use new convention for JS strings - Fix terminology Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:50:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:50:22 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112416|0 |1 is obsolete| | --- Comment #115 from Andrew Isherwood --- Created attachment 113079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113079&action=edit Bug 24083: (follow-up) Include SelfCheckInModule As highlighted by Katrin, the selfcheckin module was not aware of this work. This commits gives it awareness of the too_unseen renew error and the "seen" argument that can be passed to AddRenewal Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:50:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:50:26 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #116 from Andrew Isherwood --- Created attachment 113080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113080&action=edit Bug 24083: (follow-up) Squashed follow ups This squashed commit fixes: - a small error in the checkouts related JS - GetRenewCount now returns 6 values when a call to it succeeds, a failed call should also return the same number of values. This commit adds these additional values. - Some changes in issue.t had broken the tests for unseen renewals (the unseen tests were using variables that had been moved out of the tests' scope). - Also now using Koha::CirculationRules::set_rules to set circ rules rather than using SQL queries. - Fixed expected number of return values from GetRenewCount - Moved unseen tests in issue.t to the bottom of the file to remove the risk of interference with other test circ rules. - There was a real mess in C4/Circulation.pm due to a bad rebase back in February. Frankly it's a wonder anything worked at all. This commit fixes that problem and reinstates the correct patch for C4/Circulation.pm - Somehow I'd never noticed this before but the columns in smart-rules.tt were misaligned when UnseenRenewals was turned off. This was due to the display of a not being conditional when it should have been. This is now fixed. - This commit also fixes items 1 & 2 descibed by Katrin in comment #74 -> comment #76. - Fixed missing check for too_unseen in opac-user.tt, this test did used to exist but got lost during sizeable rebase a few weeks ago :-( - Added test for too_unseen to all AUTO_RENEWAL notice templates apart from de-DE (as previously requested by Katrin) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:51:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:51:07 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:51:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:51:15 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112418|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:51:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:51:19 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112420|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:51:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:51:20 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com, | |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:51:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:51:25 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:51:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:51:30 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112422|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:51:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:51:34 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112423|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:52:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:52:04 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112419|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:52:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:52:25 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #117 from Andrew Isherwood --- Hi Jonathan - squashed as requested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 11:55:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 10:55:00 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 --- Comment #3 from Fridolin SOMERS --- (In reply to David Cook from comment #2) > I'm not familiar with the plugin use on > intranet/cgi-bin/catalogue/detail.pl, but would an alternative be to > implement the plugin as an API route and then inject some Javascript into > OpacUserJS to insert the tab? > > I suppose the annoying part of doing that is injecting the Javascript > though... No need to inject, there is a plugin hook opac_js : https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/blob/450b145a09c358b0dc3eaa0ee97151643c1bbda6/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm#L252 And hook opac_head for CSS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:03:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:03:12 +0000 Subject: [Koha-bugs] [Bug 26627] Print and confirming a hold can cause an infinite loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26627 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:11:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:11:00 +0000 Subject: [Koha-bugs] [Bug 26745] Notice titles/subjects should support Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26745 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > A very unintentional side-effect of this patch has been to caught a bug in > SendAlerts, see bug 26935. > > # Failed test 'SendAlerts - claimissue' > # at t/db_dependent/Letters.t line 642. > C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute > failed: called with 2 bind variables when 1 are needed [for Statement > "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at > /kohadevbox/koha/C4/Letters.pm line 679 This comment was for bug 21898. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:11:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:11:14 +0000 Subject: [Koha-bugs] [Bug 21898] Add basket info available for ACQORDER In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #12 from Jonathan Druart --- (In reply to Jonathan Druart from comment #11) > There is a failing test, can you have a look, Martin? > > # Failed test 'SendAlerts - claimissue' > # at t/db_dependent/Letters.t line 642. > C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute > failed: called with 2 bind variables when 1 are needed [for Statement > "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=26] at > /kohadevbox/koha/C4/Letters.pm line 679 Fixed on bug 26935. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:14:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:14:47 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart --- (In reply to Owen Leonard from comment #13) > I wonder if the QA tool expects file ins /svc/* to be something other than > template files? Yes, it's a "bug" in qa-test-tools. Files in a path contained "/svc/" are considered perl files. You can ignore it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:15:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:15:21 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111979|0 |1 is obsolete| | --- Comment #147 from Martin Renvoize --- Created attachment 113081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113081&action=edit Bug 23091: Database update This patch updates the 'refund' circulation rule to be called 'lostreturn' and populates the value with 'refund' where appropriate. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:15:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:15:25 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111980|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize --- Created attachment 113082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113082&action=edit Bug 23091: Update unit test This patch updates the unit test for get_lostreturn_policy to reflect the rule_name and return code changes. Test plan: 1/ Read the code changes in t/db_dependant/Koha/CirculationRules and t/db_dependant/Koha/IssuingRules and confirm they make sense. 2/ Run the updated tests and ensure they pass. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:15:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:15:30 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111981|0 |1 is obsolete| | --- Comment #149 from Martin Renvoize --- Created attachment 113083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113083&action=edit Bug 23091: Add handling for new lostreturn rules This patch adds handing for the new values available for the lostreturn policy settings. * undef - Do nothing, leave fees and fines as they were at the point of lose. * refund - Refund the lost item fee only * charge - Refund the lost item fee and charge a fresh overdue fine dated for a return on the date the item is 'found' * restore - Refund the lost item fee and restore the original overdue fine (dated for a 'return' on the date the item was 'lost' Test plan 1/ apply patch 2/ updatedatabase, restart_all 3/ verify finesmode and CalculateFinesOnReturn and WhenLostChargeReplacementFee are on 4/ verify WhenLostForgiveFine is set to "Forgive" 5/ verify circ rules include fines 6/ set Default lost item fee refund on return policy to "Refund lost item charge" 7/ create 4 overdue checkouts that will incur fines 8/ run fines.pl 9/ confirm 4 items checked out with accruing fines 10/ confirm all 4 items have a replacement price Item 1 11/ mark the first item lost 12/ verify that fine is gone and lost fee has been charged 13/ check item in 14/ verify that lost fee is gone and overdue charge has not returned Item 2 15/ set Default lost item fee refund on return policy to "Refund lost item charge and charge new overdue fine" 16/ mark second item lost 17/ verify that fine is gone and lost fee has been charged 18/ check item in 19/ verify that lost fee is gone and a new overdue charge has been made Item 3 20/ set Default lost item fee refund on return policy to "Refund lost item charge and restore overdue fine" 21/ mark third item lost 22/ verify that fine is gone and lost fee has been charged 23/ check item in 24/ verify that lost fee is gone and the old overdue charge has been restored Item 4 25/ set Default lost item fee refund on return policy to "Leave lost item charge" 26/ mark fourth item lost 27/ verify that fine is gone and lost fee has been charged 28/ check item in 29/ verify that lost fee remains and the overdue charge is still gone Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:15:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:15:34 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111982|0 |1 is obsolete| | --- Comment #150 from Martin Renvoize --- Created attachment 113084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113084&action=edit Bug 23091: Add tests for _RestoreOverdueForLostAndFound This patch adds unit tests for the newly introduced _RestoreOverdueForLostAndFound method in C4::Circulation. Test plan 1/ Read the new tests added to t/db_dependent/Circuation.t to ensure they make sense 2/ Run the tests and verify they pass 3/ Signoff Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:15:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:15:39 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111983|0 |1 is obsolete| | --- Comment #151 from Martin Renvoize --- Created attachment 113085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113085&action=edit Bug 23091: Make relations more explicit This patch simply makes the queries built for the ->debits and ->credits relations in Koha::Account::Line more explicit. Test plan 1/ Ensure tests continue to pass 2/ Run tests with DBIC_TRACE=1 DBIC_TRACE_PROFILE=console and note that the related queries not include 'credit.' and 'debit.' as appropriate. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:15:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:15:43 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111984|0 |1 is obsolete| | --- Comment #152 from Martin Renvoize --- Created attachment 113086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113086&action=edit Bug 23091: Add template handling for new messages This patch adds handling for the display of the two new messages added by this patchset in the returns screen. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:15:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:15:48 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111985|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize --- Created attachment 113087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113087&action=edit Bug 23091: Move _Restore to Koha::Item store trigger Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:15:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:15:53 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111986|0 |1 is obsolete| | --- Comment #154 from Martin Renvoize --- Created attachment 113088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113088&action=edit Bug 23091: Unit Tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:15:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:15:57 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111987|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize --- Created attachment 113089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113089&action=edit Bug 23091: Add tests for \->credits and \->debits Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:16:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:16:02 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111988|0 |1 is obsolete| | --- Comment #156 from Martin Renvoize --- Created attachment 113090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113090&action=edit Bug 23091: Simplify tests by turning off AccountAutoReconcile Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:16:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:16:07 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111989|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize --- Created attachment 113091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113091&action=edit Bug 23091: (QA follow-up) POD fixes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:16:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:16:18 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #14) > (In reply to Owen Leonard from comment #13) > > I wonder if the QA tool expects file ins /svc/* to be something other than > > template files? > > Yes, it's a "bug" in qa-test-tools. Files in a path contained "/svc/" are > considered perl files. You can ignore it. See https://gitlab.com/koha-community/qa-test-tools/-/issues/43 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:16:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:16:37 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #158 from Martin Renvoize --- Rebased :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:21:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:21:03 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:21:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:21:15 +0000 Subject: [Koha-bugs] [Bug 26925] Pickup library list should be in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:24:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:24:52 +0000 Subject: [Koha-bugs] [Bug 26913] More than one title element on homepage when news item is displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26913 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Hi Phil, I'm afraid I'm also struggling to replicate this.. do you have an example site we could look at displaying the issue? Feel free to reach out to me directly if your worried about sharing the URL more publically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:37:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:37:03 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #13 from Martin Renvoize --- Created attachment 113092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113092&action=edit Bug 25462: (follow-up) Remove
      as it is no longer needed Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:38:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:38:57 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #14 from Martin Renvoize --- I've swung back around to this to do a bit more due diligence.. I've checked all pages with the related class and confirmed that they all look good with the updated styling... I've also added a followup to revert the first patch (added as a followup to retain David's contribution, but I'll leave it up to the RM to decide whether to squash/remove entirely the pair). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:40:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:40:42 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 --- Comment #4 from Mark Hofstetter --- OK I really like the idea to expose the data via an API route so would you change the opac-detail.tt file, or add the whole tab via the js? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:41:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:41:22 +0000 Subject: [Koha-bugs] [Bug 26627] Print and confirming a hold can cause an infinite loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26627 --- Comment #9 from Kyle M Hall --- Created attachment 113093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113093&action=edit Bug 26627: (QA follow-up) Remove barcode input by id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:48:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:48:23 +0000 Subject: [Koha-bugs] [Bug 26594] Patrons merge problem with restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26594 --- Comment #15 from Kyle M Hall --- Created attachment 113094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113094&action=edit Bug 26594: (QA follow-up) Make _UpdateBorrowerDebarmentFlags a public method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:52:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:52:06 +0000 Subject: [Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112978|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 113095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113095&action=edit Bug 26915: Fix FinePaymentAutoPopup behaviour The behaviour of the syspref FinePaymentAutoPopup is broken, the popup explodes with Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 It has been broken by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test which modified the return value of Koha::Account->pay (from $payment_id to a hashref) Test plan: - To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) => Without the patch you get the error => With the patch applied the popup is correctly displayed Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:52:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:52:54 +0000 Subject: [Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- You beat me to this one Jonathan, thanks! :). I've grepped around to see if there are any other cases and can't spot any. Fix works as expected, no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 12:55:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 11:55:40 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:03:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 12:03:11 +0000 Subject: [Koha-bugs] [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #11 from Katrin Fischer --- (In reply to Fridolin SOMERS from comment #10) > This is a bug report more than enhancement no ? > Please backport. Please change Importance in this case. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:06:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 12:06:10 +0000 Subject: [Koha-bugs] [Bug 26913] More than one title element on homepage when news item is displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26913 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:11:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 12:11:25 +0000 Subject: [Koha-bugs] [Bug 26125] In 'Patron search' tab link should lead to patron details instead of checkout screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26125 --- Comment #7 from didier --- Hi > bug doesn't exist in 19.11.x, not backported As a matter of fact it does. You have to enable PatronAutoComplete and use the auto completion menu not the 'search' button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:27:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 12:27:27 +0000 Subject: [Koha-bugs] [Bug 25954] Header search forms should be labeled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Owen Leonard --- (In reply to Katrin Fischer from comment #14) > With the patch applied some of the labels jump in front of the search field > while others remain above Could you look at this again? The problem you describe would happen if the CSS hasn't been regenerated. I know you said you did, but I'm hoping it was a glitch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:41:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 12:41:27 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- I feel like instead of introducing a further call to set plugins_enabled and passing it to the template we should just check for the presence of the 'plugins' variable directly in the template instead. Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:41:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 12:41:41 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:45:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 12:45:06 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112969|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 113096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113096&action=edit Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back! Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:45:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 12:45:10 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 --- Comment #6 from Martin Renvoize --- Created attachment 113097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113097&action=edit Bug 26908: (follow-up) Alter template check This alters the template check to use the presence of the plugins arrayref rather than requiring a second call to check for plugins_enabled. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:47:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 12:47:10 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Minor tidy up followup added.. Works well, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:51:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 12:51:52 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112968|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 113098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113098&action=edit Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ rules UPDATE: changed queries to not touch * values To test: 1 - Checkout 19.11.x and reset_all 2 - Add a new patron category, itemtype, and branch to your system 3 - Create issuing rules using thise 3 values, and others 4 - Delete the new category, itemtype and branch 5 - Checkout master 6 - Restart_all 7 - updatedatabase 8 - you get errors 9 - repeat 1-5 10 - apply patch 11 - restart_all 12 - updatedatabase 13 - no errors! Signed-off-by: Nick Clemens Signed-off-by: Andrew Fuerste-Henry Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 13:52:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 12:52:26 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Good catch guys, logic is sound and testing it locally passed. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:04:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:04:55 +0000 Subject: [Koha-bugs] [Bug 26937] New: Add an optional delay to the CheckPrevCheckout system preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Bug ID: 26937 Summary: Add an optional delay to the CheckPrevCheckout system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The CheckPrevCheckout system preference allows to check a borrower's checkout history to see if the current item has been checked out before. It would be nice to be able to specify the maximum number of days since the last checkin that will trigger CheckPrevCheckout's warning. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:05:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:05:53 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99629|0 |1 is obsolete| | --- Comment #18 from Emmi Takkinen --- Created attachment 113099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113099&action=edit Bug 12133: Fix issues with modifying child patron and adding guarantors Child patrons couldn't be modified when guarantor was patron due missing guarantor_id value. Also if multiple guarantors were added one could easily add child patron as a guarantor. This patch adds Instead of one guarantor id all new and existing guarantor ids are checked in case of child patron. To test: 1. Add child patron with syspref ChildNeedsGuarantor and GuarantorNeedsToBePatron on. 2. Add two guarantors for the patron, first one should be an adult patron and second a child. 3. Save patron. => Error "A guarantor cannot be a guarantee." should be raised but isn't. 4. Modify patron and save. => Error "Child needs guarantor" is raised even if (valid) guarantor exists. 5. Apply patch. 6. Repeat steps 1 to 4. => This time while saving a new patron error "A guarantor cannot be a guarantee." is raised but modifying is successful. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:06:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:06:33 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #19 from Emmi Takkinen --- Finally had time to look at this again and noticed that the latest patch didn't take into account possible multiple guarantor ids. It fixed issue with modifying but one could add child patron as guarantor. Since these stem up from same a problem, missing guarantor ids, I obsoleted the latest patch and provided a new one which fixes both of these issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:07:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:07:23 +0000 Subject: [Koha-bugs] [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #12 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #11) > (In reply to Fridolin SOMERS from comment #10) > > This is a bug report more than enhancement no ? > > Please backport. > > Please change Importance in this case. :) Ok cool I was waiting the assignee to agree ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:07:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:07:53 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #20 from Emmi Takkinen --- Created attachment 113100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113100&action=edit Bug 12133: Enforce guarantor restrictions on Koha::Patron->store() This patch adds checks for new guarantor requirements to Koha::Patron->store(). If requirements aren't met exception is raised. To test prove t/db_dependent/Koha/Patron.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:08:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:08:04 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:08:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:08:04 +0000 Subject: [Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 --- Comment #1 from Matthias Meusburger --- Created attachment 113101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113101&action=edit Bug 26937: Add an optional delay to the CheckPrevCheckout syspref. The CheckPrevCheckout allows to check a borrower's checkout history to see if the current item has been checked out before. This patch adds an optional syspref: CheckPrevCheckoutDelay It allows to specify the maximum number of days since the last checkin that will trigger CheckPrevCheckout's warning. Test plan: - Apply the patch. - Set CheckPrevCheckout to "Do" and CheckPrevCheckoutDelay to n. - Checkout and check-in an item for a patron. - Try to checkout the same item. - Check that you have a warning: "Patron has previously checked out this title: Check out anyway?" - Update the returndate column from the old_issues table to have a returndate older than n days ago. - Try to checkout the same item. - Check that you don't have the warning. - Prove t/db_dependent/Patron/Borrower_PrevCheckout.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:08:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:08:19 +0000 Subject: [Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:08:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:08:25 +0000 Subject: [Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:11:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:11:52 +0000 Subject: [Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113101|0 |1 is obsolete| | --- Comment #2 from Matthias Meusburger --- Created attachment 113102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113102&action=edit Bug 26937: Add an optional delay to the CheckPrevCheckout syspref. The CheckPrevCheckout allows to check a borrower's checkout history to see if the current item has been checked out before. This patch adds an optional syspref: CheckPrevCheckoutDelay It allows to specify the maximum number of days since the last checkin that will trigger CheckPrevCheckout's warning. Test plan: - Apply the patch. - Set CheckPrevCheckout to "Do" and CheckPrevCheckoutDelay to n. - Checkout and check-in an item for a patron. - Try to checkout the same item. - Check that you have a warning: "Patron has previously checked out this title: Check out anyway?" - Update the returndate column from the old_issues table to have a returndate older than n days ago. - Try to checkout the same item. - Check that you don't have the warning. - Prove t/db_dependent/Patron/Borrower_PrevCheckout.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:13:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:13:41 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #17 from Jonathan Druart --- Created attachment 113103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113103&action=edit Bug 25334: MTT is itiva not talkingtech -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:15:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:15:29 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112946|0 |1 is obsolete| | Attachment #113059|0 |1 is obsolete| | Attachment #113060|0 |1 is obsolete| | Attachment #113103|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 113104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113104&action=edit Bug 25334: Add generic 'phone' message transport type As bug 25333 changed the 'phone' transport type to 'talkingtech', we can now re-add 'phone' as a transport type again, and allow it to behave and support the same notices as the email transport type. Test Plan; 1) Apply this patch 2) Run updatedatabase 3) Restart all the things! 4) Disable TalkingTechItivaPhoneNotificationi if enabled 5) Enable new PhoneNotification system preference 6) Go to a patron's messaging preferences, not you can select the 'phone' option for all the same notices as the 'email' option 7) Enable the phone option for all the message types 8) Browser to the Notices and slips editor 9) Add a phone notice version for each notice you wish to test 10) Test some notices ( CHECKIN, CHECKOUT, etc ) 11) Notices should show in the patron's messages as 'phone' notices Signed-off-by: Christopher Zorn Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:15:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:15:33 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #19 from Jonathan Druart --- Created attachment 113105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113105&action=edit Bug 25334: (QA follow-up) Update opac messaging Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:15:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:15:36 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #20 from Jonathan Druart --- Created attachment 113106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113106&action=edit Bug 25334: (QA follow-up) Update overduerules.tt Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:15:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:15:39 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #21 from Jonathan Druart --- Created attachment 113107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113107&action=edit Bug 25334: MTT is itiva not talkingtech -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:16:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:16:46 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #22 from Jonathan Druart --- Added missing signed-off-by line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:19:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:19:03 +0000 Subject: [Koha-bugs] [Bug 24412] Attach waiting hold to desk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #111 from Nicolas Legrand --- Created attachment 113108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113108&action=edit Bug 24412 (follow-up): Fix POD Koha::Desk and not Koha::Library... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:19:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:19:07 +0000 Subject: [Koha-bugs] [Bug 24412] Attach waiting hold to desk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #112 from Nicolas Legrand --- Created attachment 113109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113109&action=edit Bug 24412: (follow-up) prevent request.pl from failing When no desk is defined request.pl returns an internal server error. Check a desk is defined before asking for reservation deskname. Plan test: 1. log in with a library with no desk 2. check in a reserved book so it'll be switch to “waiting reserve” 3. go to the book notice and click the Holds tab (request.pl page) 4. boum 5. apply patch, restart plack 6. refresh page 7. now loading properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:30:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:30:54 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112961|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 113110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113110&action=edit Bug 26727: Fix

      appearing in the templates The self-closing p is not valid in HTML5: Error: Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag. To test: 1) - Activate Article requests - Search for a record to place an article request on in staff - Look up the patron - Verify the article request form looks ok 2) - Search for a list of patrons - Check 2 patrons and merge them using the button above the list - Verify the distance between the button and the table looks ok 3) - Create a new MARC modification template - Create a new action - Verify the distances between the first and second line of form elements looks ok 4) - Place a hold in staff - Click on the Suspend link in the holds table (not below) - Verify the modal looks ok Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:30:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:30:58 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112962|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 113111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113111&action=edit Bug 26727: (follow-up) More markup corrections This patch makes more markup changes to the templates previously modified in order to try to arrive at some agreeable solutions. - In the value_builder EXAMPLE template, the

      is unnecessary and is removed. Also removed is the script "type" attribute and obsolete CDATA markers. - In the article request template an unnecessary

      is removed. - In the merge patrons template the submit button is now in a

      as is consistent with other forms. - In the MARC modifications template I've added
      s around each "line" in the form to add the line break, along with some CSS to add margins. - The submit button is now inside a
      and the "Cancel" link now has the "cancel" class. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:31:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:31:57 +0000 Subject: [Koha-bugs] [Bug 26727] Fix

      appearing in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize --- Great teamwork here guys and gals, thanks very very much. Passing QA Note: This got me wondering whether there was a way we could run one of these validators as part of the test suit regularly... food for thought -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:37:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:37:37 +0000 Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 didier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:37:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:37:41 +0000 Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 didier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112520|0 |1 is obsolete| | --- Comment #11 from didier --- Created attachment 113112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113112&action=edit Bug 22352: lists sent by mail, print location description For patrons location codes aren't very useful, replace them with their descriptions as defined in authorised values. For staff add descriptions. 1) Go to lists in Opac interface 2) Choose a list and send it at one of your emails 3) In the sent mail, watch the infos below the “Item” mention, location codes are displayed 4) Apply patch 5) Redo 1) and 2) 6) Location descriptions are displayed 7) Do the same with staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:41:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:41:02 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 --- Comment #34 from Jonathan Druart --- Created attachment 113113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113113&action=edit Bug 24603: Adjust permissions for cancel-charge.pl members/cancel-charge.pl should have the same permissions check than boraccount (borrowers => edit_borrowers was missing) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:41:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:41:05 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 --- Comment #35 from Jonathan Druart --- Created attachment 113114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113114&action=edit Bug 24603: Simplify tests using TestBuilder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:43:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:43:26 +0000 Subject: [Koha-bugs] [Bug 26938] New: Prevent flash of unstyled content on sales table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Bug ID: 26938 Summary: Prevent flash of unstyled content on sales table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The sales table in the register summary page contains some JSON formatted data for the DataTable. This content flashes on page load whilst DataTables is still loading and is unsightly.. we should delay the view of the table until DataTables has taken care of make it pretty ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:43:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:43:39 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 [Bug 26172] Add a cashup summary view (with option to print) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:43:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:43:39 +0000 Subject: [Koha-bugs] [Bug 26172] Add a cashup summary view (with option to print) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 [Bug 26938] Prevent flash of unstyled content on sales table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:44:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:44:01 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 --- Comment #36 from Jonathan Druart --- Comment on attachment 113049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113049 Bug 24603: (follow-up) Update to double entry accounting Review of attachment 113049: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24603&attachment=113049) ----------------------------------------------------------------- ::: Koha/Account/Line.pm @@ +324,4 @@ > } > > + # Check for mandatory parameters > + my @mandatory = ( 'staff_id', 'branch' ); Should not be "branch", but "branchcode" I'd say. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:46:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:46:57 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:47:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:47:25 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 --- Comment #1 from Martin Renvoize --- Created attachment 113115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113115&action=edit Bug 26938: Prevent flash of unstyled sales table On the registers page the table has come complex data structures embedded to allow for all the functionality we bring into the datatable. We should hide the table on page load and only display it at DataTables init time once the weird content has been beautified by DataTables. Test plan 1/ Enable 'UseCashRegisters' and 'EnablePointOfSale' 2/ Add a cash register and make some transactions against it. 3/ Navigate to the 'Register details' page 4/ Note that some 'funky' JSON strings appear in the table briefly before it is restyled when DataTables loads. 5/ Apply the patch 6/ Rebuild the CSS from the SCSS files 7/ Reload the page (hard reload to get the CSS changes) 8/ Note that the table now only appears once the nice formatting that DataTables adds is applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:47:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:47:42 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:47:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:47:49 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:47:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:47:54 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:49:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:49:35 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:52:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:52:01 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:52:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:52:01 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 [Bug 26938] Prevent flash of unstyled content on sales table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:58:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:58:01 +0000 Subject: [Koha-bugs] [Bug 26939] New: Account payment_type in the cash register details page should use description instead of code. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 Bug ID: 26939 Summary: Account payment_type in the cash register details page should use description instead of code. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In the cash register summary page the payment type appears as it's underlying code.. it should appear as the associated description instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:58:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:58:26 +0000 Subject: [Koha-bugs] [Bug 26939] Account payment_type in the cash register details page should use description instead of code. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Depends on| |26938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 [Bug 26938] Prevent flash of unstyled content on sales table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:58:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:58:26 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 [Bug 26939] Account payment_type in the cash register details page should use description instead of code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:58:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:58:26 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 [Bug 26939] Account payment_type in the cash register details page should use description instead of code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:58:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:58:39 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:58:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:58:39 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26938 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 [Bug 26938] Prevent flash of unstyled content on sales table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:58:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:58:43 +0000 Subject: [Koha-bugs] [Bug 24412] Attach waiting hold to desk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #113 from Nicolas Legrand --- Created attachment 113116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113116&action=edit Bug 24412: (follow-up) prevent js injection Some js variables are not properly escaped and can be executed if containing javascript. 1. have some waiting reserve attached to a desk 2. change this desk name to : 3. go to user's checkout page (circulation.pl) and click on the Hold(s) tab 4. you should see some popup with a ❤ in it. 5. apply patch and refresh page 6. now you should see the desk name printed properly in the page: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 14:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 13:58:49 +0000 Subject: [Koha-bugs] [Bug 26939] Account payment_type in the cash register details page should use description instead of code. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:01:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:01:08 +0000 Subject: [Koha-bugs] [Bug 26940] New: debarred comment in borrowers table is lost on patron modifications in memberentry.pl page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26940 Bug ID: 26940 Summary: debarred comment in borrowers table is lost on patron modifications in memberentry.pl page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: didier.gautheron at biblibre.com Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi Debarred comment is copied in borrowers table but it's set to an empty string on a patron is modified in memberentry. In my understanding AddDebarrement and DelDebarment already properly update debarredcomment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:01:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:01:29 +0000 Subject: [Koha-bugs] [Bug 26939] Account payment_type in the cash register details page should use description instead of code. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 --- Comment #1 from Martin Renvoize --- Created attachment 113117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113117&action=edit Bug 26939: Use AV description in sales table display Content should use the description rather than the code Test plan 1/ Enable 'UseCashRegisters' 2/ Make some payments against a cash register 3/ Navigate to the cash register summary page via tools > cashup registers > register name 4/ Note that the payment type you selected at payment time appears as the code of the authorized value as aposed to the description. 5/ Apply patch 6/ Refresh page 7/ The payment type should now contain the description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:02:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:02:51 +0000 Subject: [Koha-bugs] [Bug 26939] Account payment_type in the cash register details page should use description instead of code. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Keywords| |Academy Severity|enhancement |minor Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:03:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:03:02 +0000 Subject: [Koha-bugs] [Bug 26939] Account payment_type in the cash register details page should use description instead of code. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:03:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:03:48 +0000 Subject: [Koha-bugs] [Bug 24483] When batch deleting patrons, report who was not deleted and why In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24483 --- Comment #4 from Jonathan Druart --- I would suggest to implement bug 26170 first. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:04:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:04:06 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #42 from Jonathan Druart --- Having this code into master won't help anything: it will have to be rebuilt as it cannot be used as a good base. I am willing to push this patchset as it, given the low bug number (but not sure it's a good argument...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:04:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:04:48 +0000 Subject: [Koha-bugs] [Bug 26540] Issue Credit with Cash Registers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:04:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:04:52 +0000 Subject: [Koha-bugs] [Bug 26540] Issue Credit with Cash Registers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:06:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:06:55 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 --- Comment #37 from Jonathan Druart --- + # Make sure it has not be paid yet + return if $self->amount != $self->amountoutstanding; Won't this fail when comparing floats? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:09:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:09:35 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #38 from Jonathan Druart --- Julian, can you review the last 2 patches and answer the last 2 comments please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:11:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:11:06 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at outlook.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:18:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:18:51 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:18:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:18:54 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:20:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:20:45 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #43 from Jonathan Druart --- There is a test failing however: # Failed test 'Patron not found' # at t/db_dependent/api/v1/patrons.t line 423. # got: '500' # expected: '404' And a test missing to cover the change from the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:21:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:21:44 +0000 Subject: [Koha-bugs] [Bug 24412] Attach waiting hold to desk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #114 from Nicolas Legrand --- (In reply to Jonathan Druart from comment #109) [...] > > 4. I am not sure about the desk_id parameter we passed to > Koha::Hold->set_waiting. > We could also set it from ModReserveAffect, what's the benefit of this > approach? > > Failing QA for 1, 2, 3. I tried to address 1, 2, 3, a big thanks for spotting those. Especially 3... > 4 is for discussion. I'm a bit ashamed to say I don't really know. It seemed to me logical at the time. I'd say that if you think the day someone rewrite ModReserveAffect as a Koha::Hold method the desk attachment should go in this method, then I'll put it under set_waiting(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:22:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:22:05 +0000 Subject: [Koha-bugs] [Bug 24412] Attach waiting hold to desk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:22:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:22:13 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 113118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113118&action=edit Bug 26935: Don't use basket for claimacquisition and claimissues Incorrect basketid is sent for claimacquisition and claimissues. The basket info are not used in the default template of these notices, but if it is used, a wrong basket may be passed to generate the notice. This has been caught by a test failure after bug 26745. # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at /kohadevbox/koha/C4/Letters.pm line 679 This is a quick patch to fix the failing test, but more work would needed. We are removing the basket info from those 2 notices and keeping it only for orderacquisition. Technically: the $externalid is coming from the parameter list of SendAlerts, but it is a basketno only for orderacquisition. We must not pass it for other notices. Test plan: Confirm that the failing test is now passing and that the changes make sense. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:23:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:23:43 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #44 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #42) > Having this code into master won't help anything: it will have to be rebuilt > as it cannot be used as a good base. > > I am willing to push this patchset as it, given the low bug number (but not > sure it's a good argument...) The argument is, this is a bugfix. And refactoring things the way they are discussing is a good path forward. But it won't happen in stable for a while. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:14 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:16 +0000 Subject: [Koha-bugs] [Bug 25334] Add generic 'phone' message transport type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25334 --- Comment #23 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:18 +0000 Subject: [Koha-bugs] [Bug 25650] Add location and itype descriptions in ILS-DI GetRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25650 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:19 +0000 Subject: [Koha-bugs] [Bug 25650] Add location and itype descriptions in ILS-DI GetRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25650 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:21 +0000 Subject: [Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:23 +0000 Subject: [Koha-bugs] [Bug 26148] OpenLibrary "Preview" link target is unclear to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:24 +0000 Subject: [Koha-bugs] [Bug 26172] Add a cashup summary view (with option to print) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:26 +0000 Subject: [Koha-bugs] [Bug 26172] Add a cashup summary view (with option to print) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #50 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:28 +0000 Subject: [Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:30 +0000 Subject: [Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:32 +0000 Subject: [Koha-bugs] [Bug 26584] Remove unused C4::Acquisition::CloseBasket function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:34 +0000 Subject: [Koha-bugs] [Bug 26584] Remove unused C4::Acquisition::CloseBasket function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:36 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:37 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:39 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:41 +0000 Subject: [Koha-bugs] [Bug 26911] Update for 18936 can cause data loss if constraints are violated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26911 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:43 +0000 Subject: [Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:45 +0000 Subject: [Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:46 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:25:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:25:48 +0000 Subject: [Koha-bugs] [Bug 26935] Incorrect basketid sent for claimacquisition and claimissues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:28:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:28:08 +0000 Subject: [Koha-bugs] [Bug 24412] Attach waiting hold to desk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #115 from Jonathan Druart --- Thanks Nicolas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:35:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:35:53 +0000 Subject: [Koha-bugs] [Bug 17473] Permission for voiding payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:39:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:39:09 +0000 Subject: [Koha-bugs] [Bug 26940] debarred comment in borrowers table is lost on patron modifications in memberentry.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26940 didier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:39:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:39:12 +0000 Subject: [Koha-bugs] [Bug 26940] debarred comment in borrowers table is lost on patron modifications in memberentry.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26940 --- Comment #1 from didier --- Created attachment 113119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113119&action=edit Bug 26940: don't reset debarredcomment on patron update Test plan: 1) Create a patron 2) In koha/members/moremember.pl add a manual restriction, with comment foobar 3) try to checkout, you have a message like Restricted: Patron's account is restricted with the explanation: foobar 4) Got to Edit patron, save 5) try to checkout, foobar is no more Restricted: Patron's account is restricted with the explanation: 6) Apply patch 7) Redo 1-4 8) try to checkout, foobar is there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:47:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:47:29 +0000 Subject: [Koha-bugs] [Bug 26941] New: Missing OPAC password recovery error messages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 Bug ID: 26941 Summary: Missing OPAC password recovery error messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In OPAC password recovery perl opac/opac-password-recovery.pl there are some error codes not in Template koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:47:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:47:41 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8753 Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 [Bug 8753] Add forgot password link to OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:47:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:47:41 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 [Bug 26941] Missing OPAC password recovery error messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:51:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:51:59 +0000 Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108836|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 113120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113120&action=edit Bug 24533: Switch to aDataSort for multi-column sorting This patch adds aDataSort configurations for each sortable column such that we always maintain the group sorting primarily and apply a secondary sort using the column in question. When sorting by due date you are much more likely to want the true date sorting without forcing a primary sort on the grouping column. We achieve that by removing the primary sort on checkout date and disable rowGrouping in such a case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:52:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:52:11 +0000 Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 --- Comment #8 from Martin Renvoize --- Rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:53:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:53:00 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #45 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #43) > There is a test failing however: > > # Failed test 'Patron not found' > # at t/db_dependent/api/v1/patrons.t line 423. > # got: '500' > # expected: '404' > > > And a test missing to cover the change from the last patch. BTW: I love tests :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:56:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:56:58 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #46 from Tomás Cohen Arazi --- Created attachment 113121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113121&action=edit Bug 14708: (QA follow-up) Add tests This patch adds tests for the change. It also simplifies the delete() method structure a bit. It fixes the error 500 the tests were raising. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! The new behaviour (code 403) is tested! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 15:57:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 14:57:20 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:01:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:01:15 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:01:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:01:18 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 --- Comment #1 from Fridolin SOMERS --- Created attachment 113122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113122&action=edit Bug 26941: Fix OPAC password recovery error messages In OPAC password recovery perl opac/opac-password-recovery.pl there are some error codes not in Template koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt This patch fixes several bugs: - typo in 'use Koha::Patrons' defined twice => 'use Koha::Patron' - remove vars $errTooManyEmailFound $errBadEmail, not used in any template - add in template text for error 'errNoBorrowerEmail' 1) Create a patron A with login but no email 2) Create a patron B with login and valid email 3) Go to system preferences set 'OpacResetPassword' to ON 4) Make sure that OpacPasswordChange is also ON 5) Go to 'Forgot your password' in OPAC 6) Enter login if patron A and save => You get message 'This account has no email address we can send the email to.' 7) Enter login if patron B and save => Password recovery is send, no error message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:04:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:04:35 +0000 Subject: [Koha-bugs] [Bug 26940] debarred comment in borrowers table is lost on patron modifications in memberentry.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26940 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:04:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:04:38 +0000 Subject: [Koha-bugs] [Bug 26940] debarred comment in borrowers table is lost on patron modifications in memberentry.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26940 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113119|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 113123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113123&action=edit Bug 26940: don't reset debarredcomment on patron update Test plan: 1) Create a patron 2) In koha/members/moremember.pl add a manual restriction, with comment foobar 3) try to checkout, you have a message like Restricted: Patron's account is restricted with the explanation: foobar 4) Got to Edit patron, save 5) try to checkout, foobar is no more Restricted: Patron's account is restricted with the explanation: 6) Apply patch 7) Redo 1-4 8) try to checkout, foobar is there. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:08:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:08:49 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:08:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:08:52 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 --- Comment #2 from Jonathan Druart --- Created attachment 113124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113124&action=edit Bug 26921: Don't generate an invalid custom cover image if the url cannot be generated In case a custom cover image url is used to generate the cover image of bibliographic records, we should not build one if the record does not have the necessary data. For instance if you have CustomCoverImagesURL set to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpb and a biblio does not have the isbn defined, we should not generate and empty image (empty or invalid src) Test plan: 0. Set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpb Enable CustomCoverImages and OPACCustomCoverImages To highlight the issue you should disable LocalCoverImages and OPACLocalCoverImages. 1. Make sure you have some of your bibliographic records with a valid isbn 2. Make sure you have at least 1 bibliographic record without an isbn set 3. Visit the search result and detail views (OPAC and staff interfaces) => Without this patch you should see a "Cover image" link, and an empty block/div on the detail page => With this patch applied you should only see images when the url can be generated Note that the problem will persist if the isbn is not valid (ie. no image is generated) Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:09:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:09:07 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22445 | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:09:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:09:07 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26921 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:09:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:09:21 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:09:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:09:48 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Tomás Cohen Arazi --- You should only include Koha::Patrons (once, of course hehe). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:29:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:29:04 +0000 Subject: [Koha-bugs] [Bug 16696] Rename "Publisher" on detail and result lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16696 --- Comment #13 from Jonathan Druart --- Created attachment 113125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113125&action=edit Bug 16696: Fix search_utf8.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 16:29:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 15:29:51 +0000 Subject: [Koha-bugs] [Bug 16696] Rename "Publisher" on detail and result lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16696 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > Created attachment 113125 [details] [review] > Bug 16696: Fix search_utf8.t Patch pushed to master for 20.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:03:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 16:03:26 +0000 Subject: [Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor sections separate on patron entry form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 didier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron at biblibre.c | |om --- Comment #22 from didier --- Hi, Is it possible to backport this one to 19.11? It's really confusing staff members and I think I have a working patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:10:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 16:10:53 +0000 Subject: [Koha-bugs] [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #13 from Frédéric Demians --- Thks Fridolin. I agree with you. It could be backported down to 19.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:11:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 16:11:59 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 --- Comment #39 from Julian Maurice --- (In reply to Jonathan Druart from comment #37) > + # Make sure it has not be paid yet > + return if $self->amount != $self->amountoutstanding; > > Won't this fail when comparing floats? I think we should be safe, as they're stored as DECIMAL (a fixed-point type, not floating-point), and the initial value of those two columns are exactly the same. So when they come from the database they should still be equal, unless a payment have been made. (In reply to Jonathan Druart from comment #36) > Should not be "branch", but "branchcode" I'd say. I think that's a question for Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 17:57:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 16:57:41 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #62 from Séverine Queune --- Now I test it one more time, I noticed a few things... Unexpected characters like '' can't be ignored (we've got plenty of those in our titles because of some ugly imported datas...) I now most of devs won't agree with me, but I think it could be great if this feature finally doesn't ignore accents. For example, the word 'Thé' in French means tea and if I have a subscription beginning with it ('Thé ou café ?' for instance), I don't want it to be ignored. The same for A and À. I also have a question about sorting a title like 'À l'abordage !' or 'À l'ombre de mon arbre' : if i set the syspref to ignore both à and l' , should the 2 articles be ignored or only the first one ? For now, only the first is ignores. Except these 2 points, this patch is great and works as expected ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 18:00:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 17:00:08 +0000 Subject: [Koha-bugs] [Bug 17120] Specify number of rows per page in report and initial run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17120 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- +1, this would be handy when one has a report that consistently gives, say, 24 results. It gets really tiresome to have to expand the results each time the report runs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 18:33:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 17:33:09 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 18:33:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 17:33:13 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 --- Comment #115 from Lari Taskula --- Created attachment 113126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113126&action=edit Bug 18595: (follow-up) Catch message preference exceptions in OPAC This patch handles message preference exceptions in OPAC messaging template instead of the usual white "Internal Server Error" screen. To test: 0. This test plan assumes you have a default Koha installation that adds message attributes and transports from installer/data/mysql/mandatory/sample_notices_message_attributes.sql and installer/data/mysql/mandatory/sample_notices_message_transports.sql 1. Open developer tools, select console and run the following command: $('#email1').val('non-existing message transport type').prop('checked', true); $('form[name=opacmessaging]').submit(); Observe error: Message transport type non-existing message transport type does not exist. 2. Open developer tools, select console and run the following command: $($('select[name="2-DAYS"] option')[0]).attr('value', 31); $('form[name=opacmessaging]').submit(); Observe error: Days in advance selection is out of range. The value must be between 0 and 30. 3. Run SQL command: delete from message_transports where message_attribute_id=1 and is_digest=0 \ and message_transport_type='email'; Open developer tools, select console and run the following command: $('#digest1').prop('checked', false); $('#forcedigest1').remove(); $('form[name=opacmessaging]').submit(); Observe error: Digest must be selected for Item_Due. Recover your test database by running the following SQL command: insert into message_transports (message_attribute_id, message_transport_type, \ is_digest, letter_module, letter_code) values (1, 'email', 0, 'circulation', \ 'DUE'); 4. Remove your email address, open developer tools, select console and run the following command: $('#email1').removeAttr('disabled'); $('#email1').prop('checked', true); $('form[name=opacmessaging]').submit(); Observe error: You cannot select email notifications because you haven't set an email address. 5. Remove your SMS number, open developer tools, select console and run the following command: $('#sms1').removeAttr('disabled'); $('#sms1').prop('checked', true); $('form[name=opacmessaging]').submit(); Observe error: You cannot select SMS notifications because you haven't set an SMS number address. 6. The rest of the template error messages are currently inaccessible and therefore untestable via GUI, but check the changes this patch introduces manually. These exceptions are: Koha::Exceptions::Patron::Message::Preference::AttributeNotFound Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceNotAvailable Koha::Exceptions::Patron::Message::Preference::DigestNotAvailable You can test them programmatically by searching opac-messaging.pl for the following: C4::Form::MessagingPreferences::handle_form_action( ... and throwing each exception before it by following code: Koha::Exceptions::Patron::Message::Preference::AttributeNotFound->throw(); Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 18:34:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 17:34:35 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113011|0 |1 is obsolete| | --- Comment #101 from Lari Taskula --- Created attachment 113127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113127&action=edit Bug 17499: (follow-up) More explicit exceptions Adds and throws more detailed exceptions. This is useful for APIs and generating translatable errors in GUI. In short, replaces Koha::Exceptions::BadParameter with: Koha::Exceptions::Patron::NotFound Koha::Exceptions::Patron::Category Koha::Exceptions::Patron::Category::NotFound Koha::Exceptions::Patron::Message::Preference Koha::Exceptions::Patron::Message::Preference::AttributeNotFound Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceOutOfRange Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceNotAvailable Koha::Exceptions::Patron::Message::Preference::DigestNotAvailable Koha::Exceptions::Patron::Message::Preference::DigestRequired Koha::Exceptions::Patron::Message::Preference::EmailAddressRequired Koha::Exceptions::Patron::Message::Preference::NoTransportType Koha::Exceptions::Patron::Message::Preference::SMSNumberRequired To test: 1. prove t/db_dependent/Koha/Patron/Message/Preferences.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 18:36:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 17:36:42 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 18:38:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 17:38:24 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:22:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 18:22:04 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:22:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 18:22:13 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:22:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 18:22:48 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 113128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113128&action=edit Bug 26921: Don't generate an invalid custom cover image if the url cannot be generated In case a custom cover image url is used to generate the cover image of bibliographic records, we should not build one if the record does not have the necessary data. For instance if you have CustomCoverImagesURL set to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpb and a biblio does not have the isbn defined, we should not generate and empty image (empty or invalid src) Test plan: 0. Set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpb Enable CustomCoverImages and OPACCustomCoverImages To highlight the issue you should disable LocalCoverImages and OPACLocalCoverImages. 1. Make sure you have some of your bibliographic records with a valid isbn 2. Make sure you have at least 1 bibliographic record without an isbn set 3. Visit the search result and detail views (OPAC and staff interfaces) => Without this patch you should see a "Cover image" link, and an empty block/div on the detail page => With this patch applied you should only see images when the url can be generated Note that the problem will persist if the isbn is not valid (ie. no image is generated) Sponsored-by: Orex Digital Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:31:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 18:31:22 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #102 from Lari Taskula --- Created attachment 113129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113129&action=edit Bug 17499: (follow-up) Fix warning Fix warning DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:35:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 18:35:44 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:35:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 18:35:48 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110897|0 |1 is obsolete| | Attachment #110898|0 |1 is obsolete| | --- Comment #16 from Owen Leonard --- Created attachment 113130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113130&action=edit Bug 24223: Convert OpacNav system preference to news block This patch builds on Bug 22318 to move the OpacNav system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> News and verify that the content from OpacMainUserBlock is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacNav_en', 'OpacNav_fr-FR', 'OpacNav_cs-CZ' - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:35:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 18:35:51 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #17 from Owen Leonard --- Created attachment 113131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113131&action=edit Bug 24223: (follow-up) Add date to OpacNav news entries This follow-up modifies the atomic update so that it inserts today's date as the "Published on" date. Without that information the system considers the item unpublished and will not display the content. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:35:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 18:35:55 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #18 from Owen Leonard --- Created attachment 113132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113132&action=edit Bug 24223: (follow-up) Make logged-in user's branchcode available to template This patch makes a couple of corrections for problems I discovered while working on Bug 24224: The variables required for correct display of news items by branch and language were not consistently available to the templates. In opac-readingrecord.pl, the "lang" variable was being overwritten. On this and other pages the logged-in patron's brachcode was not made available. I've corrected instances of KohaNews.get() to use the globally-available "logged_in_user.branchcode" instead. To test, apply the patch and follow the original test plan, with the addition of instances of the OpacNav news item which have a specific library selected. Confirm that such items are correctly displayed according to the logged-in user's home library. If there is no logged-in user the library-specific OpacNav should not display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 19:55:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 18:55:50 +0000 Subject: [Koha-bugs] [Bug 26942] New: TinyMCE in the News Tool is still doing some types of automatic code cleanup Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942 Bug ID: 26942 Summary: TinyMCE in the News Tool is still doing some types of automatic code cleanup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: -Make sure the sys pref 'NewsToolEditor' is set to TinyMCE -Go to any news item and add this line: -Save the news item -Re-open the same news item again in TinyMCE. -The editor has removed that line. Annoying! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 20:01:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 19:01:31 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #29 from Nick Clemens --- Created attachment 113133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113133&action=edit Bug 7607: Remove empty inputs when submitting search form This patch surrounds the operator, index, and query fields on the advanced search page wtih a 'search_set' class. This allows us to process them as a group and confirm the query is populated before submitting the other parts to the form TO test: 1 - Go to advanced search 2 - Use search boxes to search like: Title: (leave blank) Author: clinton keyword: shuffle 3 - Perform search 4 - Note no results as you searched for title:clinton etc. 5 - apply patch 6 - refresh and repeat 7 - search is now correct 8 - Try vaeious searches with 'more options' and selecting different operators Signed-off-by: David Nind Signed-off-by: David Cook https://bugs.koha-community.org/show_bug.cgi?id=7606 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 20:01:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 19:01:34 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #30 from Nick Clemens --- Created attachment 113134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113134&action=edit Bug 7607: (follow-up) Disable rather than remove inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 20:03:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 19:03:37 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #31 from Nick Clemens --- (In reply to Jonathan Druart from comment #28) > To prevent the values to be sent maybe we could disable the elements instead > of removing them from the DOM. What do you think? It seems to work either way - I am not sure if there is any advantage in one method over the other, but I trust the RM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 20:06:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 19:06:30 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 20:08:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 19:08:23 +0000 Subject: [Koha-bugs] [Bug 25886] libmojolicious-plugin-openapi-perl and libnet-oauth2-authorizationserver-perl unable to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25886 --- Comment #17 from Mason James --- (In reply to José Anjos from comment #16) > I did it: $ echo 'deb http://debian.koha-community.org/koha stable main > xenial' | sudo tee /etc/apt/sources.list.d/koha.list > $ sudo apt-get update > $ sudo apt-get install koha-common > > Then a message says that libjson-validator-perl libmojolicious-perl > libmojolicious-plugin-openapi-perl > were not upgraded. > hi José can you include the output from the following command... $ apt-cache policy koha-common libjson-validator-perl \ libmojolicious-perl libmojolicious-plugin-openapi-perl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 20:10:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 19:10:05 +0000 Subject: [Koha-bugs] [Bug 17120] Specify number of rows per page in report and initial run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17120 --- Comment #2 from Cab Vinton --- +1. Not only that, but I believe the entire report is re-run whenever changing the number of results per page. Not particularly efficient when dealing with more complex queries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 20:12:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 19:12:48 +0000 Subject: [Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 20:12:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 19:12:51 +0000 Subject: [Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96467|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 113135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113135&action=edit Bug 24272: add check_sysprefs_cache.pl This script ensure that no sysprefs have been changed directly in the database and/or that the cache has not become corrupted. We have occasionally seen this happen on production sites To test: 1 - In the staff interface go to Administration 2 - Search for system preference 'IntranetUserJS' 3 - Add content to the syspref: console.log('Hi!'); 4 - On the command line launch mysql sudo koha-mysql kohadev 5 - Alter the syspref directly UPDATE systempreferences SET value = "console.log('Bye!');" WHERE variable = 'IntranetUserJS'; 6 - run the script perl misc/maintenance/check_syspref_cache.pl 7 - You are warned about the altered system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 20:23:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 19:23:06 +0000 Subject: [Koha-bugs] [Bug 26943] New: Show not for loan descriptions in cataloging search (addbooks.pl) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Bug ID: 26943 Summary: Show not for loan descriptions in cataloging search (addbooks.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To recreate: - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column We should show the actual display values here, rather than collapsing all positive values into "not for loan" and all negative values into "on order." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 5 20:24:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Nov 2020 19:24:11 +0000 Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942 --- Comment #1 from Lucas Gass --- TinyMCE doesn't automatically takes out HTML tags like ,