[Koha-bugs] [Bug 26584] Remove unused C4::Acquisition::CloseBasket function
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sun Nov 1 14:10:16 CET 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #112796|0 |1
is obsolete| |
--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 112801
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112801&action=edit
Bug 26584: Remove unused C4::Acquisition::CloseBasket function
This patch makes code use the new Koha::Acquisition::Basket->close
method and makes CloseBasket obsolete.
It then removes it, and adapts the few places in which it was used.
1. Apply this patch
2. Run:
$ kshell
k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove
=> SUCCESS: Tests pass!
3. Try playing with baskets, closing them
=> SUCCESS: All works as expected!
4. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list