[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Nov 3 10:23:08 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #91 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Nick Clemens from comment #90)
> Koha/SearchEngine/Elasticsearch/Search.pm 
> 298 =item C<$max_results>
> 299 
> 300 The max number of results to return. The default is 100 (because
> unlimited
> 301 is a pretty terrible thing to do.)
> 
> Probably this should be a syspref? For Zebra we don't hardcode a limit, but
> maybe we should not return everything and it would be better to have one
> syspref to control both>

I don't think a global max results syspref would be a good idea. We could
probably identify all calls of simple_search_compat() and then those that
require more than 100 results, like this feature, should handle this case by
making more calls using offset or different max results value. So it seems like
we are now back to the question whether implement AJAX as was discussed earlier
but it would be useful to have a rest api endpoint for component parts in that
case. Or we could also say we are fine with 100 results at this point in time.
What are your opinions on this?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list