[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Nov 4 00:09:56 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548

--- Comment #28 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #27)
> (In reply to David Cook from comment #24)
> > (In reply to Nick Clemens from comment #20)
> > > Would it be reasonable to clear empty inputs with javascript before the
> > > submission?
> > 
> > On reflection, that won't work the way you think it would work. It would
> > create the problems described in Bug 7607.
> 
> It won't if you remove the related idx.
> 

What I meant was that if you set the idx value to '' (ie if you "clear empty
inputs"), it will actually create an inconsistency in the form submission where
the idx param is *not* sent in the form submission but the q param *is* sent.
That is, unless you include an option in the select list for the idx that has a
value of ''. It seems like glitchy/unexpected browser behaviour (at least in
Chrome). 

But, as you say, removing the elements from the HTML form all together would
work.

> I don't think we should push this patch without having both sides happy.

Sounds all right to me. I already applied these patches locally about 6 months
ago, so I don't mind too much. Happy to help with Bug 7607 and then we can push
this one once that's sorted.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list