[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #19 from David Nind <david at davidnind.com> ---
Created attachment 113046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113046&action=edit
Screenshot - After patch applied and attempting to save the record

I can replicate the issue.

After applying the patches I attempt to add another new record. 

When saving the record, I don't get the add new item screen - see the
screenshot attached. 

The record is not added, it shows up in the reservoir, and there are these
warnings are in the log:
 66 [2020/11/05 08:29:42] [WARN] DBD::mysql::st execute failed: Data too long
for column 'lccn' at row 1 [for Statement "INSERT INTO `biblioitems` (
`agerestriction`, `biblionumber`, `cn_class`, `cn_ite    m`, `cn_sort`,
`cn_source`, `cn_suffix`, `collectionissn`, `collectiontitle`,
`collectionvolume`, `ean`, `editionresponsibility`, `editionstatement`,
`illus`, `isbn`, `issn`, `itemtype`, `lccn`, `no    tes`, `number`, `pages`,
`place`, `publicationyear`, `publishercode`, `size`, `timestamp`,
`totalissues`, `url`, `volume`, `volumedate`, `volumedesc`) VALUES ( ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?,     ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
current_timestamp, ?, ?, ?, ?, ? )" with ParamValues: 0=undef, 1='448',
2=undef, 3=undef, 4='', 5="ddc", 6=undef, 7=undef, 8=undef, 9=undef, 10=undef,
11=undef,     12=undef, 13="ill. ;", 14="9780132480529 (pbk. : alk. paper) |
0132480522 (pbk. : alk. paper)", 15=undef, 16="BK",
17="ThisisgoingtobetoomanycharactersfortheLCCNfield", 18=undef, 19=undef,
20="xix,     281 p. :", 21="Upper Saddle River, NJ :", 22=undef, 23="IBM Press
: | Pearson,", 24="24 cm.", 25=undef, 26=undef, 27=undef, 28=undef, 29=undef]
at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 183    6.
 67 [2020/11/05 08:29:42] [WARN] DBIx::Class::Storage::DBI::_dbh_execute():
Data too long for column 'lccn' at row 1 at /kohadevbox/koha/Koha/Object.pm
line 169
 68 [2020/11/05 08:29:42] [WARN] DBIx::Class::Storage::DBI::_dbh_execute():
Data too long for column 'lccn' at row 1 at /kohadevbox/koha/Koha/Object.pm
line 169
 69 [2020/11/05 08:29:42] [WARN] Use of uninitialized value $biblionumber in
concatenation (.) or string at /kohadevbox/koha/cataloguing/addbiblio.pl line
870.
 70 [2020/11/05 08:29:42] [WARN] Use of uninitialized value $searchid in
concatenation (.) or string at /kohadevbox/koha/cataloguing/addbiblio.pl line
870.
 71 [2020/11/05 08:29:42] [WARN] Use of uninitialized value $frameworkcode in
string eq at /kohadevbox/koha/cataloguing/additem.pl line 432.
 72 [2020/11/05 08:29:42] [WARN] GetMarcBiblio called with undefined
biblionumber at /kohadevbox/koha/cataloguing/additem.pl line 453.

My notes for testing (koha-testing-docker):
1. Run through the test plan in the bug description
2. Run the tests: prove -v t/db_dependent/Biblio.t - these should pass
3. Delete the record created
4. Apply the patches
5. Repeat the test plan, this time:
   - There should be no errors in
/var/log/koha/kohadev/plack-intranet-error.log
   - You should be able to successfully add an item

-- 
You are receiving this mail because:
You are watching all bug changes.