[Koha-bugs] [Bug 24412] Attach waiting hold to desk

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

--- Comment #114 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
(In reply to Jonathan Druart from comment #109)
[...]
> 
> 4. I am not sure about the desk_id parameter we passed to
> Koha::Hold->set_waiting.
> We could also set it from ModReserveAffect, what's the benefit of this
> approach?
> 
> Failing QA for 1, 2, 3.

I tried to address 1, 2, 3, a big thanks for spotting those. Especially 3...

> 4 is for discussion.

I'm a bit ashamed to say I don't really know. It seemed to me logical at the
time. I'd say that if you think the day someone rewrite ModReserveAffect as a
Koha::Hold method the desk attachment should go in this method, then I'll put
it under set_waiting().

-- 
You are receiving this mail because:
You are watching all bug changes.