[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603

--- Comment #39 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #37)
> +    # Make sure it has not be paid yet
> +    return if $self->amount != $self->amountoutstanding;
> 
> Won't this fail when comparing floats?

I think we should be safe, as they're stored as DECIMAL (a fixed-point type,
not floating-point), and the initial value of those two columns are exactly the
same. So when they come from the database they should still be equal, unless a
payment have been made.

(In reply to Jonathan Druart from comment #36)
> Should not be "branch", but "branchcode" I'd say.

I think that's a question for Martin

-- 
You are receiving this mail because:
You are watching all bug changes.