[Koha-bugs] [Bug 22343] Add configuration options for SMTP servers

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343

--- Comment #223 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Joonas Kylmälä from comment #222)
> (In reply to Jonathan Druart from comment #221)
> > (In reply to Joonas Kylmälä from comment #219)
> > > This seems to cause incorrect double encoding in HOLD slip / pickup
> > > notifications. Working on a fix.
> > 
> > Did you try with other notifications? When I pushed this I tested some of
> > them and it was working correctly.
> > 
> > Maybe your patch will break other than HOLD.
> 
> We tested ODUE and MEMBERSHIP_EXPIRY templates and this fixed those as well.
> 
> If you think more unit tests are needed for this could you please provide
> them, I'm unable to find the time right now to investigate what sort of
> tests are available for _send_message_by_email() and what changes would be
> needed there. If no one else steps in I could do it in few weeks time but I
> feel like this is important to get to the master version as soon as possible
> in case someone is using master branch in production :D

Hi, can we open a separate bug for this, as it is pushed already? Most tests
are on t/db_dependent/Letters.t.

If it is a specific kind of message, then we could check on the caller's end.
For references on how encoding is handled, refer to the Email::Stuffer and
Email::MIME docs.

-- 
You are receiving this mail because:
You are watching all bug changes.