[Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #120 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Andrew,

I think I've found some problem with this enhancement.

1.
I have set the default circ rule:
 unseen_renewals_allowed          | 2
 renewalsallowed                  | 5 

And an issue has:
         renewals: 2
  unseen_renewals: 2

so number of unseen is reached.

I am expecting a staff member to be allowed to renew, however I get:

Cannot renew:

E Street shuffle : ( BC_1 ) has been renewed the maximum number of consecutive
times without being seen by the library )

Can you confirm it's a bug?

2. If 1. is valid, why cannot we renew from circulation.pl if the max number of
renewals is not reached (but number of unseen renewals is)?

3. If I am understanding correctly, the AddRenewal call in sco-main.pl always
has $seen set to 1. Maybe we should then make it hardcoded in the controller
(ie. no need to have the template var)

4. It seems that the too_unseen error should be handled in
misc/cronjobs/automatic_renewals.pl
Don't you think?

It can still be part of 20.11 if I get answers/follow-ups before Wednesday.

-- 
You are receiving this mail because:
You are watching all bug changes.