[Koha-bugs] [Bug 19133] Password recovery routes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19133

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1. I am getting an horrible stack of errors when running the tests:

$ prove t/db_dependent/api/v1/patrons_password_recovery.t                       
t/db_dependent/api/v1/patrons_password_recovery.t .. unable to establish SMTP
connection to localhost port 25                                                 

Trace begun at /usr/share/perl5/Email/Sender/Transport/SMTP.pm line 194         
Email::Sender::Transport::SMTP::_throw('Email::Sender::Transport::SMTP=HASH(0x55ca6a314d18)',
'unable to establish SMTP connection to localhost port 25') called at
/usr/share/perl5/Email/Sender/Transport/SMTP.pm
 line 144
[...]

2. This cannot be pushed without missing tests.

3.
+        unless (C4::Context->preference('OpacPasswordChange') and
+                C4::Context->preference('OpacPasswordReset'))
+        {
+            return $c->render(status => 403, openapi => {
+                error => 'Password recovery is disabled.'
+            });
+        }

hum? OpacPasswordReset never existed, it's OpacResetPassword.

But I think $patron->category->can_reset_password (from bug 21890) should be
used here instead.

-- 
You are receiving this mail because:
You are watching all bug changes.