[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #650 from David Nind <david at davidnind.com> ---
Hi Aleisha.

I was too slow 8-(... Hopefully 21.05!

All the tests now pass!

However, when I go to Administration > Patrons and circulation > Circulation
and fines rules (after applying the patches, database update, dbic, and
restart_all) I now get a trace error, which starts with:

Could not compile /kohadevbox/koha/admin/smart-rules.pl: syntax error at
/kohadevbox/koha/admin/smart-rules.pl line 343, near ">>"
Global symbol "$bor" requires explicit package name (did you forget to declare
"my $bor"?) at /kohadevbox/koha/admin/smart-rules.pl line 348.
Global symbol "$bor" requires explicit package name (did you forget to declare
"my $bor"?) at /kohadevbox/koha/admin/smart-rules.pl line 348.
Global symbol "$itemtype" requires explicit package name (did you forget to
declare "my $itemtype"?) at /kohadevbox/koha/admin/smart-rules.pl line 349.
Global symbol "$itemtype" requires explicit package name (did you forget to
declare "my $itemtype"?) at /kohadevbox/koha/admin/smart-rules.pl line 349.
Global symbol "$br" requires explicit package name (did you forget to declare
"my $br"?) at /kohadevbox/koha/admin/smart-rules.pl line 350.
Global symbol "$br" requires explicit package name (did you forget to declare
"my $br"?) at /kohadevbox/koha/admin/smart-rules.pl line 350.
Global symbol "$rules" requires explicit package name (did you forget to
declare "my $rules"?) at /kohadevbox/koha/admin/smart-rules.pl line 351.
syntax error at /kohadevbox/koha/admin/smart-rules.pl line 356, near "elsif"
Can't redeclare "my" in "my" at /kohadevbox/koha/admin/smart-rules.pl line 358,
near ""
/kohadevbox/koha/admin/smart-rules.pl has too many errors.
 at /usr/share/perl5/CGI/Compile.pm line 132

    in CGI::Compile::compile at /usr/share/perl5/CGI/Compile.pm line 132

      129:         my $code = $self->_eval($eval);
      130:         my $exception = $@;
      131: 
      132:         die "Could not compile $script: $exception" if $exception;
      133: 
      134:         sub {
      135:             my @args = @_;

There is also a QA fail:

...
OK      Makefile.PL
 FAIL   admin/smart-rules.pl
   FAIL   valid
                Number found where operator expected 
                        (Do you need to predeclare Bug?)
                "my" variable $input masks earlier declaration in same scope 
                syntax error 
                Global symbol "$bor" requires explicit package name (did you
forget to declare "my $bor"?) 
                Global symbol "$bor" requires explicit package name (did you
forget to declare "my $bor"?) 
                Global symbol "$itemtype" requires explicit package name (did
you forget to declare "my $itemtype"?) 
                Global symbol "$itemtype" requires explicit package name (did
you forget to declare "my $itemtype"?) 
                Global symbol "$br" requires explicit package name (did you
forget to declare "my $br"?) 
                Global symbol "$br" requires explicit package name (did you
forget to declare "my $br"?) 
                Global symbol "$rules" requires explicit package name (did you
forget to declare "my $rules"?) 
                syntax error 
                Can't redeclare "my" in "my" 
                admin/smart-rules.pl has too many errors.

 OK     catalogue/detail.pl
...

David

-- 
You are receiving this mail because:
You are watching all bug changes.