[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #666 from David Nind <david at davidnind.com> ---
My notes from testing.

Tests and qa script
~~~~~~~~~~~~~~~~~~~

All tests pass!

prove t/db_dependent/Koha/Recall.t
prove t/db_dependent/Koha/Recalls.t
prove t/db_dependent/Stats.t
prove t/db_dependent/Koha/Item.t
prove t/db_dependent/Koha/Biblio.t
prove t/db_dependent/Koha/Patron.t
prove t/db_dependent/XSLT.t
prove t/db_dependent/Search.t
prove t/db_dependent/Holds.t
prove t/db_dependent/Circulation/transferbook.t
prove t/db_dependent/Circulation.t
prove t/db_dependent/Circulation/CalcFine.t

The only QA script error (qa -v 2) is a false positive accoriding to kidclamp:
http://irc.koha-community.org/koha/2020-10-24#i_2300062

 FAIL   Koha/Schema/Result/Recall.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

Accounts and records used
~~~~~~~~~~~~~~~~~~~~~~~~~

Borrower A (created as new): My Name, 12345, myname, Policy10

Borrower B (login and password changed for Henry): henry, Policy10

Biblio A:
- Record with two items
- Effective perl programming (139, items 296 (Item A) and 297 (Item C))
- Barcodes: Item A 39999000005776 and Item B 39999000005790

Biblio B:
- Record with at least one item
- Lady Susan ; The Watsons ; Sanditon (283, item 627 (Item C))
- Barcode: Item C 39999000012392

Branch A: Centerville
Branch B: Midway

Clarification/notes for specific steps of the test plan
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

See Comment #659 for the full test plan.

33-36. Note that when placing a course reserve you get an error when listing
items for a course in the staff interface - bug 26819 was created, this problem
existed on master before the recalls patches were applied but does not occur on
20.05.x.

45. Clarification: need to check Item C out to a patron before placing the
recall.

111: UPDATE recalls SET expirationdate = NOW() - interval 2 day WHERE recall_id
= X;

127: UPDATE recalls SET waitingdate = NOW() - interval 2 day WHERE recall_id =
X;

133: UPDATE issues SET date_due = NOW() - interval 2 day WHERE issue_id = X;

134: Script path should be recalls (not recall): perl
misc/cronjobs/recalls/overdue_recalls.pl

150: UPDATE issues SET date_due = NOW() - interval 2 day WHERE issue_id = X;

-- 
You are receiving this mail because:
You are watching all bug changes.