[Koha-bugs] [Bug 22818] ILL should be able to send notices

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818

--- Comment #162 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Only found minor things so far.

1. 

Those changes are not expected:

-    my $library = Koha::Libraries->find($params->{current_branchcode})
+    my $branch = Koha::Libraries->find($params->{current_branchcode})

2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it
explicit on the interface to not cause confusion?

3. 
+use Koha::MessageAttributes;
+use Koha::MessageAttribute;

You only need to include the Koha::Object*s* class.

-- 
You are receiving this mail because:
You are watching all bug changes.