[Koha-bugs] [Bug 26963] Koha::Template::Plugin::Branches::pickup_locations is very inefficient, causing timeouts on records with large numbers of holds/items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This appears to work in testing.. but a few things worry me slightly.

I'm not seeing great unit tests for the branchlimits handling of the
pickup_locations method and as we've not got new tests for the introduced
private method I'd have to fail QA on that front.

As this fixes a bug I think we should write the tests to prove branchlimits
side and probably go with the code as is.. however, as I dug into it, the code
feels a bit manic in this area I feel like a bit of golfing down the line would
be great.

I'd love to see the methods that are currently returning arrayrefs of
Koha::Objects actually return proper Koha::Object sets which could then be
chained properly.

-- 
You are receiving this mail because:
You are watching all bug changes.