[Koha-bugs] [Bug 22818] ILL should be able to send notices

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818

--- Comment #180 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #162)
> Those changes are not expected:
> 
> -    my $library = Koha::Libraries->find($params->{current_branchcode})
> +    my $branch = Koha::Libraries->find($params->{current_branchcode})

I'm afraid I don't understand. In this patch
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113409&action=diff
I fixed a misnamed variable, from $library -> $branch, which is the change
you've highlighted above. Why is this unexpected?

> 2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it
> explicit on the interface to not cause confusion?

Sorry, I don't understand, make it explicit where in the interface? It's
listed, and can be selected, along with all the other log actions in the
"Browse the system logs" page. Is this where you are talking about?


> 3. 
> +use Koha::MessageAttributes;
> +use Koha::MessageAttribute;
> 
> You only need to include the Koha::Object*s* class.

Good spot, thanks, now fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.