[Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

--- Comment #132 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #120)

Hi Jonathan

> Cannot renew:
> 
> E Street shuffle : ( BC_1 ) has been renewed the maximum number of
> consecutive times without being seen by the library )
> 
> Can you confirm it's a bug?

I think you've missed the step in the test plan that says "Select the "Override
renewal restrictions" checkbox" with this enabled, you will have the ability to
override the restriction via a "Override limit and renew button"

> 3. If I am understanding correctly, the AddRenewal call in sco-main.pl
> always has $seen set to 1. Maybe we should then make it hardcoded in the
> controller (ie. no need to have the template var)

Good point, now changed

> 
> 4. It seems that the too_unseen error should be handled in
> misc/cronjobs/automatic_renewals.pl
> Don't you think?

Good point, now added

> It can still be part of 20.11 if I get answers/follow-ups before Wednesday.

Sorry, I somehow missed the email for this bug until this morning, hence my
reply today!

-- 
You are receiving this mail because:
You are watching all bug changes.