[Koha-bugs] [Bug 22818] ILL should be able to send notices

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |additional_work_needed

--- Comment #188 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed but more work needed:

1. Fix the checkbox wording

2. $dbh->{mysql_insertid}; in the upgrade process should be replaced. It's a
MySQLism

3. t/db_dependent/Illrequests.t is passing but, only when run once:

$ prove t/db_dependent/Illrequests.t
OK

$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation/issue.t
t/db_dependent/Illrequests.t 

t/db_dependent/Circulation.t ................... ok   
t/db_dependent/Circulation/issue.t ............. ok   
t/db_dependent/Illrequests.t ................... 9/13
    #   Failed test 'Item creation fails on bad parameters'
    #   at t/db_dependent/Illrequests.t line 1008.
    # found warning: DBD::mysql::st execute failed: Cannot add or update a
child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT
`items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`)
ON UPDATE CASCADE) [for Statement "INSERT INTO `items` ( `barcode`,
`biblioitemnumber`, `biblionumber`, `damaged_on`, `dateaccessioned`,
`datelastborrowed`, `datelastseen`, `holdingbranch`, `homebranch`,
`itemlost_on`, `itype`, `location`, `onloan`, `permanent_location`,
`replacementpricedate`, `timestamp`, `withdrawn_on`) VALUES ( ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ? )" with ParamValues:
0='ILL-26', 1=493, 2=497, 3=undef, 4='2020-11-11T15:06:34', 5=undef,
6='2020-11-11T15:06:34', 7='---', 8='---', 9=undef, 10='AfCJ5loFV', 11='---',
12=undef, 13='---', 14='2020-11-11T15:06:34', 15=undef] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
    # found warning: DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or
update a child row: a foreign key constraint fails (`koha_kohadev`.`items`,
CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches`
(`branchcode`) ON UPDATE CASCADE) at /kohadevbox/koha/Koha/Object.pm line 169
    # expected to find warning: (?^u:DBD::mysql::st execute failed: Cannot add
or update a child row: a foreign key constraint fails)

Feel free to open a separate bug report if it's not directly related to this
change.

-- 
You are receiving this mail because:
You are watching all bug changes.