[Koha-bugs] [Bug 26963] Koha::Item::pickup_locations is very inefficient, causing timeouts on records with large numbers of holds/items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963

--- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #22)
> (In reply to Martin Renvoize from comment #15)
> > I'd love to see the methods that are currently returning arrayrefs of
> > Koha::Objects actually return proper Koha::Object sets which could then be
> > chained properly.
> 
> I don't understand. Are you suggesting that Koha::Item->pickup_locations
> should return the Koha::Item object?
> 
> If it's a "getter" method I see no reason not to return what you had asked
> for :)

It is indeed a getter.. but to me it clearly sounds like a relation getter..
i.e that it should return a related set.. i.e. a Koha::Libraries object as
apposed to an ARRAREF of Koha::Library objects... with a proper Koha::Libraries
object you can further refine the results by chaining additional ->search calls
for example.. which is the exact case we're running into here.

-- 
You are receiving this mail because:
You are watching all bug changes.