[Koha-bugs] [Bug 26963] Koha::Item::pickup_locations is very inefficient, causing timeouts on records with large numbers of holds/items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963

--- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 113517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113517&action=edit
Bug 26963: (QA follow-up) Migrate unit tests into pickup_location

We wrote unit tests for _can_pickup_locations as part of this patchset,
but then I inlined the method whilst golfing. This patch moves those
tests into the existing pickup_locations test so we more thoroughly
cover the case where branch transfer limits are in play.

NOTE: The tests all assume that all items have an effective_itemtype and
ccode. I'm pretty sure items all have a type at this point, but I'm less
sure we enforce collection codes?

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.