[Koha-bugs] [Bug 26963] Koha::Item::pickup_locations is very inefficient, causing timeouts on records with large numbers of holds/items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 113521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113521&action=edit
Bug 26963: (QA follow-up) Fix up tests and cover case of undefined ccode

While this technically shouldn't happen, if a library creates itemtype limits,
then flips the pref, those rules are still in the db until a ccode rule is
saved.

To be extra safe, when checking for rules of one type, we should make sure the
other type is undef - i.e. if looking for ccode rules, we should confirm the
itype is undef for those rules

Additionally, we shouldn't set the barcode now that we are not deleting all
items, so we use copynumber for our item identification field as it doesn't
need to be unique in the DB

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.