[Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

--- Comment #142 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #140)
> (In reply to Andrew Isherwood from comment #138)
> > (In reply to Jonathan Druart from comment #136)
> > 
> > > 2. The insert from the upgrade process is not correct. The rule_value is not
> > > passed. But even if passed it's not idempotent (ie. the row in inserted
> > > several times if run several times).
> > 
> > Hi Jonathan - thanks for that. I'm afraid I'm not sure what you mean here.
> > Are you talking about the circulation rule DB upgrade. As far as I can see
> > it works and is idempotent. This makes me think you're talking about
> > something else. Any chance you could clarify please?
> 
> No it's not:
> 
> MySQL [koha_kohadev]> select count(*) from circulation_rules;
> +----------+
> | count(*) |
> +----------+
> |       26 |
> +----------+
> 1 row in set (0.02 sec)
> 
> MySQL [koha_kohadev]>         INSERT IGNORE INTO circulation_rules
> (rule_name, rule_value) VALUES ('unseen_renewals_allowed', '');
> Query OK, 1 row affected (0.02 sec)
> 
> MySQL [koha_kohadev]>         INSERT IGNORE INTO circulation_rules
> (rule_name, rule_value) VALUES ('unseen_renewals_allowed', '');
> Query OK, 1 row affected (0.01 sec)
> 
> MySQL [koha_kohadev]> select count(*) from circulation_rules;
> +----------+
> | count(*) |
> +----------+
> |       28 |
> +----------+
> 1 row in set (0.01 sec)

Aha, you're right! Now fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.