[Koha-bugs] [Bug 26963] Improve Koha::Item::pickup_locations performance

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963

--- Comment #59 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #58)
> I think we should keep the number of tests, don't you?
> 
> 
> I wrote a similar patch than "Don't delete existing data before tests" today:
> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113551
> 
> I will drop mine, but I think this part makes sense:
> +            next
> +              unless grep { $pickup_location eq $_ } @branchcodes;
> 
> 
> Do we agree that this change can be considered an enhancement?

I do keep the number of tests, I just calculate it based on the number of
branches - I think the line you mention makes that unecessary though, so yes,
that line should be copied here

This should be considered a bug - not an enhancement. The current code can
crash a system with the number of DB requests generated and should be
backported to avoid issues on any large systems

-- 
You are receiving this mail because:
You are watching all bug changes.