[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

--- Comment #17 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 113731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113731&action=edit
Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved

Expected behaviour for "On shelf holds allowed" setting for the circulation
rules (Koha administration > Patrons and circulation > Circulation and fines
rules):
- Allow holds only on items that are currently checked out or otherwise
unavailable.
- If set to "Yes", patrons can place holds on items currently checked in.
- If set to "If any unavailable", patrons can only place holds on items that
are not unavailable.
- If set to "If all unavailable", patrons can only place holds on items where
*all* items on the record  are unavailable.
(Adapted from
https://bywatersolutions.com/education/preparing-for-library-closures)

Testing using staff interface:
1. Go to Koha administration > Patrons and circulation > Circulation and fines
rules.
2. Set "On shelf holds allowed" to "Yes" for all libraries/patron
categories/item types.
3. Place a hold on a record with a single item (where the item is available for
loan)
  . I placed a hold for an item and patron both in/belonging to the Centerville
library.
  . Information column in the item table displays "Not on hold".
4. The hold is placed.
5. Cancel the hold.
6. Set "On shelf holds allowed" to either "If any unavailable" or "If all
unavailable" for all patrons/patron categories/item types.
7. The hold is not placed:
   . Message is "Cannot place hold. No items are available to be placed on
hold."
   . Item table: Hold column displays in red "X onShelfHoldsNotAllowed" and the
information column displays "Not on hold".
8. Run the tests prove t/db_dependent/Reserves.t - these should pass

Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.