[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854

--- Comment #16 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #15)
> (In reply to David Cook from comment #13)
> > (In reply to Jonathan Druart from comment #12)
> > > Shouldn't we use the log dir defined in the log4perl config file?
> > 
> > I am not sure that I understand your question.
> > 
> > logdir in etc/koha-conf.xml is set by __LOG_DIR__ and the log dir in
> > etc/log4perl.conf is also set by __LOG_DIR__, so it's the same log directory.
> 
> At the instance creation, yes. But you can modify it.

True. I suppose that's true for the Apache config too.

koha-create appears to be hard-coded...

> > The log4perl config file is also not able to be parsed by anything except
> > Log4Perl, and using Log4Perl isn't really an option here without rewriting
> > tools/stage-marc-import.pl to use Log4Perl instead of using the warn
> > built-in.
> 
> It seems that the 'logdir' from the Koha config file is only used by
> installer/install.pl and misc/cronjobs/edi_cron.pl

That is interesting. 

> And so I guess we should remove it in favour or the Log4Perl one. With that
> in mind I don't think it's a good idea to add another occurrence.

But how could we use the Log4Perl one without Log4Perl?

> I think we should push this without the log, it's what we are doing for all
> other background jobs anyway.

Which other background jobs do you mean? 

If we don't use the log, then any output from the backgrounded
stage-marc-import.pl will be completely lost. 

That said, I don't love adding a new log file. I'm just not sure about any
other viable alternatives.

In any case, whatever we do here will be a temporary solution anyway. Once
20.11 is released and RabbitMQ has been around for a little while, I am
thinking about rewriting the stage-marc-import.pl backend to use RabbitMQ.
(After I finish bug 26791 of course...)

-- 
You are receiving this mail because:
You are watching all bug changes.