[Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388

--- Comment #14 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Emmi Takkinen from comment #13)
> > Also the test cases now only test sorting with issue date, not by date due.
> > Testing of date due sorting should be added to cover this change fully.
> Sorry, I don't fully understand what you mean by this. I don't see any test
> where we specially test sorting with issue date. However every test expects
> output to have issues in correct order and that includes having correct date
> due value.

I think earlier I must have meant that in the patch "Bug 12388: Adjust tests"
the tests' the changes are made so that the expected order is by issue date).
If you read the code for the first test case changed here it sets for both of
the checkouts the same due date "$date_due = $today_daily;" so it won't be able
to test whether the sorting by date_due works. But yes, what I meant that maybe
we should have tests for the correct sorting, now I understand that the
original patch "Adjust tests" might have not had that goal because it changed a
test that was only for checking whether we get separate "Checked out" and
"Overdues" sections in the slip. So I think the patch "Bug 12388: Adjust tests"
is okay, but/and if you think it is important there should be test for testing
sorting order as well for the slip.

-- 
You are receiving this mail because:
You are watching all bug changes.