[Koha-bugs] [Bug 27060] Allow undoing changes to the password on SMTP config

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27060

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113846|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 113881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113881&action=edit
Bug 27060: Handle password changes more robustly

This patch makes the changes in the password input trigger an event that
marks the password as changed. This way we don't need to compare with
the "****" string in the controller. A convenient link for restoring the
original password is added with a proper description that marks the
password as untouched, also restoring the "****" value.

To test:
1. Apply this patch
2. Have an SMTP server set
3. Open for edition
4. In paralell, have a terminal with
   $ koha-mysql kohadev
   > SELECT * FROM smtp_servers;
=> SUCCESS: The password you chose is there
5. Edit the password, save
=> SUCCESS: The password is there
6. Edit the password, choose to reset it to the one in the DB, save
=> SUCCESS: The password hasn't been changed!
7. Edit the password, put ****. save
=> SUCCESS: The password has been updated to ****
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.