[Koha-bugs] [Bug 27079] New: UpdateFine adds refunds for fines paid off before return

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079

            Bug ID: 27079
           Summary: UpdateFine adds refunds for fines paid off before
                    return
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The issue seems to be that the amount passed in to UpdateFine fails the
comparison to $accountline->amount - one is $1.80 and the other is $1.80000
and comparison fails:

576     if ( $accountline ) {
577         if ( $accountline->amount != $amount ) {

To recreate:
1 - Set a circ rule to have a .15 per day fine
2 - Issue an item of this type to a borrower
3 - Make it 12 days overdue either at checkout or in the db:
    UPDATE issues SET date_due = DATE_SUB(CURDATE(),INTERVAL 12 DAY);
4 - Run the fines job or just put a fine in place:
    INSERT INTO accountlines
(issue_id,borrowernumber,itemnumber,amount,debit_type_code,status,amountoutstanding)
SELECT issue_id,5,itemnumber,1.80,'OVERDUE','UNRETURNED',1.80 FROM issues WHERE
borrowernumber=5;
5 - Pay the fine for the patron
6 - Check in the item
7 - Note that the patron has an 'Overpayment refund' of $0.00

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.