[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694

--- Comment #30 from Mark Alexander <marka at pobox.com> ---
(In reply to Magnus Enger from comment #29)
> Could we pass $patron to the plugin and let the plugin do what it needs to
> it, before returning it? So instead of this (as suggested by Mark):
> 
> $patron = undef unless ( check_patron ( $patron, $server ) );
> 
> we could do this? 
> 
> $patron = check_patron ( $patron, $server );
> 
> And the plugin could return undef or just a changed $patron. 
> 
> I would also suggest a more detailed name for the config-parameter: 
> 
>   <accounts>
>       <login id="kanopy" password="**password**" delimiter="|"
>         error-detect="enabled"
>         institution="RPL"
>         plugin_class="Koha::Plugin::Com::Bloovis::Sip2patron" />
>   </accounts>
> 
> Maybe something like patron_validation_plugin_class? There could be other
> plugins that do other things in the future.

I like these suggestions. I have made these changes to my plugin and MsgType.pm
on my test setup, and they work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.