[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Nov 27 09:38:00 CET 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079
Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #114019|0 |1
is obsolete| |
Attachment #114020|0 |1
is obsolete| |
--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 114029
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114029&action=edit
Bug 27079: Floating point comparison correction
We cannot compare calculated values directly as those calculations may
have introduced floating point differences. We have the
Koha::Number::Price->round function to consistently round the floating
point number to a decimal with 2 points precission for comparison.
Test plan
1/ Set a circ rule to have a .15 per day fine and enable finesMode
syspref.
2/ Issue an item of this type to a borrower (making it 12 days overdue
by setting the due date to 12 days in the past)
3/ Run the fines job:
4/ Pay the fine for the patron
5/ Check in the item
6/ Note that the patron does not have an 'Overpayment refund' of $0.00
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Bug 27079: (QA follow-up) Round both sides for clarity
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list