[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #595 from Henry Bolshaw <bolshawh at parliament.uk> ---
After applying the patches, I'm getting an error trace page when viewing some
patron pages: "The method Koha::Patron->recalls is not covered by tests!" 

This happens when I navigate to a patron on cgi-bin/koha/members/moremember.pl
and cgi-bin/koha/circ/circulation.pl

I thought this was possibly something I'd set up incorrectly in Koha Testing
docker but I'm getting the same error with the sandboxes.

On KTD the value for Confirm RecallsMaxPickUpDelay was empty rather than 7 but
on the sandboxes it was set to 7 by default as expected.

When I ran the tests on KTD I also got some errors:

FAIL    Koha/Schema/Result/Recall.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

FAIL    koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
   FAIL   forbidden patterns
                forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 15)

There were also several instances of this error:
   FAIL   forbidden patterns
                forbidden pattern: Script permissions is authnotrequired => 0,
it could be correct for an OPAC script if it is was you really want error (bug
24663) (line 30)

-- 
You are receiving this mail because:
You are watching all bug changes.