[Koha-bugs] [Bug 26632] New: BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632

            Bug ID: 26632
           Summary: BatchStageMarcRecords passes a random number to
                    AddBiblioToBatch / AddAuthToBatch
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: MARC Bibliographic record staging/import
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

424                 $import_record_id = AddBiblioToBatch($batch_id, $rec_num,
$marc_record, $encoding, int(rand(99999)), 0);
 430                 $import_record_id = AddAuthToBatch($batch_id, $rec_num,
$marc_record, $encoding, int(rand(99999)), 0, $marc_type);

This populates:
my $update_counts = @_ ? shift : 1;

Which is used once:
_update_batch_record_counts($batch_id) if $update_counts;

So...almost always we want to update, but very occasionally, randomly, don't?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.