[Koha-bugs] [Bug 26634] New: Hold rules applied incorrectly when All Libraries rules are more specific than branch rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634

            Bug ID: 26634
           Summary: Hold rules applied incorrectly when All Libraries
                    rules are more specific than branch rules
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To recreate:
- At the All Libraries level, create a circ rule for a specific patron category
and a specific item type that only allows 1 hold
- At the branch-specific level for Branch A, create an All/All rule that allows
2 holds
- confirm ReservesControll is set to patron's library
- find a patron from Branch A of the category for which you made your rule
- find two bibs with items of the itype got which you made your rule
- place a hold on one bib. success!
- try to place a hold on the second bib. you're told you cannot because the
patron is only allowed 1 hold 

We should be enforcing the All/All rule for Branch A. If we put in a rule for
the category and itype for Branch A, that rule will be enforced and we'll be
allowed a second hold.

In GetHoldRule, we tell get_effective_rules to return those rules ordered by
'categorycode', 'itemtype', 'branchcode.' We should just let get_effective_rule
handle that ordering on its own.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.