[Koha-bugs] [Bug 25952] Github search for plugin throwing errors due to API rate limits

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 9 00:31:06 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to Magnus Enger from comment #3)
> I enabled the feature by adding this to koha-conf.xml:
> 
>  <plugin_repos>
>         <repo>
>                 <name>ByWater Solutions</name>
>                 <org_name>bywatersolutions</org_name>
>                 <service>github</service>
>             </repo>
>         <repo>
>                 <name>Theke Solutions</name>
>                 <org_name>thekesolutions</org_name>
>                 <service>github</service>
>             </repo>
>  </plugin_repos>
> 
> 
> Without the patch I always get this error:
> 
> malformed JSON string, neither tag, array, object, number, string or atom,
> at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm
> line 171
> 
> Is this the expected error we are trying to fix here?
> 

It's been a while but I think so.

> After applying the patch I searched for "koha-plugin" and got a bunch of
> hits, but only from Bywater. When I did the search again straight away it
> chewed for a while, then I got nothing. That is better than an ugly error
> message, of course, but wouldn't a friendly message like "oops something
> went wrong, please adjust your search or try again later" be better?
> 
> Perhaps we could also intercept a search for "koha-plugin" and warn that it
> might exceed the rate limits and give unexepected results?

That's a good point, although at this point I think I'm abandoning/shelving my
work on this, as I think using the GitHub/GitLab APIs is a flawed approach
overall.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list